From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5AECC5475B for ; Mon, 11 Mar 2024 22:12:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F1B28D0009; Mon, 11 Mar 2024 18:12:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A3178D0005; Mon, 11 Mar 2024 18:12:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58FC78D0009; Mon, 11 Mar 2024 18:12:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3BFAE8D0005 for ; Mon, 11 Mar 2024 18:12:07 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1A5AF140554 for ; Mon, 11 Mar 2024 22:12:07 +0000 (UTC) X-FDA: 81886157094.07.8014131 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf25.hostedemail.com (Postfix) with ESMTP id 7C32DA001E for ; Mon, 11 Mar 2024 22:12:05 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=nYL8NBQ1; spf=pass (imf25.hostedemail.com: domain of 3tIHvZQoKCKsjZdcjLSXPORZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--yosryahmed.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3tIHvZQoKCKsjZdcjLSXPORZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--yosryahmed.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710195125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v5GxWvxK/VaGQFMhbfA/trm2HbQ4kyEx9JBhc+nbtKQ=; b=wy8frAsbfPB1WoGhRJYKjWCN5/X6ytvpr6OmN9vAPV8MQr/uyuPb/VArA56BhmdM4qokE7 /MxG+kRA6ue6VRI21hNzBIk7q+mE7kvhE1BRb52/ASFMaN5JdvS9020wMdHGb2ezD8F/44 jCu+7yR3LbNBlJR+eBLFk5ufy5F7wGk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710195125; a=rsa-sha256; cv=none; b=W1V/LdZ62bDY3VAEI4jxpNakDQNhVHbfsGAtYw/LSTdrGYgC7JsIVH7TZv3GpF14Grg5hV nr02stbR7CNuDrBWMMegikjT4zUyc52zVvjSuUWQJt1XS30MoJwBgB0b81lfDcrdIUw4x1 tQRJb9V94cdWuHp4jGPSeQIiUAVI3fU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=nYL8NBQ1; spf=pass (imf25.hostedemail.com: domain of 3tIHvZQoKCKsjZdcjLSXPORZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--yosryahmed.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3tIHvZQoKCKsjZdcjLSXPORZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--yosryahmed.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dd1395fd1bfso3538455276.0 for ; Mon, 11 Mar 2024 15:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1710195124; x=1710799924; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=v5GxWvxK/VaGQFMhbfA/trm2HbQ4kyEx9JBhc+nbtKQ=; b=nYL8NBQ1bYecXoBigKhXyeV8XPdcGJlZyi3nkxMPuT6D/VhOQ1GkuZHE60uQybdFlz 4+WKSbY5mF1rE7iGJJaXu46g5EFaeYSu2Umkwn2qEpCXSRUf4MM9I2r5ldyUvmag1OSM lxCmfOotuaAa782o+LOjOvo2hBvrEsjVLG2Vya5Fd5kCENT5FUE2qzbqhrQJ/XB0mrcn 1YKK8R0P3gk2vRVwXbCxzByAfrn1PY7b9aHhsa6k5Mhwn4q/YyvcGR9jR6s/OLgYXxJV PeRFZW+akzyv2EroCMyQOnFe7d0eaIwX6UEssuKKzz17n3+zUNQnCShCY0S188yQeRBD dYIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710195124; x=1710799924; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v5GxWvxK/VaGQFMhbfA/trm2HbQ4kyEx9JBhc+nbtKQ=; b=utWF+ap9rDSwO08X/wL3ijDgSa8bLnHpTSpjtv0slnn9V8+jO1HIUi/9Lj1tzfvaFp jaMKK+sns132OeOVokmpcsNsO0UJGq+KLYvQctAPyN533Bv2IsmxiyWLZh9+Bm/wk+5E uMigantQdmYIE2Dw41bM4fMLQkOurRh+krbDC3FRcIC7l+ogq1UGJKjU7OxdzBm5WodD BSlo7W5wBVsL3Kxzm9To6RKIgfgmAupC+rB8A1AxU5gYAOX4S5uxjRUVL7XVY4Xhoosp LsKAkbv9VGvwT8KpIDHO29fWdoei2TMUftDVWEgJwiyrWiIo4mMspjODxD/Rg4pR0I4L VCPg== X-Forwarded-Encrypted: i=1; AJvYcCWI7INcQPTKKXR1GefJazq1WovlfYpVClwvhAAf3Cvs7gqaTNRyU6c6hqPLgml0G+EU6Whe3Owv7Q9zLeim1agUOUI= X-Gm-Message-State: AOJu0Yzl7h/XydixutzeyjFvgaPuEW9NkXgNdA2TyAmYppaQqINpMy/5 bH5T9TQ8SVMc30hco/CaEjRrM8xLr5VoOnyMAkr3ZRVW03OhMnUOWOiA9Dm3T9C+3Vzw8c9m30X UrBqMOwIyIeaj1Wof/g== X-Google-Smtp-Source: AGHT+IGgx7xurLeRDpRn80TycPbRzMMOYzvOM2OL4tmAl8caIM9VNaTFrJMB6dBqErDAhQGbxg0elgyIL6von0KR X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a25:81c4:0:b0:dc6:f877:ea7b with SMTP id n4-20020a2581c4000000b00dc6f877ea7bmr2168181ybm.9.1710195124585; Mon, 11 Mar 2024 15:12:04 -0700 (PDT) Date: Mon, 11 Mar 2024 22:12:02 +0000 In-Reply-To: <20240311161214.1145168-2-hannes@cmpxchg.org> Mime-Version: 1.0 References: <20240311161214.1145168-1-hannes@cmpxchg.org> <20240311161214.1145168-2-hannes@cmpxchg.org> Message-ID: Subject: Re: [PATCH 2/2] mm: zpool: return pool size in pages From: Yosry Ahmed To: Johannes Weiner Cc: Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Stat-Signature: 9bje33a778mroyfwzc759tcpdt71mrud X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7C32DA001E X-Rspam-User: X-HE-Tag: 1710195125-309786 X-HE-Meta: U2FsdGVkX1/6F/GJQC2KWaMuxVHbQq6oDzteCVvMfLGYNJd8lS38VZQRKOkjfkV10OgfbeqMWBywDcxDuFyjl3MwS3EBoQOe9wDIrd31+3FXfqmvg8lHMBJEhecZu/JbCm0500fWv66Uovuutl/Hw/SUSlwANV5QPRVJ9oHjkOMi92uk7JFKBch6N4gdj/t+gTIC3q3VOUrHNdt0n+fx6B9qouYeVWCbyQjjojmMKnkh/tvKvBOgtQZuzOjZIrTNtWy6+zfPamVPwNo893gLh8+oK+xZWIL+N5uSU55PT3yhodvKQb1wW03/tjllyidK7uImPG9Y+Qq/t8qB2U7ZIFykDIFvV8ytzQPaomag3I3CAuFU870RByK9ABcVW38Vmc16uQZb6TlRtm9mdehBZML6MJRvo1aQtfj0JnzYq2jutKhJFYdE+ouDAHVLqSJVH83BQk9L5/QynzOleRKG5rGOZEkTak65U66gHkHL1e29NalvLYot93f7cPYujGnG20WVqo2ifvk6aOKx/uc4o5Nni//Ave06NRC5U1yUitqh1kDtLPry4G430KvzIU5NxS9pmV1I5rK6y5tywv0dl/Kok6lTJb+WoNnNxUOxcQwmGf6r3568DBlv8wyFDNUm10tux6dIiCdu7kpgLvSVXpIrscJLHlZOsySSM59pxN/USc612gtldZDC4iLN1V6a8gjisyzotX4j6nNfAo8hZ6soDZxrcT6Sp4IJt1I0swZTJj7xI2PWwUH+qhPqXvKcl7LMimpHkhoCkqgSDdvM32rwDxJTKBEX4iWmR24VzmxJwYqLbBM0lxWn2qQrnAoGOcPCLf4Wv5wJe5E3oCWn2IcYdpiaui/WInX7qkHs3FcSW/t5Q8fJZGW4m//PhOROxElgjOdBUOhelff/1RsYBd0XQ+/BUPFpiWO16nPHvaR5nEt3RMN0J1Og97JxpotCOM2PikjCJf2iwjkcHaa UEtFNsnk k6MKANo4Hs+e5lFgIb6GZ5/CvXC8XIZhSUflS/JMyYQouBH3mEAjf6ckZDTTpv97n2UQNsGeqMQxr2U57lseBnhUQTuxsSTLn/GU5UftJmMN0C1xBHxXq/qSV8jdb7xsIRgK6LwWGcpx8hunN+c8XamPr3D45cDDpgt4lLlT4Gqv3aYJJZkd37c2zjKmGZjAlSYxTERDcdfEN4JXn1hE6no9wMVs1h+mpum9QCmkzEYFH56THGxQLvNcuGZ70lfcv/skArHpi1IvPFY8fbOPDyGsP3xj4fUD5bOKkHLatZNO76ehPYqMc2jfqEEvEvS6rP/YWFF4EbgPrvOtr5YAbFmF9ykp7xTEWaENWTuLqDmX9QPomht8aNAbuLA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000685, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 11, 2024 at 12:12:14PM -0400, Johannes Weiner wrote: > All zswap backends track their pool sizes in pages. Currently they > multiply by PAGE_SIZE for zswap, only for zswap to divide again in > order to do limit math. Report pages directly. Nice. Although I would prefer renaming the zpool interface to total_pages and renaming the zpool backends functions as well to use pages rather than size. Either way: Acked-by: Yosry Ahmed