From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF88FC5478C for ; Mon, 26 Feb 2024 18:43:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1757E4401AE; Mon, 26 Feb 2024 13:43:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 123C344017F; Mon, 26 Feb 2024 13:43:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F063A4401AE; Mon, 26 Feb 2024 13:43:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DDC2C44017F for ; Mon, 26 Feb 2024 13:43:39 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5CDCEC0A19 for ; Mon, 26 Feb 2024 18:43:39 +0000 (UTC) X-FDA: 81834828558.30.368C54E Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) by imf26.hostedemail.com (Postfix) with ESMTP id AF574140021 for ; Mon, 26 Feb 2024 18:43:36 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Fxg1JFG0; spf=pass (imf26.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.210.51 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708973016; a=rsa-sha256; cv=none; b=U0oxnICR1+U0TvS+U8a4QqzZKT0BVPk9Dax3pYm7rlAR/vmMkc9f94+a5yCfFZ4EW7Np9+ bE96MomryiOm75KF5qzUGwfRz3FA53J8mg/tmsHr9JPGqH+E/IBHZ38uC9o6mqVa9uQH39 NFfm78XKHmjHeuv6bPkUpBmK+rZBjLg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Fxg1JFG0; spf=pass (imf26.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.210.51 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708973016; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DAkbitPXYXtd7UV/o6SYG/LfxMkpu6ctTHaHbiVeocc=; b=LRicat6piqLwCG9RiLs4MZ1FV+Av1uyD9r7C1t8UikYb9+To885SYtHatsaoESIsUjUG/n VW7B99VbYRoL7p5Q2CUTIgNUqvBoPIe1F/pycwNP2y2WjzPOavZ1ut4dt6+hU1pKHqQet+ tny5zLmCP9UPVsqwgLSBcNFWrZBOW5U= Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-6e47a2edc05so1408745a34.3 for ; Mon, 26 Feb 2024 10:43:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708973016; x=1709577816; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=DAkbitPXYXtd7UV/o6SYG/LfxMkpu6ctTHaHbiVeocc=; b=Fxg1JFG0234RoGZumA1vq1rLTtsDpHp0kA/OIJBxl4NEqBj/HgfHqDNRqWITLsVEFO gaLfBcViyXuOUYrs0n5JKGy5oLVSVeFkNy1Bv/nfL5ZCTVfjbp8QJzDUUgzl1wKJwABP Qm/jCt2N9IFmA9JptwklKs4naJs2UUVxUxhxdmTjS+fifXFvqxVuU5o9mp3vMntJYJaj ZsmUwNBql+6urjx4+o/rHglpPhKlEBp/LPAl0LuD47JP596qB5ukwBp7xMHajxN4ohOu 6smGGYyb0DcMdOSU5CklYrnNnuCepNGD3CObyMigqoZCEwhUzWza4OPBKtVW9UaxlbeB QRtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708973016; x=1709577816; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DAkbitPXYXtd7UV/o6SYG/LfxMkpu6ctTHaHbiVeocc=; b=aKbcJjHfUixH9LAyA9MlW2GZjgeMR1FYLWnmqlCp57tjJtsy2pGr+mEXhuPUxP4pKj +q4z4QrDdixAdRO/AGvwIb6a3rFBbUD0fR+5EdDMG0HfHnBIqiB4mrCm2AJX9pcVrXW6 A4utHlBY/aQ6MgCTWvDAZXxcmCs5AMFq7fTuPtvSesV1BjCLKiKfvn5Ljf6TBdMraOqB rNnvr1vMhVzaHc8TA9HcfuMYUPYj2dq/aQ0jPhnayW5Gofz0jWA9jErDKT68SmhwiVmt P0uSZgy3WqjB57SDITyqROlvyFTXu/JD64UnP4HCHjb9rTpwQqlc7vcWG5zlIJhABGUQ 5ZLg== X-Forwarded-Encrypted: i=1; AJvYcCUdtJxmYILuihUgkEgGvhWnwHjgaJxblqitclV6V7DxZFqVgj/q2MeM0+lhm5nfjaEmkS2ILWJLykZXRVmbo/NTk20= X-Gm-Message-State: AOJu0YwHyQjihwB669fQKupnCKoKPRo0WbzUW6da5OfjijGrNYTi/Xe3 Q+vodCcnVYQD7IleecJv7dzOS2t2JPQn7Epy4anmLALqUJ2/tq3D X-Google-Smtp-Source: AGHT+IHJFjHVrXwCb+MKLtrxz4B3i7S6NFPxkP3MbyyfUUwlOxB03i2Y1kUIZWJF/NjtbadQv25Y/g== X-Received: by 2002:a05:6358:5e8b:b0:176:40d5:2bd5 with SMTP id z11-20020a0563585e8b00b0017640d52bd5mr11919424rwn.6.1708973015596; Mon, 26 Feb 2024 10:43:35 -0800 (PST) Received: from google.com ([2620:0:1000:8411:4943:f730:fe3c:820c]) by smtp.gmail.com with ESMTPSA id r32-20020a632060000000b005d30550f954sm4277845pgm.31.2024.02.26.10.43.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 10:43:34 -0800 (PST) Date: Mon, 26 Feb 2024 10:43:32 -0800 From: Minchan Kim To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, damon@lists.linux.dev, sj@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Michal Hocko , Johannes Weiner Subject: Re: [PATCH v2] mm: madvise: pageout: ignore references rather than clearing young Message-ID: References: <20240226005739.24350-1-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240226005739.24350-1-21cnbao@gmail.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: AF574140021 X-Stat-Signature: 3bchq7eq35yfes5x1hy5cdqa6m6w8bw4 X-Rspam-User: X-HE-Tag: 1708973016-754664 X-HE-Meta: U2FsdGVkX1+XKT9RRTUWp0J7VdHyFwCP76ydh6dS0gs0vAoCnTP61wZWMF3qJob4dCXafkwMsS+Hz1UjfjcA83gE/umR7223kA/utIb1VVf6V8vlDfqcgSwicZsGdglO++XYVNbSF/JqV6K3wCDpmM6kV3PSTiSI3iRrdEh6aFaFHJeMRCVMzVDztrZBZIPplPqPtxgULUf+kJtAxvXhFM+lHbgxBJiSSEh87xb9GfWSbZ2GSQ07OBO9n8xCYIaspla5dJ6CpudTkGqR6CQGyzSmwRYSxMzHk7vv0QqIDBD2VksVLMpHZzhuc9lasjuf6XJHm/D/mj/0W+DEG8rutJo5KtdzVZ9XMVki7Lq2vU/q3YCir3uVqpTn90eKTIqGlm7S1cYLmNKOk9CpPSAPWxfF9GhG4oXoiQA7RkSIk0brTAinOKw31c9+V+xwVJdZGC1ShPWahSpNEg1nsX359by1eg0Vor8vp/lSA7UfEcPTwtxxC0qG1p1b5yyD9e6x28oDNZyykwqLVByDOxRRPBT/XH6Tlykg6hV2lppGr54zJ9+Ris1PYc0/8KVAvMNgfoRVf/NeaBue1nASYNfFfmWyLbN/rsVVKOEjj7B1WVIQxfLPpsZwfXqcpYvC6PnEqtInr1rz1sl+sj4d1jAHjFB3GffQFsQuTiNpuGVf2oERT6plETlSLW/b46ex4adPsW09d3ESbAc3KtnGpvnP/Nb8aQ5qqn3XoccfxtgiDLNyGs0WDB49qGG+X5/ajA9ZenFFMCjU3pc/3GZvIg5XEA2cQG4mJWqyKFdiH8P5yRFhsTSOQVWu0dKRoJFNECkqfDKCk7oHceEs0hO5P5MY7Z5STrlspOfvphihd0PXu8MgC6mCJLHDbVvBqAr4xNUX7PER1GJk8OTxMrChjbd+wkGCHIcFasrYxwf4zipKHL4YNMJ1Ors6fxNTHB81n84SByNBB/uzlV+wOi2iY6r dkEEkVD8 R3Xnlp2Apu8aQUiG3ddC+0JJVUHt6zKTaboLL2K4J2Pq0fW5/3TXRO4zyHdHu3VrfF8Ek5Nr1c2x/Y6VYP7xotaMvmq4Umc4NVV3N9SmDp77QR9qhAnmRf+E+wwFjUW6m0yP+VeweUdzCsXIyELew8QHtaVSlF/LmXvEsb+5ilZjTl3yK+Hvvv+QW1Df6XQmPIQaiaXoLzrWWmDJ2lNYnRLz04hvndbHfk0qVQF/c9F1zcnZmKXfjo7MegtJ9FJI9hVsgdqhyHuhIj19OKXC4VX3TgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 01:57:39PM +1300, Barry Song wrote: > From: Barry Song > > While doing MADV_PAGEOUT, the current code will clear PTE young > so that vmscan won't read young flags to allow the reclamation > of madvised folios to go ahead. > It seems we can do it by directly ignoring references, thus we > can remove tlb flush in madvise and rmap overhead in vmscan. > > Regarding the side effect, in the original code, if a parallel > thread runs side by side to access the madvised memory with the > thread doing madvise, folios will get a chance to be re-activated > by vmscan (though the time gap is actually quite small since > checking PTEs is done immediately after clearing PTEs young). But > with this patch, they will still be reclaimed. But this behaviour > doing PAGEOUT and doing access at the same time is quite silly > like DoS. So probably, we don't need to care. Or ignoring the > new access during the quite small time gap is even better. > > For DAMON's DAMOS_PAGEOUT based on physical address region, we > still keep its behaviour as is since a physical address might > be mapped by multiple processes. MADV_PAGEOUT based on virtual > address is actually much more aggressive on reclamation. To > untouch paddr's DAMOS_PAGEOUT, we simply pass ignore_references > as false in reclaim_pages(). > > A microbench as below has shown 6% decrement on the latency of > MADV_PAGEOUT, > > #define PGSIZE 4096 > main() > { > int i; > #define SIZE 512*1024*1024 > volatile long *p = mmap(NULL, SIZE, PROT_READ | PROT_WRITE, > MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); > > for (i = 0; i < SIZE/sizeof(long); i += PGSIZE / sizeof(long)) > p[i] = 0x11; > > madvise(p, SIZE, MADV_PAGEOUT); > } > > w/o patch w/ patch > root@10:~# time ./a.out root@10:~# time ./a.out > real 0m49.634s real 0m46.334s > user 0m0.637s user 0m0.648s > sys 0m47.434s sys 0m44.265s > > Cc: SeongJae Park > Cc: Minchan Kim > Cc: Michal Hocko > Cc: Johannes Weiner > Signed-off-by: Barry Song Acked-by: Minchan Kim