From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49B0AC5478C for ; Mon, 26 Feb 2024 17:58:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE11C4401A7; Mon, 26 Feb 2024 12:58:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B912A44017F; Mon, 26 Feb 2024 12:58:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A31C74401A7; Mon, 26 Feb 2024 12:58:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9118D44017F for ; Mon, 26 Feb 2024 12:58:58 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 620ABC0A1E for ; Mon, 26 Feb 2024 17:58:58 +0000 (UTC) X-FDA: 81834715956.24.B2BFBBE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 875DB16000D for ; Mon, 26 Feb 2024 17:58:54 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JGn+ddpk; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708970336; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=29RQZolZJ+S71Y+xqolEPeXKycR8yatJmFhICqJiOuE=; b=0K+wnWm/MsUs/+GTRPtEipSRnKT0fzYZc5aPLv8MsHYRDxQt//+P8uqRdQ2AhOsDMc9GE0 qznJlgPigdQXIKz2mwzZgN/jHcXtP0QG7B/wFBhH4ZI5i7NPOvEsbBN2YNJuPd1W0d/ekV z+V2yxbpMW1OQ2eq4SQAO2Nxglt77jQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JGn+ddpk; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708970336; a=rsa-sha256; cv=none; b=43tjaDruwGZHvnmw6YOLDUP6iWP4eUuPAb+Kl5JeILTESg2zq00krgGBmq3/lGFJoitzoY MMcPxHGTo3sqNNpWK0Yh7N95RCc7X8hD81abHRhXkdQKuS6FVJi8xEOQ4etpEi8GY6eXrn FwvlhBEuUifz5eXiU3ql+damvAyFxc8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=29RQZolZJ+S71Y+xqolEPeXKycR8yatJmFhICqJiOuE=; b=JGn+ddpkrdBTTW6om/gUMcO+ha pBUlwhCxIymXSDTVQ2PS/YUum0YlBaQoERJsHAfkOI0kU8bdOq2WUcqzjFm+7NInu9R7M9ZNEgjh9 BfTnjLwVQVeMt9hDDFVhKdHgQqtHkPljk7v9WPXSF+KYsC4utfxOQP4E8S9kKY19GIEZvBEzCD3bV mbrA/wD0H633S2uXVjCXsvoZzexM8sEeU67m6PvCd4zuC5uLp8o4svfLErdr6IlyPca2T6zjNxXQn eepmZFZCY/LmfekHWR5QnZX0D3SCKQw1oYZ0IdjbqhpG937wvZ70jZCPrxxR189CiHAJ6CfuxuqHI iAkwOwQQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1refFT-00000000Dcf-1Gir; Mon, 26 Feb 2024 17:58:43 +0000 Date: Mon, 26 Feb 2024 17:58:43 +0000 From: Matthew Wilcox To: "Pankaj Raghav (Samsung)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, mcgrof@kernel.org, ziy@nvidia.com, hare@suse.de, djwong@kernel.org, gost.dev@samsung.com, linux-mm@kvack.org, Pankaj Raghav Subject: Re: [PATCH 10/13] iomap: fix iomap_dio_zero() for fs bs > system page size Message-ID: References: <20240226094936.2677493-1-kernel@pankajraghav.com> <20240226094936.2677493-11-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240226094936.2677493-11-kernel@pankajraghav.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 875DB16000D X-Stat-Signature: uds531pn5imqogze7bimekc81496qswa X-Rspam-User: X-HE-Tag: 1708970334-795492 X-HE-Meta: U2FsdGVkX18r2Yb+eQGy4+JVkjlgLSShRuh0oi8SmjVANv+HtwDfrhyE2GMo5dloK0EsxVE34TEv5pHBZAyHQDLPEORmPNk6sG2xJtOiBmG5aw75a3WiBOzAh54VHAZpjmkik9ebRnUtVE66I1M+WBBvjIfay9nRS85XyTnPzpwkXVxAcpHuZdR4GGaMkon4nzIg7I1BGmSm2Po7rFD/2nrSP3neLM0mTT9g94wyYa6Zdn920fcAWWOSZ86RkmFLQW66HDCIlOZ+K61yHlEIbaPY1W6aj4V7IiMHpn/kDunnhLcTauA2W6MpGQFmR0sc2WdHFk4/Y/VUtUtL07DOaSNFKV2g2RD0KWXAVr/CEtWm6yZOUU9zBZpTetCarqu6xa+FzKiwPdEgpr5MmdIvGczwEuyFcttC5Ngcn0kUJa2+5UGP8dPoMfMLkvSa+n315qnjeDdjbJSO0YNtOPiJ2e+HxvxtOyxvY+O+kAeD2R/nP35DpYwkKmzCSUxBTTyU80zT46Yy3yrQ4CiiZMlcydwDnbfYuobG9wnQVg9Z5CYhjk5A4KXvWAuVwW0dgsNAfeyma9DLii3yBWaOyNF7yZjiAy8SsHQ1D8qTmfXduhXp8bPlz1hqcs1SBTJ5Ft4WRGdem8tLeJIyhbqyDsyR+ekTcfnWjY16VDWywsR9triOgu1SzSLrhaNrnEicGVZQ5FPV9+XhdzZo8CFaVX9BdwiV2VqtqD0fBeQI2Trp5V83kIQOPYwC2JFVo5/7G9NiOk374hAxVoUQg2kmW92KiyB3kBMpAyV8QiJnAon1yktBgho9qVx+SxPzwucs8A3iOwpQbdzGHItln1E/oZNTqCE8lMaL8TaqrHu5j6jWx7xQfLQaNsCA4Ii3/2IS1JAp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 10:49:33AM +0100, Pankaj Raghav (Samsung) wrote: > +++ b/fs/iomap/direct-io.c > @@ -239,14 +239,23 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, > struct page *page = ZERO_PAGE(0); > struct bio *bio; > > - bio = iomap_dio_alloc_bio(iter, dio, 1, REQ_OP_WRITE | REQ_SYNC | REQ_IDLE); > + WARN_ON_ONCE(len > (BIO_MAX_VECS * PAGE_SIZE)); > + > + bio = iomap_dio_alloc_bio(iter, dio, BIO_MAX_VECS, > + REQ_OP_WRITE | REQ_SYNC | REQ_IDLE); > fscrypt_set_bio_crypt_ctx(bio, inode, pos >> inode->i_blkbits, > GFP_KERNEL); > + > bio->bi_iter.bi_sector = iomap_sector(&iter->iomap, pos); > bio->bi_private = dio; > bio->bi_end_io = iomap_dio_bio_end_io; > > - __bio_add_page(bio, page, len, 0); > + while (len) { > + unsigned int io_len = min_t(unsigned int, len, PAGE_SIZE); > + > + __bio_add_page(bio, page, io_len, 0); > + len -= io_len; > + } I thought we were going to use the huge_zero_page for this?