From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD985C48BF6 for ; Mon, 26 Feb 2024 14:49:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29589440174; Mon, 26 Feb 2024 09:49:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 24537440147; Mon, 26 Feb 2024 09:49:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10CED440174; Mon, 26 Feb 2024 09:49:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F2CE7440147 for ; Mon, 26 Feb 2024 09:49:14 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 429E7C098D for ; Mon, 26 Feb 2024 14:49:14 +0000 (UTC) X-FDA: 81834237828.25.8FCF3E1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 97A9A20021 for ; Mon, 26 Feb 2024 14:49:12 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Gx/LvP7E"; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708958952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c3UKkTKYCLN0pQgtkmF5pW4a1ghAwfGWMKL7VSuA/Bs=; b=2rhQmwhlktj2PhwglTry8zMp9VWz1V8spfhArGwHDmjXJVkLiRqc4FbsRXTusBQDImZdBh xwN7XqP5OOaXMBOWMIKpt8/g1eGDC7dWGc1z73EaA4WiibMxiVPxcHiUzTmtB5hLzyjoKb AbqcUZmEOSHTy+sKTnzAU1vdUVIrM5U= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Gx/LvP7E"; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708958952; a=rsa-sha256; cv=none; b=rMFJB6Bf9cavSL2GsRD/zCTjDThnDg0gyJvWzivdWwp3hBzZcAjruxRSZF7vvyrNnVglPA uDN74mCkqpB0xbYkP27F3LtoSjihKgbWo1vidsISVC7EntfME0rikciU18mLW/HnL1ZNCQ lzG7yQacC1oy4MOOp14k4PIzDt8/7RA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=c3UKkTKYCLN0pQgtkmF5pW4a1ghAwfGWMKL7VSuA/Bs=; b=Gx/LvP7E9EXUucEHgU+fzRNAZL igMHh+WhwMi1IZrFWTebwuVbrmsubNVoNB52Nq/mM/Gs/B+zwQSPn+0aaYo+tVc7ytsTJ415EG9Z+ ozcwirimTHULZHZz17ru0C/ShAe1F89BhUFoB8F07HRrZqAHi4MvxnhHF0LX0mrlp66dorftyV95R rExz9aL8iQBVltDD6d5BaSfCj6oSj/wUHJCHcuugD9xdbULnY1EuJ5zI0gtQwfAFFkpEZaFR2Nj3z mTdmW6gwowyJZ9ukP9jM/MczICkkTgPl2XnUQSGDA+jx+XDr6p5QH15fyRON+2iPV3LbflLpQjLjT IxGOUHhw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1recHw-0000000HQQ4-2qeY; Mon, 26 Feb 2024 14:49:04 +0000 Date: Mon, 26 Feb 2024 14:49:04 +0000 From: Matthew Wilcox To: "Pankaj Raghav (Samsung)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, mcgrof@kernel.org, ziy@nvidia.com, hare@suse.de, djwong@kernel.org, gost.dev@samsung.com, linux-mm@kvack.org, Pankaj Raghav Subject: Re: [PATCH 05/13] readahead: set file_ra_state->ra_pages to be at least mapping_min_order Message-ID: References: <20240226094936.2677493-1-kernel@pankajraghav.com> <20240226094936.2677493-6-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240226094936.2677493-6-kernel@pankajraghav.com> X-Rspam-User: X-Stat-Signature: b87iqrkdpordsj73qdn4hs9oca9me5hd X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 97A9A20021 X-HE-Tag: 1708958952-532910 X-HE-Meta: U2FsdGVkX1/HifaUCsPo04g0MeWGcWEptqNw1oxH9hAlL9k97A7ZD3YDGGtqviLYQwCUMWtUanPQyvNPL1Rd8Q1YYPnY/uKLLPQRdApWC6GfM2aS2zHkVLOSKImB90DLUHMIe2zHY8fiaSLU31RU6HAfoUpGbHoFmMwaap6d2fP+unJsXvPnqbU+cXzJiq6n3rOTX4Wj18oZc8az1gnXtJubWOUMqTPc8RvI6Hv+OdRULrbTHvFqNA/WC8ZPYvqTOBG1ABW8El61fUTxtSgv+Aq01+Q9LG2GYDkxCFvBK+8CT7VfuiV/CMhQ40Cl3azIPUvNjaChZ/ApPbZ5ZocLcsyyVxXn1q/CKF1RlW/LyHrVcUq8Vl0Zyoyfm+JCi51NQh+bPSdO0LOwt/m4y5w/Q7g9YaMuyoigntpFqk/rNZA8pz+2XL7IFiwWUi5k3Uf45renPACWzghhXCJDlMmXUavjISu5iwOeytKf3o9bqh69pDz+XfHxC2dM9yK3CPbmKZPzb5xiv6R+teFoC8mpqAUIF/gXQHBx0opWqBv/UH8XG5THXbGuIqxw8wW+3K+MzC8BSmhV3/1451xYdCAH+aA6acfbWKdfFOgPTE3DnROSRXuW8rSmg6MSzEHstT6LuSasZzdGpC41og8mfspRtK2U77vyZQ2FYpbvgJ7Bo44UQE0lBil78d4eWTWpYKrUwPDlm6H7IwJLQYLtanZsXyfrFxgiMB/MU2osl9YCyrdyI50qowmcmUwISBs8lRiR7FjgYRHSkWJs1WDgeM+R+RuJhO/Li55Ll4/rG4BbdqWkPGhcexN9P7lv+J8hjefa6YMBnTkBSWKxxw/aeQ+vExFVStaj/JQ8Y/aPNh/O4w62ndszvRDqZ8oTAQ05RYy5E7T+I2F4P9tTHFkSv5Y+sMZ0t2kYbHCdRsAx042pPGoT2dw2tqTTsORSlyZqncehs5qJ9N5k3oHuZ88qrNp 31orP991 J1zr/5OobKx/scafBQKoh4OWGaDkvf3ejSE/1V52H+QoPQ25t28mk2/0swIYJi6Iup4PX+cV8V6eyiwMaYbuwqhKZflkgUFWXXQX5ojWhEwKIpaI4GU1oqZDCT+29dspO6hXq5tugKndLs0JLPcs7SMnQkmkFMs4jpCIE6dXkvwdB9VpNZMw7JEsLZCBeVVuRstgoQkWr8TtBZt3y/iBM6tkwXiXy4hQfWYDIkprZR/BtMlWnYgHZwyKtEA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 10:49:28AM +0100, Pankaj Raghav (Samsung) wrote: > From: Luis Chamberlain > > Set the file_ra_state->ra_pages in file_ra_state_init() to be at least > mapping_min_order of pages if the bdi->ra_pages is less than that. Don't we rather want to round up to a multiple of mapping_min_nrpages? > file_ra_state_init(struct file_ra_state *ra, struct address_space *mapping) > { > + unsigned int min_nrpages = mapping_min_folio_nrpages(mapping); > + > ra->ra_pages = inode_to_bdi(mapping->host)->ra_pages; > + if (ra->ra_pages < min_nrpages) > + ra->ra_pages = min_nrpages; > ra->prev_pos = -1;