From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34841C54E49 for ; Mon, 26 Feb 2024 13:26:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9D2A440161; Mon, 26 Feb 2024 08:26:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A4D26440147; Mon, 26 Feb 2024 08:26:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9158B440161; Mon, 26 Feb 2024 08:26:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7F4DF440147 for ; Mon, 26 Feb 2024 08:26:38 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5AF0A14084F for ; Mon, 26 Feb 2024 13:26:38 +0000 (UTC) X-FDA: 81834029676.05.25E7822 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id B1BE5A0009 for ; Mon, 26 Feb 2024 13:26:36 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=eeBcRC4Y; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708953996; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+cq3hzUEhbXThrvu7ftbcKy0Wd8FG0mI00L77ictR6s=; b=OaKa0UDPUbA8kgB/Y/5+1827Ob3JdOzCEJjMUy/POzRbk+St0f3OeCTsheBT+RCOcrO4Bm HgnC+ZcKRkFJsf3opXWnlNPIUSqnAtOcfGHfYg5Cadax5tmFCRKs1m2wMD1seC2NNlxZpC DjYnvxJFVI0OvGQmYuVeMoqAEXE6wsc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708953996; a=rsa-sha256; cv=none; b=r8mInvKiZIzqYlJ2mgXWztxbELs26HLCXQbaKN6wpaZH0RTEc3iTMd+DG6HgmQAUetsPnL j+8kvYXIskIg4csSUZsLBX2krwKf+JWuCPmutGknrNJ2oka51BxtUk/7yeBJwzV9aSFmVm PPe1s1zJXvpUUnYJNs41rByDCG52fYk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=eeBcRC4Y; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+cq3hzUEhbXThrvu7ftbcKy0Wd8FG0mI00L77ictR6s=; b=eeBcRC4YHIM1lXSFhfDDRxapuW PdGoIztV67c2/pSrO1a13bqEIjN9KeeAornjhwyu+YHYNXvGnwfG9EZ0lM3RtED5g76Xn4S6HaGp4 aX75OImTQXT7D7NrOVljjlxaCOoqN/Z8MaOQFzULiELU6uFzc0LKf/6xtcHppDdp0XhZSEce2ny0r hTVK2GBpe0vdSvJYjEwLmA/zz6MdqV+L//IhNuurwa8vVzs+E36cL3FbWicohSuDTWy87kzTSI1kw 8zrAPIeBUxYBIVTkuK0HNFpz0sy1crOvU+DW8Q+eExiII0j/vmFCTkZ9Xt2EnFhknLZueT4CEL91L IY4m3JwA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1reb02-0000000HFGx-3ek1; Mon, 26 Feb 2024 13:26:30 +0000 Date: Mon, 26 Feb 2024 13:26:30 +0000 From: Matthew Wilcox To: "Pankaj Raghav (Samsung)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, mcgrof@kernel.org, ziy@nvidia.com, hare@suse.de, djwong@kernel.org, gost.dev@samsung.com, linux-mm@kvack.org, Pankaj Raghav Subject: Re: [PATCH 13/13] xfs: enable block size larger than page size support Message-ID: References: <20240226094936.2677493-1-kernel@pankajraghav.com> <20240226094936.2677493-14-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240226094936.2677493-14-kernel@pankajraghav.com> X-Rspamd-Queue-Id: B1BE5A0009 X-Rspam-User: X-Stat-Signature: 4h3zoebroqbxy6kdw3f3s3bmtm98iyaz X-Rspamd-Server: rspam03 X-HE-Tag: 1708953996-831682 X-HE-Meta: U2FsdGVkX193FItsCEIt3eqE+KiNICzviontuFg0zfbLkohxFW6h0El3fQJaIAGel6mAmIwqDsP445EU2OvnHMi5w1fr8iVrJYBkLnhYui5rYpuMfCv/MsfSkagZ76GHqQutMHccqS6Lsvh4uCvb7fCVZAtJdU+y5UpJNxlslgIj7ChzGMPFbQd205Chz4XByC9Yc+xblDKNWscE+HI9Hz5CTn1k0xSZz2hRQVhTgsUQe09qOShq1taQIasgv3wJgsy8s0QWSaGFyINQe8MWzF6wXgXka2aVWDbgE2vbzb9tdpI30A9G94EqMtcdP5dxnMz8MPsbRofR9svjPMhpeWYhP6pHDI5I61AA0bmws589ATYDU8SP3C4CuDXbio4YEIUVehg8RvvHHI/e8INW6dwLEX998okFaNFwr1FGebfOquzAr3czplEPpTt3kjSlrvdBm81dnOtBup20oqGJX91t8cLwhGbxmgQa7gt0xQ7HGHz/E6HDDjVgvGuXrROz1sy0oXP72YZm762LJqED1WQ8Ez5lXMBNJqdHxkM5sgfIrFJgIPReRW46Ld/079AutjNJ9718GM6Ine6eHxIVVdOsP2RA3dEPuBX1XabmGihogU3tBQdhJSBGomeI7khXcbuzvBqcJxy3BHhzVRQ7CSKcAOYt1cldxodObSolK91brw2vuHfuW89M/q198w385cA+/5GDGdKxU42ttPi708b0bqzml7VQQzfjjiVtrGTV+wEOPylvcYv4igqVxOyMDT44QwsE8Ml0ZSOqunsEj46xgkwfVldmqvRFnmIigs9KK1fxhYKA/rPaSqWhvohTQ0wWfYHJEGE7UszxhfaeZOQ8HNjsYwJkFELa1u/f458lZgac17IR0B32UqaY3pguGc5PsDEnYaYd5OJtuJOHzcnv4F/IqievgOncJfE5jvl3FL9BvU8iUDfpKw+uxMHb0NfMWx/OVXm/SrVbGFz 6KECzbcj SQD07zSRFeM44SqpMupfE0W2G94jgm1n+a5grAmkcge/QltRUy2VDTBILVdmtgSbt5K+p6lPeXfJHdivbZYoICgGebqkWbpoNY8DRUbuDrJC6fhaBDiobNuMIsQRWWbFfwBswAebUl2GfoeA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 10:49:36AM +0100, Pankaj Raghav (Samsung) wrote: > @@ -1625,16 +1625,10 @@ xfs_fs_fill_super( > goto out_free_sb; > } > > - /* > - * Until this is fixed only page-sized or smaller data blocks work. > - */ > if (mp->m_sb.sb_blocksize > PAGE_SIZE) { > xfs_warn(mp, > - "File system with blocksize %d bytes. " > - "Only pagesize (%ld) or less will currently work.", > - mp->m_sb.sb_blocksize, PAGE_SIZE); > - error = -ENOSYS; > - goto out_free_sb; > +"EXPERIMENTAL: Filesystem with Large Block Size (%d bytes) enabled.", > + mp->m_sb.sb_blocksize); WARN seems a little high for this. xfs_notice() or xfs_info() would seem more appropriate: #define KERN_WARNING KERN_SOH "4" /* warning conditions */ #define KERN_NOTICE KERN_SOH "5" /* normal but significant condition */ #define KERN_INFO KERN_SOH "6" /* informational */