From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B54EC54E49 for ; Mon, 26 Feb 2024 13:22:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B42D4440160; Mon, 26 Feb 2024 08:22:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE716440147; Mon, 26 Feb 2024 08:22:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D5AA440160; Mon, 26 Feb 2024 08:22:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8F0B8440147 for ; Mon, 26 Feb 2024 08:22:08 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 35C5A1C09C2 for ; Mon, 26 Feb 2024 13:22:08 +0000 (UTC) X-FDA: 81834018336.25.6423F0A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 93BA8A000D for ; Mon, 26 Feb 2024 13:22:06 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OQr75EHy; dmarc=none; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708953726; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FOEO53PWfz8jVV9tqBTYQ+FUQRTS1bvm3k8jdLn41jA=; b=UuxmHFva+lM+/Isnep+en+bEk/RWY7HAvaKO/QNM5lmzCr74kwuBf/3o1Jdjm9PU0L3Mb+ j7HT1/iBHiNTZrmYC8YA1E78QV+t0Yoe7kP+5bOTL91rHntH6QNP7tWquzI0f4rlsLnhGM JKWKqxsVCZzCGjlEJDKCTvcMZpkI7ig= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OQr75EHy; dmarc=none; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708953726; a=rsa-sha256; cv=none; b=Dq3XdXIpyprJF86NMp6n336fzEKcBG5GBU45Vx0GF4YoCLLp05draOVYntK7J1G+2mwLjy t7F1zdntgAeqIYyRn9KOaOY76HpsyGE/vyHa52bQijnTl4AZdYStl3eLN4jGDXJ3dkfCqI RohjZVq5lau304FfvDLpGQVgWtJTJCU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FOEO53PWfz8jVV9tqBTYQ+FUQRTS1bvm3k8jdLn41jA=; b=OQr75EHyHvbJCafMkmm/u1U9WI rSXH+ccZ23rmyziIKdQuyZHcIOIEAarZQfY3CZ+sW2Bs2bcKF0Jf5btQQux+Fe4wU5/ihvYNKUvZ2 3wC21wd5ZMtIyb6yDO1Tl3deOcGLOMsj8hZwpQs/rtG5GSki/I/GJWEMcPnvpzk7Pd9Hn1AE17tDo 1XfjuN4IMv3/ZassAySEFV9njPS2tsqul4pzMedj8i6IorgoDdqTU/Xkn4IRSsLLipvXMzJPny8Qo Ximm6jprNiDZNDAd7NUxwMxhCIEOH48MXeQ7ytjySnL5agTbNCVV893+/Iv1RpIHaTBlcUefT/SCp NU/gvkiA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1reavd-0000000HEuq-0Ow6; Mon, 26 Feb 2024 13:21:57 +0000 Date: Mon, 26 Feb 2024 13:21:56 +0000 From: Matthew Wilcox To: "Pankaj Raghav (Samsung)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, mcgrof@kernel.org, ziy@nvidia.com, hare@suse.de, djwong@kernel.org, gost.dev@samsung.com, linux-mm@kvack.org, Pankaj Raghav Subject: Re: [PATCH 12/13] xfs: make the calculation generic in xfs_sb_validate_fsb_count() Message-ID: References: <20240226094936.2677493-1-kernel@pankajraghav.com> <20240226094936.2677493-13-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240226094936.2677493-13-kernel@pankajraghav.com> X-Rspamd-Queue-Id: 93BA8A000D X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: y933cbhbugm7qqmp6tm1nfsi79ghu4gw X-HE-Tag: 1708953726-755424 X-HE-Meta: U2FsdGVkX1+OotdBPv+6TFD8PxbUg8AccLNmRfsBH3I2tIFEjVDEhXyMxz2z8wexiL/yhLCAz8P6iNX7xTf0bhyl7MpjWw5kO2nWqYFqxRf+pHu83ikEF5aKMiWrvIjsnaJOjVw2IE0p6KVYvvIqlx77MRLV+WfktYHySCe4YbZqFWKsAr01uR3QAoGOk5mJIs+IoUT/XJJES1E7pl4jT8lXxVg7bUqvu5+WixynfWKeT26aBZILxfTjwPqNrQ8Ym8NFkf5+wjJpZDD2DTQumarmFuuibXyiIEWDMJ33UoIqed0vjVHJjekhqkZfhXfG8PHx8wQwmH0fLfCW54cl14GupSppiQkotJqLDxct70iJs0SdkZf+R87/GrMGUuumOqbPtxbaLwylb3wyhY/JihyqMsAYH9D3afmYKwKC98Eo2h/sH1azBDq0MJgnmwknl2DqlkqxkLas4a7lQA/FsIDNVmKBtAlzS9bVIPFmgIEuP9D6Kpyg9Cmouzb/x8kIqhhYUjQtF1BTX2PUG9uEySRFPQ4yiRXHMcTXmQhAt1noA1BcVjbwPV7XKS+qcuRocWPDvHlGCjmQm++jekC8zDyyYw9gec0DSSgvF/VLfISbTv+DrW5ib9ijmqvBehmGFP1817ObIeyTK/J95faoKLV1KADLC2InfHIiWmlK4LH3WIBjdDM5nYGr0DlPgwfjbxEMg+16nQIXzSSm0qsfV2oT5yecDjbu/vcF/CLkMErnUKJEhgIvzn4FkJzopJHnToAf4g93yEIlbIkp/GK/86bZr8p7yIEzryj0R6OXDHiAF15rN/pZQInIPVUVy3hKhWTT4pzpo8VVs/E9aw0ZzDa0iHgjecLLywIL6zWiSVGm+e+S69feO5tO2Q3mRynG4Ibmm0tb0oobhMNMASkJIFZNk5RzxTrTl0R9G1mcZHxdsVV2hXk4iGqVxzKZNPCDPuPq3jUNsci5lSeyl34 pLZtCHXj URtgq+1nnOfR/+m2/41VLiNHgbgGCOgAoGRE1KfVgR8i5jgcADxEdk7XJaQGOGpI0eBjHdjy7/+UoN1OUL6lKLP9rmpGRoUwwKYH0pqwXw1gzsJTaKt5hByA6puXjzuNTccqYOvjltubQNvxM2VjrRrZ3YdLbtuaEkJqZld8OpF9fkPboRKr39iAmow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000025, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 10:49:35AM +0100, Pankaj Raghav (Samsung) wrote: > + if (check_mul_overflow(nblocks, (1 << sbp->sb_blocklog), &bytes)) Why would you not use check_shl_overflow()? > + return -EFBIG; > + > + mapping_count = bytes >> PAGE_SHIFT; > /* Limited by ULONG_MAX of page cache index */ > - if (nblocks >> (PAGE_SHIFT - sbp->sb_blocklog) > ULONG_MAX) > + if (mapping_count > ULONG_MAX) > return -EFBIG; > return 0; > } > -- > 2.43.0 >