From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76DBBC54E49 for ; Mon, 26 Feb 2024 12:44:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD118440154; Mon, 26 Feb 2024 07:44:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D80C4440147; Mon, 26 Feb 2024 07:44:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C20EE440154; Mon, 26 Feb 2024 07:44:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AF134440147 for ; Mon, 26 Feb 2024 07:44:22 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 804E212086F for ; Mon, 26 Feb 2024 12:44:22 +0000 (UTC) X-FDA: 81833923164.22.9D617E7 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf11.hostedemail.com (Postfix) with ESMTP id BB97140009 for ; Mon, 26 Feb 2024 12:44:20 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b="B+X/vnjb"; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf11.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708951460; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V9GRrB7FsQKdoO/mCKPDN/I5gsB0+aF7FI7yJuEpIP4=; b=Jp1/pjAMCkNNwtOx1i1AuvtS6BQkFoaYm9a4ySshW836Y8QxYVzD8ziInH/iIChldsdJQ+ bAxUzFGFPML9tSY1L2nE811/OKCtB5AASLligizY1wDhVPssoO3hP0of3Hund/e9DpT9UM e+qMDMJmUhm/0LukJNuMYpyrm6mHLjA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b="B+X/vnjb"; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf11.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708951460; a=rsa-sha256; cv=none; b=Oi2dV6OOOWZXZGuch2/ICPZi1BHOWJ9lSElwER2kTtmDa9EqO1U6SdfgIQ5fbOYKGiZ6ah WUZtQhX20p0YEEmYHapLh5QMTMu9OXos4FOFtjgk0ahli1gwxqdPcjudwCpL7Gr3OPSTXt wxakg1rcoOt910I5lCqWxOVo+rjjKvY= Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6d9f94b9186so2658482b3a.0 for ; Mon, 26 Feb 2024 04:44:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1708951459; x=1709556259; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=V9GRrB7FsQKdoO/mCKPDN/I5gsB0+aF7FI7yJuEpIP4=; b=B+X/vnjbJOQY7BLUx17Nif2+nKeAcNKGHP2J/hNN6e04pz0UlyHJpIVl2b4Wf09zJq cq8uB21WRiokJWnVFc+nRzQ5gaagq1CS3NrDIH2EUQsT5YdMdlthzy/LxfzeWxS1/43d tYxjdscmpMVv22itpVJPfbmoTLakCDlHK2HrfzAS26nlBiafN6WGxzqrXTySEBiGFJZQ lD+eDTjuLjAzgMEefn4mGDP8BQrcla5q2TLMo/e0t9qOXF59NAAONBP/grOwp8Y9IFfQ lV3ZdSpSwLGxsqdaFbjruGBSKAx1N9GP0fxPKOisnIApiZDsnKMQLiq+siPsWjdfzO3i TQ/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708951459; x=1709556259; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V9GRrB7FsQKdoO/mCKPDN/I5gsB0+aF7FI7yJuEpIP4=; b=HSfBWpG542mZ/qhtNJcMBWbCgQT+LhjyQAOYeNxG2f2bC+FAWy22a1ZnrtGv8uVb2Y 9U5MkTjDGrd1Nwf4Sy8teAQHrqIZwR6XJcf9K41Q7bccYU90a70EUaQWMHUsR8DrP+dy kUcujCqUjwnFEjUYXk4MiKN1ajl8ggdjpH9bDSWuRlPzm/t1cZHupEICAe0CbRFub4p0 B2YpFzS1fnvwqSjqsAZ/AaF3dDXRO1J8zegK1NpytZJXLmOgdMAHQlIlFivtf+w4RbKd CGdszhzJD50CblUhgzFZe9T9MFD4ZNcjRGb9On3BgobtMnYyutP9ONBiPX75i9RWakb5 HmKA== X-Forwarded-Encrypted: i=1; AJvYcCVe6/HHTSn8RZqroF0FSBdpAOgT8NFqNN8/WjHhS0B2xAbeYcaa0PL/lEFUhe2f46E8Pthjcebwk7DYtta2gxJnl2s= X-Gm-Message-State: AOJu0YyslYtHat4yWg5Xn5Ml4Ry84Vg9LGQFhJYuMZXZncXajLjiAKrt ThFXzXNU7PpjS4k23V1kQLxdUPudFoxzMUdHVM+kR6yVaj+qz5WrhwdE2cbS3UA= X-Google-Smtp-Source: AGHT+IGVIPYZ6gPZ6GL6KlSqg0tncDkt7FDH+J+n2o4zbqRm8gNCsIbUHWADIPqxmkwXqGjloP0o5A== X-Received: by 2002:aa7:9d9a:0:b0:6e4:59b7:1dd4 with SMTP id f26-20020aa79d9a000000b006e459b71dd4mr7434462pfq.31.1708951459543; Mon, 26 Feb 2024 04:44:19 -0800 (PST) Received: from dread.disaster.area (pa49-181-247-196.pa.nsw.optusnet.com.au. [49.181.247.196]) by smtp.gmail.com with ESMTPSA id b27-20020aa78edb000000b006e4195cccb5sm1385769pfr.133.2024.02.26.04.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 04:44:19 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1reaLA-00Bkux-1O; Mon, 26 Feb 2024 23:44:16 +1100 Date: Mon, 26 Feb 2024 23:44:16 +1100 From: Dave Chinner To: "Pankaj Raghav (Samsung)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, chandan.babu@oracle.com, akpm@linux-foundation.org, mcgrof@kernel.org, ziy@nvidia.com, hare@suse.de, djwong@kernel.org, gost.dev@samsung.com, linux-mm@kvack.org, willy@infradead.org, Dave Chinner Subject: Re: [PATCH 11/13] xfs: expose block size in stat Message-ID: References: <20240226094936.2677493-1-kernel@pankajraghav.com> <20240226094936.2677493-12-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240226094936.2677493-12-kernel@pankajraghav.com> X-Rspam-User: X-Stat-Signature: 6acigi8emd169zpfnfb1fx7xc49jpmh5 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BB97140009 X-HE-Tag: 1708951460-386332 X-HE-Meta: U2FsdGVkX1/TYEojQCSY8k8+wEPe9/B2jUbCf6T6yaLPZvT8Ma+o+NxzfA+40OKsjoQiv+DNMAi9mcYOKA0Hpmzi72cw5SpZg4xnHH8HA9fcsb5JXwiGUsQrWsmoeRFwrGMr2UYsW2nNCwMvmZxNNE3aoBv0MH0VzsU/JS4E+oLo9R7Sub+fs+sC0N3wZDvoH5gpzJp7MJQrwikg1oZ1iDrZU6PjBZyJI7EzrTfV5zSBOLHuuYMEdB9u+/HyZPrC35iGwQXDvbVBB5FvHILlWQZUGZDqUGbQr6DB/gw+PrGFRGrGcL5S5bsJzhOZrQZSOeU4fWyBV3gLqOjwJQWeeJgy2M5xpym/GzeRUe3wgnA2LptPRDA0rOrl+hU+vuGmKtE/1FCqyna7SVFVF8goNVXRHpu0xUM8LADqxhnw91G/SxEKxd5OfxZWBWyujlp14SQ4yJ9IjaxloohrMzMMNvcWfoIdsmlBiKP7IllFiZO0E+p5wGZTNb8j9dzwf++zZQ9tM0zxQ9n9Pe/crW2gjfFnF6uQYk1VEjXcyG0e4xzQk26N9Ku1O0++SzoDucMkzgwJ5CkNFT2nyXoF7IIBLCrixav8drqAaNN9VWVxacDrZ7TBq/7JmNj92po8eMEm459B0XRqPJOq3XDDHriEY9AQxMoO+Z0/1ldDz69vMSCraGAUeW0XyWLqDWszThpXh7cGWcKJol3ouu7kJschcxkQTJLe8iHbEJcJZNdLleWPmYSQCcd5Z40kDw1luQw+2fpx9qrPIAucKDvsVc5vIUpJ7vhEpo0A0IN9KKyQQ0Jkm9lvgm9mTBQFX3fTqazvZSt7bb3tubcMngPzzqoBOZQ+yU33aeZ+jJaOxqs7LXHsqdxyQ5r3UR9bPo0FQiCgBkB0ercBMbH8oxkI0IeNrGJxjXVHSZ03biemS+yl9MXKUV1T7WnItQnmchL7vWL0q8SRsygwycUz3SQqoLA sdzsmf89 9egOuU4IDu13bUPPZDo7z+JvBx0CueicwPOWFIyoUD5B2sSlDxaNeQNv28Oc4S/GrrSVPDtRLzNvnaCpDtxQVTEQ4qwSJBts6rv5+Hq2j6Jbxea3JSK2yNsl3Fg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 10:49:34AM +0100, Pankaj Raghav (Samsung) wrote: > From: Dave Chinner > > For block size larger than page size, the unit of efficient IO is > the block size, not the page size. Leaving stat() to report > PAGE_SIZE as the block size causes test programs like fsx to issue > illegal ranges for operations that require block size alignment > (e.g. fallocate() insert range). Hence update the preferred IO size > to reflect the block size in this case. > > Signed-off-by: Dave Chinner > dd2d535e3fb29d ("xfs: cleanup calculating the stat optimal I/O size")] > Signed-off-by: Luis Chamberlain Something screwed up there, and you haven't put your own SOB on this. > --- > fs/xfs/xfs_iops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > index a0d77f5f512e..1b4edfad464f 100644 > --- a/fs/xfs/xfs_iops.c > +++ b/fs/xfs/xfs_iops.c > @@ -543,7 +543,7 @@ xfs_stat_blksize( > return 1U << mp->m_allocsize_log; > } > > - return PAGE_SIZE; > + return max_t(unsigned long, PAGE_SIZE, mp->m_sb.sb_blocksize); > } This function returns a uint32_t, same type as mp->m_sb.sb_blocksize. The comparision should use uint32_t casts, not unsigned long. ALso, this bears no resemblence to the original patch I wrote back in 2018. Please remove my SOB from it - you can state that "this change is based on a patch originally from Dave Chinner" to credit the history of it, but it's certainly not the patch I wrote 6 years ago and so my SOB does not belong on it. -Dave. -- Dave Chinner david@fromorbit.com