From: Matthew Wilcox <willy@infradead.org>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 1/2] mm/memfd: refactor memfd_tag_pins() and memfd_wait_for_pins()
Date: Mon, 26 Feb 2024 16:07:05 +0000 [thread overview]
Message-ID: <Zdy3KRi3mnA2ZaDQ@casper.infradead.org> (raw)
In-Reply-To: <20240226141324.278526-2-david@redhat.com>
On Mon, Feb 26, 2024 at 03:13:23PM +0100, David Hildenbrand wrote:
> + xas_for_each(xas, folio, ULONG_MAX) {
> + if (!xa_is_value(folio) && memfd_folio_has_extra_refs(folio))
> xas_set_mark(xas, MEMFD_TAG_PINNED);
... we decline to tag value entries here ...
> @@ -95,20 +90,15 @@ static int memfd_wait_for_pins(struct address_space *mapping)
>
> xas_set(&xas, 0);
> xas_lock_irq(&xas);
> - xas_for_each_marked(&xas, page, ULONG_MAX, MEMFD_TAG_PINNED) {
> + xas_for_each_marked(&xas, folio, ULONG_MAX, MEMFD_TAG_PINNED) {
> bool clear = true;
>
> - cache_count = 1;
> - if (!xa_is_value(page) &&
> - PageTransHuge(page) && !PageHuge(page))
> - cache_count = HPAGE_PMD_NR;
> -
> - if (!xa_is_value(page) && cache_count !=
> - page_count(page) - total_mapcount(page)) {
> + if (!xa_is_value(folio) &&
> + memfd_folio_has_extra_refs(folio)) {
... so we don't need to test it here because we'll never see any value
entries. No?
next prev parent reply other threads:[~2024-02-26 16:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 14:13 [PATCH v2 0/2] mm: remove total_mapcount() David Hildenbrand
2024-02-26 14:13 ` [PATCH v2 1/2] mm/memfd: refactor memfd_tag_pins() and memfd_wait_for_pins() David Hildenbrand
2024-02-26 16:07 ` Matthew Wilcox [this message]
2024-02-26 16:56 ` David Hildenbrand
2024-02-27 15:27 ` Matthew Wilcox
2024-02-26 14:13 ` [PATCH v2 2/2] mm: remove total_mapcount() David Hildenbrand
2024-02-26 16:09 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zdy3KRi3mnA2ZaDQ@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox