From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8C1CC5478C for ; Fri, 23 Feb 2024 23:25:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 291986B0075; Fri, 23 Feb 2024 18:25:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 240EB6B007B; Fri, 23 Feb 2024 18:25:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1091A6B007D; Fri, 23 Feb 2024 18:25:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 017526B0075 for ; Fri, 23 Feb 2024 18:24:59 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BF05014017D for ; Fri, 23 Feb 2024 23:24:59 +0000 (UTC) X-FDA: 81824651118.16.DAA26C8 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf15.hostedemail.com (Postfix) with ESMTP id D7724A0009 for ; Fri, 23 Feb 2024 23:24:56 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AhhtUnNG; spf=pass (imf15.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708730696; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ao7UMHUlsZajZ+LBDOR+Sl5HBzayPn+Qg7pOB0l5nmg=; b=H8tk3Bbr3KYAIhrN1WYR9mM3WtYAvpEbHHalZmyuSuBHOpX+DjMPraZlxLCwFDynWMWMJM DAr9nBFHusACfTERxP/q3YvFC32wH5XYZn18TPi7ABY1u7/w06PoiSUbD60jHlUoXgjFzn cHzrBN5d3bY5lelXQ3X225ntJ3OSSao= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708730696; a=rsa-sha256; cv=none; b=k+xcSzGKa9z8UFKGGl+0p+4lOgddd+zKklH8vUMNKp6jtDZ7TCf4RI0hrsdArOU5x1Q8CW A78gjbi1s0G6CImQr1xUnfcZCgvvpCkmuY1+R2SKqG8OxxtUnqjNCr6LXV3Tmbs1+2MtVe riUnLrF1CBzXFUAS3eQbmFisD0yetSA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AhhtUnNG; spf=pass (imf15.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1dc139ed11fso7186795ad.0 for ; Fri, 23 Feb 2024 15:24:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708730695; x=1709335495; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=ao7UMHUlsZajZ+LBDOR+Sl5HBzayPn+Qg7pOB0l5nmg=; b=AhhtUnNGTlrSOoAm6cljNsWV2egBFSvkKgd9ErOq2U2LVPCDunfF+Y33WddhmU88cv 3o3TGGg0Xa+kXRlQzpYJclCvT6TjNxt0L8lxEWvrGo47+Cx6Pn1I/2zG+sHtarjERM3Y X41aysg+u5vUu+5U1dPjNwai+JHghZ/29rLzFCDAI9YMnN81zLPZ/a+73KG+J7fvUdRg oELl72dJdh1TsE0emDLEPlZGyJT9R2EUJSuPODyGdYV3oKTnJUj+RnHwDvQRZ9SpnaoG X+UxwH6f+FZGz8zIwMx5Gf4U7oz32cEsfbxpFGSx4KHchgaIIcWvBk/h+eKBu4h+5qte Fy0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708730695; x=1709335495; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ao7UMHUlsZajZ+LBDOR+Sl5HBzayPn+Qg7pOB0l5nmg=; b=pVhoQGqaMXYQeMmfbE5ZpYYD2WGNG2lAlVqf6grjsOWQHTBF4q3q4Wq5VbPgTPofKr 3apn0GO7oeBzsi6iSgpjw4sfHfmbAiwWVsD+/9hyBkxNWBeu78cUK05UNEE6oNMejB+7 K3Lm0fAnuFWARc8zZXDcnDBiTQg23h+1GiP1MES7Y3SicWyG5abz8JEFKAUxTYrupRU0 L4FTX8vFkcFl29Qr7QSZCL9bYRznRy8dXsdHPNz91E12uMMbL3XZEKnRewE0uzxsNAqH xGtnMvYMscoNlG470l9KNOKGkjvdeW/YEH87DAbJywG0WTRwD1avMsbxH4Hlh/u8cXGp z50Q== X-Forwarded-Encrypted: i=1; AJvYcCV/O+F109g5i5GAPiTJdFS5JX6BHLlR9XPSiyMcF9hUwuqI8SCjn/6CwvyYFNu6JkLxYj+dqPI/vO4j1dr7cDyBx5s= X-Gm-Message-State: AOJu0Yz4dS67LkJyja+3YW3mZQFbPC0FHosqZcER8kn/NBDKAIB9GmKf 2XJkdeCnKt9HpuQMB2KS+IzR9DSgGXbSLW2xJ4gXh9H7UrfmcL0N X-Google-Smtp-Source: AGHT+IHoAtezr2Ke3U6LkITmDjk/2zVtt1gxQW74Hm0HM8ZpA1E7A/r7XcYhs/My3eSzHIgtDMirow== X-Received: by 2002:a17:902:ea05:b0:1dc:6073:a3a4 with SMTP id s5-20020a170902ea0500b001dc6073a3a4mr1367734plg.3.1708730695517; Fri, 23 Feb 2024 15:24:55 -0800 (PST) Received: from google.com ([2620:0:1000:8411:e92a:5e0b:c881:39b6]) by smtp.gmail.com with ESMTPSA id w19-20020a170902c79300b001d8f251c8b2sm12212042pla.221.2024.02.23.15.24.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 15:24:54 -0800 (PST) Date: Fri, 23 Feb 2024 15:24:53 -0800 From: Minchan Kim To: Barry Song <21cnbao@gmail.com> Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mhocko@suse.com, hannes@cmpxchg.org, Barry Song Subject: Re: [PATCH RFC] mm: madvise: pageout: ignore references rather than clearing young Message-ID: References: <20240223041550.77157-1-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: D7724A0009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 393csxyzdc5ic9jcrgbxwo315hgm5bhr X-HE-Tag: 1708730696-510141 X-HE-Meta: U2FsdGVkX19/MXR4SA26e8cGtqgBpuR8sLzVNV1vXbhlD81Amifj2bPO29p6t9z6Jtae/S4dZMpQyTFNRm+E4u5K75g3/NZpQNuc4iA6HzXMRmaBgP6W6ZtY53Bpe9hXg3CDwPQcIVfMsqOAqOBpmC/kC+CmXvKp/N7T7A+fDKY+ySkLW42I7P7S3eoUN2Xqq/3I+7F9tqe+F6mIo971tFM/zJDXiWwlypexKdx8NYRT73IB4UcR8w4dR2hqD4Ooy76sLqyjYpd0hEfASvC0k4FC30Bf4gXVEDTjpV/TgN6/BBf5f7R6e3MxeEfK5fpq42yy2VLe1hASU2iXbimwR+nbQyX2MLKi5QfDKAfmLokbfQgXr8ziBKBsDTCk9qurh0Aqt70rl6pn4RwacxMpnv3JCuCwJelJojcP+u2mHNAyTUrISI0OZQC7x72qnFDOXw7eMSA5Rvee7Ojs0E0MNGzJyPTP7I3PoQLXEfTEgxSNh6gqDnA0xWKbZ/xT6+Kkb1Hfvnb3bLNkB1dhaBieF2uHrDoUaAswUeLWiZId3ZUz91LzaFdDKtPffesvknbIUirsktju5Nmy2FwHTLxFc/QBV75dIi9a3Tw7t248wAZ6R9lpSCryLKrLRs580nG8OLKOCwdlGr/KMPW1xxQ+S7Z97m6hsDU3UsyH8ThpnDdEBxf5ps0+Z9Cs+o9LbVbvbWrXfTsiyXvfF2a8ja3ve2YoV/GoMeK6x3ogDvhS9XEjcX49ess/kLnrRXVMAutvJPT06J3YUNNfx19ZGLEkwTwSmpq9YumvssPBGjYS23Bj7qHDP1iX5JZo4HKDIKiezO86rCEnpzgTmoChYt9ckdhGXER3UIOhTcp89gpZ/AbXUy+bxMtWk7iS5nJWINAfTTB8W9fUC+vbchzsvDB7y+gzMV6liKdMedA6k0lnvs3gKcoOYFKY7gbwujY4T29AG2W2EXpKTati9Bm/yCO HgkRD5/4 iNND5fdWKwTBs+497dRKI174y10N14wC82ptmeCr60ukG7F2i4W9vhN8ZxYI7/KQs4hLcnhMmKEaVrI4I8u5YbTdIf/s12l3Di5bDF7mFHpsGPo6DShJwPQ4a5RhSRJqaVtYqwO1EaTuHmyUpX0xi8uKXtQZ2qK8D4np1fbYN46l/7s0IlGCD9bjDx6ua0d0NnpbXvBHWzs7hqot1cH1uBf6fwZSIwQe+T568TA8dv5hkVKVspOvfKC9VuTcqr8+GR9LVV1FX/S333jSSV1Do4LbCPvDEWOhDaGo0FaNjdbJtnwVqTVdOyayhx3CPn/1hIhr8I2v/2C3zzqITWyd5BVBOb9lEM3cYQ1y55OJfA3QxrpkBj8KWKVD9sVQL6nVIdxNV0h57kZ7FhAkutzUY86Wn1V+XbUh+RL/oV1+eMtnmqc/EyvT/N2egcp8yPsj6MXm/JjQvci6O0BiR5y3By2QfNoej4zcCmecJvBDVbDVOyY/7Ih22na2j60Fngy+jDj65VkJ9ebvOycuGQM4Ptm9iwrRKq4CTAyxKpoGzv78bgA2Oh0sZsj1OSZv0TghU2V8WozaSH/ATw2MHL+M1bMaGe3hp8yrsw101Mpln9Ot3yg+b9VIo7RYHg95AXsE4HTLC5s4w1YIgTxjugibOKflcERwRifCZyVDcCkDh5zJwDCI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000113, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 24, 2024 at 11:20:36AM +1300, Barry Song wrote: > On Sat, Feb 24, 2024 at 11:09 AM Minchan Kim wrote: > > > > Hi Barry, > > > > On Fri, Feb 23, 2024 at 05:15:50PM +1300, Barry Song wrote: > > > From: Barry Song > > > > > > While doing MADV_PAGEOUT, the current code will clear PTE young > > > so that vmscan won't read young flags to allow the reclamation > > > of madvised folios to go ahead. > > > > Isn't it good to accelerate reclaiming? vmscan checks whether the > > page was accessed recenlty by the young bit from pte and if it is, > > it doesn't reclaim the page. Since we have cleared the young bit > > in pte in madvise_pageout, vmscan is likely to reclaim the page > > since it wouldn't see the ferencecd_ptes from folio_check_references. > > right, but the proposal is asking vmscan to skip the folio_check_references > if this is a PAGEOUT. so we remove both pte_clear_young and rmap > of folio_check_references. > > > > > Could you clarify if I miss something here? > > guest you missed we are skipping folio_check_references now. > we remove both, thus, make MADV_PAGEOUT 6% faster. This makes sense to me. Only concern was race with mlock during the reclaim but the race was already there for normal page reclaming. Thus, mlock would already handle it. Thanks.