From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F22CC48BF8 for ; Thu, 22 Feb 2024 19:02:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2314B6B007E; Thu, 22 Feb 2024 14:02:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E17C6B0080; Thu, 22 Feb 2024 14:02:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D0EB6B0081; Thu, 22 Feb 2024 14:02:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F34A56B007E for ; Thu, 22 Feb 2024 14:02:37 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CD6F21A0EE9 for ; Thu, 22 Feb 2024 19:02:37 +0000 (UTC) X-FDA: 81820361154.19.D1E596D Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP id D59841C002C for ; Thu, 22 Feb 2024 19:02:32 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Wi0guPry; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf21.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708628554; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YCzvJZi0MIn/MC1Y9lAaG+iLw9IpGIZIgpDw63icD0g=; b=zxOL1mpn2SNchBeP8t1HdUBh2z1/Is93GF8qEyiMhd8C0gYr7ZhbuygXR9ZXJ0lKR/A1y+ k4axIEFDFeyHjbZ0MBNqNoERwyLbQxxLKL4zPQk6IFAO64dhh4jPEUFKUnMujjcDPZMlzG e1FB6d+8syeE4/mpdnoEfudrE8TS8QM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Wi0guPry; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf21.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708628554; a=rsa-sha256; cv=none; b=18rh477TTKK+cqai1d5c3sqE9ktA44D4N9WGLsSjNasf4kFiODoTa48yVWT/MHrtwDxUIg 8L0xdqfHe35Ipfzw7cGJj+qNtbjQzfVpLBUA4L+OfVV2OWao11ENfRPEgygbX7tSyPLRgO 5chuqMP/TkP1ZAKeHW8YhMbRfb3Vfac= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YCzvJZi0MIn/MC1Y9lAaG+iLw9IpGIZIgpDw63icD0g=; b=Wi0guPrypagKM5AyWUB9394kF3 CFB6bUbQSvfLxajhjcmCeu7UuZP02tVovaF3blNETNVDWhHF+6o/5c6+RjokHzeL8mv5Nr7uEOfSm XQ+3BY6ac9/YkBaS7CF9NID8/0v5/vtnQtXaNTcFPb9JXScoKHZw4GD6coUUZ4WXOPkWG3K198JGu DjaUQAkdYCWmuQHJxPccl5Azh4D2YDIyqgrLfYUhsuadTX8E3y04HYjgisRh8Yop7+45G+O1wPQT9 iCCW3QDg85QlcHZwCrwopX8rSc0jWaZvzYpUqoat0iH6KwLuPBQ1KL6kQo5E7Qv7pbWnWtTtHp61t XPpjjwOw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdEKu-00000006Ejv-0bd2; Thu, 22 Feb 2024 19:02:24 +0000 Date: Thu, 22 Feb 2024 11:02:24 -0800 From: Luis Chamberlain To: Matthew Wilcox , Yosry Ahmed , Chris Li , Daniel Gomez , Pankaj Raghav , Hugh Dickins Cc: David Howells , lsf-pc@lists.linux-foundation.org, netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [LSF/MM/BPF TOPIC] Large folios, swap and fscache Message-ID: References: <2701740.1706864989@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: D59841C002C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: qpge5pcjgy8b1p44cs1xiuu333r4cabk X-HE-Tag: 1708628552-260240 X-HE-Meta: U2FsdGVkX18HpTORM2JoQJiSZtm0CSKHBExGspiqfz79kZPKfIIBUweELIKtppjCGZ+2FRULoJHXqYYPqeNGlJ5f8vNOU0HvOnZHsKr7FlUGGugJJc24bu4SQP030rKSzQLISVC66V0dosWeIoVJCDM4oB2+NKOL45dBpwalXUQ/XSJw+TTZcnr6vBrYqcQE/a/CuVRcrfzp7hsPh0oCTBRVGpQw1s5Na2CCFvF72VvO1oCkbuFy1TZA80n4kafj5Q/eWvb8X5cj0NWGwbouu0UlQAJQdCR5tYRiP/mFmxS+hO7x8qfEMyxLXnWE960LxrcX5dArt2LaR7c6qAwaCxTZfWSGzE/28w3HQwXLpm+Lz201Fo+3BjK1GDREcNSygHz8ehNFNFje0CBcdiOTj26YTfIQ9L52ZAdU88KPUsZmofulOAnqIhU9qyNxJrJ0kC38F/MvrE/iLKm0W3T/9lX4xj1hvGaut+vOknTY3mi+GGQORKL+RnW6J+hkffErs4OGdYUYRl/VoKUT1aeAW9FopErDfjOJGGQRgSC20cYqLp9YaiJA+2+Q01y0KU1bLbAd0OR7L96Hk7wrN7zI/1U4VXsoJL0mhFyBhiO9az409//wLYDkUKd85YJq7zPyNzLWq2d1Mx49KWO6xWpf7F6q397XyA48AyQfV0eBaq9jM8bc8cWd91DKmT0MypHA3sXb8Q/JXLwYGh5bbJvH05N6C8uhzBFUHA2ZEg9CaZ+110R7IyBRcnkzACt4hPoJe+KArBwBPkq9IYGDzlrB2pnrIBtwT90j/BaOW9EWF2pC719a282XPV54439l7A9XV0BkmRW9R68NXAON+U5orlWXjGG1GrYhT+3D171xkAL8+goMkBiMORD+AocWQL26vWZWXP1zXOA5dhZQceVfOx3VyeaUyVkvM6GKvVQ+tVes3KdBmyrnfWjATJ4Mf0K08caUJf2O4Oi12BmJPKF 7UJ43z/4 z1bdQtw4U19hjzNUi5UXyIPDak57DcaQpz6hlpbLUdYPhhFVbeqE/ZwYfXOaylsrK8BL+PxbNwGPUUvPUTRPdLz3VC4zl2tPfpWl3dxiVk34FMAc1e01IqNsV+MZnErhuLZ0dtYv/o2JEWABiP8b2HELY62zlYfjDwXIGNTh0BkCqHkBACch4Qf9SH6MVTTUOjZ4rXI35Xi+GQd0VMMaqU4giAnnSS9GpyTr6M9ALIjhl6c4OhC7zKEbm//9+xEKpg1TWiGZxLEkMnMU2CEPY9Z6Dpdpa3cgC/2Yx4stQNUpdQk5MjzqjGLjC4YUG2kiv6djvIVQxafzLDe+TWdsdF5sFC41Rgrd2RSEJ7UAtjU04QRdUoMGkvd87RlpdtbvwVVBeiKAXjZghL2nxKoOo0ar9cUdktNWl2wWyWTqGBI75h0Yu14FHyJtSIOxYOQV0UYVo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 02, 2024 at 02:29:40PM +0000, Matthew Wilcox wrote: > So my modest proposal is that we completely rearchitect how we handle > swap. Instead of putting swp entries in the page tables (and in shmem's > case in the page cache), we turn swap into an (object, offset) lookup > (just like a filesystem). That means that each anon_vma becomes its > own swap object and each shmem inode becomes its own swap object. > The swap system can then borrow techniques from whichever filesystem > it likes to do (object, offset, length) -> n x (device, block) mappings. What happened to Yosry or Chris's last year's pony [0]? In order to try to take a stab at this we started with adding large folios to tmpfs, which Daniel Gomez has taken on, as its a simple filesystem and with large folios can enable us to easily test large folio swap support too. Daniel first tried fixing lseek issue with huge pages [1] and on top of that he has patches (a new RFC not posted yet) which do add large folios support to tmpfs. Hugh has noted the lskeek changes are incorrect and suggested instead a fix for the failed tests in fstests. If we get agreement on Hugh's approach then we have a step forward with tmpfs and later we hope this will make it easier to test swap changes. Its probably then a good time to ask, do we have a list of tests for swap to ensure we don't break things if we add large folio support? We can at least start with a good baseline of tests for that. [0] https://lwn.net/Articles/932077/ [1] https://lkml.kernel.org/r/20240209142901.126894-1-da.gomez@samsung.com Luis