From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89E0BC48BEB for ; Thu, 22 Feb 2024 12:37:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 188246B0085; Thu, 22 Feb 2024 07:37:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 137756B0087; Thu, 22 Feb 2024 07:37:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 001E06B0088; Thu, 22 Feb 2024 07:37:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E3CB06B0085 for ; Thu, 22 Feb 2024 07:37:03 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BBE131A08A4 for ; Thu, 22 Feb 2024 12:37:03 +0000 (UTC) X-FDA: 81819389526.23.7895E77 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf28.hostedemail.com (Postfix) with ESMTP id D9989C001A for ; Thu, 22 Feb 2024 12:37:01 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=D1xO5VRo; spf=pass (imf28.hostedemail.com: domain of sashal@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sashal@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708605422; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zl7VxNCsDqEdIL+QjMQWr2fTPXGWtgy9/N5FC0HAvsU=; b=ZMtQoCkJdRxQdIG5EcKxWXGcWizNbLjHNvfV3qVPZIFpfV0qym/v07kI1c/W076W1Ded1N pRrVNYBUTupBWMGj5syt9WvLPFaXLhh08Tcji9cIXTq/T2X2f+lshkCEPs3tyJHeJCsKhm dPi679kQgLSTsliRo+sb+AELwbXaNEs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708605422; a=rsa-sha256; cv=none; b=UWCwyLuTKRyjpbpGxPRLMovVlifk7HmoO6ww40iKt6s4vMPI6ZiETyc1M0J5l8dCAiRbhg ftKVkSUfVrduWkNi7jt4CErcQCfDmO/hE+BjWUproH+UCJ3rxjvnzRwXuS7dkRy5OJaUZj nikuWJgpy8Lo7zsz4UHHQ+o7V0zSmIE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=D1xO5VRo; spf=pass (imf28.hostedemail.com: domain of sashal@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sashal@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 21D05CE2271; Thu, 22 Feb 2024 12:36:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D8BCC433F1; Thu, 22 Feb 2024 12:36:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708605416; bh=5JMBWnzvOQc2q9DWqlLSJhqyKMkqobNiRXLfi0gNSkw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D1xO5VRoWXbIbpcnOhY/uLVhsXx/2oRZ2xD235yMjQklY/wimmoooLrtFXjW9Jd2Z 4Nj1KxVN1DvLIa1/KLDUWTU+wbSCz1KQ8tj6JDssXczs9h0SpBTrx+KDnzmj78TzPK 0B5HvJD/XEpCogvsZ+B+MdxKl9ZrlYE/ljxwDSq0reRjMdhHSTtcFSdPy3LfF4PqlJ Ywlx5zj+OqnDsEhvPpU4WlBXF1IExGnDeQL0nS7vBvAnXO6Wed5aQEoMhaVfghyMV/ sODhTLvWPinMcOY35mJfngLaWw4vzUTgQwd63hFrGlFol3IW7K8oYunizs4JzskfHg 6m0ipcTYDF3nw== Date: Thu, 22 Feb 2024 07:36:56 -0500 From: Sasha Levin To: Pavel Machek Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Kees Cook , Kentaro Takeda , Tetsuo Handa , Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Andrew Morton , Sebastian Andrzej Siewior , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, surenb@google.com, michael.christie@oracle.com, mst@redhat.com, mjguzik@gmail.com, npiggin@gmail.com, zhangpeng.00@bytedance.com, hca@linux.ibm.com Subject: Re: [PATCH AUTOSEL 5.10 7/8] exec: Distinguish in_execve from in_exec Message-ID: References: <20240202184156.541981-1-sashal@kernel.org> <20240202184156.541981-7-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: D9989C001A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 7zfbghsrjtbmui6i976kgqaazmw1rr1m X-HE-Tag: 1708605421-490341 X-HE-Meta: U2FsdGVkX19JSEbzMsgH0dISZfzHQ3p5abGkedPRUj2up6/3diHfRV8ZhB7rpGiuxicuB0QSuyb57cKVZ5dD6zvxFtJSlJX0OQ9aVzHOuiZxl9wksaqZ15bIKalBxBWqHvr7jzzN35EHtXTQPejxENiCsT6gwbXXfn0/b/2+EBrGMtiQSRxOuzVhl/z36YfG92Goom2XwDVAnmL3hB75tJL/0JoRqhLe2ygoJcr5k44Cl1uH1E54684DnCFNOolu7qI0nV7PTUQ1reUeQm3dsBBkfn2AAaGUzoJCzLGkwvI3vPaZTJfSy1AiNbvqz4y1+1l69Fd1FdOghNVzibesStwd4hOmJBFsDJRbZMk3ZJUoXVjXbkn1RrhLr/TsnjJXK1ZnWHwHORG1n5fjPRq1fHGYuj5aBvnm+KB3xt1j/V9vY48J44eWOQxkXzCR3jgcEylYXL6xyfn200cN+/qipGQusaNy2YyXiy9ZCcnjqSE6T7LI47honKqSWAWtWWs7uJQwpVupwlizHJTLDLfFqm2kQrULwuFJxDBVpbh2FV3fk64+hMZfl/0vsBhYTLCeVGAcf0nsgdWTkEW4GyJhlRjaPYM3bCKjdZk45pN/8gugqC8PDG7sbGRdezGYICF4mtPXhuCNKydspAfoabHbbtzE4HcluM5ps0KaETDt7cZk+EpRykEfC2F+j8BEpQ0JG4TuWjWI5m/2CL5MlYfXFEXlND46qwOcnJfISCqu9blIDLaE38RtRd8nM2JaE++wsRWenf++joi9MiDAiFUFVWoI6E0NQ93fy9PbCVlIthLS79qpflGBLLGAIDUWypifzjN04x9+W9Xmw1VwMCvvLAzrWJKlHtQpMFWDkrB6whUmIe4PhgFXQDBZrY20CY0pAzruOBWDwCWmRXtQ1m7SvpseQ4o8f7cVnWhEofmCF6Fk7KExpM+8aQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Feb 18, 2024 at 08:12:56PM +0100, Pavel Machek wrote: >Hi! > >> From: Kees Cook >> >> [ Upstream commit 90383cc07895183c75a0db2460301c2ffd912359 ] >> >> Just to help distinguish the fs->in_exec flag from the current->in_execve >> flag, add comments in check_unsafe_exec() and copy_fs() for more >> context. Also note that in_execve is only used by TOMOYO now. > >These are just a whitespace changes, we should not need them. Dropped, thanks! -- Thanks, Sasha