From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE2BFC48BEB for ; Thu, 22 Feb 2024 12:12:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 824A46B008C; Thu, 22 Feb 2024 07:12:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D4CB6B0093; Thu, 22 Feb 2024 07:12:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69C506B0096; Thu, 22 Feb 2024 07:12:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5A7F36B008C for ; Thu, 22 Feb 2024 07:12:34 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 28A70120DB9 for ; Thu, 22 Feb 2024 12:12:34 +0000 (UTC) X-FDA: 81819327828.09.E572D4E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf06.hostedemail.com (Postfix) with ESMTP id E9F2518001C for ; Thu, 22 Feb 2024 12:12:31 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=FE4RHYf6; dkim=pass header.d=suse.com header.s=susede1 header.b=nU7WDITh; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708603952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iDZS9rn1ORcB7JdPkuWo18rKAM4Uqo344IyJ6OSxvyU=; b=f7/xThlLI5jUMR7LC7VFNB0FFzwFa5EopLNdlbhuvbyN5e0quFK3Sz+HKp/mTh5oMq+GFJ hyVRIjTKCg2vxLzQ9AyBIG/5qKIXC/uHJYzSRx0HsEEbuEKu7OJ1xPxvb595ib5ffRlKuS EXt/5Gau0v9JMbxWVLyfodEE9NMdoKo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708603952; a=rsa-sha256; cv=none; b=7LWbWobboYtdcfzcb1zBXVa9NeSBLHpE5OGnYSwvfrNwbTkPIVLruW1RGJSOYHM1fLEA+N 9LyEr8b4CRFGIKVdcIVLFNpUdwfYwb2JtMpB+DjKcKEF1afhQuxGks1KBMQEoWJmaHd+gC PcWiiwL4LOrVOT4UjGCEaP6LVTfAgMY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=FE4RHYf6; dkim=pass header.d=suse.com header.s=susede1 header.b=nU7WDITh; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E029522040; Thu, 22 Feb 2024 12:12:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1708603950; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iDZS9rn1ORcB7JdPkuWo18rKAM4Uqo344IyJ6OSxvyU=; b=FE4RHYf6KQniBvu69hMH61YFsJGUm+be/AWgzv3XVTDS8haXVcKEcmtqhLYtyoH79wE+BF 9rTbXWAQMLmYQg3dhbWCm6OQO7Hl7M/EukNOai/eLMIyuZ/W9oozZ458YgCq5yQMsvEOG9 9pG+sSYy3ZZ9rbeHDquU39srhn5O5Vc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1708603949; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iDZS9rn1ORcB7JdPkuWo18rKAM4Uqo344IyJ6OSxvyU=; b=nU7WDIThkhntaO85yrfZH+rTOcDv2P9JE96isJ7T+1A7OWnrrCYh5wjA2AMoxhC/+10aqG iaI/IirNep5cQnEr9Hn5ohr48ApPMWRLfdMJkWuT0SulHAuto1+doT2DtrDHrf4LrtEqzZ KGRJHRN6xIdAfHSvGSq+zmWiPenhKQM= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B76F9133DC; Thu, 22 Feb 2024 12:12:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id tUIxLC0612VEJwAAD6G6ig (envelope-from ); Thu, 22 Feb 2024 12:12:29 +0000 Date: Thu, 22 Feb 2024 13:12:29 +0100 From: Michal Hocko To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Petr =?utf-8?B?VGVzYcWZw61r?= Subject: Re: [PATCH v4 06/36] mm: enumerate all gfp flags Message-ID: References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-7-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240221194052.927623-7-surenb@google.com> X-Spamd-Bar: + X-Stat-Signature: dnzfo7wnb9o1b76xgy6y96bxnd39zp71 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E9F2518001C X-Rspam-User: X-HE-Tag: 1708603951-849456 X-HE-Meta: U2FsdGVkX19iAWlP+rmUUaH9Fji+xdP3Ljj6h9555dboxRcbvfBevNMBcL5N6ghshfLWPjz6TrwZkXOvo4XtaaUx0w+QNak79tZh8W3FgpvDHTLUHC7CW9lPTG3MJPK6wmlCJf9K4qpXYW5P9pFiS7Eshwzj/0QMvLq9R24PF9Y5j6aariBgpJMYwkqLIlWdQopu19F8DMwJ7wGWkr3eIPUD3SaEyABjC/EsNRyMKQdT2cQB7WLCT2bMydOeYxugKpLW2KfiZuIy2sGFA/YopqvnhvUH0mzXcWCBw2h7Am/LmKUMmGSdEQoDxNm50u4sFw823/oJOHapp+3MH78HeIU8LsrHQaorjTa7On1pcoNRQlgnuti2rQZt/CEFmTI34RBYmExMi27Py45dpJUf005dqW6+jLOjfxMhPqHVfqTyaU+CKZrm3ZW1sOAckiGzrI8iQWawhH+xswNkKgBjI9s5sEQF4xuCdUDvUEjPgUPf4IsJ+v0rDZY27tWEX+kLag7C27cEv751SL2/JW2XPlOYR8cIDYE8KQ7yRfQvo/uC/WGz78OwYnZzqVb8njSKDRaHjTmC1i47VMlh6jJrW1JZvlMB95nvbk04cfxlM5iYfWcksCX7j19V97w7OjN2CdTYb6B6KHWbL7qAn4jBxXdd9/jeg/Ch/GjcDIaBFwT4gkdwaOxgMx44Z6IiUAtWGox3KzHc67rjDApKjbCX5gOw4xmkv9bXcUtcWgcgD0IDM864Q0ZFMLUTIK7s7VPJ7rsYuHhLwfWD7fn4NbsqxB/za3YZZtvEsrfDLQuN/QYMMHPu5jf2pur8M0bEjOyO3ZqDjwmWevAToaTLeQL6yX/ATc+OMoGRXHZRPgEJJaMqS08RYCbJp6ZhfqqGbn4BdMJB24KjY1aid11nIVvWqOsNgQF6Apdrfwf0fQuIHjEaT0n0gnkdG8OfiXqytZcllM/Xrxh/LUCFotEJQgN kJg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 21-02-24 11:40:19, Suren Baghdasaryan wrote: > Introduce GFP bits enumeration to let compiler track the number of used > bits (which depends on the config options) instead of hardcoding them. > That simplifies __GFP_BITS_SHIFT calculation. > > Suggested-by: Petr Tesařík > Signed-off-by: Suren Baghdasaryan > Reviewed-by: Kees Cook I thought I have responded to this patch but obviously not the case. I like this change. Makes sense even without the rest of the series. Acked-by: Michal Hocko It seems that KASAN flags already __GFP_BITS_SHIFT which just proves how fragile this existing scheme is. > --- > include/linux/gfp_types.h | 90 +++++++++++++++++++++++++++------------ > 1 file changed, 62 insertions(+), 28 deletions(-) > > diff --git a/include/linux/gfp_types.h b/include/linux/gfp_types.h > index 1b6053da8754..868c8fb1bbc1 100644 > --- a/include/linux/gfp_types.h > +++ b/include/linux/gfp_types.h > @@ -21,44 +21,78 @@ typedef unsigned int __bitwise gfp_t; > * include/trace/events/mmflags.h and tools/perf/builtin-kmem.c > */ > > +enum { > + ___GFP_DMA_BIT, > + ___GFP_HIGHMEM_BIT, > + ___GFP_DMA32_BIT, > + ___GFP_MOVABLE_BIT, > + ___GFP_RECLAIMABLE_BIT, > + ___GFP_HIGH_BIT, > + ___GFP_IO_BIT, > + ___GFP_FS_BIT, > + ___GFP_ZERO_BIT, > + ___GFP_UNUSED_BIT, /* 0x200u unused */ > + ___GFP_DIRECT_RECLAIM_BIT, > + ___GFP_KSWAPD_RECLAIM_BIT, > + ___GFP_WRITE_BIT, > + ___GFP_NOWARN_BIT, > + ___GFP_RETRY_MAYFAIL_BIT, > + ___GFP_NOFAIL_BIT, > + ___GFP_NORETRY_BIT, > + ___GFP_MEMALLOC_BIT, > + ___GFP_COMP_BIT, > + ___GFP_NOMEMALLOC_BIT, > + ___GFP_HARDWALL_BIT, > + ___GFP_THISNODE_BIT, > + ___GFP_ACCOUNT_BIT, > + ___GFP_ZEROTAGS_BIT, > +#ifdef CONFIG_KASAN_HW_TAGS > + ___GFP_SKIP_ZERO_BIT, > + ___GFP_SKIP_KASAN_BIT, > +#endif > +#ifdef CONFIG_LOCKDEP > + ___GFP_NOLOCKDEP_BIT, > +#endif > + ___GFP_LAST_BIT > +}; > + > /* Plain integer GFP bitmasks. Do not use this directly. */ > -#define ___GFP_DMA 0x01u > -#define ___GFP_HIGHMEM 0x02u > -#define ___GFP_DMA32 0x04u > -#define ___GFP_MOVABLE 0x08u > -#define ___GFP_RECLAIMABLE 0x10u > -#define ___GFP_HIGH 0x20u > -#define ___GFP_IO 0x40u > -#define ___GFP_FS 0x80u > -#define ___GFP_ZERO 0x100u > +#define ___GFP_DMA BIT(___GFP_DMA_BIT) > +#define ___GFP_HIGHMEM BIT(___GFP_HIGHMEM_BIT) > +#define ___GFP_DMA32 BIT(___GFP_DMA32_BIT) > +#define ___GFP_MOVABLE BIT(___GFP_MOVABLE_BIT) > +#define ___GFP_RECLAIMABLE BIT(___GFP_RECLAIMABLE_BIT) > +#define ___GFP_HIGH BIT(___GFP_HIGH_BIT) > +#define ___GFP_IO BIT(___GFP_IO_BIT) > +#define ___GFP_FS BIT(___GFP_FS_BIT) > +#define ___GFP_ZERO BIT(___GFP_ZERO_BIT) > /* 0x200u unused */ > -#define ___GFP_DIRECT_RECLAIM 0x400u > -#define ___GFP_KSWAPD_RECLAIM 0x800u > -#define ___GFP_WRITE 0x1000u > -#define ___GFP_NOWARN 0x2000u > -#define ___GFP_RETRY_MAYFAIL 0x4000u > -#define ___GFP_NOFAIL 0x8000u > -#define ___GFP_NORETRY 0x10000u > -#define ___GFP_MEMALLOC 0x20000u > -#define ___GFP_COMP 0x40000u > -#define ___GFP_NOMEMALLOC 0x80000u > -#define ___GFP_HARDWALL 0x100000u > -#define ___GFP_THISNODE 0x200000u > -#define ___GFP_ACCOUNT 0x400000u > -#define ___GFP_ZEROTAGS 0x800000u > +#define ___GFP_DIRECT_RECLAIM BIT(___GFP_DIRECT_RECLAIM_BIT) > +#define ___GFP_KSWAPD_RECLAIM BIT(___GFP_KSWAPD_RECLAIM_BIT) > +#define ___GFP_WRITE BIT(___GFP_WRITE_BIT) > +#define ___GFP_NOWARN BIT(___GFP_NOWARN_BIT) > +#define ___GFP_RETRY_MAYFAIL BIT(___GFP_RETRY_MAYFAIL_BIT) > +#define ___GFP_NOFAIL BIT(___GFP_NOFAIL_BIT) > +#define ___GFP_NORETRY BIT(___GFP_NORETRY_BIT) > +#define ___GFP_MEMALLOC BIT(___GFP_MEMALLOC_BIT) > +#define ___GFP_COMP BIT(___GFP_COMP_BIT) > +#define ___GFP_NOMEMALLOC BIT(___GFP_NOMEMALLOC_BIT) > +#define ___GFP_HARDWALL BIT(___GFP_HARDWALL_BIT) > +#define ___GFP_THISNODE BIT(___GFP_THISNODE_BIT) > +#define ___GFP_ACCOUNT BIT(___GFP_ACCOUNT_BIT) > +#define ___GFP_ZEROTAGS BIT(___GFP_ZEROTAGS_BIT) > #ifdef CONFIG_KASAN_HW_TAGS > -#define ___GFP_SKIP_ZERO 0x1000000u > -#define ___GFP_SKIP_KASAN 0x2000000u > +#define ___GFP_SKIP_ZERO BIT(___GFP_SKIP_ZERO_BIT) > +#define ___GFP_SKIP_KASAN BIT(___GFP_SKIP_KASAN_BIT) > #else > #define ___GFP_SKIP_ZERO 0 > #define ___GFP_SKIP_KASAN 0 > #endif > #ifdef CONFIG_LOCKDEP > -#define ___GFP_NOLOCKDEP 0x4000000u > +#define ___GFP_NOLOCKDEP BIT(___GFP_NOLOCKDEP_BIT) > #else > #define ___GFP_NOLOCKDEP 0 > #endif > -/* If the above are modified, __GFP_BITS_SHIFT may need updating */ > > /* > * Physical address zone modifiers (see linux/mmzone.h - low four bits) > @@ -249,7 +283,7 @@ typedef unsigned int __bitwise gfp_t; > #define __GFP_NOLOCKDEP ((__force gfp_t)___GFP_NOLOCKDEP) > > /* Room for N __GFP_FOO bits */ > -#define __GFP_BITS_SHIFT (26 + IS_ENABLED(CONFIG_LOCKDEP)) > +#define __GFP_BITS_SHIFT ___GFP_LAST_BIT > #define __GFP_BITS_MASK ((__force gfp_t)((1 << __GFP_BITS_SHIFT) - 1)) > > /** > -- > 2.44.0.rc0.258.g7320e95886-goog -- Michal Hocko SUSE Labs