From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C592C48BEB for ; Thu, 22 Feb 2024 03:51:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FA0A6B0072; Wed, 21 Feb 2024 22:51:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AA4C6B0074; Wed, 21 Feb 2024 22:51:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 598ED6B0075; Wed, 21 Feb 2024 22:51:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4AAFA6B0072 for ; Wed, 21 Feb 2024 22:51:20 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1BC21A05F7 for ; Thu, 22 Feb 2024 03:51:20 +0000 (UTC) X-FDA: 81818064720.22.27F2D69 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id A2E47140003 for ; Thu, 22 Feb 2024 03:51:18 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=apGU9qyw; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708573878; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i/7HIyFgwgzD7YbEDR31NVPlVkKUleWuI0Mc79KExFQ=; b=XL5TUVOeRNj7uDb6gWf8LCDrnQH6i56/fIUGaFoEuc6nQC/CDT0R4VLKe69X9ZN8FcVhNP 0sAEM8dOXpmPekl+Ibgb6B2nF0Gb1Vjls54DBvKEU7r2AnUr2qiqrtCx1oXxo5CxZN6ifK qmv9roBtJiXyHp662CmAb8YUr2LZWtY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708573878; a=rsa-sha256; cv=none; b=nqQXyiFsCuXbxgcW2rIRBJHprEaP3joKdtwH5JwFHSnyb0TLHjQ8l0Qd0rnJNCj5DLMTWQ mufMxQuL6lGAXCejxsZ7umAcbbQBPuiCPyR0X9GkfiENzs33OivB3rDklOncOpzDmOvJ29 mq6/SKWHuYLxvRYREGRWlnPxXUf3iCE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=apGU9qyw; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=i/7HIyFgwgzD7YbEDR31NVPlVkKUleWuI0Mc79KExFQ=; b=apGU9qywdin7SKMFel85/KBcxq dYyK6+2aDKa8SI4lIUbdk5vL8F/W3opK2JsUcA5cPvRrB8xCLy+95KzcQ7NTjZqy5bPe3/67Zh4WW hK8CG3AyqzQvw0cMVwsYaBhfM/+OmSqlEbo3MfnyYOGoNuSal00W5s0vE/g/Nq0Z9uLaDPouvqU08 zI+BXEYpwdpSiagmuzFestJBOfYN/E8dzzHW/v4/xvZvome5KYLvknMA2HUfUUh0BerLnJPfgT3Cs rMvsjf5nZRxDaKt1zE1qMmW1WrkE+4d1V/ixzdisgsUSZzQr9RpCs2+8ND7O1qxdRbNZcFXlftSNy z2OQdYSg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rd07A-00000002VKP-1vyV; Thu, 22 Feb 2024 03:51:16 +0000 Date: Thu, 22 Feb 2024 03:51:16 +0000 From: Matthew Wilcox To: "Vishal Moola (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, muchun.song@linux.dev Subject: Re: [PATCH v2 4/5] hugetlb: Use vmf_anon_prepare() instead of anon_vma_prepare() Message-ID: References: <20240221234732.187629-1-vishal.moola@gmail.com> <20240221234732.187629-5-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240221234732.187629-5-vishal.moola@gmail.com> X-Rspamd-Queue-Id: A2E47140003 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 9m75zyd6qemi6g6copoerwa8p7infjqs X-HE-Tag: 1708573878-136169 X-HE-Meta: U2FsdGVkX1+XBAWqsqUjPE2dhoL4pd3rWuwieqxHS3pvb+zY3+Yibtl6PK4EHIn8kc5kTYwRZfwlpH9YGDSrYJaFOzQ5aITkaCbeDqNNoCOC5ORhyXIYtaq8lFFE3AFaMzW5b2ifOVfazMgn7RMDAZ0RRn+67W0cBi8T2d+uGEIUgMXkLoKCUScqLkY9UqF8glIlCImUgkey6U18VdwSPbmLtdnAB+o2NXi26f8WIiXnsQo2E0wytmkibQs9XEmgLVuGD4xZAERi3nx/7QbPUo9RTcawHmIGF0diFFBicAQtOu/TXU5DSK11AmWogXC5zezVLJtnmlS7wAx1OoyHahJygNCh7wxmZW8XLT3A31+9GsVmwrUJQ0VN+5vze3+g+erD6bFqWiF7MzFF1yBrCMe9u6dK8f8bp2t9CIl+8d+gBX4//vzqx8lauMVIzUy2Wvzn1Iw3xpS2y4OfKBiobwoRl9bGWhhFYGZPRt+XLmIuQig+wM+D2WHPu25hYNsh9J2LKZm13dLjbsQPOkunh09UnAz87UAQpB7Uz4uKyqx57kZfJRDOVG4TiXsjBn2d3QJaxybN6uIIJezfXS3nADYsfmzAFrBHnmOC7yETscPbUTGIJGYwq1NC+cbkszlpyin/UWJ20ui8Q3YPOUUGvpsvLQ6tAjnuOhZ7JbhvzoS1P51uEI+X62/LYi9v2xsFsUvX3UkabF33buzfDhMYuS1sbmi/rMKMMK9uvaeLe0MblWxstjqIKuAoinngW6xWrdwDQ01h8bTRCIZAoe9evLZyeatGoVIGES6rkeYfdm3WK+p3TblFU8SQtFz9YEgvMUAQm5khXp6NzAbTAksMkw80S9SCOD6wXup5rih6bqTdzB5Ahdm7cKw6pYFMsUXkLF6WP7iVDn8XJ7j7Px5EwIv+ii16gvDfw9ptfeQKqYvIaPEpFDxvVDDcz6Gg0MVAAFSarDwtIaU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 21, 2024 at 03:47:31PM -0800, Vishal Moola (Oracle) wrote: > hugetlb_no_page() and hugetlb_wp() call anon_vma_prepare(). In > preparation for hugetlb to safely handle faults under the VMA lock, > use vmf_anon_prepare() here instead. > > Additionally, passing hugetlb_wp() the vm_fault struct from hugetlb_fault() > works toward cleaning up the hugetlb code and function stack. Reviewed-by: Matthew Wilcox (Oracle) > static vm_fault_t hugetlb_wp(struct mm_struct *mm, struct vm_area_struct *vma, > unsigned long address, pte_t *ptep, unsigned int flags, > - struct folio *pagecache_folio, spinlock_t *ptl) > + struct folio *pagecache_folio, spinlock_t *ptl, > + struct vm_fault *vmf) Is it worth removing vma, address and flags?