From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4132C48BF6 for ; Thu, 22 Feb 2024 03:41:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60E4F6B0072; Wed, 21 Feb 2024 22:41:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BEDD6B0074; Wed, 21 Feb 2024 22:41:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AD556B0075; Wed, 21 Feb 2024 22:41:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3CF766B0072 for ; Wed, 21 Feb 2024 22:41:52 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CA561A0C56 for ; Thu, 22 Feb 2024 03:41:51 +0000 (UTC) X-FDA: 81818040822.19.F9A3F24 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 5D4F1100004 for ; Thu, 22 Feb 2024 03:41:50 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=RmuIeskV; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708573310; a=rsa-sha256; cv=none; b=KEAzIHnt0XK4zopHrA3cO3+onkBcgTd7cHa2OLP29Rk2uEBUoSqMtO0CbB0LZsWXtKb8SC ba4a8w1J0rbxMIW0VY4Bt7PvBsB63urPYnfu6EWdrB6OT1u/yKyOXzif3BnEEaMnykCjoQ uKTgmxzbU2rO+ZZS+CrAsYmpsRMWTHo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=RmuIeskV; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708573310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e9Kb7+9juqy5FhJMaaMa784eYLFmC0FDrVU0K/noLKM=; b=7dkmygKcEpbMKT8wLBGEir4CzB45MwrDXLnLkT3VrFn6P9IJKwVRfOjCZ2pLlXhvSCw+F1 FhRTMq4foJcbw6BE7b7ScX5ZPmN1l034uUNHGlrPhP36G9X/s7dcbiNbQLffniyDVHGQMj 6wXya0Wybg5HisDqCNVHLZGHHU5Oa/o= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=e9Kb7+9juqy5FhJMaaMa784eYLFmC0FDrVU0K/noLKM=; b=RmuIeskVf1E2Kxz6/IxeCqW04N CrbDilGBItIwOekuLDghEjj2hDdun5rXc3L4bAfOV99PtDvb67Mf1ba7arpix6VXSnbs00G6mssY5 nlD564ezWwhpmki+hHXLXeBn54a2r/lbeEQH/3+s7amcsl4nSNK6LSDKLDC5M8Zdh0itiqeQ7nG5D x8HgU2+kJhxsR9SNjgXwWwkEiJFy2ugsGThnhoDc7OjyDsLMZDF2/V+mFLt/yQl08do2cPbXKpJ7D +4Zqr/hAW8DYfRg6rUvXFK9Mx/nfM2T0ObcCtOIFnrH1RRtnaT97Zeo2AScvocj+WF4jPFTjQ93rR qxEMcOsw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rczy0-00000002UCI-2zDG; Thu, 22 Feb 2024 03:41:48 +0000 Date: Thu, 22 Feb 2024 03:41:48 +0000 From: Matthew Wilcox To: "Vishal Moola (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, muchun.song@linux.dev Subject: Re: [PATCH v2 3/5] hugetlb: Pass struct vm_fault through to hugetlb_handle_userfault() Message-ID: References: <20240221234732.187629-1-vishal.moola@gmail.com> <20240221234732.187629-4-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240221234732.187629-4-vishal.moola@gmail.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5D4F1100004 X-Stat-Signature: 555q7ma5f6pghwq4zifm3qjapw6ezbja X-Rspam-User: X-HE-Tag: 1708573310-366297 X-HE-Meta: U2FsdGVkX19NZWaE2R0ogr0V6Y74OGRkKEmINqjv0cGGv4NYP10vdusg5GUkpr+nFT8B+Ip1vH/tRAQ5cZTr+y8DWaEmuttP0TkKVIBWLapHFfBFttVberOtvIeD8oSKnkm9KY7o54fR/NaXjQX4UCLOIPFuCUUZxEXEZUkTJ4mDd2iJ7PgqU9VctfkDiyZHY57xOuG7LTGUN+N7vgASVkfFhJaBIykz2Z9JszMo7wnbNf7YkpzwE9jCWAyTVRm7QmbXLKadbFz6RwGJE3BVG3Kc7HntimkTD2soKXxXDNspJi40swtjPTToQcJRYV7IogRAao3pLMvHsaK5OR0iVGVhWfAE2EGBtdyw9mblHVIs6tlOFongFGwUpOiZG+ADAbAZQj3JvijIHaCw7LZbPmHoTrElvNOskd1YrLOjvXH9ptxUVXiMT1zqnUo3V6j4qaRsavJfweHZYb+mwO45+huOzKA+zoIUFRhr1kqK0SjGX1oxjgXy0VZibz5c9uG2hhUq/dwGajasny9zG1Fq3X9qiC77120+TV84lPSa5AYftEoWTZyrDVWf8DgyYRz6jrK5H+2ew0Op2uwkNL87FOzcjDrW5Y3Y1dzPL97rffRtz3nKDldLJDT8iWM7lNldbAio8UistCT4o186qm55BEiVSeUdQ9r+QHH73wU4uN31RT5gDf2f/vqLd6Ld8lYB3D2DWhXyCeKtV9Rwes6sGliR2LtbUE4BoPMHTenF+5ZD0MD4P5IYv5fhh7esiqKb4sCisSmCJmF0Hna1IE8javmnq4wXqrPqfx54qrtmD7BZQUjYFTotvNYTspTp/SzTqwWpCzhbQ5+i+ZN32M+qJEC6I+p8qqQqv6EMpjQVTo/FTI8lWG6dLCHa22J3CxbbIkZelFSPyoSWINAOba4rSlyy5NwQGi88gHF17D7tNkRx1kc3PmC3ceq5rApY1GOmVWnfZA/t34c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 21, 2024 at 03:47:30PM -0800, Vishal Moola (Oracle) wrote: > Now that hugetlb_fault() has a struct vm_fault, have > hugetlb_handle_userfault() use it instead of creating one of its own. > > This lets us reduce the number of arguments passed to > hugetlb_handle_userfault() from 7 to 3, cleaning up the code and stack. > > Signed-off-by: Vishal Moola (Oracle) > --- > mm/hugetlb.c | 38 +++++++++----------------------------- > 1 file changed, 9 insertions(+), 29 deletions(-) I love the look of this ... > @@ -6116,7 +6098,8 @@ static vm_fault_t hugetlb_no_page(struct mm_struct *mm, > struct vm_area_struct *vma, > struct address_space *mapping, pgoff_t idx, > unsigned long address, pte_t *ptep, > - pte_t old_pte, unsigned int flags) > + pte_t old_pte, unsigned int flags, > + struct vm_fault *vmf) Should we remove vma, address, idx and flags?