From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC5B3C48BF6 for ; Thu, 22 Feb 2024 03:35:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AA5B6B0072; Wed, 21 Feb 2024 22:35:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 65A076B0074; Wed, 21 Feb 2024 22:35:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D3D96B0078; Wed, 21 Feb 2024 22:35:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 39D586B0072 for ; Wed, 21 Feb 2024 22:35:49 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C5589140C39 for ; Thu, 22 Feb 2024 03:35:48 +0000 (UTC) X-FDA: 81818025576.19.4EA5B7A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id 60FD140006 for ; Thu, 22 Feb 2024 03:35:47 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XlZsiqoy; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708572947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k2qqGakj6suncR5yFTplOvwhI9MQ07qi3BIxDZ0n86Y=; b=OZvb4BOfA0W5+W+rS9K0dAfCaBboblTrdd/ZKJ5N1hbKBcahP66MXVw7eG3TfIPP4OptAT 4GmepQIYJcU8aW9ShCPn5LYryNTYC9hWs2M/GuXx4U2d6bNEKg0ZINz40KOcKaLI33fZQe cKbts3im6M/Mnrn2stie3ZHkfW7Dq84= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708572947; a=rsa-sha256; cv=none; b=cuIKrxMC6ka0rTuxGVRs+gHbvrNqdKXUA23vJcFawYsI03X2eA2EJ9nMrfbE6Gh3GluZm0 8EGcof2ZMHgkmWUGUBzqRwcGYGK8UpxDPrf4NRfm/jFSd9mMkeWCmCyM6XKNElXQvBPaUl SX86j4BiD8C9Zbg+g1ymGZ8HZ/bayz4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XlZsiqoy; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=k2qqGakj6suncR5yFTplOvwhI9MQ07qi3BIxDZ0n86Y=; b=XlZsiqoyvBGd+rE9mW8Fd2Bby3 sjmex3EpRfExrk/r+40NGtN49fo3fE9AREhgffMlFj5ghpupNJrD9TIwhHtaW5Pi+FluHzRCSiGF8 d/nVuqN2zQsVN3gKV5scRxFNXrAJjdAROVffaY+raUGFZYd5hS0vRSPCYPKRIDdezxdcD0M2rsFJV /yuJh+E2eKRLAul0dnCigD4O1pZx2dXSGZr//5vg/s5rFjpY+YJLnxXaC6kckkfcxwDyycoUl3isR nfA796cBiFDJaqut3yRrMDtZQBxKtUDwjwWGZPt1yTx1P6QZ/zwhabYErmbHb5SPo5D436ZCDzzTC H/jJ6UPw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rczs9-00000002TJz-215C; Thu, 22 Feb 2024 03:35:45 +0000 Date: Thu, 22 Feb 2024 03:35:45 +0000 From: Matthew Wilcox To: "Vishal Moola (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, muchun.song@linux.dev Subject: Re: [PATCH v2 2/5] hugetlb: Move vm_struct declaration to the top of hugetlb_fault() Message-ID: References: <20240221234732.187629-1-vishal.moola@gmail.com> <20240221234732.187629-3-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240221234732.187629-3-vishal.moola@gmail.com> X-Rspamd-Queue-Id: 60FD140006 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: myzkyxkkduf5tiouxi5q4d3z4x6nu48j X-HE-Tag: 1708572947-298480 X-HE-Meta: U2FsdGVkX19tG/a3TxkCHZrdEe1i2lhCGu8KXqdyVExaG//uAkUc2/TgBL62Lvw6IK0+/0gbO1nP3tiyHHhpYiJUKs0JpGFiRJvma1Q/0OYDAIyTe3S4wHcXiT3YRMWCGpUvQHOiJhbE9OOmcJTTJV6lg2SS00A7u+O+Pjueda5oonS7z1xNPplu3EueaTOZF4vhJt1HqPhwK8HsyA8wfumKpynKqCrH82TldbGLW2mFLkQPJlu6o+c9RoPZmjPytO4epBtFKKSyLrqCnOZNruQJ8qvTzOYdbny/U94yxmGp2AcJc0atbLVYsYmImRtdlsG1QrPQH2ZWQl9Lc2dfoIJwqhanyPhJ17WIa+ZB7iFwyt4rJJnCZp8vYJTZ7eC8Uqtg1rYJjIe2R0QoseTElk3HulpsHfJ/lD3AdHAu48d62IhXNp/jNPvUJug2ultya4sEG+tmnLKACHY/55MzHk7qYNkE2TNv6JsrXPygiFmBVl4xRbAtB87EyfqvNJFiL3yNQm5R6Xu5BjmmMNc/otwU9p4r+xC+NVhRTbGfImn4VwW+SA0H7FYf3oENAyMD1ge/5tJvpBPuLDGxoc56k9/Pw1l9SxFssdmCo97fGIkbJx00MrTYf2DEjMaGkNdRVisEdMpKLKg7ph4EyZudsm4fQS16ULtBK6dDm8C408Dt1JIju/3Wkc1WGsFG8IDfl4YRzzzWEMerbBWPaoMLbGI0Cov3sbvlKyOF0C+G1FD3Z1vYwauA1WTp9EpDV5sVgk35qja8I6Cp09KCN0/sE05ROSLf939OZD9jiWQl80d6pWUFr0t3w5TZOqBIVic8OMyK73tbOVZGCcp2IWQQUAMrgoskK1ix9AuCKxmvrlBpYYeldw30bxNYmiIc8eEFSPIuSvpVtqItYQvE7MQpiGHh/vD3zRHWmmtX/sATjqbjkg96s5CsjMiZP1bZFii1tapC/9vKJb0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 21, 2024 at 03:47:29PM -0800, Vishal Moola (Oracle) wrote: > hugetlb_fault() currently defines a vm_struct to pass to the generic s/vm_struct/vm_fault/ (both this line and Subject:) > handle_userfault() function. We can move this definition to the top of > hugetlb_fault() so that it can be used throughout the rest of the > hugetlb fault path. > > This will help cleanup a number of excess variables and function > arguments throughout the stack. Also, since vm_fault already has space > to store the page offset, use that instead and get rid of idx. > > Signed-off-by: Vishal Moola (Oracle) Reviewed-by: Matthew Wilcox (Oracle)