From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7267FC48BF6 for ; Thu, 22 Feb 2024 00:40:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3DAB6B0071; Wed, 21 Feb 2024 19:40:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DED386B0078; Wed, 21 Feb 2024 19:40:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C66F76B007B; Wed, 21 Feb 2024 19:40:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B43FD6B0071 for ; Wed, 21 Feb 2024 19:40:05 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5A6FCA109C for ; Thu, 22 Feb 2024 00:40:05 +0000 (UTC) X-FDA: 81817582770.23.74353AA Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf01.hostedemail.com (Postfix) with ESMTP id 611F640003 for ; Thu, 22 Feb 2024 00:40:03 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b="0/JBejos"; dmarc=none; spf=pass (imf01.hostedemail.com: domain of debug@rivosinc.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708562403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3cPh5EYVwGWaYgvsr8YLKJcb0/yJUuFAluKjFfz/1Eo=; b=YHbcbRIYikq9TLUNXS9F8TsyEtqbER3bcUyKJ+og9eExjEZ9SIPN8tldKTlIrXZ1ZgljVC 7a0DyWn/p0pE8DSDTLWnkaindCa+f7KyHdxkCojDSh0ArQOKPg6jp1Cc1OoEe0TnWwujHu umeNVjllSHu7iHJIaZRg7xHJPWh72RA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b="0/JBejos"; dmarc=none; spf=pass (imf01.hostedemail.com: domain of debug@rivosinc.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708562403; a=rsa-sha256; cv=none; b=js84QToI4dvxac/w1W5HA5esoVB3sXgLQMAVBIaBNmnQULKihLnDGkv1/1HA2n1bkoGcM2 GvbDOEItSimITiCEk227PChBitTyjQBUUlAHuFybUDz6M4rPWgLkyONWSDa0/Wzgguno2v 3+yUTK82VSTUcAUz3pdAF+vd6QzgGSk= Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-295c8b795e2so4369818a91.0 for ; Wed, 21 Feb 2024 16:40:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1708562402; x=1709167202; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=3cPh5EYVwGWaYgvsr8YLKJcb0/yJUuFAluKjFfz/1Eo=; b=0/JBejosUjyMI5XshqY4gde/S7Y7cvp3HL5GAgPfbHn3TxjuS3cN83KjIiIwkRL5j4 e1KkOz34/L7ypK/tPDh0hZwtclqIcNVw8s0yqHe2wuogTtzZvjN/tkHCaIWKuCYm6X/b 62U5Yd84Iz9xi3wW5/MTnmJHWOIot1/mrlnM4fr4F/GFNyhuFvg0H2h8QdakpVqaFAYh eGkWbjtsSBxcopa3TBfM/wYjRqLGGVVGmhgmrDeU2KQ+YbV6RyBWSxpm9j7Llugo8Zsm 4FVPTromKHU/8bFu/vZLjJ/UN4YPzAiHLEKuUEIL1TZdbjEeZcEhAzI7bEJqJIkh+6Ie 7rDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708562402; x=1709167202; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3cPh5EYVwGWaYgvsr8YLKJcb0/yJUuFAluKjFfz/1Eo=; b=ZW4TmPxjwXUE4eJ8XLiF6dypfTqUwIb19FKJLYRRnKawl8OCJhSgHQ1k2tvqnO+AOf CItSIrzyQJc3u8HAuLB7W92yrOR8rI3JvrwYVzuFDGGsqORth3ReEek8P99bd17IN+Li m0QKCbsYSMVeCM50P/6VJhqyb4ZGNJoR141ALMl82usa4jz1ggtKHyyIrlH1WbUEhRxr JqVslrW6jfUQp+pG4TyFIi8LE78N2zG/za2TvGjjKtzoS0aLyBnqL0bQEZhOcIaTh+Em PcwCBa2hUienaoXVBFnVfSQIqb8aETRN52DdmH5hi5oFIORHyo0PW2zZBsSxJj+povN4 Z6gw== X-Forwarded-Encrypted: i=1; AJvYcCUwe/5zOsPYMTePgbUORrQWbEq1fE5wvCDdk2hJhl4GWmrJ42+eQy38WLwXGIbB7Kl6rArncn3iQIyfsyyywPfZsLc= X-Gm-Message-State: AOJu0YzdD+UkLfctpx10KRIA/wkHBCPyTtymmfrAW0qxVlLXLcXtzhSN cSc5nsZGL/CYtBe251Rnk9FI51NkonShAiKy2YeftjK1KSlNlJjXFcOHWwFomKE= X-Google-Smtp-Source: AGHT+IGotfMmm5x9Xi19DeFfmbyjknJKTAh4y49q6+Q/YPgYYL/De9ObYQYYyxWmR72uNSf6FbQ1Zw== X-Received: by 2002:a17:90a:72c6:b0:299:4fa7:71e5 with SMTP id l6-20020a17090a72c600b002994fa771e5mr11324761pjk.8.1708562402076; Wed, 21 Feb 2024 16:40:02 -0800 (PST) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id qc17-20020a17090b289100b002993743e4a7sm2480570pjb.20.2024.02.21.16.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 16:40:01 -0800 (PST) Date: Wed, 21 Feb 2024 16:39:57 -0800 From: Deepak Gupta To: "Edgecombe, Rick P" Cc: "ajones@ventanamicro.com" , "bjorn@rivosinc.com" , "conor.dooley@microchip.com" , "broonie@kernel.org" , "keescook@chromium.org" , "kito.cheng@sifive.com" , "paul.walmsley@sifive.com" , "palmer@dabbelt.com" , "alex@ghiti.fr" , "Szabolcs.Nagy@arm.com" , "alexghiti@rivosinc.com" , "atishp@atishpatra.org" , "cleger@rivosinc.com" , "josh@joshtriplett.org" , "linux-arch@vger.kernel.org" , "gerg@kernel.org" , "linux-kselftest@vger.kernel.org" , "bhe@redhat.com" , "charlie@rivosinc.com" , "david@redhat.com" , "samitolvanen@google.com" , "heiko@sntech.de" , "panqinglin2020@iscas.ac.cn" , "mchitale@ventanamicro.com" , "corbet@lwn.net" , "revest@chromium.org" , "mason.huo@starfivetech.com" , "ojeda@kernel.org" , "baruch@tkos.co.il" , "waylingii@gmail.com" , "linux-riscv@lists.infradead.org" , "joey.gouly@arm.com" , "ancientmodern4@gmail.com" , "mathis.salmen@matsal.de" , "aou@eecs.berkeley.edu" , "shr@devkernel.io" , "andy.chiu@sifive.com" , "shuah@kernel.org" , "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , "vincent.chen@sifive.com" , "greentime.hu@sifive.com" , "oleg@redhat.com" , "willy@infradead.org" , "zhangqing@loongson.cn" , "jhubbard@nvidia.com" , "ebiederm@xmission.com" , "Wang, Xiao W" , "cuiyunhui@bytedance.com" , "brauner@kernel.org" , "catalin.marinas@arm.com" , "ruscur@russell.cc" , "shikemeng@huaweicloud.com" , "jszhang@kernel.org" , "jeeheng.sia@starfivetech.com" , "alx@kernel.org" , "guoren@kernel.org" , "omosnace@redhat.com" , "linux-mm@kvack.org" , "evan@rivosinc.com" , "bgray@linux.ibm.com" , "apatel@ventanamicro.com" , "akpm@linux-foundation.org" , "linux-doc@vger.kernel.org" Subject: Re: [RFC PATCH v1 11/28] riscv: Implementing "PROT_SHADOWSTACK" on riscv Message-ID: References: <20240125062739.1339782-1-debug@rivosinc.com> <20240125062739.1339782-12-debug@rivosinc.com> <2914cf78e47010e195d963857b37807e8446e3be.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2914cf78e47010e195d963857b37807e8446e3be.camel@intel.com> X-Rspam-User: X-Stat-Signature: asa1ker45car4j6b7o7ukuqd6ssey3wk X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 611F640003 X-HE-Tag: 1708562403-545126 X-HE-Meta: U2FsdGVkX1+IvfOUdjX7NPGZdCpGd1ICSqtfRGHsz3jBrAraR0UazZbVgJ25JlS3RMNFtfdZ+sBo1MyAK63FfVEv+s5twx5revlFX0Q5jTt38Q135q1y7jkw7aWvkUTjLpmpqIfy8euLkEaAmI6j1M2vZIyHBC+NppbEen1jH3mWxsUFq5O2OjSgjhtr8MOT7YMX4/bYhhCVNKEobSaZECW07mHeWrzepNCWk+DX16dp0nrQr8qWf64egUxCM+p+Yt0TmKs8QEpiYuuBtoAU/b/Vfs33G6NXGYq3DqVdrR4kYuVeUbPtEMJJCntsOrjludwm59i3bsEgLrL0II/j7t4GDPaSgXoRT1Tt/0qVW2OyIg/waQTjjAmivV2OEETvH9sC3LN1hLj/D2/bmPGyMwHgTDgKh+RE7lf9jYwR5c1QBz/e05fUoow/qz4F9g8ggF9WF1UX1squa7jendUfJIL434rS0yelNonHO+w1nXF5vYNbj9eqbh0FILVOk0nqSW/37S6lQw6tC4V/xbMdHyCG4rntqUDwevMeYQowTvnlgfJZXrBdQATzcCfq7vkqYedoH5c1jYPu22rkQndolHykndR0iwFSh9CQapNTxQNUi7vo8S3ZkmZlslDxz+5/71yy4hKMFs/xRLR5KgE2l1W+huCSOC/4N/FZIWydCIG+ZuWRf0uueb1oRIOJr5GRQSEBS8l24d0Heup2w9kPpaRuFc2gIGEsnmp+Z2L+9havAoMc5n/aDzF7c45rtGnv6gcjrck9BRZ472UlEu/0EhQrwuEP+vRM/jXzqrgpqkoUb+hYclBFxKa7jR436V7yJWt65LZFthSL73ygmxa7rgqrcZpbmMx6/2vbJT964IrLdgJE79q0iDiFnQk1GteFHzvqlLpSk9PBiZJrnmaKWSUYajza4vXVwZOoRrgsfkoG+PRnbzcB/Iy7Hb1u9K3cSqNDzAw3+UIsJWfvzfJ fA0VXoIK AADdvQ7ifvGiBUh3NzSw1sKwYPDyFMgIWDlYM8vjW2rYy0pCazeVz1kv1kg5dnef36JsPe53VN+eLvGC351BfufKr7MAPbjQqTvQcoQl2QE9rj5o4gmSc+NPJtIez5hfQJb/T0rEpysG+PAraS+CHK5djJEtD8XSPIBhqP/FnGihQxVU4RyBYNHcL3ju/BhS8QxwMU4YTtJIgFCo8AE7JB8vCGW/rW/vpS+XFF/zmHKsmkGjVQjnxGj8kfEyJ1FO43tV3q/hkScFD75Q/t1wVwGBd0qvl1mFKgdzLxZUP8WYHxFy4ROqMoSIKHdux+2brP4Ez96b6zx94D8boBv/UTAOErfMyZjzz9+X9tcsW6AbbdgDZg2ZEDNz9j2sL0ZoxjoLqV4aiTUED4CHjcNBsNAzCXOelbcL+lyZgytWfepv8jtIO6qykMykM74A2tydfDm2/k9ZXViplTdEbt6dwdLYdcuf6urPxYzCxhu7VQMxOVz3jalwqvhmY79wKLURF22eq+APARz1FGGqg+qW3ApZEU9+j6bbff4A2TvGHtVG99m0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 09, 2024 at 08:44:35PM +0000, Edgecombe, Rick P wrote: >On Wed, 2024-01-24 at 22:21 -0800, debug@rivosinc.com wrote: >> +       /* >> +        * PROT_SHADOWSTACK is a kernel only protection flag on risc- >> v. >> +        * mmap doesn't expect PROT_SHADOWSTACK to be set by user >> space. >> +        * User space can rely on `map_shadow_stack` syscall to >> create >> +        * shadow stack pages. >> +        */ >> +       if (unlikely(prot & PROT_SHADOWSTACK)) >> +               return -EINVAL; > >Are you sure you need PROT_SHADOWSTACK? Since you are passing >VM_SHADOW_STACK into do_mmap() directly. Sorry for (very) late response. In this patch series since VM_SHADOW_STACK was an alias to VM_WRITE. And that's why I needed PROT_SHADOWSTACK to disambiguate. I am updating my patches and going with ARCH_5 bit (and thus only 64bit support). So x86, aarch64 and risc-v will be using same bit position.