From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26E34C48BC3 for ; Wed, 21 Feb 2024 11:55:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8ED5F6B007B; Wed, 21 Feb 2024 06:55:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 89D536B007E; Wed, 21 Feb 2024 06:55:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73E426B0080; Wed, 21 Feb 2024 06:55:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 63BF86B007B for ; Wed, 21 Feb 2024 06:55:38 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2C52B40A2C for ; Wed, 21 Feb 2024 11:55:38 +0000 (UTC) X-FDA: 81815656356.29.4B3D2BB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id B2B0A16000B for ; Wed, 21 Feb 2024 11:55:35 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GV0pdRqw; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708516536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PLsLM/ECtgqgj6YScdKuDzdQeO2PVy2fvKFbE23nuA4=; b=g3lM5XCZA5P5LV2NrOXJ9L8JC0PpTCMRGjgzJ7YZvk55eN6YjW+eYbwfrjHq8EpT9YPcC+ Ox0oys0AoCLbXh8l8STLb2DNmI+8jBg1CFgpiv9Oind9Aq7+R9wXwX4YRrbAjmQ7NFHlWc Iit5i+tf8H5Spm51sQCRygL7ZBebfF4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GV0pdRqw; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708516536; a=rsa-sha256; cv=none; b=V6orrDr38WvwwEY+AzVTcsKReymO4NsKrYni7k8u03d8razOWaTsXPD/n9tM497UbCefSH GAivjBoTIp04SAD9iJvwRAmK69qEep1u/YGBpobh1LXi1hj650L/FuT1XNMaXD9xo3TRy4 NVaKMP/+XNEsYYpvvFqahxucuLPvo38= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708516534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PLsLM/ECtgqgj6YScdKuDzdQeO2PVy2fvKFbE23nuA4=; b=GV0pdRqwCDFEojga+//XMYrng8iSA9UBdeFwI2m9v5LaeDyHONiCFJaHQqQLJjgB+JnkZ6 1l4BX64CQdGqU7BFTLacCKSCoECcFsdFvO9N+QkQ7QfPnhmfYwyuK+nXANndwjDl3nmUYS VvQQ8UYR8qBiW7PR13BlxrUNM1f0JAs= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-329-CAt2KnjVO36S6P-mmWZ_hw-1; Wed, 21 Feb 2024 06:55:32 -0500 X-MC-Unique: CAt2KnjVO36S6P-mmWZ_hw-1 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-6dbd919aba8so1474142b3a.0 for ; Wed, 21 Feb 2024 03:55:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708516530; x=1709121330; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PLsLM/ECtgqgj6YScdKuDzdQeO2PVy2fvKFbE23nuA4=; b=XWm5rsBlvgljYeKuEbzWTvU1Cu38wi5SG2OhUb4iLd1qZtmkZ9PIuBq3ar97oV8PcH 0hYpQELYxVrvuRl7ynmOgCKLrQ8M+ULgHa7qfzea3gob8ruB2jZfNNx8Moc120WOM1Gw vGL8zXsIEh2/f6qNEoF8M44mJxwvxwnMtabowKOJuqTNRHrlzoF6W71MjOzVIOkzWAsJ tFf512aJnFdIn4IXDVf6nibdncRLWMNzexDuXwM0cGMOyl1Dk7MajEGfNPTzgEgI9QdG 4P5BPk6Lt2pgXJo01E5arTIp3fUlYksyCom2TYEQcCQG4pQ7Z5D3sJp/t06rOlbmkzwb rCQg== X-Gm-Message-State: AOJu0YwPmt/49bQxuIzuP6aYXPe0P68m1xfyRoqajzpXG4oJYdmmW08C MUas4BHBMK0F5Rtw8B6csTt06NzaTVleeMnXMrkp2vyWPEn8n3bFDNI3NJy8VKCrAZI1x6iuxqW YPx3ptmUzmoBWtNU0cENv9RkjThnygozjvhn2E6NIDCc4yVuw X-Received: by 2002:a05:6a21:3397:b0:1a0:cd02:b2f1 with SMTP id yy23-20020a056a21339700b001a0cd02b2f1mr196521pzb.3.1708516530464; Wed, 21 Feb 2024 03:55:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IGRO+9lM9EY5N92dCc9bYoUlt/pUN8sgkXoKwNhU9AZ+BNLKu2lSvew+Aw+SPUl5ZIlIuODvw== X-Received: by 2002:a05:6a21:3397:b0:1a0:cd02:b2f1 with SMTP id yy23-20020a056a21339700b001a0cd02b2f1mr196492pzb.3.1708516530136; Wed, 21 Feb 2024 03:55:30 -0800 (PST) Received: from x1n ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id b3-20020a170902a9c300b001dc0955c635sm4149309plr.244.2024.02.21.03.55.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 03:55:29 -0800 (PST) Date: Wed, 21 Feb 2024 19:55:17 +0800 From: Peter Xu To: Jason Gunthorpe Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, James Houghton , David Hildenbrand , "Kirill A . Shutemov" , Yang Shi , linux-riscv@lists.infradead.org, Andrew Morton , "Aneesh Kumar K . V" , Rik van Riel , Andrea Arcangeli , Axel Rasmussen , Mike Rapoport , John Hubbard , Vlastimil Babka , Michael Ellerman , Christophe Leroy , Andrew Jones , linuxppc-dev@lists.ozlabs.org, Mike Kravetz , Muchun Song , linux-arm-kernel@lists.infradead.org, Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox Subject: Re: [PATCH v2 06/13] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing Message-ID: References: <20240103091423.400294-1-peterx@redhat.com> <20240103091423.400294-7-peterx@redhat.com> <20240115183748.GR734935@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240115183748.GR734935@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Stat-Signature: 5qp5q5g73okkfr9zkabrq3edo3zqgkws X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B2B0A16000B X-HE-Tag: 1708516535-301789 X-HE-Meta: U2FsdGVkX19yDkZoaV8VtLOxnWznR3TVGThZOEnnrttuGwA1kq87PCK6Yvw+h99iNLsF4Xtm9Q1L+NdtCPPeIPcbIISvZh1ZPyUlStzsSEL+3Nw4unTW35lV4iWLPz8QGRWHC7w1+lr4iQiB/QlGwfe93SKTxeISKDaFoiCwUiXQHAYUtLxvzbLNqjlHX/JBtXk0KIHEIHjowM9N/JdhLGyHDsHTVqn71C/1XFQ12f8Tqq7Tn9UtAfN0AJ+jsa32zIa/savNi5vL5StPwpvgepIc7byI58SOb1fxFGpD0Ek3kxb5kOZMsQCj85Odak5rSe2l71wmPC2IumGBXCIuH2S0cRx4XoQ7sADltYBkx8NEd3lkbHXkhkvY/gMRFqSHVGOY8NLQjbr3iypYBMYGBZRlbJfWpNxJVXsGciREPR0jje4uy+fVoiDQb7iJzQDOKDxesiZ7l8kBgvSpvU1SxqOf1uJrka16YDQvGunwUJMBHEiBT0frr0f9aubLhDY5aXhjuQ7dJs5al0/q6neRXeh0+cOe41JEx8JQVBeJfrMuIWQIW/g2Aoxnt6skcgfZjuxk60p6+YlVYBy0djoNevtLEhBy+1Qtz8tPoRi2uEdjApVMNbSTKp+pekDg/br/r3bHhsGTWlSb/jKV6Wsq91yrvBn7gAZ63Zwt41B/5EM1szsbxLTGoFAiDwN8l5QJRDMtcaISkL8BvhgPvrCaHz3texjELR50p9kQPfVe9CTDkpfTWXUA/MkrXnJoUNz3HfbC91RhQ0HGuqMnhUydV9fLGZnLRoVGCjmOG80VOJs9Sxbtl0lsdz+K0byvydQ2s0c4+XEYrITgbULV/60DRvoVG6DkeFPaianLJ033h700wr4w5poHjQw+LVoC7JATDd31YqHXSgyok/Xb9lImX1BbboDTHE6e/Y27GzH66hMbBTRx5eMivDha9zHlpPPKLwEcuHZklMToqhAKbG/ H7ldcEru fYgWVmE5/44kDWBLlI6t2oV308IIEgKDKSXU3ZVIPsRKiLig1bPshXBcle2f3b/6hSo3gayspcUEjErHlouI/9tezfkjuIbF+CxYJ9UAPsA9XhArZjd1k2V7HG43k6STfVKx7sGBKyrVLGRM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 15, 2024 at 02:37:48PM -0400, Jason Gunthorpe wrote: > > Drop that check, not only because it'll never be true for hugepd per any > > known plan, but also it paves way for reusing the function outside > > fast-gup. > > I didn't see any other caller of this function in this series? When > does this re-use happen?? It's reused in patch 12 ("mm/gup: Handle hugepd for follow_page()"). Thanks, -- Peter Xu