From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 954F2C48BF6 for ; Wed, 21 Feb 2024 10:48:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0508B6B0071; Wed, 21 Feb 2024 05:48:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F41466B0072; Wed, 21 Feb 2024 05:48:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E082E6B0074; Wed, 21 Feb 2024 05:48:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D02CF6B0071 for ; Wed, 21 Feb 2024 05:48:14 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9198780A0B for ; Wed, 21 Feb 2024 10:48:14 +0000 (UTC) X-FDA: 81815486508.12.5F2B4A4 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf25.hostedemail.com (Postfix) with ESMTP id 683D7A000D for ; Wed, 21 Feb 2024 10:48:12 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=NURmmB4H; dkim=pass header.d=suse.com header.s=susede1 header.b=NURmmB4H; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf25.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708512492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+RE6Ltq2vFZk9oVHrjoTTw6kf5GQSsD0ggzPHZ5wiEQ=; b=HSreDrWmS6GGPFe15kwyxtsRtxjFBn+YDrduKsrXptbOr/Z1tqUQr6lijI1iczibXbI+TP nhCxbVzwA/CTlRd6tBNQsZjnARR90SG1iusEMvDVhrPNu46yLHyBtKE0gXKND5Jx/8E/cK J77JnFvwobsGMERNah8PWKpDswn9B+c= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=NURmmB4H; dkim=pass header.d=suse.com header.s=susede1 header.b=NURmmB4H; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf25.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708512492; a=rsa-sha256; cv=none; b=WRq2d5mpQgs2LN44zJIjeoEGabp9J/p1VLdZMTs04ElPw5R7wKDZmSP3TRrTg+iaJiMCOR MuGPqdeotcT8f3QDbpnuHtliCV9tKM3DQw7HFL2ZH8OUQYDJ8qxJYwnwnkopwg51f4ucTg rERUxDoIOSuMp9RRf4spxc6W/9PfyAo= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8B39B1FB4C; Wed, 21 Feb 2024 10:48:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1708512490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+RE6Ltq2vFZk9oVHrjoTTw6kf5GQSsD0ggzPHZ5wiEQ=; b=NURmmB4HElCBZ1jAKQSvF3s7ZW4oVjnsWXUItR76gU07w9tFK0LbFhhQDcmpxMa+YYf7S0 HmBBRwSJ3IGJATS0tGDOYv1gizDkXOIaBv+MK3aMrXoSTHc/7k4hVkC2pMkHEVPu3OV76T 6Ys5FVl1DFJ9H11uACQ68tcIV8go4G4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1708512490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+RE6Ltq2vFZk9oVHrjoTTw6kf5GQSsD0ggzPHZ5wiEQ=; b=NURmmB4HElCBZ1jAKQSvF3s7ZW4oVjnsWXUItR76gU07w9tFK0LbFhhQDcmpxMa+YYf7S0 HmBBRwSJ3IGJATS0tGDOYv1gizDkXOIaBv+MK3aMrXoSTHc/7k4hVkC2pMkHEVPu3OV76T 6Ys5FVl1DFJ9H11uACQ68tcIV8go4G4= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6F108139D0; Wed, 21 Feb 2024 10:48:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id P5hhGOrU1WUQSwAAD6G6ig (envelope-from ); Wed, 21 Feb 2024 10:48:10 +0000 Date: Wed, 21 Feb 2024 11:48:09 +0100 From: Michal Hocko To: Greg KH Cc: "GONG, Ruiqi" , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , cgroups@vger.kernel.org, linux-mm@kvack.org, Wang Weiyang , Xiu Jianfeng Subject: Re: [PATCH stable] memcg: add refcnt for pcpu stock to avoid UAF problem in drain_all_stock() Message-ID: References: <20240221081801.69764-1-gongruiqi1@huawei.com> <2024022119-bogged-action-c877@gregkh> <2024022134-tackiness-earmuff-59ef@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2024022134-tackiness-earmuff-59ef@gregkh> X-Spamd-Bar: / X-Rspamd-Queue-Id: 683D7A000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 37ts7u5paquh3rj7p6qfqs7o33u9buwf X-HE-Tag: 1708512492-373005 X-HE-Meta: U2FsdGVkX184gfw4cb0+9MDw1qWPIc/mW0u7DYk9O8Z85ybxrR9va8MnU3M4ZVmSzeLpbz3duG6T7+PrXF9uflNv+9/Jnqu0Ee1PvfppXqwoNo1tshPzqDbAoIZThPkKXcj4BHDBPU9hjnBqrTLy/pIitxJPe56k1WqVKlQU5VXz2Zz7UpCfoeQ3uWGAg2quoScDwtiSsHtMV8ze7MdCqEbcHmLnGZOAENTbEVQ2ZzAxSIKrkvHN47uvy/SDLWYJyniV0faNzUyjclZlBMUjlQ5Sp2dcNaprPWLlESISUnuj/NFtEk92zCCFYf04ba5yS7q3g0mtO7175IFekpfv1jmEL0LmvskryZdu3FW7kzZ4VA4TgEWj6d8dpmxES8DSDJU4lO3vABYzcfKKj/5LHE9VDFraKIAYFsX6Af4eMi5jKe2N2duvJaEQe3iGnv7PIkzkm6Y7pXJeUajsp5EFfQ5hnTTaWe7GP+WjCsL4DnrtBaYRBM1bNYWUOpXu0fxaanaIg6ny8vE2krcqDmd1YOGuwbd8WFj65iqfk/MPj9CElimuQiwN5CVDmCk1AqgnV9DImuIP1bQ9Y5koEBcvnlIeJriyaC3qSVz+J7pMgD/lIawV5kHYsyS7OgQFhrUEdCqncISSRv3mpUgz61t5cBFpje4JU6fNcrwk6Zfa3MLeVE9540EOR/QEUiGTsD7CYElJAAhANQltJlLmrz4jNgfcIh3pcmwpHYkAYrC5N0WN37yyJdA3dNS/AGYBVYoYZhT3nwiatV0ajYsuKMTl1s16r8kUOgc9mOSf8LSFCpi34UBrhKTPIH5QBqH529nZ5u+S9ts2MQxjFmUfylZ2QzJG1am5oXpmx4/jkrAJQRiCDDpGiMNmf7IPi4RDiARS/X7V+5GtW5nIL7Ryn+pCT6Kl8cWw2CGKUkXVIJNJHqxNL42oBhO76irk3gGCNC5e X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 21-02-24 11:33:55, Greg KH wrote: > On Wed, Feb 21, 2024 at 09:48:05AM +0100, Michal Hocko wrote: > > On Wed 21-02-24 09:40:29, Greg KH wrote: > > > On Wed, Feb 21, 2024 at 04:18:01PM +0800, GONG, Ruiqi wrote: > > > > commit 1a3e1f40962c445b997151a542314f3c6097f8c3 upstream. > > > > > > > > There was a kernel panic happened on an in-house environment running > > > > 3.10, and the same problem was reproduced on 4.19: > > > > > > Now queued up, thanks! > > > > Give it some more time Greg, http://lkml.kernel.org/r/ZdW2gMajIw_cUN2-@tiehlicka > > Oops, now dropped, thanks! Race conditions. The thing got resolved in the mean time. The patch is a partial backport, and I am OK with that. Now with my questions resolved this is good to know but a note about this being a partial backport in the changelog would be nice. -- Michal Hocko SUSE Labs