From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E8FBC48BC3 for ; Wed, 21 Feb 2024 10:22:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A00576B00A3; Wed, 21 Feb 2024 05:22:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B0E86B00A4; Wed, 21 Feb 2024 05:22:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 877F76B00A5; Wed, 21 Feb 2024 05:22:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 778276B00A3 for ; Wed, 21 Feb 2024 05:22:28 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 30FC51A09A5 for ; Wed, 21 Feb 2024 10:22:28 +0000 (UTC) X-FDA: 81815421576.21.F67F4F8 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf11.hostedemail.com (Postfix) with ESMTP id 33D6340013 for ; Wed, 21 Feb 2024 10:22:25 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=WJvTciW+; dkim=pass header.d=suse.com header.s=susede1 header.b=WJvTciW+; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708510946; a=rsa-sha256; cv=none; b=EC/MUoTuSotuYW4upkaitLsGyGd69TW7VpsjfYr6+jnKszpx+z8dR+eYDfYSDaadRjbHtQ UxLPFIv9ccCjzwzD3r6jCS1eG3CVPTbkPjDhbGE4dxxB+dwTCX5XV/vzr4cOCoKAb2ukfU sJ3epVwKJfTqkAAJ+hKulMjl5yCusj8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=WJvTciW+; dkim=pass header.d=suse.com header.s=susede1 header.b=WJvTciW+; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708510946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JUQXQbWJgELZMgcNLwzkaVchD+3Rj5s227haqHX0N/s=; b=UmpF/4DNurPd76xSvCpyUWBcWmcsBdDjubXM4VBJlyGsjNjb6Tz7ohaIhFfdtXmpNwaF6a ZXe55R82TxhFByy0m1mED1Z7qDn9KuMEeKFZCHJTf+pMAKLAtU/xymznEnpkLiJIII2bO+ lsxVJuQG9MZLO2SmwuKEIJRvPLJav20= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 865FD1FB4E; Wed, 21 Feb 2024 10:22:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1708510944; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JUQXQbWJgELZMgcNLwzkaVchD+3Rj5s227haqHX0N/s=; b=WJvTciW+etvqI61sZ2YON21tndWkWqxdlXhMC1CzDAlJWk8l1QG4fhrkXb6u9LQ5ewo9Eo nKhqOBvylDd8dLQtbbZOZsXWJoUSDa0s/MHEKCPB/TBjtX8nlrkIQb/Kn5OEjNoUWPdA8w wECuTljBPVjTe8xoXGJkuolbzTR2xb0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1708510944; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JUQXQbWJgELZMgcNLwzkaVchD+3Rj5s227haqHX0N/s=; b=WJvTciW+etvqI61sZ2YON21tndWkWqxdlXhMC1CzDAlJWk8l1QG4fhrkXb6u9LQ5ewo9Eo nKhqOBvylDd8dLQtbbZOZsXWJoUSDa0s/MHEKCPB/TBjtX8nlrkIQb/Kn5OEjNoUWPdA8w wECuTljBPVjTe8xoXGJkuolbzTR2xb0= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6933E13A69; Wed, 21 Feb 2024 10:22:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gcG0FuDO1WV9RAAAD6G6ig (envelope-from ); Wed, 21 Feb 2024 10:22:24 +0000 Date: Wed, 21 Feb 2024 11:22:23 +0100 From: Michal Hocko To: Gong Ruiqi Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , cgroups@vger.kernel.org, linux-mm@kvack.org, Wang Weiyang , Xiu Jianfeng Subject: Re: [PATCH stable] memcg: add refcnt for pcpu stock to avoid UAF problem in drain_all_stock() Message-ID: References: <20240221081801.69764-1-gongruiqi1@huawei.com> <5436af7a-26d4-7c04-466a-7163d5a26040@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 33D6340013 X-Stat-Signature: 3t613jrwcnqqnebphuf5f3zsb8rqgoa9 X-Rspam-User: X-HE-Tag: 1708510945-392262 X-HE-Meta: U2FsdGVkX19XYi3ZafmLoaMIozxYAkTJFZH0SnujuSCpXKIyzR/zp1DC8sxp9eQaUfxyMbVHVNOzv4uqUPXKnDU/mMLgp52I0VcchxhR+raywa5AAJH/+Pl9T/55bnWhI6YDg9KhT8OArcMQvDjC/9M8neDRLHARaTTJWWZHBGzEFkS5c13O/Vk9TmZCqpehWTusOd+kCBebbHZ6dwyimQrZ4sZv89YklXi/E6ajazEnV6Av7E0cUHpBxPbkuDMh3o1B7jJZgloZ7gzDr7Prmj8SEGHMRnmu8fHuS4o4iU/ie7+73Cxlwrq9+SJdT5AS4GT4zdEoISeL6bU1MhVT2qshsA+EQMgPRYD/RsuJURNVJNmC8LtFcDiJyDaXax6ddq8G9udjZBcyVM7RbYZT9+VBLrPSEVxMrJ7sK2hkX4OCZpH3AgsYYJjsy6e94OBRXLYGZfgyBv3pBAKdwA81X8K5WuqxdVjXRBOPFhv0Z88F0Vq9O2OF/U954P+pY6h7zciqb8zSO56rTkJ6dwx6XMZ4+NYAB2R83SCGJEBNyRSPqypYcms30V/GPZr/kDbDfrEcCN3JjB9193XoVx6vabCkEeH5YtxrSfV7bj1aNAaP0aJb2L9r7SQSSkt1CS+t4HDbZnYjT9zc/fFzWi8TDn+OmbIeITSSdKmG6XZiqaI8vdoAs9qiGPTgkcNm+HIJvoW7jyQ0q4BBUKTyFSDpZgLONSRGQyuJef7YVUzQXi7JxMkSX2aXM01frw1kPzMV8c5KtswDwXmvSfrH3mWYXS7NjeHTZdxdzhI5fmQ7OcIzYxngUB5ZbemOqxdmzwXW/hrT8nnNBnNVrT/8dl8LK5c+hv9/8H+bUlPpt310Es1DO3e5JVGuM8i0KvOhAzTTYFo/wwSoG3NwV+rvxpVTAprTRon0Y/oPWPMIgvGRssHfXKzkdizGqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 21-02-24 11:08:02, Michal Hocko wrote: [...] > You are right. Thanks! IRQ disabling is there in one form or the other > since db2ba40c277d ("mm: memcontrol: make per-cpu charge cache IRQ-safe > for socket accounting") so 4.8+ is safe. Backports to older kernels > would nee to pull this one as well. Scratch that. Prior to db2ba40c277d, we used to disable preemption via {get,put}_cpu_var and that should achive the same result. -- Michal Hocko SUSE Labs