From: Michal Hocko <mhocko@suse.com>
To: Gong Ruiqi <gongruiqi1@huawei.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeelb@google.com>,
Muchun Song <muchun.song@linux.dev>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
Wang Weiyang <wangweiyang2@huawei.com>,
Xiu Jianfeng <xiujianfeng@huawei.com>
Subject: Re: [PATCH stable] memcg: add refcnt for pcpu stock to avoid UAF problem in drain_all_stock()
Date: Wed, 21 Feb 2024 11:22:23 +0100 [thread overview]
Message-ID: <ZdXO39jcmhWeYUxS@tiehlicka> (raw)
In-Reply-To: <ZdXLgjpUfpwEwAe0@tiehlicka>
On Wed 21-02-24 11:08:02, Michal Hocko wrote:
[...]
> You are right. Thanks! IRQ disabling is there in one form or the other
> since db2ba40c277d ("mm: memcontrol: make per-cpu charge cache IRQ-safe
> for socket accounting") so 4.8+ is safe. Backports to older kernels
> would nee to pull this one as well.
Scratch that. Prior to db2ba40c277d, we used to disable preemption via
{get,put}_cpu_var and that should achive the same result.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2024-02-21 10:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 8:18 GONG, Ruiqi
2024-02-21 8:38 ` Michal Hocko
2024-02-21 9:50 ` Gong Ruiqi
2024-02-21 10:08 ` Michal Hocko
2024-02-21 10:22 ` Michal Hocko [this message]
2024-02-22 2:01 ` Gong Ruiqi
2024-02-21 8:40 ` Greg KH
2024-02-21 8:48 ` Michal Hocko
2024-02-21 10:33 ` Greg KH
2024-02-21 10:48 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdXO39jcmhWeYUxS@tiehlicka \
--to=mhocko@suse.com \
--cc=cgroups@vger.kernel.org \
--cc=gongruiqi1@huawei.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=stable@vger.kernel.org \
--cc=wangweiyang2@huawei.com \
--cc=xiujianfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox