From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64FE1C48BC3 for ; Wed, 21 Feb 2024 07:48:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8DDB6B0098; Wed, 21 Feb 2024 02:48:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D3DE36B0099; Wed, 21 Feb 2024 02:48:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C05CB6B009A; Wed, 21 Feb 2024 02:48:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B128B6B0098 for ; Wed, 21 Feb 2024 02:48:56 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 78224120987 for ; Wed, 21 Feb 2024 07:48:56 +0000 (UTC) X-FDA: 81815034672.06.463ED2F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf24.hostedemail.com (Postfix) with ESMTP id 70471180017 for ; Wed, 21 Feb 2024 07:48:54 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="SrlViTr/"; dkim=pass header.d=suse.com header.s=susede1 header.b="SrlViTr/"; spf=pass (imf24.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708501734; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IRbu95ndc5Q/k1aKpotHjrytQ9wAORSBPZnVG4BEI2M=; b=YLaG2r0RIK8IgKb9tPGEbBFr8gXBdd/N6E/+YVuMn52hLPSnH8pa5zMyr1xMTARkFq94CG N5ykH5PofZ6ffh1LZzxIHImU5Ob2sCY+5I9FyPkFwCaSHoLWBbcHlCEeREVtbHoxNgVsfG 3oDbV9DK6xhnFq49FkfeavILhrUU9rc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="SrlViTr/"; dkim=pass header.d=suse.com header.s=susede1 header.b="SrlViTr/"; spf=pass (imf24.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708501734; a=rsa-sha256; cv=none; b=gtuRV/qFZNEtYAyO4sZh1B83AqSGrONcRJTg352PJghaUGCJqZUPnCNJLNqCOxydtILzeF K7nC89v/A+7oxtItYP6CYPZDOJiyFatgOC4KsduIcSNoYUqdg1Qcf6wg9+wfCbyTNFgNwg 3Rk4uPJYGXf6akErfLSufIr/Dch+9hE= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CF7812208B; Wed, 21 Feb 2024 07:48:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1708501732; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IRbu95ndc5Q/k1aKpotHjrytQ9wAORSBPZnVG4BEI2M=; b=SrlViTr/C5TBZl7o+JwS33u9jVycvM3LjkdsrOAYDiVrHQnebyHHBzBlIa+e+FzWaUUx5b 4ZwgBGIVATpHu4p7TlT0+Mw87OW/CBoxb20tZifCP/fKD8LWqpg+S/U5y0Hhp/mBZGNJQs gNAiD7l+pmpOAIm1tTkQdUgtgBTHjyE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1708501732; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IRbu95ndc5Q/k1aKpotHjrytQ9wAORSBPZnVG4BEI2M=; b=SrlViTr/C5TBZl7o+JwS33u9jVycvM3LjkdsrOAYDiVrHQnebyHHBzBlIa+e+FzWaUUx5b 4ZwgBGIVATpHu4p7TlT0+Mw87OW/CBoxb20tZifCP/fKD8LWqpg+S/U5y0Hhp/mBZGNJQs gNAiD7l+pmpOAIm1tTkQdUgtgBTHjyE= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AEEF413A69; Wed, 21 Feb 2024 07:48:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id bf/4J+Sq1WWOHQAAD6G6ig (envelope-from ); Wed, 21 Feb 2024 07:48:52 +0000 Date: Wed, 21 Feb 2024 08:48:48 +0100 From: Michal Hocko To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 0/4] Convert memcontrol charge moving to use folios Message-ID: References: <20240111181219.3462852-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111181219.3462852-1-willy@infradead.org> X-Rspamd-Queue-Id: 70471180017 X-Rspam-User: X-Stat-Signature: tudiwtutrytbanbdwu99fxakorzg6iux X-Rspamd-Server: rspam01 X-HE-Tag: 1708501734-42706 X-HE-Meta: U2FsdGVkX1+wK4vs3e0U02Z0Pfun9wRJjqvO1OSKjjsE8XHZrmwF0DkPOnOpKkivvB/QwObg5+1T1wwhC1XFvSVLnfs+38ubOh9R3RwI1rd18hvPGRHC16OM0QxOp6YWJDEyzQNe7fD3jg1f25mX0gmIIQCHv2sG6e52/xuQRTrGeyM0M8ukoXnbJoDSGNlJHpXRpEgNNXpvdKeL6F9tJautWScrDzSssQrqNZCgPsG89Ns1qohDHADWbSw5nyFjDwkfjhKG0ZFDlDtoPsHqsIAAQVcUhr3/3mpwsiw9ez5A8GvVRCcPxVmPrNy+siI4hP0JRQpuJJ3qDCFl41UCASeWHIQ5tKtrhyWQRW+M71lQpG/I/trpof541vs4+TSEKAApGBlzrXPBXQ0OYOqwkjkmnGvgKUSZvNwf6JeZRNURpjMxNnBBK5bz+6fLbGvCr5Wn+1LbPsCUTKd6L0LKZxzcpGdxFX55/WCobIFQb0ZBOXPMt/erCwxcGjn/923CzS9o+xQw7p/erTtVm/bRmYIwL+mcJC4V3bgjtkxbpaQA3ObLHhd92CGKI7o3xf6HMVqtHfudhiVd9LiRj2DcsME9JRqncAByZ/cPTXiNucXz8fwYvRp86eKiAO169M88D5KK/On2i4CgsVdz4BLe27w1eSlbuIjANFEQEk51+fTDmKD/9r57uxbgXeEJ96wr527oUsLDAywdkv2kpVMie2atpT9uZuLX4TTCTi7IakccvMbdwt58M2FP+7gpap0LAI+Hz3hFRRguBbnj+LpVaTpr2I9dl4HbXVQRZfrf8Q5UghGfrJTIwxMdcHc4v8gx4j8okL8iRkE8FWtkgInJpRCovtOPuZAeRu8XRxjAGcEE04jquOx0fP8UAmapKHzEMMwphq94erk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Thu 11-01-24 18:12:15, Matthew Wilcox wrote: > No part of these patches should change behaviour; all the called functions > already convert from page to folio, so this ought to simply be a reduction > in the number of calls to compound_head(). > > Matthew Wilcox (Oracle) (4): > memcg: Convert mem_cgroup_move_charge_pte_range() to use a folio > memcg: Return the folio in union mc_target > memcg: Use a folio in get_mctgt_type > memcg: Use a folio in get_mctgt_type_thp > > mm/memcontrol.c | 88 ++++++++++++++++++++++++++----------------------- > 1 file changed, 46 insertions(+), 42 deletions(-) sorry, I have missed this before. Thanks for the conversion, all seem fine. The code is rarely executed because it is not enabled by cgroup v2. But I do agree that it nicer that it fits to the new folio scheme after these patches. Acked-by: Michal Hocko Thanks! -- Michal Hocko SUSE Labs