From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4741FC48BC3 for ; Wed, 21 Feb 2024 07:10:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF97E6B0071; Wed, 21 Feb 2024 02:10:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ACE306B0074; Wed, 21 Feb 2024 02:10:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BE506B0075; Wed, 21 Feb 2024 02:10:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8C4146B0071 for ; Wed, 21 Feb 2024 02:10:43 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4B233120996 for ; Wed, 21 Feb 2024 07:10:43 +0000 (UTC) X-FDA: 81814938366.16.77D7330 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 95F3A100015 for ; Wed, 21 Feb 2024 07:10:40 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SVI+m3TR; spf=pass (imf05.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708499440; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VOlrYMmoEpRW+NdqInqmdntxj7aJK+0IpKZ0inMtZCk=; b=2o6T49aBGESu86cp+zCPab4FLKXphv2snU+qEyakmOgj0FUjDmdbcXeviuvhxhAcqShLCw 8FC3nNV/caSf35cQ/2jub1OPXiQVvHr5UZHU8xU8E8FFO7LgDszYUI0+yLQXb0wexJndte wkAiopjx9FkX5n3a7gl1gUu7PBK4TbY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708499440; a=rsa-sha256; cv=none; b=qOFDe1nN3y0aZtkYbpPWu5lxK82kvz/AQIKWUAZxFUF1+yfgo7xfv+zBAHpu15P9jQ3hFN U9IrWLqZY6jEGNkuxHUaiTSNQP7/B2t0TiCW+IfSiR5Nw5t/wsuZGL+lmyyfUV2PKyEKwK RIa5Hf9fW/NaFdtTcPQ3HEMahiE6oR4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SVI+m3TR; spf=pass (imf05.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 90462613F1; Wed, 21 Feb 2024 07:10:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2042C433F1; Wed, 21 Feb 2024 07:10:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708499439; bh=A+d6DunIrChPzyLKEwkHG4SMJU+8ZOEePbqT/034MOg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SVI+m3TRr9NZeiwKeQU+Je9+cyUMD7o4+u25WNFyM8EfHG6wE/PR1+OKIXjoFamMz 9kKnpafi5tsUeaxG+fEscpdoTOmK+6kYgcIDQfIeQquQgDPLOEkwAiDq8yevqlucsG 9BkboSvAtkQj0iDqe1YsbII0eh1IQIMNmYxQmXncNC96+OFeoTPDaRIrvm+a4/DARd WGOR/LXPDR7lRCjeHl1770zJep5xa3WNsM5XxGls6h4Dhsz02BbRvfM9LhpE8BOhNW qG4LNXFnNckMsjkpGo30HJsP1z5BxdP6gU4CpH/Ta1jGxBn72QzgtLSlPKrsKw9mvh IpTqG7pAYkXKQ== Date: Wed, 21 Feb 2024 09:10:02 +0200 From: Mike Rapoport To: Rick Edgecombe Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, debug@rivosinc.com, broonie@kernel.org, kirill.shutemov@linux.intel.com, keescook@chromium.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, luto@kernel.org, peterz@infradead.org, hpa@zytor.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/8] mm: Switch mm->get_unmapped_area() to a flag Message-ID: References: <20240215231332.1556787-1-rick.p.edgecombe@intel.com> <20240215231332.1556787-2-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240215231332.1556787-2-rick.p.edgecombe@intel.com> X-Stat-Signature: 8n15jdtsr8pp9afu5iom4oaj486js9we X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 95F3A100015 X-Rspam-User: X-HE-Tag: 1708499440-127287 X-HE-Meta: U2FsdGVkX1/EoztmxMOj3PuQBWeq/gEvJsLRFkgf/uNil6OUahM30MYYoovsUImQUW6Jw4coMiYnoTGP/ouOtGEVNpR3dBRw1TXyglsyx2L+6t2P5OhN6UKVb0bGGvq3HPIH4cvVSEPBdBcVVmJhof2rDtdBZ7BBwgv8uCRjPFhKMtCjSzKm6/Xbep5clERE0RoVfI/zi0y0ThU7T3aUUYbNMohKYZDwp/q5OZx9Yp/og/Y1CNxdD/8A7CU56agA9TY0hWh6HVYvGc14SREymCv1ZwDvZ68RgiBJmphNQ5OVyyFE3DBXP6bvGkz3tCKoJMZ/xRSqRnT2dlCDVVGiGmiK6oVvTKAm58VTrmcOo5dR1btEKq+his0EvaXnGitBmayePBAqcBwuavMyxf8RFtzGCLkpztWjiA02zXo1/k9Mq12luIhzm72DGSLpB0hmTLezX3lvFQ3S0d7r8gXsETFzL+fBV6os0kgoO//WOVCKcu41qcCjCH6i93cwXkfMwbiHrTWw77Ny9FcV6qRp39EEH18odlnxlulUz1zz/geLA4PTnjLLy2g5XYIU35LqyrFvU/Ypp0AsG3yYE0uQBq6csBCnWTKUmg/uMiED80La5c+JXzSYK+qiwMdTwlekVSmrudSYt33pPFasXdNr9S46wB0mgB8YwhrRlG/UWVSiOV+mh995o+gLHDbmdymoc2UtNn4XJJEF4qE3TRoNNqjSbB1xpC8PnS7n/ktihpYlPzXCGtPqGBWu3bgLddPfHPEIfNuoM/xWeIHhjBCr8IgZouVPA+bTvmtUvvmCDIrmwsVlYjg+Sv0Y7iwfcm8W265Rd0kv0fwdE9K1D6LSqJYBDESXN5BgtAlxh/EGGfHfgliX3RMw7X7NFJ0wnAjGRDLlodFrQuhzNXF/jVKfQm5IHBNo4TXc4y6/tt4elwnE+FsTA2mFmiSuO2zbGGQXTI8DiaN/QLHfTPONsY2 dfSmwaBK mpSph/gSD8K5F/FLLcPL4hDTGCYqtrQxzoyT/gTx2qZm/DtVz1v4doiLgAid87swYMe4ZbsLIXEhjEDoRwyMTwtpkrv4EHO+1JPLgQz36UV8srlRa9Hyp99jvXqNYTyHQSuEVKnvKGbClzyGXOU1KubAotORZf6uAeDpWzzj0UPMkFiXSBpMUx4oxlzhC+mBUK5ijBmAGxcLI5G8PNknQWLd/0/2AYV6G9CY3HPLdjTTkGbG8sfP7sjUxb5qX+hRWJ14Ad+eQKs3CAYM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 03:13:25PM -0800, Rick Edgecombe wrote: > The mm_struct contains a function pointer *get_unmapped_area(), which > is set to either arch_get_unmapped_area() or > arch_get_unmapped_area_topdown() during the initialization of the mm. > > Since the function pointer only ever points to two functions that are named > the same across all arch's, a function pointer is not really required. In > addition future changes will want to add versions of the functions that > take additional arguments. So to save a pointers worth of bytes in > mm_struct, and prevent adding additional function pointers to mm_struct in > future changes, remove it and keep the information about which > get_unmapped_area() to use in a flag. > > Introduce a helper, mm_get_unmapped_area(), to easily convert code that > refers to the old function pointer to instead select and call either > arch_get_unmapped_area() or arch_get_unmapped_area_topdown() based on the > flag. Then drop the mm->get_unmapped_area() function pointer. Leave the > get_unmapped_area() pointer in struct file_operations alone. The main > purpose of this change is to reorganize in preparation for future changes, > but it also converts the calls of mm->get_unmapped_area() from indirect > branches into a direct ones. > > The stress-ng bigheap benchmark calls realloc a lot, which calls through > get_unmapped_area() in the kernel. On x86, the change yielded a ~4% > improvement there. (bogo ops/s (usr+sys time)) > > In testing a few x86 configs, removing the pointer unfortunately didn't > result in any actual size reductions in the compiled layout of mm_struct. > But depending on compiler or arch alignment requirements, the change could > possibly shrink the size of mm_struct. > > Signed-off-by: Rick Edgecombe > --- > arch/s390/mm/hugetlbpage.c | 2 +- > arch/s390/mm/mmap.c | 4 ++-- > arch/sparc/kernel/sys_sparc_64.c | 15 ++++++--------- > arch/sparc/mm/hugetlbpage.c | 2 +- > arch/x86/kernel/cpu/sgx/driver.c | 2 +- > arch/x86/mm/hugetlbpage.c | 2 +- > arch/x86/mm/mmap.c | 4 ++-- > drivers/char/mem.c | 2 +- > drivers/dax/device.c | 6 +++--- > fs/hugetlbfs/inode.c | 2 +- > fs/proc/inode.c | 15 ++++++++------- > fs/ramfs/file-mmu.c | 2 +- > include/linux/mm_types.h | 6 +----- > include/linux/sched/coredump.h | 1 + > include/linux/sched/mm.h | 5 +++++ > io_uring/io_uring.c | 2 +- > mm/debug.c | 6 ------ > mm/huge_memory.c | 6 +++--- > mm/mmap.c | 21 ++++++++++++++++++--- > mm/shmem.c | 11 +++++------ > mm/util.c | 6 +++--- > 21 files changed, 65 insertions(+), 57 deletions(-) > > diff --git a/include/linux/sched/coredump.h b/include/linux/sched/coredump.h > index 02f5090ffea2..428e440424c5 100644 > --- a/include/linux/sched/coredump.h > +++ b/include/linux/sched/coredump.h > @@ -74,6 +74,7 @@ static inline int get_dumpable(struct mm_struct *mm) > #define MMF_DISABLE_THP_MASK (1 << MMF_DISABLE_THP) > #define MMF_OOM_REAP_QUEUED 25 /* mm was queued for oom_reaper */ > #define MMF_MULTIPROCESS 26 /* mm is shared between processes */ > +#define MMF_TOPDOWN 27 /* mm is shared between processes */ Nit: you may want to update the comment here ;-) > /* > * MMF_HAS_PINNED: Whether this mm has pinned any pages. This can be either > * replaced in the future by mm.pinned_vm when it becomes stable, or grow into -- Sincerely yours, Mike.