From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF053C48BC3 for ; Wed, 21 Feb 2024 06:23:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72F3C6B0080; Wed, 21 Feb 2024 01:23:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DFB36B0081; Wed, 21 Feb 2024 01:23:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AA996B0088; Wed, 21 Feb 2024 01:23:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 497DD6B0080 for ; Wed, 21 Feb 2024 01:23:12 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 15D6614073A for ; Wed, 21 Feb 2024 06:23:12 +0000 (UTC) X-FDA: 81814818624.11.35210CB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id 6CA7514000C for ; Wed, 21 Feb 2024 06:23:08 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oU1axoh6; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708496590; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OlrDKDxjflUCEmdbU7yemP1+yw4nEnT9q1BotCfOJkc=; b=MB6xOOr71DKeOol6hCjhQg8EaOHdPV2rO/H+t2auYNDlBhxIEPzofrZ+NwO3jKhQGn4r1g 5tZhwUWdRXtW4vPtT2SHq8Cfz5Kt+V/9jsbp+BKsI6YjJHwoe8vELeMTYgQFlcoY2JH+r7 Jv0TTNcJrkvy7q0m4dlHM8RwWuHcSb0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oU1axoh6; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708496590; a=rsa-sha256; cv=none; b=NL4TKSAVtj4ar99lV5ofcyT5SY0XUyfGyaXBAamyfJFBuO17Xsv4O9D9m+Kgp3SsSyuHiI gG5mVd13heTkJ8pdxpSys8Em5T9ZnlAA3XXA/EmnWICm7FDWt9I0Wpg3gui/SUpsuj9ZV7 r2q6UtJLhALdsS5fpHgcvUhgvm3wvJQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OlrDKDxjflUCEmdbU7yemP1+yw4nEnT9q1BotCfOJkc=; b=oU1axoh6HQwSGAzpI/epDTb49U WEAtP2gf3fLrUV47CbxNuzpecwDD9Sn8h++6fwd67cO+AybJMKQoJ7KcnPylCYZqgHfPNg248NGQp 4lXWpEdjwI23oU/81EUdyn7ASLvVX9JxcNpz/HplYPH3UBYw5nmmHd+BSFNit00qdDFGS29OG/vZq NtkEhTNgVZkdc2zXnhYkA1Jj3Rvo/IJD53NFDRktIl05j8kazm9hURnfND8DnUZyCo+/GAHQBCEPC FLukpqIgCcmJXRS3LiI4obesOCVLHb1MJIHNLsgvzLLSsgBl3LP4gdkWzOsCzYKhtlgEJwFLCKU48 ala0aN1w==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcg0Y-000000000xn-0oEg; Wed, 21 Feb 2024 06:23:06 +0000 Date: Wed, 21 Feb 2024 06:23:06 +0000 From: Matthew Wilcox To: Dan Carpenter Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mm: use ERR_CAST() as a cleanup Message-ID: References: <5a64b69a-40a6-4add-b758-ec3a9d93eb11@moroto.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5a64b69a-40a6-4add-b758-ec3a9d93eb11@moroto.mountain> X-Rspamd-Queue-Id: 6CA7514000C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 4uwzhizsyogfhcet93kbde64cso8czat X-HE-Tag: 1708496588-892396 X-HE-Meta: U2FsdGVkX1/gE/Yd6gkqOqVB22Q9TW9boJH4bUAQjMknem+YJoYKo14TjnumC73shSKyNrtep/yghj+4/+SDAjXNfBJuxFLrMjwk+QIcgUdQKP1QTaInk3fQs8eAD+RDi1KqMefGy96sPue4mlKX3fDqhbN8/FzgZZl7KAsvn/cumC7ghla01VniL9UK2/0ysXYDawTGn/Lk1gpaa16u8qL1HzJaZdW1oxEfJocEEfUtrkuTzQ7zf7EAsfVuybS9fE8lQwY3Va1e9LtlEP/aTK9OXLCfSxCiNrS3w8eyN0ltCh0xKBQsUN8bSKMzCrLlb/APOrld0P60pb/+oPWQgb46XPxMW01VY/QfYPCUdLVMXwfzHrRpRjb1GhxWKkwaZWScDTQ8JAP/JU0Wh3dtVF359NYKTMFgiDaP3jeFvFVA2mbeECMGhFoSa8Wdpd3PZDM8hIC+2XZfbj8dIVfnP+Yca2hjZcZdy4q2Txg6Ql4U3a5m658j+SyGWebJfRzU5GoMxwApoB5J/bv5B+vIx6HnhScYCH5LcaJKV+7DVtMIfPqS/x44xriyDNhjXHjHoyvdT7PdfN8PAGGSiAzSFgWao4vjvIzRW/RVPXmn9qMQAqeQqAQEtNWPgTIbRDgdbSFvS64fxKffialBWn3DSpSWrKlRF/GIYSK10kGHC1XEsFMgNkeSDmPVcLvMbKWu9Uhsg58mYnXeHS8gFSJG62xlFDsyRJpwQN815Vw8zYhyW2eWz7VpjgBGwANWMQKSVZ0SSgno7sf7RvEFeKpd6DMFReBB6zOi0u6itELVc3n8j2ZN5NtQjHHz1PqrzmosaGAcALiqPnQ7Lvxi+t/EOs97jkJHH9PZgVF2+yNQyaqDDYT6q3lZA1ZbvZAsA+U5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 21, 2024 at 09:22:13AM +0300, Dan Carpenter wrote: > The ->page is the first and only member of the folio struct so this code > works fine. However, if we use ERR_CAST() then it's clearer that > this is an error pointer. NAK. &folio->page is an indicator that this code is in need of cleanup. I use it in my scripts.