From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43475C48BC3 for ; Wed, 21 Feb 2024 06:12:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0A286B0082; Wed, 21 Feb 2024 01:12:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BA3B6B0083; Wed, 21 Feb 2024 01:12:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 882016B0085; Wed, 21 Feb 2024 01:12:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 763806B0082 for ; Wed, 21 Feb 2024 01:12:53 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3A64BC0961 for ; Wed, 21 Feb 2024 06:12:53 +0000 (UTC) X-FDA: 81814792626.19.141837D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id B8B68160007 for ; Wed, 21 Feb 2024 06:12:51 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OKlplEh9; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708495971; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eyCQyhGzuVlugjIt1ksnTcbcpu7e/5tO5wtvMkPfgxM=; b=gRJ9JHRKIZUBn5459Q9sriYQe7qrC8JjE4MemuBR6hDfM7RiniY3A7EX4bdyeEOXVLkHnH /8Dn6vJMjBsQjD43l7+s8Uc2DXgG8Ew+PnRa3wNCV7KAOtOHn9Xoq0So86FcDso4MOHyac PKZRN2/wuCgP13OzqqTF3SA/UJQrHNQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OKlplEh9; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708495971; a=rsa-sha256; cv=none; b=a/uzQ8UfsDdr5hzCOf35fhTohlO6/tLE3e8ib2xWIAjKYcpfUQetlxw6TPGBg/xkJMtns7 897WFnCYyEn0aWO8vNTuiKzxIUElKLVs5d17uUQmzro+BMvprriACUAbvd16gScvZ47nHm I9kmadTEYlzO0SC3aPSxboYhGKYL0t8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B53DE613C5; Wed, 21 Feb 2024 06:12:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 131CCC433C7; Wed, 21 Feb 2024 06:12:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708495970; bh=+a2TXUHgHx9ewr828yRhngPu0FUo2wmIaOoxSHyJyc0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OKlplEh9sLMQmx9Hl2i/IucT2jZPkZkqUmKau+bypPFQXCBJkoU0q84nYqYGkAkne RM8+aCtQ4agCD/1XSIyO/NFouZXnFYphrGuBsB3Ft83cCfPWCGLvmMgaZO+bSzIS5R E8a6NWAxNuwFRgxZ0836adTGyJW5Vg2JsOxRNLdx5z5Q8RNnSmWtqnSCQdTWGwYG8T /tDxNQcgSfbneLqAQXjL9BlLJQAt/jZv97L3DsZPyGXGSwLoaHbEqkN1oX7oLItycf yHTwKYU84FMuamlGIj9BKTQj7icxsI85MGWE+idKBePbMRuii+DX4dpKes+uQn483V E+ybak4gkvBLw== Date: Wed, 21 Feb 2024 08:12:14 +0200 From: Mike Rapoport To: Rongwei Wang Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, gregkh@linuxfoundation.org, rafael@kernel.org, pierre.gondois@arm.com, mingo@redhat.com, dave.hansen@linux.intel.com, luto@kernel.org, teng.ma@linux.alibaba.com Subject: Re: [PATCH v1 0/2] support NUMA emulation for genertic arch Message-ID: References: <20231012024842.99703-1-rongwei.wang@linux.alibaba.com> <20240220113602.6943-1-rongwei.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240220113602.6943-1-rongwei.wang@linux.alibaba.com> X-Rspamd-Queue-Id: B8B68160007 X-Rspam-User: X-Stat-Signature: xit83krf78eb4io14d7ixt4c39wnuabn X-Rspamd-Server: rspam01 X-HE-Tag: 1708495971-343864 X-HE-Meta: U2FsdGVkX18V9Mh6nRTFzzGDAwzVRCCP9bykWxG4NkU3cXWR1RXfNf/a0bBajgayoqZePj9KYYBo8/acEqWjY3HD4wCqp2J638R+1zM4UUY02Hlfi2DFoFCrJ+1Ie86HdEOLeRTqu1IlaCVHYvFH4p/GrnD3VWi4kZGtRP52STr5qw69I+HNVt9zMoPq2zpVIEzMMRcJi88bs68RVEZ22V672A9T96t6fFjsK5iE4U5yjIa9mJl5liSPuAXvl2J5EfX6CPszNH23nG/7ajiUU/nbgxG24fso+YC1BfZt2nvFAnG80HixIZU/6DN1kdI0HMCyjIKsepARG9F4B5nElcXXBjygeDXY6kfxPcPUdXEvKAxI0nDeXDwFU0Mh3GmSirvOGJUz1iZ1r38HkQ1ZMgwX6i0HFXRbSCQLpKEZRjoBpaBOvyTsDsJtX2QGMvCuX4vBq6Q12C4cFcK9JbUMU0/PiwZ0R/x2Bbid/HFaORsvm7mdQmpHCERbZdF/b6sKh5xeSulHbGh6Ryk5qPZ2wKEkvohs9iZLBSDlKLwoKJ4N3FYnEA8I7PRVav2+DP7zeOj/8gckywIfhs9m0RWCFS2mQd9XeZg0UzzffGt84gux5kkQFMvCgauseKcHfVuT0LLBLse0wXILyNP9zCxzgrkbQKKtUpjxuLq8B2mxs/KvpZt7Mx8wZLfoJIh5DNuVoWZkRLMhkONf18QhxydwAeefB4zTmExTTF2//DcgGaXtmopaKXsT9tSsk3AB+Tg3iBCgTNr2kf+h16fchNVpEyOhvClchZ8pE8R++fFiotleCebrNLoAxdIc7zgsVDi6/UMqw9NdQ17KRqug6FXXHTkQB8U4BrolU9aU/pdOHDtNSLYIJVa9EHXM1aNrSmdGZCeaxTyzgTA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 20, 2024 at 07:36:00PM +0800, Rongwei Wang wrote: > A brief introduction > ==================== > > The NUMA emulation can fake more node base on a single > node system, e.g. ... > Lastly, it seems not a good choice to realize x86 and other genertic > archs separately. But it can indeed avoid some architecture related > APIs adjustments and alleviate future maintenance. Why is it a good choice? Copying 1k lines from x86 to a new place and having to maintain two copies does not sound like a good choice to me. > The previous RFC link see [1]. > > Any advice are welcome, Thanks! > > Change log > ========== > > RFC v1 -> v1 > * add new CONFIG_NUMA_FAKE for genertic archs. > * keep x86 implementation, realize numa emulation in driver/base/ for > genertic arch, e.g, arm64. > > [1] RFC v1: https://patchwork.kernel.org/project/linux-arm-kernel/cover/20231012024842.99703-1-rongwei.wang@linux.alibaba.com/ > > Rongwei Wang (2): > arch_numa: remove __init for early_cpu_to_node > numa: introduce numa emulation for genertic arch > > drivers/base/Kconfig | 9 + > drivers/base/Makefile | 1 + > drivers/base/arch_numa.c | 32 +- > drivers/base/numa_emulation.c | 909 ++++++++++++++++++++++++++++++++++ > drivers/base/numa_emulation.h | 41 ++ > include/asm-generic/numa.h | 2 +- > 6 files changed, 992 insertions(+), 2 deletions(-) > create mode 100644 drivers/base/numa_emulation.c > create mode 100644 drivers/base/numa_emulation.h > > -- > 2.32.0.3.gf3a3e56d6 > > -- Sincerely yours, Mike.