From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 222D8C48BC4 for ; Tue, 20 Feb 2024 23:56:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 883016B0072; Tue, 20 Feb 2024 18:56:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 831616B0074; Tue, 20 Feb 2024 18:56:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 720E26B0075; Tue, 20 Feb 2024 18:56:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 62C1C6B0072 for ; Tue, 20 Feb 2024 18:56:48 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 29176120858 for ; Tue, 20 Feb 2024 23:56:48 +0000 (UTC) X-FDA: 81813844896.02.6F6EC6E Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf01.hostedemail.com (Postfix) with ESMTP id 6FE5040011 for ; Tue, 20 Feb 2024 23:56:46 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b="1Zi/jj4J"; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf01.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708473406; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zy/rgs0g/TbA1UDA0cVJ8uBAr2YACRPG8fR71g83JJo=; b=2ZcBaM1q+NbTGQ7d7bVTkK04Fiv2hc078+4DrlFD/PlLTD8SN6nlwMLtyWY4YdJDY5w5tC sM7IBI64eq7deXdrhVASi+gHXdT5Tdm7FpJYxSpuqNXKrRx1cRRJD5cpF4XKDDqxXTGFKl tZOxobYkbg0VpFZjsmi8slSAQU5+/vk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b="1Zi/jj4J"; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf01.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708473406; a=rsa-sha256; cv=none; b=qTTtoqo7ieSFcweVO1oXeyRuwhtgKmDllKWO8mO6iyzZsYF3MhxN8fjwgnlqVxqIYix3Sk EqpGIkE8Zs7W9+uyaZpQT8k6/bALsr02lmMuQRenwwiR/LTE951SqbR6ghGwFQ30n7aeqn AKvEtcJbYw+OVG7KPGRdLY1qzTvNRTs= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1dc1e7c0e29so7296955ad.1 for ; Tue, 20 Feb 2024 15:56:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1708473405; x=1709078205; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zy/rgs0g/TbA1UDA0cVJ8uBAr2YACRPG8fR71g83JJo=; b=1Zi/jj4JZ2yYmGVgN85X+dOOZ6LEv6D7glxiyhyJZlVriO8UbDPZFeLM2F3s6IJssq S5k/veo/OBpky/9wG7KakEgdEC3vW9wcayS9v/HBtWEAhm68PPfWihvZ9RJinJa7W4KW pqNFvhajtAfTAD39lI5q2K48ikGs7QLkVIiV50llzPslOX1P113Ui15Db/qLRom1jCHy FNOB4APztrUj5H6Yyk3fU0Pcfllv6HX/eXbKVsp+y7kWjl9XdTUd2ohaHFc/oL1jF+qk +tOsN9ZjGm/bZ2zzKy8MU2kv8/463L37MboT8qy6DA1fenV2WGkwjnLxeo7pyI0oGe3m h1bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708473405; x=1709078205; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zy/rgs0g/TbA1UDA0cVJ8uBAr2YACRPG8fR71g83JJo=; b=mr69I/G0sar/dnospPEmYjTZHLZdd6BLYuOaHSzQlVwFIieSrkPvs4U9FhI4t3mHtJ Hw9viCET23tIGWgOL9uan2QUf2zHpYaDi1aS96zblbCBuPkm48A79fzaaar37P678vys uZdmTEYWYemzpzTdxG+75QwHsgvZAo8oaIPXZcK74U2i7sigFpJmLOj1nAGtEhDV7jGu K3NNfbrABgv6/l1ON/A64zqcQ3Xl73+T1M8XtIwiB9OPvjIUX25UERIToFU69cwXnUz3 qzSgpAi1fzJTSRiUMv6reuy7qCsSX2+pt2PmM05396f8HPN3xN4JfFJd1AQWkULr6+dl Z+Ow== X-Forwarded-Encrypted: i=1; AJvYcCUa7EfgFmA4dy2zTbj2E1CbdB03D9PMYjFSJGivkKTqFJhqBQXOo4r2yD3BzWIMOsgFHVGdJtF4PTGZtpbTAQASa9w= X-Gm-Message-State: AOJu0YwFwVI541gpkrQvnL3vPHXE7Jx6hCuqd7UIFACD0jzW0FNe/xI3 o1xfeHIoyWnulc7ZHH69e3WVF/3K+oTsf7hE4V/oVG51op3S5ekthJwNs+rdOql2hMzW0E7pUiN a X-Google-Smtp-Source: AGHT+IFotZJCcbrZixEBtgri2TFS4JXpCO2EQWoDNfr5rKn5a4FAtP5Nc/i6qSkf1cC3p/mg2mPeRw== X-Received: by 2002:a17:903:2342:b0:1db:d9ed:f91d with SMTP id c2-20020a170903234200b001dbd9edf91dmr10759987plh.33.1708473405306; Tue, 20 Feb 2024 15:56:45 -0800 (PST) Received: from dread.disaster.area (pa49-181-247-196.pa.nsw.optusnet.com.au. [49.181.247.196]) by smtp.gmail.com with ESMTPSA id 6-20020a170902e9c600b001d706e373a9sm6776810plk.292.2024.02.20.15.56.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 15:56:44 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1rcZyc-009HRC-1h; Wed, 21 Feb 2024 10:56:42 +1100 Date: Wed, 21 Feb 2024 10:56:42 +1100 From: Dave Chinner To: Christoph Hellwig Cc: Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , Hui Su , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 10/22] xfs: use shmem_kernel_file_setup in xfile_create Message-ID: References: <20240219062730.3031391-1-hch@lst.de> <20240219062730.3031391-11-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240219062730.3031391-11-hch@lst.de> X-Rspamd-Queue-Id: 6FE5040011 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: zk8n418nhtzj194qnppnyp7cc6so3b5y X-HE-Tag: 1708473406-528334 X-HE-Meta: U2FsdGVkX1/CnAruig4qkjU3nHYcIodyYlTkzINC9h3OBPyBypzBLKRbZzqBVaoyF7AMO6rp911zfnmwh/wrh70oG148Z/6pbi4CApci5RWX6hJSthCX+nCJ5gPbumFgvkH4c2KbZKBAzkJ7YBXBxbVby3UE6tiyDfAKnwEkSeAT8TxA9eFrcDRDzqZcXx1d3qwEWcaAJsDmVCkFedpMQB7/KhKUy3h82JfolATj5kn9c/ArEwxvETqbWvuuYxhgrx4bNIN+e/4qRpjHVZuWH2rt/SorQCh4F7PTAh2jsQ6okWDGPdDZBBQSfeQ3GLBQ2ZGKuC2Z5p98OIFT7f1ggI3WnhlYX5sDg5QxaRnJ1UCi3T96c3aaJLWOeURtGV5ad2Bd+THbdgaQeDR3HpY9o4cO1gmYXsY2Q/qjAcwqi3FXJmXrxDgZpPWRP2zVkcWYBUuqGbd2a4TMEft02LE7DAmvF4dEvxn8CWDkHVEgSJrb0AyNlZwwqdRYTpGph11xNNR/Q2xNF1Jdw5f1+1HlPEB6lWQOzdDzSyX9wWmsvxIbbDWORTN/ZChO5ymLImJQsV0AE6dcs0+cqlWyc9+cYtx/jdKcbf0eWOIpvI51awzOTBfGuEB2gAKMM9KfyB5xVXsj8aefvkcLO1309pPEY04hQ3lvJCdJIR/SghfGFwS8sgwE2/4JOIsaSpPlmZSBEO8Sas1UVVGKwXPPVa2Th05c3+tGU8aw5AUh+LHXYW4hEDUxdTq5KNfIU1+ChZNE294bm8SCM2oHi8Z1dEUebUZMVaNmOnehIbbqAY3hgdUQ2UrmO/cH3qbon2qXJrlPxje8G0lLndNZlFJvyu4t0JiUF0noDjoGiYjUw94aCaQFmPb++X7i4chuguup6h9J4OG+S33EFgW59j5XDzTWO3gZz1QOIf4Jtpi8t6nJBdjijLyS7kUz5q77uUtTc07/TTEapZCJsOPil1qgNz5 9xBh3v13 QjEx7S0IogbzSVWHFJ6bQQa6Yq7XA4zxU4GkwktZNmTyQMvbyaxQAYl5GwBYkojMGzxPmso67R3w2PXAd0nZJdUs82tB2SJSuA6Ng5LKOxYiroU6KCuQDGhTFPBtCokBq4AaobWLWSVMct2l7Qd1hw3dd29LrMRsk87Er X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 19, 2024 at 07:27:18AM +0100, Christoph Hellwig wrote: > shmem_kernel_file_setup is equivalent to shmem_file_setup except that it > already sets the S_PRIVATE flag. Use it instead of open coding the > logic. > > Signed-off-by: Christoph Hellwig > --- > fs/xfs/scrub/xfile.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/xfs/scrub/xfile.c b/fs/xfs/scrub/xfile.c > index e649558351bc5a..99a2b48f5662e6 100644 > --- a/fs/xfs/scrub/xfile.c > +++ b/fs/xfs/scrub/xfile.c > @@ -68,7 +68,7 @@ xfile_create( > if (!xf) > return -ENOMEM; > > - xf->file = shmem_file_setup(description, isize, VM_NORESERVE); > + xf->file = shmem_kernel_file_setup(description, isize, VM_NORESERVE); > if (IS_ERR(xf->file)) { > error = PTR_ERR(xf->file); > goto out_xfile; > @@ -85,7 +85,7 @@ xfile_create( > FMODE_LSEEK; > xf->file->f_flags |= O_RDWR | O_LARGEFILE | O_NOATIME; > inode = file_inode(xf->file); > - inode->i_flags |= S_PRIVATE | S_NOCMTIME | S_NOATIME; > + inode->i_flags |= S_NOCMTIME | S_NOATIME; > inode->i_mode &= ~0177; > inode->i_uid = GLOBAL_ROOT_UID; > inode->i_gid = GLOBAL_ROOT_GID; Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com