From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99495C48BC3 for ; Tue, 20 Feb 2024 23:55:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F381E6B006E; Tue, 20 Feb 2024 18:55:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE8646B0071; Tue, 20 Feb 2024 18:55:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAF2F6B0072; Tue, 20 Feb 2024 18:55:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CBD116B006E for ; Tue, 20 Feb 2024 18:55:50 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A28FCC092D for ; Tue, 20 Feb 2024 23:55:50 +0000 (UTC) X-FDA: 81813842460.27.732E5A4 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf03.hostedemail.com (Postfix) with ESMTP id CAF4820016 for ; Tue, 20 Feb 2024 23:55:47 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=dz768Vm9; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf03.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708473347; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wCeoJ7wd2Ym9WpusOgs2eL3q4fWqznt5WpzS/+ydovM=; b=l0WEnP8GfO1pV5R8Bd7spQfVAC6gYbnZSy2KWl9vDEX7OXJec4KQfOQ/nP64CkGMhDcief seXuryY92FfP4FVpOujuQBdHoUWziwkMKv6G+hTVr4VMJ96r0dLfW377vmQdbJlkEJMyTA v2EAPrEVB+A5hThUq79Azp5pWoiCNZU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=dz768Vm9; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf03.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708473348; a=rsa-sha256; cv=none; b=zgmjuntYTfgAwR43HqvW9D4MQkyYf6PK/K24Um8x+wHmtteumJL4Kbk8+RiNNRcDhajqPX +j35VsLlieovrawc/30IsURETUqqd1jAfgaQJsJi5vQRM1EIGKc7+PXZf1d0Ft14ONkKi7 zyDVgJ4JH8bTE+jdElNb3lgS6jved54= Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1dc1e7c0e29so7293635ad.1 for ; Tue, 20 Feb 2024 15:55:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1708473346; x=1709078146; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wCeoJ7wd2Ym9WpusOgs2eL3q4fWqznt5WpzS/+ydovM=; b=dz768Vm9t8RUZDBgBQTWeSPoooOPBsJPDE+kwOrZq0GE7Wix+wjQP7kd0b5k5y4kUe 31Mnimkwi/t0UIJclNZkqASkos2zOPU8w+ME7ejYUUwcBR493N+E5dgSlbzt/OOujATI idkFJy0zisWSQGfktfOjn7p0A89OSWj1jA7tTWVJ6RqSItr5kA1hxKWCNMv01HlF5gNb 8OnZmQuZTnH0AAStkkjAeny84k7ZV7ANLWxP3qRdkEStfk6P6TB8g9jrI8TJkcrWV19L H1Reuuolzcj92cxch9ZSE0RhQCqMsrY+CNdwsa2VTXNdfSk6k0EcQ7qOdRrbsiiq+a6O q4tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708473346; x=1709078146; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wCeoJ7wd2Ym9WpusOgs2eL3q4fWqznt5WpzS/+ydovM=; b=UvNL09qhEbATYp5i7LaQ+NvJrcWVctAPdN7unoSx5tkSPz99HnHWWbaIQdMuzCgJSR 4NgT2/1uVQK7xsfnBzgGkn9pw1kExa3YGzjezG/+9QBu8KeatX7rUQo8Um3BF0+hzA22 XKsUhnIsLZECkm7ExUk4Eb/Yol+XoZg7uyBxy9qT0eLJzvGzIK3bUebV0ZIXU/bk1+d7 Uxa8IPzq2fFTKrlYJGMtNVUOfCoXCZ+ToWIDlNJrS12AQ2Bj/tiD+vrvbbZ3cOwsfHL5 x3/ddad7R5+D7JdmACaK/bOlyOLRNgagWoJiGcQxw8FIX6RFQsizxBw8tDX06K54c5FG NCIA== X-Forwarded-Encrypted: i=1; AJvYcCVXg4YolG85nKgESRcEgv+Zjp0tkynX6hBFIpkcZglAhQ3l+74387fpgl5AZ1IXtBkjsTqA6h9Zk0G+uEASRmQNCI4= X-Gm-Message-State: AOJu0YzFbFYLTNXCzC0AzhhtD4cq4yBFrY2SivJx9dGNORWxXNIHDJ1m gfggfFDnuDs7k+UHBLYuztl3PZCC9UTXFkz+SPns+NRC3pRZqcIOupqUI9VKZIA= X-Google-Smtp-Source: AGHT+IEzYVQ1RXOWRhg73P6iXAoqf2eMAnWBvhQQZaaY74jbe7V1cTJ22dYomzA8shnl3c12ErUytw== X-Received: by 2002:a17:903:32d1:b0:1db:d2f7:6884 with SMTP id i17-20020a17090332d100b001dbd2f76884mr10136234plr.25.1708473346591; Tue, 20 Feb 2024 15:55:46 -0800 (PST) Received: from dread.disaster.area (pa49-181-247-196.pa.nsw.optusnet.com.au. [49.181.247.196]) by smtp.gmail.com with ESMTPSA id c20-20020a170902c1d400b001dbc3f2e7e8sm6584954plc.98.2024.02.20.15.55.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 15:55:46 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1rcZxf-009HQO-2D; Wed, 21 Feb 2024 10:55:43 +1100 Date: Wed, 21 Feb 2024 10:55:43 +1100 From: Dave Chinner To: Christoph Hellwig Cc: Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , Hui Su , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 08/22] xfs: use VM_NORESERVE in xfile_create Message-ID: References: <20240219062730.3031391-1-hch@lst.de> <20240219062730.3031391-9-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240219062730.3031391-9-hch@lst.de> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: CAF4820016 X-Stat-Signature: w4mqw8pktrhtd6a18fki6s18r9a79yaz X-Rspam-User: X-HE-Tag: 1708473347-303829 X-HE-Meta: U2FsdGVkX19LIAwGpJLDR5/fFFeGF9LIIwEonr15Z7nxItjXcbdDI+y72EHRinSwenAFdjf5AHfePzoOcEkHwLJ8JAKxqvPYrdvkkZfS+R3OqBK/WIKaO5yh+GpXcZeHnIc/aVvmjcXTKkBaS79vsJ16kGBHS9fQ045rqYaH5GPLckFQ4nsO16znYtlzKIyjVeVFeHmU0sPP6aw5s6z+U2OfbPjfcuFpqqjCXYLZCM+QCd5uZPr8DaTzfXKnithT/ZN+rfYNgm3yZDPeJYEvUSBNuT+7phcO0kBA3IykEC/u7EwufV98WbHaOTun6mQEI6yfYmpXMqxozAJOhbffdyYYYpYXQcIjd+CpUIquEYpA2G74b6Lk9NSiQkbTse1rSOflSPg9W4Ew6bI/uqsLllm5VB6P16opuWg1fr1vLWtrTxbfWs2XzwPAgF5FQDvPkCCmvd7OOJNPGQnRHLz5wAbXLBCNYYl5eCbf6SV7N92Wtp721TzORaEn96CX2gTTgsruSy7UUYkaie6tJjKqeYzCBpkwihPU7EMYhslnCZ9DEue/6R5CgMHBNnRonAptul6txcR7366oz75QiAz0l61+iM3XUnY3Ror68bEYkSFGCOZg6W9TWhhjVIyMVlFfVj/K/kupzbez/VeMff8vXe+9U5F3uYBRmLRf8G6PG9pddBa4j38dm3c9ECUTZtoMemNL4dyK2S+VEfLF6EYDfe4scoX8pIC9+o2RfdmBCDni1G850JldbdQYRSxKtgJHm7TCfAi52qgkKcAu/3lfV0E4s3ldBx5Kv/VkKMM1TiXzz6tdi5MnK2B70/jQ54YEdGet9v8JkiMDRBEjwcLN186/aW+Q9acobbEehO53+Z3TLnFACDRa8/5q6cBJD19JqJsqHQauTu9TMafTvjFnbzj9VtCWimyP5Fs+03TN5VLoSVkwq7dS6MOMTYFkTpD4dfAMddkl0FfL3FAvA46 1q9MqShw Yt5uZzMP+KPTAqKIdTVMqA+CjqB4qQjo2d6nYaBeHyQ/GRTmbtJE5PiaiY/Op2SFPeInGmBgbEPp/du5D5B9yMp1u/RzfaQWiLrm6/tc5SdpR9+vwpdbOInHR6wEC2+qCVHvQ0Oa+lnCUAWivp244HZTWHpRWTINUOCW9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 19, 2024 at 07:27:16AM +0100, Christoph Hellwig wrote: > xfile_create creates a (potentially large) sparse file. Pass > VM_NORESERVE to shmem_file_setup to not account for the entire file size > at file creation time. > > Reported-by: Hugh Dickins > Signed-off-by: Christoph Hellwig > --- > fs/xfs/scrub/xfile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/scrub/xfile.c b/fs/xfs/scrub/xfile.c > index 090c3ead43fdf1..1cf4b239bdbbd7 100644 > --- a/fs/xfs/scrub/xfile.c > +++ b/fs/xfs/scrub/xfile.c > @@ -68,7 +68,7 @@ xfile_create( > if (!xf) > return -ENOMEM; > > - xf->file = shmem_file_setup(description, isize, 0); > + xf->file = shmem_file_setup(description, isize, VM_NORESERVE); > if (!xf->file) > goto out_xfile; > if (IS_ERR(xf->file)) { Make sense. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com