From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34F0AC48BC3 for ; Tue, 20 Feb 2024 09:03:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF51B6B0089; Tue, 20 Feb 2024 04:03:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AA67B6B008A; Tue, 20 Feb 2024 04:03:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9465A6B008C; Tue, 20 Feb 2024 04:03:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 83E1D6B0089 for ; Tue, 20 Feb 2024 04:03:53 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4E40E8055D for ; Tue, 20 Feb 2024 09:03:53 +0000 (UTC) X-FDA: 81811594746.05.1C3CD99 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf19.hostedemail.com (Postfix) with ESMTP id 19A1A1A000F for ; Tue, 20 Feb 2024 09:03:50 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=iVVZxCPB; dkim=pass header.d=suse.com header.s=susede1 header.b=iVVZxCPB; spf=pass (imf19.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708419831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HtYF3RuaEm+NzlpgPch3zINQmsdJoPtf6DbiXYTNMqg=; b=lycElixmoOoCtXN13yg+yH4g2ndnFM//NcGi4EllUYMHrFNc31H/ZPEjMXJW6uPJUsvhZ0 m37RrTS0kCOZFsxUHzJ4A0mw/YFB6n8D8EepnKcBNTOAMqkBhaKbPZLPm2RDCI5Hj/3GR6 HoTsnqSi1959wWsZFhPHYhN21ioNnME= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708419831; a=rsa-sha256; cv=none; b=l+oUgeGaWGjCB4ntw9KOnJqIaeMwqeazsDCoJ4iCR3Cmda5TpS7pWRYUL11xqDSy8yC60s csn5jfACLEmAK6JQdOwM6Z4sB8cpor7AvY7qQzcgFs2g+9jvlmgp2XCmsQHUO7CI4MO2Cb XeRGFaiQCQFzL1X3fSGdHuILHCpEP9o= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=iVVZxCPB; dkim=pass header.d=suse.com header.s=susede1 header.b=iVVZxCPB; spf=pass (imf19.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4CAA521F24; Tue, 20 Feb 2024 09:03:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1708419829; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HtYF3RuaEm+NzlpgPch3zINQmsdJoPtf6DbiXYTNMqg=; b=iVVZxCPBaOVzA5M9nwoBJBcpQGc2PYQwp1JIIRZT+lN1W0GPw3oSP5y8MEzxQPiElAS7QB r1RdtkEiniDzN0srpEAeFF75zlV1MCyZaBvIw29RAi/TRg5KTWkMxYcXX2O4DcRMyRiHcm zycIpZm2E1F4q6ePgMSUFnivHLg1ea0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1708419829; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HtYF3RuaEm+NzlpgPch3zINQmsdJoPtf6DbiXYTNMqg=; b=iVVZxCPBaOVzA5M9nwoBJBcpQGc2PYQwp1JIIRZT+lN1W0GPw3oSP5y8MEzxQPiElAS7QB r1RdtkEiniDzN0srpEAeFF75zlV1MCyZaBvIw29RAi/TRg5KTWkMxYcXX2O4DcRMyRiHcm zycIpZm2E1F4q6ePgMSUFnivHLg1ea0= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2D856139D0; Tue, 20 Feb 2024 09:03:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id R92XCPVq1GUvYQAAD6G6ig (envelope-from ); Tue, 20 Feb 2024 09:03:49 +0000 Date: Tue, 20 Feb 2024 10:03:48 +0100 From: Michal Hocko To: "Huang, Ying" Cc: "Aneesh Kumar K.V" , Andrew Morton , Donet Tom , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dave Hansen , Mel Gorman , Ben Widawsky , Feng Tang , Andrea Arcangeli , Peter Zijlstra , Ingo Molnar , Rik van Riel , Johannes Weiner , Matthew Wilcox , Mike Kravetz , Vlastimil Babka , Dan Williams , Hugh Dickins , Kefeng Wang , Suren Baghdasaryan Subject: Re: [PATCH 1/3] mm/mempolicy: Use the already fetched local variable Message-ID: References: <9c3f7b743477560d1c5b12b8c111a584a2cc92ee.1708097962.git.donettom@linux.ibm.com> <20240218133851.22c22b55460e866a099be5ce@linux-foundation.org> <63a0f7c4-3c3f-4097-9a24-d1e3fc7b6030@linux.ibm.com> <20240219172130.82a16c1ebecbf8ba86a8987d@linux-foundation.org> <21f343fa-84a7-4539-91e2-6fc963dbfb62@kernel.org> <87frxnps8w.fsf@yhuang6-desk2.ccr.corp.intel.com> <7097ff95-6077-4744-a770-b90d224c0c9b@kernel.org> <8734tnppls.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8734tnppls.fsf@yhuang6-desk2.ccr.corp.intel.com> X-Stat-Signature: kzzigj7kbwijexja8d738txwm4sdu39u X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 19A1A1A000F X-Rspam-User: X-HE-Tag: 1708419830-883125 X-HE-Meta: U2FsdGVkX1/ZtZ/pbLIuqKnGP3TsDIRjpRgel2WahEVmaDxBaUIoOWZBpymOquTO4GLN6X27EDgR0t9mKAd1pAjqs2V+WM4uju+QXvkbL9tdgBtf18sysoqVarFDC8gISbEXXyxqIqU2OJtIZgvlJ1U7trL3CJ9NlDJ0DyTcH8OQUYEElv0XxuDN3IJArm8TVcO1waZ06EgbJgSxf2M98xw1IjoCxgNyz173C26pHlGg6kP/cWwLYuuDZppvM6XBwnGjP0UB5pu/DT17zvqhAY+hV5GuQ1wBRohGU9Ad7YbCBr6WLGT5eIimaQICP0Jn5sjpgxF2yHxoLfj6zB4guUEtxlRm9ssiRcAOVGDO7NOetYE1P8PCnFqoEn3s78lyEstfwD67l2NkXEDT+B6XiNlcl+g4B8sLPj4Y31dt3sGDe43damrAIa50OdPO9i0LIbQYRpV0CLgdoZefPqbC+MVWxBM/GomCVLI5SmPjBMl4aQOrPRUMKhmH0bhn7uGZ9ESripqU9Xv35r9GnCZY7miGhZo4QVO/AEeOZ5vUgHfoBVNVb1Pl+W87gQse5cgxuxjBaVP6rfQ/4mJt2gtW7D+0x3YvTU17kWc3peJmUL4VwhluZs5UsFJG3EbdRd93G31IlUWEFZx3laOcbN+tMDEVvh4zKEC152lkRO4n/FdW0rgZvEo13QPVjDYbfuSV4lOfdklOLri2FkbY2gDlMeXcRy6HhX1khLKt6cE1MBCVj4j+b+WC8W30ABII1S/TR78ml6vggERdVL1oCgswJzkKHLcTsvN6mLekedzwW/nzrTad6pe5ahUwodZ6PGhWOXbZXb026yjIVnopiU36R8SckfeEFGfYd4FLtb2fBuCFrYuab6lgs5xVBdqEW81ZlPvST0XKQoFkO7DNuQEeG0buPZFzMBCtM9yRYdbKCQmxm23w80RymyFk50gpQoZCghLgkX8DUOnQfMKEmNL e8DX0Bpf shywbajkCRVeck6o4ywv8vGent8/OIClhNeu8nKE+hudw3h2+u/ZmrZs4zwEox6XLnhdTkT6KD52ZvjY1Vm3o+NC/RiB4fCWCiDvYgH31jPGK8ILUbKmopQn8+Fgqtri/o5HbfiZ2tRMusnA4ROjgaIbZ4jNBmFlwg2LWxHWiEKYYkoUageJ+jfrWcXpLXjoOvw6az+605s/xrc4oL0pO093U1g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 20-02-24 15:22:07, Huang, Ying wrote: [...] > This isn't an issue now, because mpol_misplaced() are always called with > PTL held. And, we can still keep thiscpu local variable. yes, this is the case but it would be better if we made that assumption official by lockdep_assert_held -- Michal Hocko SUSE Labs