From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27D80C48BC4 for ; Tue, 20 Feb 2024 08:49:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C4EB6B007D; Tue, 20 Feb 2024 03:49:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8751B6B007E; Tue, 20 Feb 2024 03:49:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73D856B0081; Tue, 20 Feb 2024 03:49:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 64BE16B007D for ; Tue, 20 Feb 2024 03:49:03 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D32661C060E for ; Tue, 20 Feb 2024 08:49:02 +0000 (UTC) X-FDA: 81811557324.22.1D573BC Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf07.hostedemail.com (Postfix) with ESMTP id A34AF40012 for ; Tue, 20 Feb 2024 08:49:00 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=JoYKdNM3; dkim=pass header.d=suse.com header.s=susede1 header.b=JoYKdNM3; spf=pass (imf07.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708418941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NA7J3Y3vhZLjDH51M6OXG8PWjFrYhMMpO51KFvCjoVI=; b=Eb1lB4aozzhW0+yA/SJGMUz8+cryQ+VxXjrus1McREGtiBQKEJzAS8TBmV5HNuYJ+Is6Wg AU2/rthgTBrRGsyd+5vZP7qgWZuz/vVxLcAKsNKzWhQPb7QTcATQ5vwdXteyP/Ftx9uguZ hy3zP/U4YBNGi8a4UHePtlGOtnMyI4I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708418941; a=rsa-sha256; cv=none; b=ikca/mmfxEShTuGx2pRnUc/Yn4vInm+Trhvr+/2J8VFwn4AJSDdA7J4RuxHc8rdPsEHrq/ JBC0RekB/vVLMwLoNCXVLt/ujtGAnCVrehFiHwcxUq+ziVtbdOK4uYD/8cJr0JEnDFJnHt X/2ilVQaSy1TMnPtYL+UPJeHwsGCA1A= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=JoYKdNM3; dkim=pass header.d=suse.com header.s=susede1 header.b=JoYKdNM3; spf=pass (imf07.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BA372221D8; Tue, 20 Feb 2024 08:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1708418938; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NA7J3Y3vhZLjDH51M6OXG8PWjFrYhMMpO51KFvCjoVI=; b=JoYKdNM39nCYsRL0sZvp0+yzB+eKDHNkGApRiibylMOLY+9lgckn/wRgWhJoDOkPEs0Ag8 CrpKTbxfTeT9duaneRdiu33rxOsgseILo2iP8yNQbxMZ8TyVJxu9vROWim49h/aKRyEetO PuUN6cM1ysURTQtKuiz9t7n890GT7Bs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1708418938; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NA7J3Y3vhZLjDH51M6OXG8PWjFrYhMMpO51KFvCjoVI=; b=JoYKdNM39nCYsRL0sZvp0+yzB+eKDHNkGApRiibylMOLY+9lgckn/wRgWhJoDOkPEs0Ag8 CrpKTbxfTeT9duaneRdiu33rxOsgseILo2iP8yNQbxMZ8TyVJxu9vROWim49h/aKRyEetO PuUN6cM1ysURTQtKuiz9t7n890GT7Bs= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 97C7C139D0; Tue, 20 Feb 2024 08:48:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id A7cCInpn1GUeXQAAD6G6ig (envelope-from ); Tue, 20 Feb 2024 08:48:58 +0000 Date: Tue, 20 Feb 2024 09:48:57 +0100 From: Michal Hocko To: "Aneesh Kumar K.V" Cc: Donet Tom , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Huang Ying , Dave Hansen , Mel Gorman , Ben Widawsky , Feng Tang , Andrea Arcangeli , Peter Zijlstra , Ingo Molnar , Rik van Riel , Johannes Weiner , Matthew Wilcox , Mike Kravetz , Vlastimil Babka , Dan Williams , Hugh Dickins , Kefeng Wang , Suren Baghdasaryan Subject: Re: [PATCH 3/3] mm/numa_balancing:Allow migrate on protnone reference with MPOL_PREFERRED_MANY policy Message-ID: References: <9c3f7b743477560d1c5b12b8c111a584a2cc92ee.1708097962.git.donettom@linux.ibm.com> <8d7737208bd24e754dc7a538a3f7f02de84f1f72.1708097962.git.donettom@linux.ibm.com> <25b420aa-3fe6-40a4-8d60-a46ab61ee7b7@linux.ibm.com> <0f0fd8e3-98b2-4001-ba6a-6a8a26a5393f@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0f0fd8e3-98b2-4001-ba6a-6a8a26a5393f@kernel.org> X-Stat-Signature: icfiew4ssm39dzpohmea5tuxoqhgg64i X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A34AF40012 X-Rspam-User: X-HE-Tag: 1708418940-655995 X-HE-Meta: U2FsdGVkX1/TaKtx56qGAqakzeQ3kgDMayGPynQ1siziDq/+YIvKUc0L4AEvsafxKcTE/NOvBeYKBCWMQWBQjtguDDhC/H7SKmjiPcX28R3UOOw74ufPEkvbMBe7BS4yQKJhepUJ7MA28z4Dx1LS9kcTzvkW1w5SZ557tBWTDSToBGqSIJ17Eva9pAadaIlF3MCg2jpn6adO6tCfGj+bgDEe37qfp4uQf7azSYV5FvoRWYghaDzdTSsCQhRch7zlKIpdb19/neOWpGtx4LUxMAJoD+sI+AZjZY0B/f6cCnpIkDuf6En/yx9fXiDa25blvt3VW6FMfm9qVaUeFz3U8EtGFtAxVVChge2hKyT06WoXR07d/7FwGkVTFBmCbMcxasIK9eTYhMKblSNOj0zEyTcwSOnz8Xwa5P9W8bd2XrHFUR72BVeNWkoYmb3wMawJO0D8c+8mH/Im0FqR8GCHlLyxJnmtfid6kqZFcB4XLO4VirKWaRPZY6v1iE5KavQIBxa1as6J/Ydk40plCviARbXoAammMWaZdrB75YdkmyyEeOnYCDweIR0v8RUok0cypwOA37Uo8LdN8VChTuVIIpMKIFOZ6HaOUkFcRlcTud7p+ARNRWmP5Gw5FTziG6KRzuMQVH0KbKWgiuQ532C4esFI3506wxclCCQTsCSXjZv8V7zysHoX1mjanb565g7fszsPT+NhLOEHiKqySRj6nvguDB6lgZTuIseQ84bA7yyOsYryxPbv+/iystayENyWR+ey9DsYZtW4y+CKw+Bk0NaRy4fV8cujPBFPyZ89DshXdaoLZE1mxPd5uvOp07v+UybPsvYuSMo7Fh2E4SZymcLJ2XBL6pGrY5HR2uGObsBiNFAqgisMAwEZoplIOHPk35IVYycDGAcsml/N5+Ih6HcrmFQYuN1v5oF1Ct1qzALf+b1mqnRkUrcFBWUCEvjLgB2mxA+RY6bovVja3T8 b+IVLPeM zjS+8zh+63PMF9dopzHtic5Nhh8y7veiJ/9U5FQ1N6AFk9qhqb6LkIE4EWvFRzm7Ol0IvuEhJmK6KObiOzsm0MuG4pfLM3tJZxH6FN4QIIXO4K+dZ32R1PIEuIstJE0X04aizaCJPSXK3tJ1e4/BLM9kZEj/I2mHXEudFyfbMkwnu3WJoeCXxhxS7dIFjD1NZ6iYr8FUqYgfD4A2RWmXzecZTqa+/TUm9/zwXCMuXLXm+3XaRSGeGrYd3IKAUgNGWFt1V9ibHqWZ7J0s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 20-02-24 09:27:25, Aneesh Kumar K.V wrote: [...] > case MPOL_PREFERRED_MANY: > if (pol->flags & MPOL_F_MORON) { > if (!mpol_preferred_should_numa_migrate(thisnid, curnid, pol)) > goto out; > break; > } > > /* > * use current page if in policy nodemask, > * else select nearest allowed node, if any. > * If no allowed nodes, use current [!misplaced]. > */ > if (node_isset(curnid, pol->nodes)) > goto out; > z = first_zones_zonelist( > node_zonelist(thisnid, GFP_HIGHUSER), > gfp_zone(GFP_HIGHUSER), > &pol->nodes); > polnid = zone_to_nid(z->zone); > break; > .... > .. > } > > /* Migrate the folio towards the node whose CPU is referencing it */ > if (pol->flags & MPOL_F_MORON) { > polnid = thisnid; > > if (!should_numa_migrate_memory(current, folio, curnid, > thiscpu)) > goto out; > } > > if (curnid != polnid) > ret = polnid; > out: > mpol_cond_put(pol); > > return ret; > } Ohh, right this code is confusing as hell. Thanks for the clarification. With this in mind. There should be a comment warning about MPOL_F_MOF always being unset as the userspace cannot really set it up. Thanks! -- Michal Hocko SUSE Labs