From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09688C48BC3 for ; Tue, 20 Feb 2024 09:56:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FBD46B006E; Tue, 20 Feb 2024 04:56:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6ABD86B0072; Tue, 20 Feb 2024 04:56:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59A256B0078; Tue, 20 Feb 2024 04:56:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4B0B46B006E for ; Tue, 20 Feb 2024 04:56:13 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 23799405E2 for ; Tue, 20 Feb 2024 09:56:13 +0000 (UTC) X-FDA: 81811726626.27.F5122DB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 93868180016 for ; Tue, 20 Feb 2024 09:56:11 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708422971; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T+wLnJwnhE6J0r9dnKQyydgfCYyhjDTncQF8zwPvie4=; b=d78g1D5AvF0aRykPA1iUNDNvllZbaVK2kBHOfnuYd3VouwRkEbbr125RVbdyH/WK2L+VmN 0DW4/ceDoBEBn32vR5oeaGVqnpVA06REcygSl1bnLrFwt2VsFh4Zt4pb+lT/jXAiVRoNt4 B1T4igmLJhWEg+5TN67SVxlCzWgC9E0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708422971; a=rsa-sha256; cv=none; b=IptJZ4SFIFFL7d7ssvc4DCG1nleFtndJG1kQ/CEdr2mmGF0Akdc+Bq3NeoMzmx6R65ZHQJ kjJcmAZ8RuLySv+mez7ufrJSb+julg4UE+K4RuhRppSNuvsh3h4Pm61UkU7qTGyIQo60b6 MOQLvz7Bay87V8N7TMPPQcqlJoFOHLk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9E63B61152; Tue, 20 Feb 2024 09:56:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BDD13C433C7; Tue, 20 Feb 2024 09:56:02 +0000 (UTC) Date: Tue, 20 Feb 2024 09:56:00 +0000 From: Catalin Marinas To: ankita@nvidia.com Cc: jgg@nvidia.com, maz@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, reinette.chatre@intel.com, surenb@google.com, stefanha@redhat.com, brauner@kernel.org, will@kernel.org, mark.rutland@arm.com, alex.williamson@redhat.com, kevin.tian@intel.com, yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org, andreyknvl@gmail.com, wangjinchao@xfusion.com, gshan@redhat.com, shahuang@redhat.com, ricarkol@google.com, linux-mm@kvack.org, lpieralisi@kernel.org, rananta@google.com, ryan.roberts@arm.com, david@redhat.com, linus.walleij@linaro.org, bhe@redhat.com, aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, kvmarm@lists.linux.dev, mochs@nvidia.com, zhiw@nvidia.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v8 4/4] vfio: convey kvm that the vfio-pci device is wc safe Message-ID: References: <20240220072926.6466-1-ankita@nvidia.com> <20240220072926.6466-5-ankita@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240220072926.6466-5-ankita@nvidia.com> X-Stat-Signature: n9j4mgkmy6gb4abk4wqsi91mmyrzohzr X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 93868180016 X-Rspam-User: X-HE-Tag: 1708422971-31129 X-HE-Meta: U2FsdGVkX1+wnM6HE1rGGz3VaE6K6I7a8w3nwqv2V6lF3lr4BXSTfYimKhZrpchYUUzBH11Lys3xTsiF9p1291hnRsv+FDfKoyaw9vGrVsSUBIvpYP+e5HvhZbaePoNpwb718+5zRZDSi77K66+wdls8uzBBgfJ7a8vXziv6N/+bDQJwWEvP9c+kApAQ0HhNPGURDAxVtkOdjMIyOpmMZYX+b5nIoBqlVm1mgnSUmX/GnNhdsXeK57W0bxWXvZQEvBUCo+n8IBUmXq0FjLuKDMWbMOEj85zzI1rRLtIGbZsJTAvZhCDdNU4MZO3YpaEXASNApX4sI88qjo30/kM+sLOJ0oOJiM7oevd87ACh6VCodO/l4I53lJruL9rd3Kos4oN2to7QTSRRh7uHXKhhXD2A/JIFeHSujx2Fx3sZmTmYO+EE0LHqIE1M11fUp33EjuG77VmDTL9WgpaVk5AWCoGQqyWlHH9VFevZR4P4J6L4MKxCd7VMxzhBPL83ioVgoNWdOtPEiz/gau6Jo+5u0pztwg78d/E9FZr1Tb/tgeLhelWinU1jkDDfakfy/0i3xm0CftdA41IxbsPVRa9ezSEa70p5dun4DDdMx++BMH03fVaTyYvbIYp3873OhUXwYUqdpAQPUPb8ZDXlE2NjjMaQeBniHjayxPTanx3auhuk6KwZcksjmy17jTIjZacKIxlvypknfwKrHmttFoDlNKmXeANB+1F8cmQPoTiOQXUhe9jDVAX9TxAv3HMdFzj2lpO0KMjmKSIQaASfVUxOnXyUM6/3UwWuvMxO3IKRA4vC2j8Zn+wC/KbSxJd6+5g03jGG3kIhYU21f5/TIu8ZvOCv1v1PTxi811hcCrBQ5O0WXwoL0zcRUKoP8HGFEUFiamGlE5aKIvXYPtWt9vQso9xOSY91/Qoijv/7SUhfhgdKS21qHFmxzMzqo00pAIUU5RwTE9mB8ZNJn2O0PF4 leJB8Ard wxK5V/oofxMZfZSLPqBAzjKNgCT1pqjdyKH9w3B9HyUO2IgY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 20, 2024 at 12:59:26PM +0530, ankita@nvidia.com wrote: > diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c > index 1cbc990d42e0..c93bea18fc4b 100644 > --- a/drivers/vfio/pci/vfio_pci_core.c > +++ b/drivers/vfio/pci/vfio_pci_core.c > @@ -1862,8 +1862,24 @@ int vfio_pci_core_mmap(struct vfio_device *core_vdev, struct vm_area_struct *vma > /* > * See remap_pfn_range(), called from vfio_pci_fault() but we can't > * change vm_flags within the fault handler. Set them now. > + * > + * VM_ALLOW_ANY_UNCACHED: The VMA flag is implemented for ARM64, > + * allowing KVM stage 2 device mapping attributes to use Normal-NC > + * rather than DEVICE_nGnRE, which allows guest mappings > + * supporting combining attributes (WC). ARM does not Nitpick: "supporting write-combining" (if you plan to respin). -- Catalin