From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6154BC48BC3 for ; Mon, 19 Feb 2024 16:51:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB7D76B0075; Mon, 19 Feb 2024 11:51:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D68276B0078; Mon, 19 Feb 2024 11:51:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C58026B0080; Mon, 19 Feb 2024 11:51:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B5D4C6B0075 for ; Mon, 19 Feb 2024 11:51:16 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 427BA140503 for ; Mon, 19 Feb 2024 16:51:16 +0000 (UTC) X-FDA: 81809143752.27.167023A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 10438100021 for ; Mon, 19 Feb 2024 16:51:10 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=u19BYPk5; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708361471; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i0E4eQpTOIwPHD4AY+ANWQYLzpqrYXlwWbKYvpZ1KIQ=; b=w45K6pIqECDfpTCE+ubBJ8yRRPlMj0Y6hKyf3k2mq+Z87RWBPi46ykRFIOupvaobA+FBVn UWefH8COoccg7xVqfl+Ppj5n8xDVm6BEx0/B+qZVs/N7FTDDzRdsrLfKeLSYCU8Br8A9GT wq9ZLgGgNlVHxS95KUddE//9P3NTU9Y= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=u19BYPk5; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708361471; a=rsa-sha256; cv=none; b=m+zeBYSK3yDcp+/10Vk260qM3i6JXulrtglAXX6pi11kUsfimHjHFqNK4CESCuYnoqfOIV sHGE7ii2DvjE1lHkYHBo+Ih/AYVU0SZpZ7+nejibML50QABOrweK9qJMfm4tsLsC/j+v+v jyYzeGGPWHqBtpbYB6f0z+/iQLxVnfk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=i0E4eQpTOIwPHD4AY+ANWQYLzpqrYXlwWbKYvpZ1KIQ=; b=u19BYPk5u9c0pMjXJTYREC1I7o /e42Y6IuzK+u/EZSLfbcVb59UobsbB5xDL/1Vl6Z+w0ESAaGYDzzOXHoIPUmeZDGXW+OJdJAMfkLd A3QwVsJLULB9uHsyacx3pv0ET2dc1hbEq+6PGABRtG/8fXgyJfKFtWpkYBYx6d8m+jUtU2Igxh5Sq zd3EblFPpGBgAojJ2YRZN2KcddLs99hBq2L9U0lfpKPoZ4E2VsVE3MTYXp9ETwppxVqbIpiO4ydqM blid2wBl4QRukgIySrSbOUocpIJ2utO8GhtFMcxfm0kOiMQC1Rw0IBpyDG3er2njLH64pv7LVeSp2 wA5CowFg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rc6rD-0000000DIa6-1rTK; Mon, 19 Feb 2024 16:51:07 +0000 Date: Mon, 19 Feb 2024 16:51:07 +0000 From: Matthew Wilcox To: lipeifeng@oppo.com Cc: akpm@linux-foundation.org, david@redhat.com, osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] Support kshrinkd Message-ID: References: <20240219141703.3851-1-lipeifeng@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240219141703.3851-1-lipeifeng@oppo.com> X-Rspamd-Queue-Id: 10438100021 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ifurqe5cjqzzbddibxjm86wmwzfgneou X-HE-Tag: 1708361470-845043 X-HE-Meta: U2FsdGVkX180k3FNI4l8MVFIFhIJ3S3Gzj6GRE5Enf78ZfOqRYShk0TgCDL2+41ixWPOu0OPjEoL/spFZH9T+uGVNZ6brm0UH/cQQPezfYHf7oNv4/56nWLIcBFyJAbwsp0JwWCeosAU11JRrX48lim7AeygeucJbbdFwNm9XqfsSoLB0VOKDaLfr6CxoLLG9Uwrto9ryyobJRc+mPRwwFLX8Fe2Kve3E0Gwmm4/jJGMveQkFrfTd5/uTKScAlXOV9qx49/WFLZazesGJaf2uIMe8f3Y/k/zlkzd5xHQmgH6uMmJHkhmI2nF2JwHrf/QjBwoVGcVs0LKkN+FYj6hIXdBWiR/xZsB3aik902CI5U+l+tqB3YhkcJXxLbrFnKRLvuq/9itwSPZuvmlkOtcdQneMSG7zXzPkLckIXy9bKVyDv47SbClzvr56jM5Yug9cvlZNdjgKGVojRZaTatQ/NAY4UBU7GEfZljC4U65UuHvLLPD62cvuX58H2UInlBim6r6uquxXaFIQzI3js9LyENPYFRTvM4fzIuEthEWXx69eCj5hEeXr8o/WWVrKUlNsoXMEGPZgoQezIrRC6NQ3RKfzJs2ES1kWQXzXV+zFVMTgk0YM69dSSH5k4x2VtQ7rWPjZQa9eIQYlr+RCrd2RxDLCkhiQsp5qA/rH0CCOeI3bdzFBfl+iKDJSlOlBL/ijI/UmOml+JNq/dmucnVQi10vsMqN4ZQ7sOc3HqgCfw8vcdkYbzoQTnM/1ULGApFLM8ZaHbIkp2npu7cpe+d2o0l1oDkudCSMMlfm7u69oVipuuoH+F+xReKarHGiSpfP9XXg0k4WRC5JUjwv1xxd+g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 19, 2024 at 10:17:01PM +0800, lipeifeng@oppo.com wrote: > 'commit 6d4675e60135 ("mm: don't be stuck to rmap lock on reclaim path")' > The above patch would avoid reclaim path to stuck rmap lock. > But it would cause some folios in LRU not sorted by aging because > the contended-folios in rmap_walk would be putbacked to the head of LRU > during shrink_folio_list even if the folios are very cold. > > The patchset setups new kthread:kshrinkd to reclaim the contended-folio > in rmap_walk when shrink_folio_list, to avoid to break the rules of LRU. Patch 1/2 didn't make it to my inbox or to lore. But you should talk about the real world consequences of this in the cover letter. What do we observe if this problem happens? How much extra performance will we gain by applying this patch?