From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65BCDC48BF8 for ; Mon, 19 Feb 2024 12:02:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA4BE6B0072; Mon, 19 Feb 2024 07:02:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B55476B0075; Mon, 19 Feb 2024 07:02:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F56D8D0001; Mon, 19 Feb 2024 07:02:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8CAB66B0072 for ; Mon, 19 Feb 2024 07:02:15 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 07CEE80315 for ; Mon, 19 Feb 2024 12:02:15 +0000 (UTC) X-FDA: 81808415430.09.297E0AF Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf02.hostedemail.com (Postfix) with ESMTP id DF98E8001C for ; Mon, 19 Feb 2024 12:02:12 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=To78uyru; dkim=pass header.d=suse.com header.s=susede1 header.b=A1NLMhrb; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf02.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708344133; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tQ67GULT9b2cq8o8yDuQQdBKS5DXm9sCybmVYMJMEs8=; b=YiKtDoBzmXLIst3rMA89fa3OV4EqWsqb6xkE15Op7oKC0YTB7JIziwcNflUSXXnD4kPEzd FtAOHWFx6Y/ktb+c1B+dJSF9LsOBtkpXyFibxUkze42iXN5BkTEMfPE1Fg+VNejLmbhtP/ eUQSl1uKaSGsBEAQMUFq5jcY+LUh91Y= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=To78uyru; dkim=pass header.d=suse.com header.s=susede1 header.b=A1NLMhrb; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf02.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708344133; a=rsa-sha256; cv=none; b=MJTfd50+TMNVqNMN/j4fUbIQP232b/Euh1ISHuQK49yZbWLVBaoxxlOf1c7ocN3xAzOKq8 NOJlQuLfMDHqh5cv+RAhg6z8rKNXTilkWESmCYnSaXCOgmenEJj+gOeQsxk5QDZ0d808zf 4WpmFI7m6wESzyoM0aqdxw7hsDXhzWc= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3B7FB222F6; Mon, 19 Feb 2024 12:02:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1708344131; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tQ67GULT9b2cq8o8yDuQQdBKS5DXm9sCybmVYMJMEs8=; b=To78uyrujPNe5UELxtzj2tigRKklvQJMo5Bv7bYjY6EM2HIKrbTpY0wcePEEYrEXoPuHrd IL8uqPD9sqMNi4Yt6UZhhEHBfb86stjJewTsS8cgZO+IGe8bAy4P7UzSVieM3EsM4HwdDo 7OHSpE7LsHeA5ik/pEQaRYy3j3QvpEY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1708344130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tQ67GULT9b2cq8o8yDuQQdBKS5DXm9sCybmVYMJMEs8=; b=A1NLMhrb/o9+kAV69g5AXZVzzWIWvKlqCyj0Cb5nrQN8F1oLnbcBGvRZO0W3lL8ceMuiHH bMd2WSW19aOStA57+gs+lCfrH3Wv4OtMk8ZoI0Fs21SCtvaupNgvsHe5ED+9t6RfjToDeb ls2EMCTxMaQpPgDU958wMOiHLnFeTWU= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0D25E139D0; Mon, 19 Feb 2024 12:02:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XM7hAEJD02UfPAAAD6G6ig (envelope-from ); Mon, 19 Feb 2024 12:02:10 +0000 Date: Mon, 19 Feb 2024 13:02:09 +0100 From: Michal Hocko To: Donet Tom Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Aneesh Kumar , Huang Ying , Dave Hansen , Mel Gorman , Ben Widawsky , Feng Tang , Andrea Arcangeli , Peter Zijlstra , Ingo Molnar , Rik van Riel , Johannes Weiner , Matthew Wilcox , Mike Kravetz , Vlastimil Babka , Dan Williams , Hugh Dickins , Kefeng Wang , Suren Baghdasaryan Subject: Re: [PATCH 2/3] mm/mempolicy: Avoid the fallthrough with MPOLD_BIND in mpol_misplaced. Message-ID: References: <9c3f7b743477560d1c5b12b8c111a584a2cc92ee.1708097962.git.donettom@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: ed9bf56wyecyxh48mmdoaxm4qw4g8dph X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DF98E8001C X-HE-Tag: 1708344132-460357 X-HE-Meta: U2FsdGVkX18K/FT59NmcLpc5TkN4DhQmb1Y4E+ZsM65yxwfHkTdT/SketLitQELJLsZPxiPSltYuJq4LKQQtqTvScgjwwV0IxXabbfUGagMcz0a54VrbNzXLQ12ombmsk/tGOom0hzUE/nGSoZs/HCr6moStcwbzqVIkeV+bEQhv1Qv4deXJdZMYRqqSX2KpOAaRMepab450aQagBsCS6DtjxWOQ8UEWmNlt2erV2Sga+GkivmSaIE8h4vWCEwTOQvTrCCXoDxU2RcEebAo7iIkVmJy8bkA/6G8gB2EFkhOFBKVWOVxEavNhnsE7CMlCnPk/CNtz0fI5l85pSRDXov/NxeDglIxz0P00pYsjl1ZOEpo2M51Q75fhh6m7Q9n6LBZf4xB7iHDa2o7TcOdtp3zUUsnzIBPK9L8scNKGhMoOO66OG3SLUnjIQO2FLrCd/L18ZoAp09+Qir2LDczyp+kMlWG6xTcPyfrDU2BHupEsiY549M5cQA+MqJS3JFFJGF0Lq7r3F/A6kBs1QIJj9bSScCGvOAl0X+IU9hYCAOme9bMncIK4G58NJGvdilYhcayY3e6stynvNruc4COTOS7wCVQl+xBF0ey42oaUV4EGkRgsOzjT0Ym3qSV9JgTOg7Nqp/EfoszZqKCIdskVUwQs4KGsM+yLgIf9Hn/sx/Gt/XIlUPBhL4VY+q53cS0ws+3ty2uoqGqTgkFBCJZT7ApYDx98xglXEezn+xrW1GczERZLG9TSqXn/NJNL6ZSnzrTYQCL1AoOiY8avdDk8IbBpsE4sZ5u+LwjU+hSsWmQo7/UWcocxbxPngy9o7qOjkx4RLc0p89UZBsLL7dW0P3gdBj8i/7KD9Bi2hiZnIBpGE+goLhR4irBnxT/BfGddztS+xmrfKFmYyI0Xs0N4i5niSR7YVzbMo13fRq6ff1ju1pNFD/k+k7hOPb+57f0GueFOyxSiQ6fMH9J0F7O fdmCNhY5 G5uDM8n+IPnXE1TE4IY+4MddCIUtltxWJ1l794/7hIeLqkivMjy8oA6Pe7rcQwh0lEAWxXwRiWtfIMyWC0uTA8pB3zznV4lG4dEYUMk91vGCaTjYUL4F6eap1RJyyoSGRj4mczixvqOQkHIHr3WApQZqMssw5q4VB+zMaYL/kzbLRJLHi1R/BFWtEqpXGOESrZiASsslG7ZqqHXvRD64H8c+MgFad3GAmke7JYJdfuLNV3VNON4J7pe2hzJL1dRhwYzhuoNKdE/qTkZiIrv0Z03R1CzrO+x0MzdU1FR+B4PxM92nlrNcxmlqyrFgg9C/BvXnFbkFQyNCgywRxCyJiycllWxioK5p+yUl1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat 17-02-24 01:31:34, Donet Tom wrote: > We will update MPOL_PREFERRED_MANY in the follow up patch. This change > is required for that. Why is it a separate patch then? Does it make review of the next patch easier? If so make it explicit in the changelog. > > Signed-off-by: Aneesh Kumar K.V (IBM) > Signed-off-by: Donet Tom > --- > mm/mempolicy.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 8478574c000c..73d698e21dae 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -2515,7 +2515,15 @@ int mpol_misplaced(struct folio *folio, struct vm_area_struct *vma, > break; > goto out; > } > - fallthrough; > + > + if (node_isset(curnid, pol->nodes)) > + goto out; > + z = first_zones_zonelist( > + node_zonelist(thisnid, GFP_HIGHUSER), > + gfp_zone(GFP_HIGHUSER), > + &pol->nodes); > + polnid = zone_to_nid(z->zone); > + break; > > case MPOL_PREFERRED_MANY: > /* > -- > 2.39.3 -- Michal Hocko SUSE Labs