From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE2C5C48260 for ; Mon, 19 Feb 2024 08:10:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55F906B0085; Mon, 19 Feb 2024 03:10:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C0EF6B0089; Mon, 19 Feb 2024 03:10:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33ADB6B008A; Mon, 19 Feb 2024 03:10:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1E1E06B0085 for ; Mon, 19 Feb 2024 03:10:00 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 925D080273 for ; Mon, 19 Feb 2024 08:09:59 +0000 (UTC) X-FDA: 81807830118.09.BEFF67B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf01.hostedemail.com (Postfix) with ESMTP id 4DF084000D for ; Mon, 19 Feb 2024 08:09:57 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Sb4MAF9D; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=IlB1cgVw; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Sb4MAF9D; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=IlB1cgVw; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708330197; a=rsa-sha256; cv=none; b=rswoH/ExqZGD4ZRLtjyBOuwbVr0MjzCL7M55dSifiej22g5iBxrjHBBE9aV+GMhh/xQK5+ cu+unO0CypQoirND5ZNzx0ZSizJvE8zA/PDCqrxyNgruRsMr2gpaWYneakJdSOe3YVl9Iw GqUp9Yzw13KSFseA9XqyyDGjQF9eZMU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Sb4MAF9D; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=IlB1cgVw; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Sb4MAF9D; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=IlB1cgVw; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708330197; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+W/bpv2D3c0ZM1YOskN3/VvP+1dFlkBTARg3DDHNZV4=; b=Zep45svLkf3I3dabATkvwT6iq9Dsg5aghK4C9yYO5tRhnhjkOG7uxUNuXuLKzrbF1OXMMW wBnzfvoc5zSddLAOQmXf+QyHTaTSLaWYOWdQeG8LhF99QFzOBkscyjKPgVNyw3Rk/7Ye5Q VPx1155SkzHLyKGoGoDCb1mKfhfVcOY= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 860141F7DD; Mon, 19 Feb 2024 08:09:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708330195; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+W/bpv2D3c0ZM1YOskN3/VvP+1dFlkBTARg3DDHNZV4=; b=Sb4MAF9DroERnRVpTUQKSc6xiAwy9itXQnqmCAmWldYwnhwba3C+m7puLCqejqZeK9V/GQ +d+RqD0PG7AabQv9q52OZ4AYm2i+YsJEwgNMQM5Re5L4LYDp9o106dGDcvOv/kgnvy7o5Q 8QEe9R8B9CpTaNiiHG0WuRdO+I7wON4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708330195; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+W/bpv2D3c0ZM1YOskN3/VvP+1dFlkBTARg3DDHNZV4=; b=IlB1cgVwV2qR4MEjkpQRMz+jGRbWHpkHwHhdjiKwhJG6aoLRcvrsbGqsdn0VRZ56EIGyeP SK5KuG8f2+U1dKDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708330195; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+W/bpv2D3c0ZM1YOskN3/VvP+1dFlkBTARg3DDHNZV4=; b=Sb4MAF9DroERnRVpTUQKSc6xiAwy9itXQnqmCAmWldYwnhwba3C+m7puLCqejqZeK9V/GQ +d+RqD0PG7AabQv9q52OZ4AYm2i+YsJEwgNMQM5Re5L4LYDp9o106dGDcvOv/kgnvy7o5Q 8QEe9R8B9CpTaNiiHG0WuRdO+I7wON4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708330195; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+W/bpv2D3c0ZM1YOskN3/VvP+1dFlkBTARg3DDHNZV4=; b=IlB1cgVwV2qR4MEjkpQRMz+jGRbWHpkHwHhdjiKwhJG6aoLRcvrsbGqsdn0VRZ56EIGyeP SK5KuG8f2+U1dKDg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id F22F213585; Mon, 19 Feb 2024 08:09:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id 3gZiONIM02U6PAAAn2gu4w (envelope-from ); Mon, 19 Feb 2024 08:09:54 +0000 Date: Mon, 19 Feb 2024 09:11:06 +0100 From: Oscar Salvador To: Baolin Wang Cc: Byungchul Park , akpm@linux-foundation.org, ying.huang@intel.com, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, stable@vger.kernel.org Subject: Re: [PATCH] mm/vmscan: Fix a bug calling wakeup_kswapd() with a wrong zone index Message-ID: References: <20240216111502.79759-1-byungchul@sk.com> <517e58d4-7537-4d9f-8893-0130c65c3fdb@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <517e58d4-7537-4d9f-8893-0130c65c3fdb@linux.alibaba.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4DF084000D X-Stat-Signature: pr65mcihq7oynnoa3kzip5nahw7bi5wm X-Rspam-User: X-HE-Tag: 1708330197-807690 X-HE-Meta: U2FsdGVkX1/0K/LwFkQd6zumO38y7SrJ5Soht1pgst2fl6yja6B/rY2WXy9xDxt0f/DUBXR1wZVyKj6jflK3yG/+BOAapQWEQfsQOstER6g7ZuV00fZ9oQ03dHB5pXYqTJipqi6g+L+BkwtyRcHwAQ8Iclb6kKpKqx5nWw3/jogWcE43E3udG+D+t5NeQkQHfotYTqNBm+NyzqBpKQ3YKyM9p0GCfXhrguft/coYR5Jjyxf7LbFnll4VUYwdpdkZRvBiTr5Nq/g11oslUi7+Wppz9uIaq1rKNzWy8whESYsssjkeZRvKwJyi/0gaHstKcC26Az8vMlPNd1YAwXagExYK4v9NSKhmIp4uHPK+fp/w+M7ObIhm8Mpcsg11+bbuTGkHa5y8h5E6bdH+iBOFczgD1fGp9yT//iJmmKcw1Rrch5k2arPU3HmtqXGLDQeXzUr3+Qv1Rqz0PGPBFfqsYUp3DMuxz/IXEYhxmbq0z5qPRK6MTaOh+1wldrgiRvvV4ipS3tgvXb/uoG89ipm+3gcwR6+rwzrTE0PZqsA+2RP6V+CpRPAARDslvTTUNifQNgH9/mZwp0mQ2PD11NFcsZKXnaE0U9TyFJE3u9DbeQsGNDC7fOtVUzrNOqRoKq7xZ1JRHC6htJPDQwCKcuhY2ZfsvK9/9yAX1Dx7PdgVKSTWXZ0SfAE0qI+iTXtp04sPRrX52BdwdYGoVXojRsTDAZcwVIpynzbXkZTDDu1ZfSHlVqW8mNE/uLJtpiF4ljgvaS2cnts1SCmnQ3MLbAHebBSr4AU/Xr7NXk7bbI30Z8KcSDIvcpxb5SdrE6Y2yTH3Toi1/3Ax1N+nQJUNVfReAR1anG82NP0xZ4QB5+PlBZux/6A9Vu72d2wXavC1wT/3t5uxSHLlC/fDNezo/TTdwL1JnauAg8KRnjOgcbwRfKaBRSzTfJFIEgCMCZy/XP4j7L5usR8AnISmk0RTm/F 0vJgBx1e 73eihnpaa35bafu7Oh5dDNjdYxH9CZgXlcLiwfr2elohR3iGj/8/Hi8TBPxxdY51+afxt5rbHrqb6JFaJj0B3UBK4sj6TdPAstEPctbayb+HPTvHShQKwrp5szeS5k/VJaNjBDNVhfuSfaSMwXvHzfzH9I0u5BY87tc3dzElzuDDXWpHFYosejCHbJ4o+fXRU4crcCli83yC9b4s7JfwLNa1hRWH+YoQI8xByy+znV+/66Pp0cjc4snFcPk4sRy6OZPXTA5K+Gj3/nqtLApujdhjUzVJkMElNvmJWA70vw1NLjtb9jlUtrlDVQTgBoeHlh81BTvOt2Ej+ST6tBT03wVvBzQah4Z5SU4R0xvxdWI4ABegQrjFlfnGCOJ+B4HgZShV2TY7xOl82M40= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 19, 2024 at 02:25:11PM +0800, Baolin Wang wrote: > This means that there is no memory on the target node？ if so, we can add a > check at the beginning to avoid calling unnecessary > migrate_misplaced_folio(). > > diff --git a/mm/memory.c b/mm/memory.c > index e95503d7544e..a64a1aac463f 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -5182,7 +5182,7 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf) > else > last_cpupid = folio_last_cpupid(folio); > target_nid = numa_migrate_prep(folio, vma, vmf->address, nid, > &flags); > - if (target_nid == NUMA_NO_NODE) { > + if (target_nid == NUMA_NO_NODE || !node_state(target_nid, N_MEMORY)) > { > folio_put(folio); > goto out_map; > } > > (similar changes for do_huge_pmd_numa_page()) With the check in place from [1], numa_migrate_prep() will also return NUMA_NO_NODE, so no need for this one here. And I did not check, but I assume that do_huge_pmd_numa_page() also ends up calling numa_migrate_prep(). [1] https://lore.kernel.org/lkml/20240219041920.1183-1-byungchul@sk.com/ -- Oscar Salvador SUSE Labs