From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C7D9C48260 for ; Mon, 19 Feb 2024 04:24:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 092556B0078; Sun, 18 Feb 2024 23:24:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 043156B007B; Sun, 18 Feb 2024 23:24:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E73D16B007D; Sun, 18 Feb 2024 23:24:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D94486B0078 for ; Sun, 18 Feb 2024 23:24:50 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 88107A0222 for ; Mon, 19 Feb 2024 04:24:50 +0000 (UTC) X-FDA: 81807262740.08.6BDC349 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by imf19.hostedemail.com (Postfix) with ESMTP id F2E291A0017 for ; Mon, 19 Feb 2024 04:24:47 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708316689; a=rsa-sha256; cv=none; b=kAFnwYtnbqJSZvVSIzxTNLpmf42Iyl819k+NnwnFrd997QGq9TTQYjpGrx/mcTdoblzZiD 44V2CtwiFErqMyxVrF73VNeymldkBJ6ZXMwkfMFP6HEqbgGSYDy2EOY3bSwqZbKRTwCAjf xHQUOrQXpdw6o7i3UhnQYhReBAdkoGE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708316689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yJ/Obh2QB90pXcK3UEStredWGaDxMcSobt72H5F/fxs=; b=Onk1yx6sQvA0g1o8j8Ffw0CTLxH0fofTl/opMnPaCou3uDAJ+0jMqvJ4Ce8cZm9nXAkqbT 1nd7c6eO/FEn35aTFpolWu/D57aXDXhtGv4uMREiSm4omi24T9u/WIGRXtAVu4jf1TNZOJ ZArTN1VB2KY2kgmI5f4E785xBTuHfA8= Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1rbvCn-00F8Hm-6v; Mon, 19 Feb 2024 12:24:38 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Mon, 19 Feb 2024 12:24:51 +0800 Date: Mon, 19 Feb 2024 12:24:51 +0800 From: Herbert Xu To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, davem@davemloft.net, hannes@cmpxchg.org, linux-crypto@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, yosryahmed@google.com, zhouchengming@bytedance.com, chriscli@google.com, chrisl@kernel.org, ddstreet@ieee.org, linux-kernel@vger.kernel.org, sjenning@redhat.com, vitaly.wool@konsulko.com, Barry Song Subject: Re: [PATCH v3 1/3] crypto: introduce acomp_is_sleepable to expose if comp drivers might sleep Message-ID: References: <20240217045102.55339-1-21cnbao@gmail.com> <20240217045102.55339-2-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240217045102.55339-2-21cnbao@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F2E291A0017 X-Stat-Signature: a5a5yf91d1878s9o1r4y5omr9bex5em8 X-HE-Tag: 1708316687-368972 X-HE-Meta: U2FsdGVkX18nFpPlAh6WVco1oHcjvcXlyIVUbwpalK5I/LAEiJjSzCyf1Sfzb+XVdXLGsLzsLWGxBe+SAFBL64EN4hpAOmXqqwmfBuoUu1Mh5fgqAyoDwWXOFle466rurI8Xtjz+W/a7uagLvmVsRw6uSOaSbtb/bXS7gaOXHzSdaDQGrq9Pynk8LFY5QVgFVgoyRgJg+w8C0U9QGA+k/+CnseTjAwfxNC+N0DVL7wc+qQTL//gbghwUGi43hdHi2K5ubU7nFCLRX0F/7sk1n+b9D4kDqtiXvmNPWtAdknw9rTAr6e34zS1ifMOj7rnkTa72Kbzbm3+kGXLK7Tl3efSGSE0Fjo4BQr+kvGG1cqhY88mbVADku7hgzl+WWvy4LQyBKmMHI0mcmY2H5RD/nqwnLUi91grYG1/oFWSUPpXCdf5IKyejxKMNfEWVt/uzqV93vMQBOJKWvwV2h05S92m/Oiwr4MCUxztHSHK5ev6dihsYUBkFLoBnDNzWNC3K2L4k4MpIgilQIUAOVRkshpZJzkXzXbR//ioxMHWB0WZmACNBwzmrLiQjUVoupIlPmZw8L7xwUzyGZhAGCu2c0Sag2s7mtKwyN4OnhCf8qioxKFOgDyLLbGS1hmw2cFKyW1jJSYtnANk3ZKW0RpJc7b4R+4BbJXq333OG87i14WKA0xsCGApW7LmQoAsWlT4tlA/6yUi8EBtGr8ZB8fMUN+fJXw6XZtNY2rA158kyRkF1vIv0rlLBzT9RKcuL2TW14XeRRI9QAnaysbJj0Yn69kUZvPeDv9SbPyXEGNrlL3wj4k3nV9sPtThijve3OisdEbzVo2Z4fIdEDLa3OzeHICuaEemWXGg5fZJ/Px1Lvw3ZOtS8HDYpqgzg+JGqMM4K3TbnliMZ1rSdMdDalvgFZTvpK8DJntZi7Mbq7p1gynwdRbflon11Ie75wMD4H8l3A/3UoZbbk3Dw++2NMd8 1riaGXll N6YMTrdFAC/W4XINKch60yoxb/BVJmqg2Indv0c4mk+Fz4HI3ywfXg5mQuaa3LxUcEaytPk3THtY1OTab+dM3l4NvL+l+OzuiBeg0Kh0QTfjlHJ02eZaYt1ioMI642OhEK+DJLQF610raLR1y0Rczy4b+AGT7dtCq5d2+W8Rbe+gUxKhaMU3Bf4mnxTMzGxjsjl0Nv679DJUM3bX78BPbUV5NYQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 17, 2024 at 05:51:00PM +1300, Barry Song wrote: . > diff --git a/crypto/acompress.c b/crypto/acompress.c > index 1c682810a484..fa15df394a4c 100644 > --- a/crypto/acompress.c > +++ b/crypto/acompress.c > @@ -152,6 +152,14 @@ struct crypto_acomp *crypto_alloc_acomp_node(const char *alg_name, u32 type, > } > EXPORT_SYMBOL_GPL(crypto_alloc_acomp_node); > > +bool acomp_is_sleepable(struct crypto_acomp *acomp) > +{ > + struct crypto_tfm *tfm = crypto_acomp_tfm(acomp); > + > + return tfm->__crt_alg->cra_type == &crypto_acomp_type; > +} > +EXPORT_SYMBOL_GPL(acomp_is_sleepable); Just because something is of acomp_type it doesn't mean that it's async. You should be testing the algorithm flags. So introduce a helper crypto_acomp_get_flags (see the similar helper crypto_skcipher_get_flags) and test it against CRYPTO_ALG_ASYNC. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt