From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 811CBC48BC4 for ; Sun, 18 Feb 2024 23:30:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFCC28D0003; Sun, 18 Feb 2024 18:30:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CACC28D0001; Sun, 18 Feb 2024 18:30:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4DDC8D0003; Sun, 18 Feb 2024 18:30:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9ED828D0001 for ; Sun, 18 Feb 2024 18:30:37 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 31219401D2 for ; Sun, 18 Feb 2024 23:30:37 +0000 (UTC) X-FDA: 81806521314.24.BAF12A9 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by imf28.hostedemail.com (Postfix) with ESMTP id 63A22C000C for ; Sun, 18 Feb 2024 23:30:35 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=vASAIRma; spf=pass (imf28.hostedemail.com: domain of david@fromorbit.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708299035; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4WH8LTQvKwKieb8zhWVOVP+dVrquGfFVkSlC1ATGzZk=; b=FjdOViTKjLuyJL4eJnYaOBNniBO9PvEy2uSD5ZgIQxdl57cgaE0kTUWaByTAge1xLNAY2d Fi28zD+e1pxJrO1btYCw7Rg3RnPvgtgch5l76HSSlbAaHzZKtWTSWqVxgVnCjkffk9Llgv mf0iD3/q0JM+ElltTVm3CWla/LhAKKg= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=vASAIRma; spf=pass (imf28.hostedemail.com: domain of david@fromorbit.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708299035; a=rsa-sha256; cv=none; b=ATJldX9Aberawn3edYAsSAjvSRkWbBAAseeRvb3xfayuDTP9pX1tGhJOGe9f/6/Eb+SzwP 5LofC/2StDiMUm2QkbHTybtCWCI2MpFD4Jais6/wXYgIl6sYJCGscXvwyfAoXHmu8jkKzA 4lQXGUChHOLMwaINwRunkQO0Lu/MB5Y= Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-5e152c757a5so605996a12.2 for ; Sun, 18 Feb 2024 15:30:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1708299034; x=1708903834; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4WH8LTQvKwKieb8zhWVOVP+dVrquGfFVkSlC1ATGzZk=; b=vASAIRmaT2+Vyi9vwi39uc6FRK3ghJFQ/DBmnkjrqa6Xud0sbB6GKqpXUPXE44nvqV 4ZdxYSsd0oYgixlNmTwMHm3JgJx/RUbhmXtsPw6vBjQlRGgL1Q/C2SBFhxj1WOMAl02Z EmwsYZ5VzPp60BzwDqG5SdRgx/p7kP0Uao8KvYojVL6pfvSS3lm6fQQnoVamOhhbDZ6O SUT6hN+mvD38XyGZ2eWsZFS96pKmw+kt4Ud4kA1fpV73WfYEawW+RGvfr+bjmrOa1Sht USxxcCVbesUYBL+7uhS4H8niWnCv5lRWe05J2rmhqwJ7SPelN1w9E+n+seJ1ZqiSENYR HwvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708299034; x=1708903834; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4WH8LTQvKwKieb8zhWVOVP+dVrquGfFVkSlC1ATGzZk=; b=Bhij29DYCCzFY0VQTL0LiZ86sFQA4+76RB9R7Bbz/a9UdKMh0bcNA7YlOqt0Z0MFkc eezzwt7i5w5mqyhjxVuJN9NtHKJIX3A1TnPfdlFEfECcPBeM99SWEPGX1XV6xZXM1iH3 jo5xscgGm5F0C61i9wGKCTnjEzuS66QEn1JhCZKWEoeWe1Rt8lLU1PQK+Ylp81oqp6r4 9KgDZQ+5MjARwwdaCz2klIBB+3cHm8bRf2u860yLqemHY+6dIxCuvv650Wvfj9S957FO 23/oJVWf16G0Y5TwQKZ9pLxYxGBP5G9SNiP65lnOQbNOipxINk3YBHY212v+LN2+9pc6 p5rw== X-Forwarded-Encrypted: i=1; AJvYcCXRdpPu91BxaQ7RoHZ30ueYfuE+AuUNnonTd5fTNLkWhQpzUBHHT1zo7MpUW3twEHqnNMKTlSvqybKkbb332PfG7Dk= X-Gm-Message-State: AOJu0YxhYpxhr0/30wBvcwcH/PxIPoF4Zx3KKHqbu9tQWvxRPv+Av8vN 8feRrQRmDphzXq6hWMNkIQsyWGGZHp60rTtMkqtRytI7L4QPEzFm74t30xKH/nU= X-Google-Smtp-Source: AGHT+IE1cqk+0d4mXMYCmEGKsEpcy/Mfx41JRPf1UIXJLPObtkL4d/xQS6Q3CT+ceON8NCgFjf6sgA== X-Received: by 2002:a05:6a00:4b56:b0:6e4:5e48:178e with SMTP id kr22-20020a056a004b5600b006e45e48178emr1758218pfb.21.1708299034112; Sun, 18 Feb 2024 15:30:34 -0800 (PST) Received: from dread.disaster.area (pa49-181-247-196.pa.nsw.optusnet.com.au. [49.181.247.196]) by smtp.gmail.com with ESMTPSA id p4-20020aa78604000000b006e363ca24dcsm2735011pfn.67.2024.02.18.15.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 15:30:33 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1rbqcA-008NTC-07; Mon, 19 Feb 2024 10:30:30 +1100 Date: Mon, 19 Feb 2024 10:30:30 +1100 From: Dave Chinner To: Zhang Yi Cc: Christoph Hellwig , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz, ritesh.list@gmail.com, djwong@kernel.org, willy@infradead.org, zokeefe@google.com, yi.zhang@huawei.com, chengzhihao1@huawei.com, yukuai3@huawei.com, wangkefeng.wang@huawei.com Subject: Re: [RFC PATCH v3 07/26] iomap: don't increase i_size if it's not a write operation Message-ID: References: <20240127015825.1608160-1-yi.zhang@huaweicloud.com> <20240127015825.1608160-8-yi.zhang@huaweicloud.com> <74ab3c3e-3daf-5374-75e5-bcb25ffdb527@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <74ab3c3e-3daf-5374-75e5-bcb25ffdb527@huaweicloud.com> X-Rspamd-Queue-Id: 63A22C000C X-Rspam-User: X-Stat-Signature: msumkputaj9orot19wg8syojx57mrgcq X-Rspamd-Server: rspam01 X-HE-Tag: 1708299035-943782 X-HE-Meta: U2FsdGVkX1+OmHIZXRlh8YcJHEjXvopRXbUlDDDH+1p6m38tIWzQzctflmKce7VpsFefRs1hcYF+6VJBJpLwnfOEDRwlkNUz7SdhM6iH3ceLeqPf/1hWjoazkfbTK8HwR2sanREIS2xvAdjKF9aSnuGy6+Ui1b8ySPJ+MEA2vKCNMjuhv5sPjSG+gsjn471UmwEHACTwZEXko6CNhjQERqxHaXwVyxJNoBK6pLnnw/8+WndnzTlm4U9o17r1iPJfb6ix9gnLCzzHl/eJsp+40YMGGgZCftJMrkMfwyMOnS8Ff2OLl0InHUwFmsAZtZ1X1sJST26IhkBjiBpwdtL5ipwMHI3u3Mg6SJDH93W9cZDPno3WEjq65WSfVRUh9LD1CskyurvFCPKTk6eksHehKvVekGTmpN6M+Viyt2M0dhwzEtPZhc/Nok2Ij6JZ1rpqq0CElSWnQPX3BuS8m35iaEpjaWz2EpQds5+CIr3Q/fHnBs35+RLCSXY70AE9eq2rv+A8HT7S4KgP8jCfWIUNxuNFQ+BlVIj8wd06afeKHotWa6jml3L2sdF0vccc9GREhFlpcVsVrMVadzaXl8sqPog2b8wd9XtxthOWT0VeXkh292plbbxTAtY12tqinzob5pVtgnUADChbtLerFKbYytL1mWt0eMkOUqy3cK9RwHIPPDvV2ulx9vYelDHUxb+aekipRNoqAlGuHARjIPIupo9bsiTZhHVWYmT1JTYXqLskV3yqF/FshyT2KFZyLmTaG7et8m20NzKEkYydGTpxxMs3SVI1s68a1cvsk4J1iis843NRfMHzC57Mh3eRn2t3qK7EnzY4mR9TbFoo7U6ULtRIxtQ1HXMj759127/9I/a5r0jZ9yeVq2eExCkKDsRZty6abosyvrACRBBOIaRWO8v1PByRBlDWYEGQLVawXRvR37JgI4W5VKMqxdVbLgrQN1DO6UElYh2Vo9iC6r0 PQEQcslQ HGbrF5t5pba0+3sEB4nabPhkyu812FyvgVsN9FP41RrjmcyNTT29qG53tCPa+bh6EoIhUDiUrAw7pbR69QIYnB0vZcrvllXwsXQn0SB0KuEVJ471RbANlKReL11vop4Kd45MFtm60JdXD26mT9SPveswwPppH7/r6nqFu6HcS1MHmrkUXZjPFkzEGS33DhVp+hRwdIKIoEYyxn2G+y0FxypHw5Qr8RVJStPDfmP377l/+EXQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 17, 2024 at 04:55:51PM +0800, Zhang Yi wrote: > On 2024/2/13 13:46, Christoph Hellwig wrote: > > Wouldn't it make more sense to just move the size manipulation to the > > write-only code? An untested version of that is below. With this > > Sorry for the late reply and thanks for your suggestion, The reason why > I introduced this new helper iomap_write_end_simple() is I don't want to > open code __iomap_put_folio() in each caller since corresponding to > iomap_write_begin(), it's the responsibility for iomap_write_end_*() to > put and unlock folio, so I'd like to keep it in iomap_write_end_*(). Just because we currently put the folio in iomap_write_end_*(), it doesn't mean we must always do it that way. > But I don't feel strongly about it, it's also fine by me to just move > the size manipulation to the write-only code if you think it's better. I agree with Christoph that it's better to move the i_size update into iomap_write_iter() than it is to implement a separate write_end function that does not update the i_size. The iter functions already do work directly on the folio that iomap_write_begin() returns, so having them drop the folio when everything is done isn't a huge deal... Cheers, Dave. -- Dave Chinner david@fromorbit.com