From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82CFDC48BC3 for ; Sun, 18 Feb 2024 02:02:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA8686B009F; Sat, 17 Feb 2024 21:02:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B56EB6B00A1; Sat, 17 Feb 2024 21:02:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A93F6B00A2; Sat, 17 Feb 2024 21:02:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7F80E6B009F for ; Sat, 17 Feb 2024 21:02:58 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E32A780397 for ; Sun, 18 Feb 2024 02:02:57 +0000 (UTC) X-FDA: 81803276394.15.9884804 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by imf01.hostedemail.com (Postfix) with ESMTP id AE29D40009 for ; Sun, 18 Feb 2024 02:02:53 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=WLMNv5pX; spf=pass (imf01.hostedemail.com: domain of oliver.sang@intel.com designates 198.175.65.9 as permitted sender) smtp.mailfrom=oliver.sang@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708221775; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UX1Y2TliWNgWg/AnRUCOjeDu8sfQuTqTzQ07IF+lRP4=; b=VxzI0TCDEUEDAwUytdLTP+3xxaXUs9zBvYYr00a5YJpjK7GHkNDBFpG4rSykERj2UgzjoG m1Y1oDICQcx8IBe1ItTV9yL5ad1gfu1UA1Da9GrpvkTlo430Hi6vb62/p/bxFZZCJ1oEri 0tIGu/ANM2a4yNNV7Zy45uesxMZPJOk= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1708221775; a=rsa-sha256; cv=fail; b=TIma7VG39sIXsosY89NfF49pGyWqLuc4dhMYUGUYPOlwDiPm9o8VO8BPb6BnEJrI768yLl UkGMBG9PJpmcoyxZl59RkyEHx6dD4/0orMJrFga8x4orRgkzonmazRx+s0RLjreOBYl4bl mYISDW83pER4Zt23B2zUelqrK2MDpUI= ARC-Authentication-Results: i=2; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=WLMNv5pX; spf=pass (imf01.hostedemail.com: domain of oliver.sang@intel.com designates 198.175.65.9 as permitted sender) smtp.mailfrom=oliver.sang@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708221774; x=1739757774; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=OnCLg1A8pAezY/5Y3gHV00oQ4X2SMk2p3foxOoLUybk=; b=WLMNv5pXhLHDLwcV3OmxR9n3/V+X7pIOBELOlCSkRmzClpQnMqf+RlpZ QOolznNrRfxewP2A3enSBo06yG748Kba4ZwZ/NkXrrqEuPokaXb6tLGhk lbb4dqZU6PnOkIjw8i0ET4d4drxq2SYP3pS8TDgSVYNN56T1TvJQDr13j RqAMCK9BjJ3Nhpj88kJugnZk05/ViMDNWMh4ULCF0tcUHq/5hdryyDc9y wELjTW0TOuq57V+4xtQkr/zX8I0eDFXeKD7uebglIGq5GNGHant6H3sTy uFEYSdsIAmpsB1pUU2vuacFZH4qr9Rp1YjFdk6+daT+p6idfQT6VxaSmL w==; X-IronPort-AV: E=McAfee;i="6600,9927,10987"; a="24788288" X-IronPort-AV: E=Sophos;i="6.06,167,1705392000"; d="scan'208";a="24788288" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2024 18:02:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,167,1705392000"; d="scan'208";a="8846765" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Feb 2024 18:02:52 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sat, 17 Feb 2024 18:02:51 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sat, 17 Feb 2024 18:02:50 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sat, 17 Feb 2024 18:02:50 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sat, 17 Feb 2024 18:02:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IsuTcrg3wCNKcfqAbgguQi0qXo0qMAhtVP1Y5JME7uyPwIl9GlF4mgLQvsHItRXMuxIpCGM5Rb8qaWyXscKJUXu6cEPQxeUvQ2f95ohYRdNr0UVQGl+0qaVgbMTtnUvVN6l4apSqP5GkhmyokwCQSDFgpQ4ESnpN5vz7zsxrdOm8Duh4zYmgZpBjKXnCmcqCrygHfJWdGyQVio/wpEfudVluGkj8s/z0NQwph0q9ZXoo0R+s4EGoTIJPAQIUEvcPJhByIQYfd0RwHxs4wqZ6fvzGFJO0mrprazPiH1NHb+bQaRNQDv+5uR7r+jkiyl/byj7Z4DSb4KzteVdQW8GJug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UX1Y2TliWNgWg/AnRUCOjeDu8sfQuTqTzQ07IF+lRP4=; b=CYJKLB9WAQj5d2QsyLLwNpjBiIH6ZPJ2o+rWEkQwOFaM3oxaVCNntb/0oEJP8e9Ha+D/hR8UBCGrNxTuwYai08UWOXep2AHmszEyHfDj6bm+hDnNghS+wYZXoZ73S09083YjQvb9ob4zQQMl8NA0pquUPqMTner2chm+C8Ilzr6WUkotyCPofdqD7rmxrFtW0/2R2L4KsAJsiBMaHbl2ISW0bVrVzwTUYpRAhGwZ2VQyWkzGCGiqNt/tNYAL5YVGd5iiCELL21ppvJAI9EENorSVXFa+Abj2NVjXvP94K2eJiYLIlOBCUOViqPDuJ/UyTfI1Fu3o4SI9sKq+GO4Paw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from LV3PR11MB8603.namprd11.prod.outlook.com (2603:10b6:408:1b6::9) by SJ0PR11MB5868.namprd11.prod.outlook.com (2603:10b6:a03:42b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.32; Sun, 18 Feb 2024 02:02:47 +0000 Received: from LV3PR11MB8603.namprd11.prod.outlook.com ([fe80::a026:574d:dab0:dc8e]) by LV3PR11MB8603.namprd11.prod.outlook.com ([fe80::a026:574d:dab0:dc8e%3]) with mapi id 15.20.7292.029; Sun, 18 Feb 2024 02:02:47 +0000 Date: Sun, 18 Feb 2024 10:02:37 +0800 From: Oliver Sang To: Chuck Lever CC: Jan Kara , Chuck Lever , , , , , , , , , , , , Subject: Re: [PATCH RFC 6/7] libfs: Convert simple directory offsets to use a Maple Tree Message-ID: References: <170785993027.11135.8830043889278631735.stgit@91.116.238.104.host.secureserver.net> <170786028128.11135.4581426129369576567.stgit@91.116.238.104.host.secureserver.net> <20240215130601.vmafdab57mqbaxrf@quack3> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SI2P153CA0001.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::7) To LV3PR11MB8603.namprd11.prod.outlook.com (2603:10b6:408:1b6::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR11MB8603:EE_|SJ0PR11MB5868:EE_ X-MS-Office365-Filtering-Correlation-Id: d7c6e8db-c5f2-4de1-84a6-08dc3025b401 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kxf97+XNl+tb3LCofsTIamF/OjRZnI/CMrwt8G9S+PcnhJkaJY7n3BFHzNUT++0+9C+u/LmLY0LeigXSVFEvMr+3Ugyv6q0N+ZMnuWsUhS/qGir/MsVDmq1IfSNTbteNbUtCntwJzvHmhd9QQ44l9/BnSzEr3iZZgspuEwZtvhm/cUtPsBkFo1MRHxp42tJkuP3TglSBQuqS+kGg1cSSmXqzL7AvfaUxwBjrXXABfBW4IkWf2nDZr5I3MKMqNZjPn7Enx56jXXJSfqgpdSyvTJN0zuZDvkdR7m+dR/TLEBJ19PnqMiQBi+rs/UG+SllVXLjpOq3A2daRPB/N4PBkrdbgw+dkdsd18vQ/DtgAZH+Ch3YP3piRtLED+we089awa8txJ9RO8Z13O8XmoGkS0rNEwWj4D9XLzUeiJjmS5LttVfZyyD+wx0QFE+2qUWULm8C8jMrpD252Cc/A12yc2bvDaiA8DUKrup5ky0SI+THtvP/TiqTbqo4+ATf1szBJ4kY9SxLgA1ZPtfCnlSElnf4Zc/PilNPi24FA0MSWrF5eZj9YMdgEIJqG8Oq5/ubjSKgFnsO/fJFjv/PUgpQo0Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV3PR11MB8603.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7916004)(376002)(366004)(39860400002)(396003)(136003)(346002)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(26005)(107886003)(41300700001)(83380400001)(8936002)(66476007)(66946007)(4326008)(6916009)(66556008)(316002)(8676002)(9686003)(478600001)(54906003)(966005)(6486002)(6506007)(6512007)(6666004)(82960400001)(86362001)(38100700002)(5660300002)(33716001)(2906002)(44832011)(7416002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uncXpx3V+8XWrw2agoqEp8ULKq8A47SzIFKkir6JeonS2Gu0b1i4gbB1sVaS?= =?us-ascii?Q?1sJ69khxInbqIQdzW61JsNw1Z8csbahb5xYV+NO345Cmp7Ur8Qw2XzI956jf?= =?us-ascii?Q?Y01lTfWxxsWaEEzVWhaVsbV1FPRn7bN/XQ1Q6HSdWkcWg+ChjzCmEP4u0Obq?= =?us-ascii?Q?wK+PeLF9wvPYOyRPH8k3PXlL7FWgTrP8XJOEsl94E2RxCPAg92pmFaF1+trx?= =?us-ascii?Q?veWKM1AcBXJKM3XuLXdsyS5uVCd36BYEwxBE61996qm+FB8mBwRpH1mMtePB?= =?us-ascii?Q?V1rDRDLxRF23uRklcIrERoAVc71eOU06PIz6PoenkZDonXO7gLNQ3LW7iLO1?= =?us-ascii?Q?JrRvIEvOMauHY2o9EFyzfwdbLh1NzjO2iWCZuZuOATz17EqhO8KzAzMedRKV?= =?us-ascii?Q?maCTYywS5OwPT99I0Z0YPLXaMUZSVSIdcB6O0eX2OMLFmaraSoaocX+DKNcA?= =?us-ascii?Q?MFd4xfjJ1/1Cxoph0WqrS/4bS/DjwmpUIrS35vcboVMzpN/YYQdffBDULsj/?= =?us-ascii?Q?bkMahSjd6EkmVCqD1WyzW04RhghlEwAsUMWrdbnV0PPe0qHHFjlpvu6UPl0d?= =?us-ascii?Q?Y2IJS5PgQ9nUayC5BA6vspw6+CLosUcDyoZelTomFe4ZvyiCC7xEGvCaZQ1J?= =?us-ascii?Q?+vyg63N0fZcL2deALIOOlbd7X+vua9Vf0wLMVB3RMBKRhoZeHSJey7OW08cO?= =?us-ascii?Q?yTIDAU+MuU7C8LKBz0FOlls44eZP1aKsKOsWsF5ANYVm3zAD2nWEpO5c/W/L?= =?us-ascii?Q?q+V2ux7igYoljeKf85xNRJuxa56uCs3AeLnrYWWgIBXpnnfxXrCLxSAIfVp9?= =?us-ascii?Q?sFuXlZhYAMLfEEHtB/GZdpycNWfDKK7g4+G9ERNttqe5QgCm8pydBhqhyRki?= =?us-ascii?Q?pNbQUgmJhIP3chKiZmwXpeqdVpnh+uWiSTfd0BjMv/t13t05yEjKE9Oov5kc?= =?us-ascii?Q?beRW3E/RVpopzW7ZiWEjBm4DLfBi1tFWcPK7k+sJE/W8C3vN/u4BdsBcnN0Q?= =?us-ascii?Q?zGSDZvuSQmlbOBA+fEEBBO28hY5xIYnJSC5dPfhZq7ZTB+Fcq0yIJTl230t4?= =?us-ascii?Q?oT7ksjyRrLcxyPO/bdis0xiSBaxPBVIqSst0DkGkDZ72abhAPiNoNAGGv54j?= =?us-ascii?Q?5zxBRcGJdwH23mK2D0PVIq1fXUJn6QEHn4BkcQXmeavLLxeP79wTIK5QU551?= =?us-ascii?Q?OX//AzMdv9kO5OEx4jUHtTggUm/mb1keRVS+9ur/xOfpIuJ21gJxlhvpvStz?= =?us-ascii?Q?H+DHNa5UHKTN7l3S8mi2lFGukurnpP0qcQOuw7Fbp/vTi3EAxx1j7afh3oex?= =?us-ascii?Q?XS8p97veJPDN9uwWf+LGtQHn67FdrnpEUJ4jdWY/T50GM4BuWPNyEQfariUW?= =?us-ascii?Q?zZDnic4EpZbSn2+zozbe8/FjxNwGKBHlvGrQSQ3IWPKpSvErYHP7mBxItHrK?= =?us-ascii?Q?FRSiT0LqqfuBIq1mE8HOglq3HucmWEC4KGm8ksJ81WpwNeBQzVgzq01zd2Sz?= =?us-ascii?Q?n+duzoRMmnSmas6e2a0/cf4DGz65Kr8jY1RYSYqJosmLgk324f+2r4nx1pO3?= =?us-ascii?Q?Z2aWBuKbYkTayUrWR15CQarAFWUzCvZCIwdLhjICY1EdrrkAhSTbkpbVSTmP?= =?us-ascii?Q?BA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d7c6e8db-c5f2-4de1-84a6-08dc3025b401 X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8603.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2024 02:02:47.2598 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vTVMbvyCQ0gHkXMtnVK05PZB8edGvWsedjGrIX+fG4Vs0Pa8LisRSNC4URNZisuZ8/u5dteM4XZ8f/VX7GfO7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5868 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: AE29D40009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: emekkxsin6a9n544efh6xxa5wnooratr X-HE-Tag: 1708221773-636897 X-HE-Meta: U2FsdGVkX19WTLpRDh8qrTa0mjDm70EXSkRqE+GCNzGrQMOYN+lsFryLHWLzIZ/M/rlFBorKWrvs5Y1XxfV5EH0f6szLUKYhZNlaG4+5So1/6ojw+n7NildI6TsU+l/WQr9Rh3dvEtk97YozMKuLwEI9SPKcluH4Ni1o72X/8GwDaLehKfQ6J4R80KNC88aOO1ep1Wt1n5aIB8js10A4PXVvAsVsb3e4fu1htd7Xfycx/6h6j1U+igMzxy/zOv/I3He6ViQuPOn2Ux4xMaaurj7X3EYxzWOXpnZtFzq7e+tXsYViAdqXD5zF29sHUgD2Gyp5qhR+Dq56h4V+JUfch+CxyC6yxiW5cktLlbf5JG392lvTDMweIuq7dw05QQAr+Lg+nEfvOe9ce1gTXoFTWxC2w0dSymLHsYCLW9Eo8gNLwNzjs1EeSca8mY9mCZsww4d/z7TUKX1v4w0OCkF9yvPyXEfd6lsPeceMOsOCT49+b50aSNiCd1Cl9xvURr4+vp1O/lCh5Ab+LxA8LN/2x6Y7LJGrsIhKT5nfZZW/VtC4ceRwjF9p0vxhKNX/WMoQ6Nr6qxvlPJ2z8h7ikB/5PuX5LaCdWEbP/qDpSqkp++BypGuIV8WXLw/3rh3x93CnraiG+imRIUCfTEeaGIjZov3sCAh0zc71HzX4951fa4pnzG8CtMnliz5vGFnTc1pfclHf8mUC4GWWk7pbaLICzCFHnYxDIhrVyIzLnKSByxBjUkaFDYniSJqVhrR+DRUoNyQPRQi4Bqhw32tKIC5PxmNNCzMA0UKwvv7LIsV/YL+G/XIUsku6qtV2mb7Zxd55n0PwyTucmk0lb5K721f55uNM/VI6IfViKtu68PM+RjrMUNNc+omxoz4+DLINMK/vSDfMq8Se7XXJwossOSOpb/8drZVpYsJl18/KohvU/T1L+f63dlwPGfrbyRciSA5VCJtXMas3/Z98MVcTKHW jow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: hi, Chuck Lever, On Thu, Feb 15, 2024 at 08:45:33AM -0500, Chuck Lever wrote: > On Thu, Feb 15, 2024 at 02:06:01PM +0100, Jan Kara wrote: > > On Tue 13-02-24 16:38:01, Chuck Lever wrote: > > > From: Chuck Lever > > > > > > Test robot reports: > > > > kernel test robot noticed a -19.0% regression of aim9.disk_src.ops_per_sec on: > > > > > > > > commit: a2e459555c5f9da3e619b7e47a63f98574dc75f1 ("shmem: stable directory offsets") > > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > > > > > Feng Tang further clarifies that: > > > > ... the new simple_offset_add() > > > > called by shmem_mknod() brings extra cost related with slab, > > > > specifically the 'radix_tree_node', which cause the regression. > > > > > > Willy's analysis is that, over time, the test workload causes > > > xa_alloc_cyclic() to fragment the underlying SLAB cache. > > > > > > This patch replaces the offset_ctx's xarray with a Maple Tree in the > > > hope that Maple Tree's dense node mode will handle this scenario > > > more scalably. > > > > > > In addition, we can widen the directory offset to an unsigned long > > > everywhere. > > > > > > Suggested-by: Matthew Wilcox > > > Reported-by: kernel test robot > > > Closes: https://lore.kernel.org/oe-lkp/202309081306.3ecb3734-oliver.sang@intel.com > > > Signed-off-by: Chuck Lever > > > > OK, but this will need the performance numbers. > > Yes, I totally concur. The point of this posting was to get some > early review and start the ball rolling. > > Actually we expect roughly the same performance numbers now. "Dense > node" support in Maple Tree is supposed to be the real win, but > I'm not sure it's ready yet. > > > > Otherwise we have no idea > > whether this is worth it or not. Maybe you can ask Oliver Sang? Usually > > 0-day guys are quite helpful. > > Oliver and Feng were copied on this series. we are in holidays last week, now we are back. I noticed there is v2 for this patch set https://lore.kernel.org/all/170820145616.6328.12620992971699079156.stgit@91.116.238.104.host.secureserver.net/ and you also put it in a branch: https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git "simple-offset-maple" branch. we will test aim9 performance based on this branch. Thanks > > > > > @@ -330,9 +329,9 @@ int simple_offset_empty(struct dentry *dentry) > > > if (!inode || !S_ISDIR(inode->i_mode)) > > > return ret; > > > > > > - index = 2; > > > + index = DIR_OFFSET_MIN; > > > > This bit should go into the simple_offset_empty() patch... > > > > > @@ -434,15 +433,15 @@ static loff_t offset_dir_llseek(struct file *file, loff_t offset, int whence) > > > > > > /* In this case, ->private_data is protected by f_pos_lock */ > > > file->private_data = NULL; > > > - return vfs_setpos(file, offset, U32_MAX); > > > + return vfs_setpos(file, offset, MAX_LFS_FILESIZE); > > ^^^ > > Why this? It is ULONG_MAX << PAGE_SHIFT on 32-bit so that doesn't seem > > quite right? Why not use ULONG_MAX here directly? > > I initially changed U32_MAX to ULONG_MAX, but for some reason, the > length checking in vfs_setpos() fails. There is probably a sign > extension thing happening here that I don't understand. > > > > Otherwise the patch looks good to me. > > As always, thank you for your review. > > > -- > Chuck Lever