From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C33CC48BC3 for ; Sat, 17 Feb 2024 08:57:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1E556B0096; Sat, 17 Feb 2024 03:57:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CEBA6B0098; Sat, 17 Feb 2024 03:57:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 895FC6B009F; Sat, 17 Feb 2024 03:57:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7655D6B0096 for ; Sat, 17 Feb 2024 03:57:53 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 17566A00EC for ; Sat, 17 Feb 2024 08:57:53 +0000 (UTC) X-FDA: 81800693226.25.E5F3989 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) by imf06.hostedemail.com (Postfix) with ESMTP id 4C01D180005 for ; Sat, 17 Feb 2024 08:57:51 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Xud0HmIp; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of 3DnXQZQoKCG8lbfelNUZRQTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--yosryahmed.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3DnXQZQoKCG8lbfelNUZRQTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--yosryahmed.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708160271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s8cN5Ao/Va6tTEguzjCrGVvZrh4wckSSwaDJTd7QE8E=; b=LdJpifQXcoXInApmyr124STZoOf9FexPtoLd184jzo8ocKKMKaJBzmf+4d+MGvuiOUrVUY EfAZxSZ9JtuA2HIo6IXi0+YkocD1XhPtNcFZG/c3iUOkK+3atEG5N2TbC4/EZTW+2gBbxs xt9fEDMp2iSvRPqAPqOqEnubW8HYIIk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Xud0HmIp; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of 3DnXQZQoKCG8lbfelNUZRQTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--yosryahmed.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3DnXQZQoKCG8lbfelNUZRQTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--yosryahmed.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708160271; a=rsa-sha256; cv=none; b=4xXNtj41iDtROtd5PBNIjbPmTxUXSHvgOrZSXsKTzwbvP+RkGzvDS1P4BK37l6f0vhLWnB rKesHx4ZVrkA2YN5YXcxyCxaqLiiUVdBM6iF6iMxIsrb8NMrLI1pcOCTyuShRNEBYPYaPi cGU/6LtLouqasFOX+pCh3Fe0YTMEm6Y= Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-1dbc9504a1cso4106775ad.3 for ; Sat, 17 Feb 2024 00:57:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708160270; x=1708765070; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=s8cN5Ao/Va6tTEguzjCrGVvZrh4wckSSwaDJTd7QE8E=; b=Xud0HmIp1dm3Qni8UZOunbwI1V3VjirkCCJ0l8dsIjcmOGRJPJtc7ECJcEGgA7FAED pyfhbnro26KAAiyDOs3GRMLXt3NEaKnXiwU2/+4xNP52kkAf8EtHo9XGx0kK/YeZjVpm Q/JzIOTXJllAjIIHdh3jB/YbczWMmmQYDzwksAiFz2gNLynLERo+SRMjoXoipEH4ghoT dl5jIWism26Ru5wabW9XV40Bff+siXaytudQSd6zX+23WaK3CayKP7dMYiA9KBzNMAwG 42wIby3CKCE6Lx9zHWot2LpStqtgU0QOpL176wR/7jZwH+hKTABj3E9WpaH6Ot89wZne 8jXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708160270; x=1708765070; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s8cN5Ao/Va6tTEguzjCrGVvZrh4wckSSwaDJTd7QE8E=; b=rVKqlZMyWXevzRG9SsXN5sa9Mm2R36nN00iDHVXw9l+OBdlZM2ntU+fcfAnV1BqSYi 9nupYAq+Fnpnd0Mj7CoCygofQplD3UjsADqpD/s0da6FRNXOumf5zWe4kyCwsBaBnq/n 4PyCAVG22quER5bSDsmIVcicG3FimkeJsDri499yVxOc9Iv8uB7z6iyWqymGPO4E+hwx pt4P9GGSw5uvxsY0o3vpYqArUZo77wkgkwxb+aHmXell7SHYdBwqzhKqlb7Ii+FX79Tq 9z4qFfDfou5xhGnu0GUMZyeMzlE9aBvvJnjCR5bFBVjCX3kGmP+xJbqexuXuXqw4xtU9 vQ4Q== X-Forwarded-Encrypted: i=1; AJvYcCWlCu4YiE2PF4Nr9GaHs6bIm4iDnX6l/DB8cvEKQPHQYygG5nGwcJTqK1Ev6PV0GNNKUD75TV1EtcaFk1Uw/OapjKw= X-Gm-Message-State: AOJu0YwdW2fBXrZcIRxViriEh23RuWdyR4nAdiiCnLsHaocxzpsu/CNO NNhTlhV+iKjvjFBJmcbecr2fUXwiYNjvoDk044FTk3BrFcc6v7ul6APytTcrdTSfEOyIOB5Nef5 AGbgJ6zxTfmVsGBoazQ== X-Google-Smtp-Source: AGHT+IEAAsrCHHSYH+FWB1DTFFZRQ147uLGFkQxg/t6LkTT5Z8beOk+u1/7w1Y1yUyt3zCryhzsAjrxBtgciXbJZ X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a17:902:ec90:b0:1db:c1f7:3590 with SMTP id x16-20020a170902ec9000b001dbc1f73590mr161997plg.8.1708160270011; Sat, 17 Feb 2024 00:57:50 -0800 (PST) Date: Sat, 17 Feb 2024 08:57:47 +0000 In-Reply-To: <20240217053642.79558-1-21cnbao@gmail.com> Mime-Version: 1.0 References: <20240217053642.79558-1-21cnbao@gmail.com> Message-ID: Subject: Re: [PATCH v2] mm: zswap: increase reject_compress_poor but not reject_compress_fail if compression returns ENOSPC From: Yosry Ahmed To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, nphamcs@gmail.com, zhouchengming@bytedance.com, senozhatsky@chromium.org, linux-kernel@vger.kernel.org, Barry Song Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Stat-Signature: 7j3uwxqjfcto7aawqfaaenm6n7uhextb X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4C01D180005 X-HE-Tag: 1708160271-30050 X-HE-Meta: U2FsdGVkX19EEeehhLAyH/sXi+dGacyPrmB8njFK1P/SxisPY7ZRfSmKgVx8SkB2wJ7gi9hDSbGViRvBaF7ZgRuJXzFOqRJalfTU0BU+xwKIcHteSy589jQzcRJ/opaz2mzk6gqjxs0ZHN2iKy6HGLQwklA9x9ogiDHZZDGViqlSXtQriD5OyuGfZZrAq32LfBs7dDfQlNTlhewRscYwpiSm/+6zcDNRIFROFp8tXE5Us4FRfPaN7mHRL0Q9I45nM3yJjHKhiB13UW4s3PoycWppyPcq514wtNrKKWYeWyzlQsUkzBrTLzuYhrdjOt5jyaY7w29d1DA+duNkXKyjaFBP7Qtiw5LqGq587EVjz2L/3jXbmP4jafdY0+dPF32JLgDT7WCusxT1kUhsGauU3vd9HNJRB3BAEhbyXTaQ0x6cGo0b8lMjo/VXe9FMHNW2Jwz1qw9I6z05I8IVce3C4oYX/p9vrLAgy6jjfcxsZHK0jjKzrH3Ja0KTzsIGkidpEr7sxA0/Zn+Zv+inY0vjWo7Agg+qv0jzRqLkS9vclmwTayMb2ASoplWJ146CT/PsTkMw3yNWLXWsxyrab9RqSUSwA5CR3rRmDEZQdxDibw0aBjvG/tsjUa57Wu9eVEnSY7KzAOn3p8ozCNaUpQqJhlPc82sBly0nU0M59EdaQ+OZBZLPHeboq1TPPuuMYU3bC4cKxCS0K5wy0jYTn3oTYDFhccF1uP2FCumMJ97y5/2+M/kLWtiBVBwr/amSPEeK6216tm0bPfEmC7VUFA8Ff4XBzHHdD9Z1LgnayD5vx4yRl1ccUJUrQVPfTGbVwJv9Whr9pMPGoTU4/QtYR/2nwMD9+HnitCCi4HH0P7clZTTDFiDnUtK3GFKRo3JVed+AYr9XwhojWLTDeP+R2CsLAyfD3XxFVozR1WUmB/WrLb1gRI3HqilVtzF3DnFHYUuT4zEmOzbir6BH5QW7vw6 mEkT1Y7f Bwm70B5TUKrti0Z8MojNLw8PLNONO6yU/xFV7LVpBc38QmL5R4O3cPuFqOETfhUvp5cNUSG2wKf8BTML9FZCYvIjGZRnJaANLDu423puQW/MlkXw8aOY/cPMUC5E8aicmYQK5Pak1kh0RMs49njNiZ0B8SZfwBfrHyXe8RMYDcBF0vosPaSTH+XfZ056GRoXB7x5HIIC+m+DhWC7YAA0VqDJ3jjL+ZNmQp+ENn7fSbQL1Tq0aVlNcl+KzKBUgF8Ab7RVEWYsfQUfZERXM/mgxoiZ1+AHiF8dKJv8ZYsnurRanyRQmvhoqI7DQifhKjyFdFDWiQjGRiFBiIBNuWRzzjmbxHHb5WdmiA7jP2N55Q4iVB8PQVWldmO7cevNuLoz5nYftyIfYrkFm8Ey+zK7JqWU33GgkJ8XDXpBTeSW5OQskslyG0608AeRciXuY/KMNRECzr6KbU+rLxKm81GnAjRwZZpneErGI5ur9osaoUtKv5DkDMksjmcnZJe68zVPPGbWrzpBXBWuLWmeZhuky5JZUDNtHvV5lO863fhRahgMDHYPeDCxpVuzecpYYohnd3bBDUwu8NMt1ScltZjTHie0wsBAdG+eKeSNgY+6CG90M5UFVoDQwpibSdyySmYAZjImWf+G5ZoGslyGmFj0PEXPtUAXH8XbmGeEHcBhH68mO4zETeXSR0/18jBFM7NX/VokJ83BdhTA/2VceYWFOe8/qilW94pKVbPFcKIE6WJgqiL0vtK4+IlzMMJreGmPsz6mAIbUBLM5hPrkPW5gAcckVQKuvu2+lres1C09rIcFCobuYNq5ytFdAUHUddA2O7hGDtdQY0G7WAWsNhg29sH5werdznzKejWLiHToFqGbnvrpkQEw6L9KG1Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002617, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 17, 2024 at 06:36:42PM +1300, Barry Song wrote: > From: Barry Song > > We used to rely on the returned -ENOSPC of zpool_malloc() to increase > reject_compress_poor. But the code wouldn't get to there after commit > 744e1885922a ("crypto: scomp - fix req->dst buffer overflow") as the > new code will goto out immediately after the special compression case > happens. So there might be no longer a chance to execute zpool_malloc > now. We are incorrectly increasing zswap_reject_compress_fail instead. > Thus, we need to fix the counters handling right after compressions > return ENOSPC. This patch also centralizes the counters handling for > all of compress_poor, compress_fail and alloc_fail. > > Fixes: 744e1885922a ("crypto: scomp - fix req->dst buffer overflow") > Cc: Chengming Zhou > Cc: Nhat Pham > Cc: Sergey Senozhatsky > Signed-off-by: Barry Song > --- > -v2: > * correct the fixes target according to Yosry, Chengming, Nhat's > comments; > * centralize the counters handling according to Yosry's comment Yet Yosry is not CC'd :P The patch LGTM, but it won't apply on top of mm-unstable given the amount of zswap refactoring there. I would rebase on top of mm-unstable if I were you (and if you did, add mm-unstable in the subject prefix). Acked-by: Yosry Ahmed Thanks!