From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F924C54798 for ; Tue, 27 Feb 2024 16:00:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC4DD280024; Tue, 27 Feb 2024 11:00:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B751C28001D; Tue, 27 Feb 2024 11:00:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A63E4280024; Tue, 27 Feb 2024 11:00:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 96FB628001D for ; Tue, 27 Feb 2024 11:00:28 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 060E21C06AC for ; Tue, 27 Feb 2024 16:00:28 +0000 (UTC) X-FDA: 81838046136.30.FD2647F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf19.hostedemail.com (Postfix) with ESMTP id AA4271A0043 for ; Tue, 27 Feb 2024 16:00:23 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=KqpHDucB; dmarc=none; spf=none (imf19.hostedemail.com: domain of BATV+5d0d8640c4fce96ce78f+7492+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5d0d8640c4fce96ce78f+7492+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709049623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CuJB5bRBJbOy4In+KKiCZi5akTRyl9NVfEAfw816xy4=; b=X6VlMiNODLvCu1o1i5rny0SPmQbgzpTrG7bxBhUgJvg4IK3kDdX70vjoI5Gp+HCQEgV0yN vKZdWm+nJJ7saX/zuiC8apXn6Rl+NR/LJMhuwJm+q0U6L7nkb+0kw/7IfPXUpBGPbcixA4 /a/sRZVIs02nzUn2sKDPlFiaNRM7G7g= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=KqpHDucB; dmarc=none; spf=none (imf19.hostedemail.com: domain of BATV+5d0d8640c4fce96ce78f+7492+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5d0d8640c4fce96ce78f+7492+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709049623; a=rsa-sha256; cv=none; b=HMLqhV4PXPJsbYQLmAxYD3KlQzQpn5pTNdCSbfutZvb6phdXmK+neO22HAkS04niq0Gl4M wPIUK7hBt7DIf2xiMqUlp4/UZTfooedXCF4Mq1fB04q3hcI1lLe5o3yVCgqsCmnSL0dOBn okgoeR0NuiJDCpqTlTJn+GUM1HYplLM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CuJB5bRBJbOy4In+KKiCZi5akTRyl9NVfEAfw816xy4=; b=KqpHDucBRg5Iv9IKONlQDUmmIM NTRyFQtftMfeOC0U1oENORYEroE+VVuyz/8hcWrZl4Bx0JyDioMkktPp3WzKojAvOv9335Wo772Bz uefvIc6c0w/grkBdW+Z03XO9A4ZguEhzaM7MLmY6PgcDv/UmTwl5UWywzVMTJ7qM79ZjUfRxUON63 5tpxRgb81hq1YYpXiAIaz9Qss0A0oPFyd9b7+U3vcyKFdrOitsYeDX9wOMlgeqwgXmgwc+dFVMARW yzmPSUW2rC1VYqoU77sSzHjJT/2+juunQbH1ojNBFtTXXmQxMdKC3Q3Gt9JVWNf3994BuHcyhIMkr 3wXQm3rQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rezsQ-00000005tJI-0eyv; Tue, 27 Feb 2024 16:00:18 +0000 Date: Tue, 27 Feb 2024 08:00:18 -0800 From: Christoph Hellwig To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Lance Yang , Ryan Roberts , David Hildenbrand , Yin Fengwei Subject: Re: [PATCH] mm: export folio_pte_batch as a couple of modules might need it Message-ID: References: <20240227024050.244567-1-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240227024050.244567-1-21cnbao@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: AA4271A0043 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: opgpez4bc9kkr1uy6r1c1cbcwx14s5hy X-HE-Tag: 1709049623-81438 X-HE-Meta: U2FsdGVkX1/1QlbnjsYZzxjtjxmttanlz3jhOIWn4qe39/QrFUykAEk7g3TSo4CYuNF4FTmTrc+swWSrtrOL+y4beodPYhsl4WZv+CeXqHOXyu41u/DPMflIBO1CkaVdShFt8QTZaHPQr71ZeDQh3VmVxDLO88s9YsqQNewWtZ0VHe/2xhamZO9ulmxIL+e05zhoU7BLOL3AvNxlsmx6eeXLnaLY8YIEG6MvBAAr/KTFBfwtU8KZhLRxbBo0V7ydA0irZFonbwndyV5DaV8nSStst/K7+uqnlZiyYZPAviSodRn8MoOdniL3Lrt5aUNlkDv/1uIvqksXvX2efrFyHZAK4hjVFuOtTg+Fh124tcf2Pefmi3gwrIqaf9Q6Spy7RLFl6hn/BxcMYxdKaOxRa8XMuzoGrlye7xNopzoOLuXPnhaa8IPZUcQOlTcyKrNLOVoi3nR89UX0aRSSDjWHOmNGDKzdgCHAckZ7mVI6AU/XbpuTbDEE0GhW/kDRC0G8jLZsp6Vj1e+fiDMMivIIP8PabD9pQMqHe+DYFIovRhGMucqTwWnZuOgnY6thjwG8XS8OCMUjSBcB3FucoHm8QuwKrwKmMfnJig3bsBCzTIo4eujIlOdZdvsvopoUx1pLDVOVqvJRwabbx0IH6kBVlVaeuB2jwWDynnYFfIIP5r9wqusYX1z7XAUeCVQjqcuTUS0ypCudCyt1qd/aASiMOQc19bLYBNGxVqEU2tJgtSB6gUqe/RQaukFl1UWr+U5VKg87r/rVQfDRFOdlwqv4JQdbNJWbyOSn0PNdc3uwkuSBUigB0zeiurDXWaTormhxe1xOA/KCvki0M+lKynw0ga6V4Ml2YN78PwgkqS2dwLs6B7sONPMF9myrRrJRDxsOtaTSjEa96RHSrzAbp8pl50OE40gTemKzZc/VuCFjNmPUYAXgtkzBCFw/YvM35SBIU7MssIkoHtbLQoMweQ4 d2saG+7d fJLinnA2ImDCcZGaf/eIff1PhaNTIKSXF/0PbImxzOwe9rfI+skNxivO5d/f7tcNhpk2T/ny6IT5+PDSrXlWtZv6v95abfx+8zxxBZZ0S68CIT30v/thtWg0bse0T1T0NVG+3SHpDwwZYY3tCTKPnZm1ceVBIge4QxKpx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 27, 2024 at 03:40:50PM +1300, Barry Song wrote: > From: Barry Song > > madvise and some others might need folio_pte_batch to check if a range > of PTEs are completely mapped to a large folio with contiguous physcial > addresses. Let's export it for others to use. It doesn't look exported to me in the patch (and that's a good thing!). But even for making it non-static you probably want to include that in the series actually making use of it. > +extern int folio_pte_batch(struct folio *folio, unsigned long addr, > + pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags, > + bool *any_writable); no need for the extern here.