From: Christoph Hellwig <hch@infradead.org>
To: Barry Song <21cnbao@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Barry Song <v-songbaohua@oppo.com>,
Lance Yang <ioworker0@gmail.com>,
Ryan Roberts <ryan.roberts@arm.com>,
David Hildenbrand <david@redhat.com>,
Yin Fengwei <fengwei.yin@intel.com>
Subject: Re: [PATCH] mm: export folio_pte_batch as a couple of modules might need it
Date: Tue, 27 Feb 2024 08:00:18 -0800 [thread overview]
Message-ID: <Zd4HEjS6vpIvwfR9@infradead.org> (raw)
In-Reply-To: <20240227024050.244567-1-21cnbao@gmail.com>
On Tue, Feb 27, 2024 at 03:40:50PM +1300, Barry Song wrote:
> From: Barry Song <v-songbaohua@oppo.com>
>
> madvise and some others might need folio_pte_batch to check if a range
> of PTEs are completely mapped to a large folio with contiguous physcial
> addresses. Let's export it for others to use.
It doesn't look exported to me in the patch (and that's a good thing!).
But even for making it non-static you probably want to include that in
the series actually making use of it.
> +extern int folio_pte_batch(struct folio *folio, unsigned long addr,
> + pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags,
> + bool *any_writable);
no need for the extern here.
next prev parent reply other threads:[~2024-02-27 16:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 2:40 Barry Song
2024-02-27 3:18 ` Barry Song
2024-02-27 9:11 ` Ryan Roberts
2024-02-27 9:07 ` Ryan Roberts
2024-02-27 9:14 ` David Hildenbrand
2024-02-27 9:20 ` Ryan Roberts
2024-02-27 9:27 ` Barry Song
2024-02-27 9:36 ` David Hildenbrand
2024-02-27 9:51 ` Lance Yang
2024-02-27 9:53 ` David Hildenbrand
2024-02-27 9:57 ` Lance Yang
2024-02-27 10:21 ` Lance Yang
2024-02-27 10:30 ` David Hildenbrand
2024-02-27 10:53 ` Ryan Roberts
2024-02-27 10:55 ` Lance Yang
2024-02-27 10:38 ` Barry Song
2024-02-27 9:18 ` David Hildenbrand
2024-02-27 16:00 ` Christoph Hellwig [this message]
2024-02-27 19:01 ` Barry Song
2024-02-28 1:46 ` Lance Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd4HEjS6vpIvwfR9@infradead.org \
--to=hch@infradead.org \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=fengwei.yin@intel.com \
--cc=ioworker0@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=v-songbaohua@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox