From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9FC0C54798 for ; Tue, 27 Feb 2024 15:37:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7714E6B0274; Tue, 27 Feb 2024 10:37:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 71FE46B0275; Tue, 27 Feb 2024 10:37:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59B646B0276; Tue, 27 Feb 2024 10:37:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4334D6B0274 for ; Tue, 27 Feb 2024 10:37:30 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 07C97A10FE for ; Tue, 27 Feb 2024 15:37:30 +0000 (UTC) X-FDA: 81837988260.08.7100EEC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id BF905C0013 for ; Tue, 27 Feb 2024 15:37:26 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CE81Ecs2; dmarc=none; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709048248; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=048Rd0Tnfw7wUdrVUDBOkaiJ20Lu58pUzR90H15XFkE=; b=JBBbu7sJoQwhiGPfueXGjWG18O0x+H0Exs3EhNHbuMWSO4Su9BG2pySlOh+eoGbc9BQpzk ditHeHRQhKP++1ECsMXl7W+PK2vG28qj7zS11KSL1XLsV7M2qHQw5mi8RQ8owcBJIoPKX3 sEPWZFV7GpNokhOk4Z+QwluKUxtBx68= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CE81Ecs2; dmarc=none; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709048248; a=rsa-sha256; cv=none; b=Cm6ywWWyIGaeV6vBviZ8YDUJa35p97LcPUI8yDmt96ZYapBhWZJkNYyw/oJTpB0IGBWYTU J2St+66qEgHatlSdp2t4iddakoyHAp8eoZKgE9ZlYl2orNVr+eI1OY63LijQc1TryD/aC2 gi3LPkg19B3K6a0HM/9Yz6uE+x/wUmk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=048Rd0Tnfw7wUdrVUDBOkaiJ20Lu58pUzR90H15XFkE=; b=CE81Ecs2WMvq5uJ4+l/IRss8nC cPO8AUcaqJV/X10HslcSeuRVYnBOqXQC7AeQYm6nPeryy/k+r7WspXf23n2wHzDQ1j9kX5GrSbwyP liiVgkvDPg/CTZL7M9vvERLT52Smk7Vpjeyx0ieaj4WtsukEUykYWpTCkxzHYmVEj/pTE2sLNLPv5 z+7+tf2QUpUy3QdICA+EgCoN6pNma9oXxOjyostxHd8gmAB3HKiiM//a3K+Ombv4i/PND2Q9Xe3rj FgWfrqlgYPkOKTBpZMtGSOQsbRldl66R/rSQ5AvpHG7IOiPMe6serX2FTErKR8jo0INoJz4wZm8SY dFbvABwQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rezW3-00000002jiD-46dS; Tue, 27 Feb 2024 15:37:12 +0000 Date: Tue, 27 Feb 2024 15:37:11 +0000 From: Matthew Wilcox To: Alice Ryhl Cc: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Kees Cook , Al Viro , Andrew Morton , Greg Kroah-Hartman , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner Subject: Re: [PATCH v2 4/4] rust: add abstraction for `struct page` Message-ID: References: <20240208-alice-mm-v2-0-d821250204a6@google.com> <20240208-alice-mm-v2-4-d821250204a6@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240208-alice-mm-v2-4-d821250204a6@google.com> X-Rspamd-Queue-Id: BF905C0013 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: gtoser44iworbsjmb7qxtqdrmiqycngc X-HE-Tag: 1709048246-773420 X-HE-Meta: U2FsdGVkX18bKqMJddpVD4DpmeU6m8XzTZ2Un+aD9WP6jJzKEcSY37BiZdNLIBWtipM+yjLCa7wJ9yTuNheL9uFXeIN/cdRsFu+Mm1AxBDUMDrUoV9iR7QbIvn9zeUVVUwKt2BeYclIM2pui/S/xRFD2TS5qUTXiguF8LGgI3aa/dNgd6YkV1yQQuL12F/Gw96McOUHBNp6P03V91if4QIWP60kOQyndaSj7P5nRiQ4onQP77x1Z7jpxaaLFwimcydPQOCzPG9Qk/goqtTL2UWxzsAzV38g2MJeD1bi9WbkGvOe2P/OpnJP+emNvvqwFq2hkNLGxmAeEkdyZ9OgUUj6Gf4gIPIXgLVoEQ7tLm105GYmlbDntV4jrgquFaycf82x/I2yPNcClrBqRLfF5ZiEPBcVV1mnBPsesVgQ3OmQfg/rNOhnLHFJ+Jvd7uRp09KxEtBGQ8r1I28JqzvLgAghXjd3fMuhqsd7Fg7PPh9SIyhw8Ilp8Va9hGLUtkfTCBzD/cJ5sBL42qzhH2q/zkC+jkyk4zvOzAv1Fh2jBtIjLka6xMj4O4xQIVhTkip54uwCokJLET52ytECbLcALnJrOqcI1LqSzUfeZ756CFK38TQW8DK28rTsRE6evs1criR5vM+2tmqlBAGxOCKUDUFdqDOZyZ6lX5YgtA2/LeTqUVCifN4b1rz5fPSl/z3VQoc2wsHJdyCK6vhK6r4OWuFCOxkssxfLyTNQYRKGhsGHO3/AACqFoJcUQHQsv8BOLMwrW2GG7feFXFy1VbHXzMNrNJ6W8GnwF6N7JNwXZK4xQTzZLxtYwFxiRPhPcgQ3z5Xwbjh1W5LXfvrk/3t0e22iciiS3YqVJjRJj+RNGIDFsoviv1ys6jJxaF2lssN3E5DK0SMHj9hQ40dG5lOcyid2c/PCcaTmkXi7o0GehQkP4BVGICOFgn6iUmeOGv8Z2xR3DRS6LrAX75XdQ49c MEsqhPfb DlwhYK7EemdE8ogjwYADoIDoDOUPajsbh0v19I2bJbTTCZg+yO8X2jZ1CxjosO2Ke10JosQesALHnaKnxW/mTtXMtIAKsGFOnXuzWhK7ntxoSea7EVKvmkbcYEh96a0eAUXofEfSwW3DRESmdT+y7K7FccEIf6lk4WDOjRh79b62mF3Eu/im1e2qW5N37cTzFaEHapgxYPxeNdJjAjzU3+9UryQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 08, 2024 at 03:47:54PM +0000, Alice Ryhl wrote: > +impl Page { > + /// Allocates a new page. > + pub fn new() -> Result { > + // SAFETY: These are the correct arguments to allocate a single page. > + let page = unsafe { > + bindings::alloc_pages( > + bindings::GFP_KERNEL | bindings::__GFP_ZERO | bindings::__GFP_HIGHMEM, I thought I raised this last time, but this is over-specialised for Binder's purposes. Many places that want to allocate a page want different GFP flags from this; they shouldn't even be the default flags. So either what you're defining here is a BinderPage, or new() needs to take GFP flags.