From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58717C5478C for ; Tue, 27 Feb 2024 15:16:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB3B66B00A4; Tue, 27 Feb 2024 10:16:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A63BC6B00A5; Tue, 27 Feb 2024 10:16:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 904246B00A6; Tue, 27 Feb 2024 10:16:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7C6DA6B00A4 for ; Tue, 27 Feb 2024 10:16:08 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 40566A047B for ; Tue, 27 Feb 2024 15:16:08 +0000 (UTC) X-FDA: 81837934416.15.EBF08A8 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf29.hostedemail.com (Postfix) with ESMTP id EA73E120016 for ; Tue, 27 Feb 2024 15:16:05 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=VihdrFF9; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=NMhDP5Sr; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=VihdrFF9; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=NMhDP5Sr; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf29.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709046966; a=rsa-sha256; cv=none; b=ENrPuXc40Z/K6HuHda85suIIOEX8FXrT4ivmr6TyTpYvWxybu2ai4nHX44rOxYoGsuakHC uKuhOkBNJbtcgm8cGfeV09qxa7Ur/PgW1v9rsWGsqtC0zt1wmPI0X9IbolOMG4UlZBBbzl x9qjCxFLZx8du6sC7QMUDDBsPjp2VUI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=VihdrFF9; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=NMhDP5Sr; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=VihdrFF9; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=NMhDP5Sr; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf29.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709046966; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JZ/KbhKK6eGZmN0r12OosY6StcJkfekJBBlgQb36fNs=; b=MNAlscZv/K+0KXqtgq+lSkE2fEbsmi7JPZK3P6K5jaqNFNz8LqMr4upBZL3YiGSTNM/gaQ EBHfSf+hx+ssNrjVS+ZjKrRptReU6tgcvxeAHO1ym3PHBHYNCRDrLLQOBuvvkVk2GKNPoO L0dbKB2PmwnzzOrtR8Sb9ycl8Oarezw= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 126001F461; Tue, 27 Feb 2024 15:16:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709046964; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JZ/KbhKK6eGZmN0r12OosY6StcJkfekJBBlgQb36fNs=; b=VihdrFF9d8S5FVkYKn0hTax4UqSvWcJSafsUOBjEuW/b0t3AxnpQhAzgdPA5w60MO4sHcN G7qED5PcgNwEsI/mnAZeVEYBiGJYL17ChY3iBVZbvP6crKra17TNR/3IOcnlSe/wftV1HN uG18XWA4N94q+NhpkogQxoONLXne+nE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709046964; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JZ/KbhKK6eGZmN0r12OosY6StcJkfekJBBlgQb36fNs=; b=NMhDP5SrF32zrAya4SDOW10wyzx20ZZS4aVxt/qGF3QwXfrXCK/7mztyv/y8GJdA013jXz ueH3GpsERrrDxzCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709046964; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JZ/KbhKK6eGZmN0r12OosY6StcJkfekJBBlgQb36fNs=; b=VihdrFF9d8S5FVkYKn0hTax4UqSvWcJSafsUOBjEuW/b0t3AxnpQhAzgdPA5w60MO4sHcN G7qED5PcgNwEsI/mnAZeVEYBiGJYL17ChY3iBVZbvP6crKra17TNR/3IOcnlSe/wftV1HN uG18XWA4N94q+NhpkogQxoONLXne+nE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709046964; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JZ/KbhKK6eGZmN0r12OosY6StcJkfekJBBlgQb36fNs=; b=NMhDP5SrF32zrAya4SDOW10wyzx20ZZS4aVxt/qGF3QwXfrXCK/7mztyv/y8GJdA013jXz ueH3GpsERrrDxzCw== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 8512213419; Tue, 27 Feb 2024 15:16:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id uPTFHbP83WVSCAAAn2gu4w (envelope-from ); Tue, 27 Feb 2024 15:16:03 +0000 Date: Tue, 27 Feb 2024 16:17:16 +0100 From: Oscar Salvador To: Baolin Wang Cc: akpm@linux-foundation.org, muchun.song@linux.dev, david@redhat.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, mhocko@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] mm: hugetlb: make the hugetlb migration strategy consistent Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EA73E120016 X-Stat-Signature: ysgudmpfxniufcmakjw5y34trg7apjg5 X-HE-Tag: 1709046965-531131 X-HE-Meta: U2FsdGVkX1/FKA2whcgXoarL7flcLE4yrplMignO2kM1Mg2/np4Sj3MaQHlAafXuPPk1WdmijYwK5NvuX9eiovxdKvH9lMZU8QDNH3Dhy6p57z2LrU0aXD7xA0BR6eOmZyStkMDmJwx9n2aEY4/k2nKSmtUBtku6aufP67Q8WrXzJUXG7ddo6dW3m2vRuTWoBB1TXiKpY4irGnHvZfFwFDXzYt6sy8H59jc+kZ4hTr9o5iMGAZ1lWfr5R9hq4wo5VpyLqMatq1azJE/BV3b45Cm9GbcR2IzxUA70oGkH3IkvkLJIyW4JGnOHCGzUkaLIvCmKLS/kRMEHJsB9pw2fqFvw5ln2p4kdNfufQ0SuJPD/c4gdRMtrRsk761XBeL8++1Pwwny6oChFY4p/PMwUzrLu/gyWrdVVFO1kIzv3o9Rv4boxHFneotxWMlTTSOc7pDexHZzAARPmPH33stF6P1hqZyIKO1qM1HHblYk6J1RqV79RxH7IbSutUf7A7UoBCTyf0jbT5HtoS/hM/IctIRQ4iSHro0JO+qRU676pxL1GjPWVb5tJdhIhdzZd5hCG6KernV2aevwCv6538Oh7DbgZ3NdX8kk2xpqWhfilwgLWppssqy+90sx6rsCqTM/HgxfJ/jlpvPcoPeq/apHqbRkU0XT1iMnce3bBHO2j3BHILNz8SVp6PG5bJxjRERZIRjN7YzCB7UWy/PYOXATIyMFZP2grkqnIMux3hyVOvrloJRsh9WjkpWL5UNCilgq4+frTksWP3om0LJg90PtnIBKRqN6ZMBuXL/7nr7ajbJCwamS20SSQK5oHf1jFvE2QkPBcxIMbAQ6l/yzR5QknYF2EHE2z62+K7aUjS+g5MW6bIdyb047lvf2HIXfAIegszppAvdxVP4s48zuIbKL5sdE3ph8cWJv8fALUmZ388B4B7U8UC4mQBr8Y3ZJVQGdVY/YCRyhe6hWqmLAfonQ jM3IPh4g TnGqVZ8XaZrgdsYuMhlaQlyh32b5tweI4NYvkyZ/P0k4nMeQUvZX3x3+fawtq34nNR/ICQYBDReyBZLz8Y8JeHfjjoMZTn/2k7t/TB7BDevM/oafKVy8kDfgyoOKbYtUlR/mGxVC+8JoBiy0ct+/LdKfZHOt4B5t/MY2ker00a3A4kyB1mbV28Jl36XN9sRQ1jz6pmrR4JP8Kbxs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 27, 2024 at 09:52:26PM +0800, Baolin Wang wrote: > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -2567,13 +2567,38 @@ static struct folio *alloc_surplus_hugetlb_folio(struct hstate *h, > } > > static struct folio *alloc_migrate_hugetlb_folio(struct hstate *h, gfp_t gfp_mask, > - int nid, nodemask_t *nmask) > + int nid, nodemask_t *nmask, int reason) I still dislike taking the reason argument this far, and I'd rather have this as a boolean specifing whether we allow fallback on other nodes. That would mean parsing the reason in alloc_migration_target(). If we don't add a new helper e.g: gfp_allow_fallback(), we can just do it right there an opencode it with a e.g: macro etc. Although doing it in an inline helper might help hiding these details. That's my take on this, but let's see what others have to say. -- Oscar Salvador SUSE Labs