From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2D80C48BF6 for ; Mon, 26 Feb 2024 21:18:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 541FD4401C8; Mon, 26 Feb 2024 16:18:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CA5544017F; Mon, 26 Feb 2024 16:18:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 345894401C8; Mon, 26 Feb 2024 16:18:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 213ED44017F for ; Mon, 26 Feb 2024 16:18:25 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id ED715120892 for ; Mon, 26 Feb 2024 21:18:24 +0000 (UTC) X-FDA: 81835218528.28.0FE682F Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf01.hostedemail.com (Postfix) with ESMTP id 1ADEA40005 for ; Mon, 26 Feb 2024 21:18:22 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=q46C5gW7; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf01.hostedemail.com: domain of david@fromorbit.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708982303; a=rsa-sha256; cv=none; b=omzUAcsw1nIp1RR3ZAnB/5ps3U6sau89HJOdN6DYGOjPfjSTKnnMbuUSiJj2GX3ukKUhx4 pmhMR+LYFRZPmfVCB97GVLh5oMMOeN+2zfQdYTRnEMFTUYSDCDfLDV3lRM0eMI+MXbmZSV MhnJ9oIKs6uwM7+sTuNqLJ2/ZBtD0Mk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=q46C5gW7; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf01.hostedemail.com: domain of david@fromorbit.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708982303; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I9bpXPsVA2dblkxjM286LakoqzaJhRDzLGBOQQdyQhQ=; b=mYfXFGEoQ0IDTO7pmxDxTXP9X6uW20tLnAuAjlC4de1NLpykFdRIbJPy9y7h6GHaehWHVq gtOX7nsXUZHlBU1nSWIo/a6l98EfIo+F5TSWlJ7ECTc8uhVFvSEkel+BT0LnfwVCCZmlsV d1QAcsTHQy+eILDSM831cM7iJ4Hz35A= Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-5d8ddbac4fbso2978189a12.0 for ; Mon, 26 Feb 2024 13:18:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1708982302; x=1709587102; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=I9bpXPsVA2dblkxjM286LakoqzaJhRDzLGBOQQdyQhQ=; b=q46C5gW7fVW6vtyqjtzgpsA3gKW0zdB879YrGj5i9lTdjkwo2e0hsdu1ndAaL9BB31 EisGyoMvLwk08hs+L8sW+n5gph3VF0mXp16ss0MhZMN0TtF9Ce96Dzb3FTuN8plF7SqX ZoAn/fFZWHT8P5W2sXBOFXWGAS9KQPrhAdL5y/zyJvpBP9aFtax6fjaxvh2JRfNWp6h+ fPFcTrTtWaGm+RRhVlHuXhQQZ2Ekk20VeTL9/asQVOnr/hg6a4HaAQkiJLJ8LjBppm39 3pK8zg+WCS7wQnLN22q5a2nx0nT2q4AEGMG4hrd7ii/mu5NTeCq+kTwcP2y8GM1OO7Yc ncXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708982302; x=1709587102; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I9bpXPsVA2dblkxjM286LakoqzaJhRDzLGBOQQdyQhQ=; b=PN4UtbfIxFewViVvWEYoZOZ3l4+rZeSNULhuLnrqODD7SVhxJoHzgRtiiMy2DBjQEP EbwmyPuvvGotGKeQFWnPW3YJy4nmvMuCVGF4qXrSvN8VpdOMelSYNgtjDFr8vO4Aqz2w wUIxnJax5k2lReai4jxb/Ij+CcqInfMXcSsv79xCNw8+MTEOLZJiIKvn+h/U++LYa4V0 4b7IjOgg74ZVloJ/cCXmcAeFp0g0j5RQC+hEgIl8HIW4PCTE+GHSTsdMKJKJp0WRMEZW Z9GFtsUI9V7QL3oSOs5rAFxL7kQ9ZYtVBTkbOboZC3Ovq3HmYJ5pOqvZ7zpuPaYM6RqN NFbQ== X-Forwarded-Encrypted: i=1; AJvYcCWHjaz4w6F6CoBs9UDdPar7Qn3aB+vbYNsHduwm+9OJZYtHfQrYO0dLI+JzCjHWq7b8JoI6EVjjqnXVAc5pHYu/GkE= X-Gm-Message-State: AOJu0YyWof7A3lt43uudCbZpC0uOlggLCqSC/PkP95Xn6JRIxfjegKvR tklyBsy4N7QtlUQXqfE1cInLJp8zh1Ov9KqJlm7tT2nXnztCz5CQ93Ho7zCdl+pnP2stZRWMHdw e X-Google-Smtp-Source: AGHT+IEaS3503yij5SnTzXRX9ma5fz0nrIGs9M8iQXzfkpIF9Fk1rga0qUb/2ASG3WoYZeBci0kbFg== X-Received: by 2002:a17:903:32c6:b0:1dc:b3bb:480a with SMTP id i6-20020a17090332c600b001dcb3bb480amr1448955plr.49.1708982301931; Mon, 26 Feb 2024 13:18:21 -0800 (PST) Received: from dread.disaster.area (pa49-181-247-196.pa.nsw.optusnet.com.au. [49.181.247.196]) by smtp.gmail.com with ESMTPSA id y11-20020a170902d64b00b001db94bead0asm127599plh.193.2024.02.26.13.18.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 13:18:21 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1reiMc-00Bv0s-2p; Tue, 27 Feb 2024 08:18:18 +1100 Date: Tue, 27 Feb 2024 08:18:18 +1100 From: Dave Chinner To: Matthew Wilcox Cc: "Pankaj Raghav (Samsung)" , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, chandan.babu@oracle.com, akpm@linux-foundation.org, mcgrof@kernel.org, ziy@nvidia.com, hare@suse.de, djwong@kernel.org, gost.dev@samsung.com, linux-mm@kvack.org, Pankaj Raghav Subject: Re: [PATCH 13/13] xfs: enable block size larger than page size support Message-ID: References: <20240226094936.2677493-1-kernel@pankajraghav.com> <20240226094936.2677493-14-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1ADEA40005 X-Stat-Signature: o8qwmgfkqeyuqoxwjabp7rgp6mdapcc7 X-HE-Tag: 1708982302-903435 X-HE-Meta: U2FsdGVkX1+T54KlvbRSRHnqSSQ7UdeE1Sjczh9VUesUsuOMebzckqebgrdLNjs3aExVJ1wfXvJMyd9RL6YHA6lqwUVosfzAl507Dd/yy20U32E4hiXlQe278tHTFKunxpOllpQB6b8sGgor96tiR5Lmjo7DOKP43d4+pOfnLwpcE7WaYeye2mnu0YO0PV1GHxfYuvl9gZjGOqnIgerXwVma7PT/LVu7R+xfJx92fDdW4p6p0bMiKCF+w2HLA8iNzmig/FttULDaD1IFiG92m+vnd+ExZjYNX4Xiuuue5A67Tz/NVccT0p6Xil2w+clCkuSYx8CgyEzSw2eDZ5xOsJDyplDWbu30mzbgOZnNY/Q41qyWAo1UYMl5a8PR5D/oZrrY12ZAE5zW6/cyiQqSkIXc30t1+AqNLW+fx56kbbYiS+8xDiqbiQSvRdFA5L0IQ99nrxJ42AqBzq0U6eSyr0slStrUmQhlbFrs8C5dzhZZ9ROaZJBRAsfP/6f+v8OWfzuCCEqGB6dIv61s3iEKKj5iR2x2RH+r50BaOPZeV52GmqQ+NbsDiGySMKgpM/SH6NCXs38EZepuAmBroJRG39/k2l5FtX04uMDQLJFh92s/4K+Ay/VWyIdhOm8ifhzT5Tn3W0ZAAt7g5/QFNKYneLH1dtiROCuhGO3CLESna6p5i+Bom00y7HFS2Xdd9yFVx7qrJPi9pjAy/vAzs2EOpHw5R+wh42VdX76yqs6cufcnqMzHINJ3BN/OA43mZru+Tp99hj79vixjYUXF1hL7YsGWrcJoIR7WWymKf8HcIX3WusYFWvgRiL7YrKZf7vZDEaC9y/oAUKsJKc8Majgq+yLOMp9+gt3Ix7LNJNB+9JWekVkrovpkq0MMf/s18iKjknSPB7Fqr9AkLQyp2kcsXgDl0qGs2+Ey86twRuG2qVlao8Mg9hSy0Ash/6+CrH9DcmeVZw/YiSiGibyv+WS LeeCTUIp A8ciqeEl/RBCP873t1wzFaalEwrL7RB1CRbbypsjR/OoTt5HAPqP1OZaRD3c3uIz/lUYKt7KaiWtaSQ6g459/ZsncMXmiqh+G25KKil53mvEcLqxt8mJdXZgqWg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 01:26:30PM +0000, Matthew Wilcox wrote: > On Mon, Feb 26, 2024 at 10:49:36AM +0100, Pankaj Raghav (Samsung) wrote: > > @@ -1625,16 +1625,10 @@ xfs_fs_fill_super( > > goto out_free_sb; > > } > > > > - /* > > - * Until this is fixed only page-sized or smaller data blocks work. > > - */ > > if (mp->m_sb.sb_blocksize > PAGE_SIZE) { > > xfs_warn(mp, > > - "File system with blocksize %d bytes. " > > - "Only pagesize (%ld) or less will currently work.", > > - mp->m_sb.sb_blocksize, PAGE_SIZE); > > - error = -ENOSYS; > > - goto out_free_sb; > > +"EXPERIMENTAL: Filesystem with Large Block Size (%d bytes) enabled.", > > + mp->m_sb.sb_blocksize); > > WARN seems a little high for this. xfs_notice() or xfs_info() would > seem more appropriate: Nope, warning level is correct and consistent with what we've used for these experimental warnings. xfs_warn(mp, "DAX enabled. Warning: EXPERIMENTAL, use at your own risk"); i.e. A message that says "Expect things not to work correctly in your filesystem" is definitely worth warning level meddaging. -Dave. -- Dave Chinner david@fromorbit.com