From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E621AC4829A for ; Tue, 13 Feb 2024 22:45:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D5938D0014; Tue, 13 Feb 2024 17:45:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 485508D0001; Tue, 13 Feb 2024 17:45:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3261F8D0014; Tue, 13 Feb 2024 17:45:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1D30B8D0001 for ; Tue, 13 Feb 2024 17:45:10 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CB38180C71 for ; Tue, 13 Feb 2024 22:45:09 +0000 (UTC) X-FDA: 81788262738.05.D15E963 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf11.hostedemail.com (Postfix) with ESMTP id CB58D40015 for ; Tue, 13 Feb 2024 22:45:07 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=YGGpIGdi; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf11.hostedemail.com: domain of david@fromorbit.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707864307; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VSX+f82UonQUib7g2mNUoZMszrXmjLE1tVvT69rZd4k=; b=gzMNcQVgfM3uY5l5e++JUoT3tuQIsLkIFh0hpAHSdWlBzh2CGonnRCefoNAI/DHXTwctqT DHKWATCZ6QbRd8NKsLubSjKHVQyQD7aoso3nwG2F+23c1dcCbCrZ8VtEBYDFKZ4GeO+IXf xjbj6C3RnDLxK30Ei4LbER/jxPaRUTs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=YGGpIGdi; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf11.hostedemail.com: domain of david@fromorbit.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707864307; a=rsa-sha256; cv=none; b=PWRia/eBuQNfkULZXfJVDAvyZDilha/p3esGw1L/EzZfbfyyfv5HPJxtj+xs91mRAjqVJ3 gDStF8PiYwjr42/0DWf8Sb6/JT5GPa4M8VX/VEUorc8Ti3LsfR77muU63wfzbp3VKZ1O1h sKG+vdJCj5PtF4eDEPbetYCHjMBpqM0= Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so3784800a12.1 for ; Tue, 13 Feb 2024 14:45:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1707864307; x=1708469107; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VSX+f82UonQUib7g2mNUoZMszrXmjLE1tVvT69rZd4k=; b=YGGpIGdif1NUgMwxQvQyX3EPtg/p78cXsbLiW/hNBtz+zzNM/Ikk5ClfVVDYaXUkRp JiFNpVT6JNwriL0zv5IZN76GQMupoG1Ol0inAkxQEzOrewDTZbdJIYmp88PFRfScRKBe m8hOA0bZKz15sHN3XSu+tJmJhP2ntmsOlYfb5Tt51G9SzOPKo9poYRFK4QHIFsFd1Znv fRmj01YfPwl5JBI+5IEW8CN8hP5ikBvTakHmokZplpVZWTLhMvwIG8gA3TQZplkvmTgx 5LVb5M0kjJcyepHZ80rJgxR9dYcBu2kA6uigWOjrZA7Y8GsuiW2WKjWpoOUrbuxVvf9I of+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707864307; x=1708469107; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VSX+f82UonQUib7g2mNUoZMszrXmjLE1tVvT69rZd4k=; b=k5ZTWKYYjHZLZx2rHXBzEai1SxMl/8rj8aacu6eZ8aFg+Wg949dzGUU/rUu1rdJXO6 eJYj11LcBX+nadvoExULlE7DUgiUxGbtQfsi+V9zZZIhz3UmYimbvIidIn0WWaVbuT+N IIU1eQ2bZGiv/lFjm/pPBjqsBFS1ue/uVE3kmqTaDLqo96gdRo9rmaKEHH8Dt4iapb5U /ILN7eOxX9ICtc+GcwNKaMF/UmnLGFcMQwolDNTOkGNTHgT9VrNqzkms+7xY9x0Js5Tb mBfQlTDqH6kzRF8pHbSfJWBl70HXpY+OMqJA98ffr+96ikdAe2w18OxCFubUbX+oWzRD kYWg== X-Forwarded-Encrypted: i=1; AJvYcCVgpwS8B/ZsfAF97xKUPIsVvxngY1yqA+Q64QA2KrO0e8flp4xiTBoqZr8l8+7PzoJvYoRp0zzb20V1mX5gM7dwumM= X-Gm-Message-State: AOJu0YxjFF6BKLo6ldlvMmZgSjKb+ZwkaqgRxlkKQrFPfVgbEFIWrwNN f9DVbo2VhZo/XaG4t7kbW5tQn7KXFsk7+smdMCmWl05HxuKrH8uPnt2guVZizRc= X-Google-Smtp-Source: AGHT+IFH5HuMfmvbE4pmOe8SUsWhXGmBy/f8wCL8BkqKfjRUwp7p68YSbmTclZDRaoQsSL6V13FV8Q== X-Received: by 2002:a05:6a20:43a0:b0:1a0:60b2:45b with SMTP id i32-20020a056a2043a000b001a060b2045bmr1445690pzl.6.1707864306761; Tue, 13 Feb 2024 14:45:06 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUuBRLYz/ZMeJAh5p4WoSM7f4br1opheRIOVUqkjHYvdjjF+sUGuH9OCmB++AXrk+SYj0c14b2v3mPw++EN5XDbXUgzFjupG5q/2qyZlwfpXk7ulACrPgHmp4r3KNjuLVlqX12ACdOM6raWkbIOSUq2HvhIHlPQKjzHqg2RSsAnT6WjoVb9ntIfUxaXQ78lEaHrGDv1By1Kx5UK/Y9eYvQtynsSTLzuvYmO/JroPwUvPGCYTRZsNKaVHDXL2Wgr68Ql9oDQEQBRIXLlsJAB5f9dVuP6JW0oOzHEGa1FnkQfY1sJUTbp7aeZP+0CR3s3kN7F/lWm0sk7hJOK661u6uz4PF40Z9d0XYHNhlZk242dwNhEkKooSKpml+jjj+Xroa6a3KvQe2FjcC3GQztgrVCGprCGpX0MeQ8Z2Ck= Received: from dread.disaster.area (pa49-181-38-249.pa.nsw.optusnet.com.au. [49.181.38.249]) by smtp.gmail.com with ESMTPSA id r18-20020a62e412000000b006e0503f467bsm7953728pfh.39.2024.02.13.14.45.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 14:45:06 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1ra1WQ-0068Mq-2a; Wed, 14 Feb 2024 09:45:02 +1100 Date: Wed, 14 Feb 2024 09:45:02 +1100 From: Dave Chinner To: "Pankaj Raghav (Samsung)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, akpm@linux-foundation.org, kbusch@kernel.org, djwong@kernel.org, chandan.babu@oracle.com, p.raghav@samsung.com, linux-kernel@vger.kernel.org, hare@suse.de, willy@infradead.org, linux-mm@kvack.org Subject: Re: [RFC v2 13/14] xfs: add an experimental CONFIG_XFS_LBS option Message-ID: References: <20240213093713.1753368-1-kernel@pankajraghav.com> <20240213093713.1753368-14-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: g5pmud5uuuwc4szyepbuq4ay3nroqp1m X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CB58D40015 X-HE-Tag: 1707864307-209813 X-HE-Meta: U2FsdGVkX18bwBAnYkkiwXZct3Wif1TqIOHKR21uF3fdYnyroNdVEv0xA86CdJsyWDnx4BWnS3CwMpF1kwV3EosLEY2+tHcAdxUUFVocA2oVYWUCiVyaZdo05rUeAcaLIjLJa2ZzG2c2yPAfWYABi2cDynBgkY2VSzEwHD70jZHsL/z4QZoH7cMuJDqJyFZ/KaXwF6db/rMqZil9Lz2A/ujeOdpN9DWnL+4OpLr/dTDDC/N2BRf6vbHR5XkhbjF58MGFbYAVsCJLbTeMmotEba9fM45s9352DgAVvnS0hwUSm+IEg3BmZXR3BYL/0XICHHMEDrrPacoTg4gbpGdw+Xk4PW5pZzx7sAQIBtB2azW0kuVj4ygQ7GYIDq5xmfJkAogzg7DsImv//oh9t4BM2J19gCtQxZ6wsst73niHJ+NN8tZDzOPBoJ/2+ipa6Wt543Wn8+RdriO/dtA3YriIOJkewFxJtQeax0QNHcDnXhliMXY/r5xgqp5Y3vpgdV6oOng82cct/Abz1SpBPmSJyTSaPmBRkC/BIPpFEVFlponVh51oDbFKJ42dGsSH/C+wX73+k38hgmvMlEc7YrC4edrUdmQvRddTtTHUaHEu55amrbH3glTpMXL/Ih8LQ4uSWRmkIPSZa0nDz1EpqSUoGFRO1vLhtLPOacQ/UyI1xQ0VleWKGdQ3lWfW7wiDn/JUTPkKtINr1VyP0VkinQgXWgt27OF4fTc0wiqFVP8mqbpuzLDCfyCEAtsXL1d7nU0pO6KxQQkrRVXZLRSSC6Xg8cKOHZ7WrBHBeHe1Lq7sEKtS7FiOeZJYfgmVE4MxfejuZ4qunpN0ZQT8GTWiI+6uELBGjqaDGmCaDqDVyHalKDmU8wA7beJa1twmeZU3yHlT0cMr4LgfBtlqj1xGnjAElsglu9WNlOzB2WPVBSaE4chwtv+GWG9ZIzOVs8Fudkgb49nXZjbfQpv87lCXtwx qYFQUwEK YdLNRr8MVAZGkzsK23XAsIZ/14b+Ulp74lUERPRl1NpB9aCN3gKfX+IIu5t5XZOs9YvQfkNCsvC7m/UQiWp/rFgfFNEANGaeN0LsCU+0720sbkuYOtLCjlEY3JUr+6Z93YpyVh4LmXlP5ucV5vCvrJmLqkdyx3tmvS8IzWLGMSxIk2yBSTBZQj0Fx0c3n699vgNs79TjFBCEqSnuF72sm+bw3mjgv77x2wXBrK3feCSwBK56ACIz8E8fWMlQYpLxcOgJmD80BXWyuDZwnBbcDC9hTVNjjXtfKCI9jaDCdDjZpHtO9tyQX4R2Z0Ci+qyviRN905icGsXjGIcF1wy0kh8oK8NGHfes/V5SnzyYPnH73RhEwGxkeuX3fKWzR+0HChmAbTKofWXgmCTLWiMyDJc2tnNi8DQ2HQ+X8aKUW3hoEZ3rhbvjET/ZpJuOps9p6dxqOGrLmKJDKXp8jKGcKKbLHcrX1Y9fTVMpga78ruB6P8yEjD9U7pqyPhEhOkGSRzryEuU5aTsmKmaA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 10:54:07PM +0100, Pankaj Raghav (Samsung) wrote: > On Wed, Feb 14, 2024 at 08:19:23AM +1100, Dave Chinner wrote: > > On Tue, Feb 13, 2024 at 10:37:12AM +0100, Pankaj Raghav (Samsung) wrote: > > > From: Pankaj Raghav > > > > > > Add an experimental CONFIG_XFS_LBS option to enable LBS support in XFS. > > > Retain the ASSERT for PAGE_SHIFT if CONFIG_XFS_LBS is not enabled. > > > > > > Signed-off-by: Pankaj Raghav > > > > NAK. > > > > There it no reason for this existing - the same code is run > > regardless of the state of this config variable just with a > > difference in min folio order. All it does is increase the test > > matrix arbitrarily - now we have two kernel configs we have to test > > and there's no good reason for doing that. > > I did not have this CONFIG in the first round but I thought it might > help retain the existing behaviour until we deem the feature stable. > > But I get your point. So we remove this CONFIG and just have an > experimental warning during mount when people are using the LBS support? Yes. -Dave. -- Dave Chinner david@fromorbit.com