From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7576EC48260 for ; Tue, 13 Feb 2024 22:10:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09F616B0071; Tue, 13 Feb 2024 17:10:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 04EDF6B0083; Tue, 13 Feb 2024 17:10:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E58EA6B0085; Tue, 13 Feb 2024 17:09:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D3D5E6B0071 for ; Tue, 13 Feb 2024 17:09:59 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B39D1C0D28 for ; Tue, 13 Feb 2024 22:09:59 +0000 (UTC) X-FDA: 81788174118.26.8A651FF Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf11.hostedemail.com (Postfix) with ESMTP id B54FA40013 for ; Tue, 13 Feb 2024 22:09:57 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=hegflPb0; spf=pass (imf11.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707862197; a=rsa-sha256; cv=none; b=h7V1QBq1s6oScpLaXikz5xkwsPM8K/xFm5pufEiq1FHAdERpWUMQauy9UKz8wpNumKdAnn 4uDjuEtM7XTFfVl3bmY/utyBDWuHAT2kd4ZJu++res5YyqMMF8kkWyyvzDhWBZUAMfTq55 SlciLNIVzmrlKYNaSSVX7rLKDavG6zM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=hegflPb0; spf=pass (imf11.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707862197; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KHrAkUvYa6loZ8pQ9MvgMBm7Y/FcJKqjouZpJd3Deg4=; b=B73gqd9EZAjPFRsAuy/a0ZWYDlyThwaCGp+2TAlvjaKnN7TaCVGuV7ZiE/hAwRwY4WCNTJ 1yg4YrUNuzhjmdv+bplfwNuRWnU04O2uMQi1S6FDO+qc3KiKzoVIgR2FcaUmCFt9ASmsRY cuhrGpzdWnGUmtuWFSCcp4pr4jXZOXc= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1d7881b1843so44355875ad.3 for ; Tue, 13 Feb 2024 14:09:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1707862196; x=1708466996; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KHrAkUvYa6loZ8pQ9MvgMBm7Y/FcJKqjouZpJd3Deg4=; b=hegflPb0OkCUp96WwV95C2jW1LLQ59n7PPcAikTfyDVm4zDkuCTn3NdLvD6Y5dD+1O jGzuD+zoG1CjZmzYtzBDRLNAWRsZFqyC8SiJR9dMCZpiNVNejgZxNlbcQIhsHvTc1Ua5 KLKtnVADbkCtCzHkO/Bql/s3WJ+tJjzU0yLem+Dg0iOQ9ZXf/+fYWS48uyyEpluXmm7n 80My3IUBA3glHbNOeAH/GiAhrsYyhv7K4J9YJQSHQybXLuoSd6LTXz/dlfeEcB6dy4u4 69NMD61RMAvOhbnP9uSICeaqxvyrQcgtMv5E6J+gIo/o5No6E3nitfwxp2eR5uaZIDR8 okgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707862196; x=1708466996; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KHrAkUvYa6loZ8pQ9MvgMBm7Y/FcJKqjouZpJd3Deg4=; b=fEX74sU5sxWQZvDKuqNw0nefsVD0DP/QhKjnbE9ZQsos8HAwUR9RL/7RDbKbTnmP6c WVqBCZreUah91X9zCu/rfC6pTHPAqIO0w+yox2k92yvYPl3AcpaFzi1Bk49KNCrt9Opf muNqe5XSyLg9Q+fMoIKxsjf3qq7vcFUL4uo5T9dJ9BK+Kf7MAw0f+y4O/kZuh4c10Umt +6JzL+c9TUJTxJAe5P4W3nw7etVUvFfmzhizIlzgdjSmx7staLze8WX6oRY7zHfYGs+2 /LZ1e8ehyO6UxCRgETmgyTeylHT4oQ4QCPovqiS5sWOszgAuoaipaOant9xj8+kts1Ar ZAQg== X-Forwarded-Encrypted: i=1; AJvYcCWu+15QZRikXT0sQXta3R58YS/vs/B0q4B1zq6GZDDPGIG37AcD3WanU5b/ODhs4UBfGJWldtwMTsA84q267waFElo= X-Gm-Message-State: AOJu0YwEECs0cwDH6bSuGzMt20HpFvfCrou+nIpzm8Ta+3GbpedyOrUF 9IKxLCCttqhlzRMf9xtRvY6yO8wQV8JA5oiqQCErBTonQMDsfotbNtJqrUBxutU= X-Google-Smtp-Source: AGHT+IGgqUUsjn257/XY2P22HF+jK6l4KCqtveCToMslA6YTTEIfSnRD2gkjjAU8E2S7/q7gFf6VFw== X-Received: by 2002:a17:902:e5d0:b0:1d9:14fb:d142 with SMTP id u16-20020a170902e5d000b001d914fbd142mr1287192plf.32.1707862196652; Tue, 13 Feb 2024 14:09:56 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCU0ESVTZZSVdnxEus9YiyUaZmdXAgx/Xl1gU3CR6MVu9J4mZ+RaM5oZScWBYV6lzac7Dd70RSYsCsBl6RjMuqdB1SViohyMqK9AjP/0Nubsg9spL66O5OJ9Ilh7PBEprTOECIhR4U6k6dNjIhuTIXL/2IwZhep/x5ggajcUnMC/bk5OAyhKaCOSKT/Fhh0h9gzWNpDTA1yDdR0F3fWjhBlbaaNq9IE4qPiAV6YN6DHzTGkL0o98qmyE1stg1SerRm983++Xdcd9i9cIKm6UmxT76yjpRoBGWL4/rDpAF6zXb4cbDPR+ZUd4YdnTtJs5vpMd34GoiUONqcfhPSbbZ7BjT1L6j/ImosHNqAYul6ynTtmVdRe1uBCKFj0KHY0Z7CP/NUPO++Ga4G3eJACOq5GzM8gHlKkeW/vvvzQ= Received: from dread.disaster.area (pa49-181-38-249.pa.nsw.optusnet.com.au. [49.181.38.249]) by smtp.gmail.com with ESMTPSA id jc19-20020a17090325d300b001db2ff16acasm1894517plb.128.2024.02.13.14.09.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 14:09:56 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1ra0yP-0067hn-1k; Wed, 14 Feb 2024 09:09:53 +1100 Date: Wed, 14 Feb 2024 09:09:53 +1100 From: Dave Chinner To: "Pankaj Raghav (Samsung)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, akpm@linux-foundation.org, kbusch@kernel.org, djwong@kernel.org, chandan.babu@oracle.com, p.raghav@samsung.com, linux-kernel@vger.kernel.org, hare@suse.de, willy@infradead.org, linux-mm@kvack.org Subject: Re: [RFC v2 04/14] readahead: set file_ra_state->ra_pages to be at least mapping_min_order Message-ID: References: <20240213093713.1753368-1-kernel@pankajraghav.com> <20240213093713.1753368-5-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240213093713.1753368-5-kernel@pankajraghav.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B54FA40013 X-Stat-Signature: iimd159aj53o9uyzw554sby3rj9gihce X-Rspam-User: X-HE-Tag: 1707862197-571632 X-HE-Meta: U2FsdGVkX18D27xvGsAPIw5is7CFeZZIsP4mdXlPWFcPtUtrQt3AC6tVWPk0L5adUW7UBjMFyVp+bs9V8HzQVUI8e3CK4gpxec9QsfYDi6GqV2gCq2dNui62ptfkjkwPmfvJ4Q+5MYn9p5bJHaRA6F2N2W6ZBo9g35TgENEJOj5iSlln0v3swD9gr2j12B8hZ3ZPvVuHsCT19sNwzmQ1Ul1JwJzzLaGDsALvuTVYEF2NNMd2OfYwtVhGDO9iRKtZoaVi++VLROyWkBeSWzT/u3w6P8ZUeKnxn87q3OGQ2vOBT81y0yPFdexcRDbtVvTLMvBqnn3UEZb+WHAVQKqg3CIx9dR3xGuJbuvgFQeAJoXeZH4pa2eBrySFfqwQXu3tdKMN391MstPiIzZ6o1tqW6BghthtUfxviQ9Og1sGnqEgz+N9P7acOJSjMMoJlsYhxLH8VXVr/G+xkXKQYyIdZmuOr9qkJsOFm/zS/4zaKALr7sLeDvw+qUYn0BW4LOpE8sYV51Om79bT92F9X8aXRoPOofSQBabhEU9pnduXbCs+GknUzku21OrMyCoUuJnjiXNmEeOcommF0NZhXTraXPBQdoLfl2LVcQ4Lc0GDMmnhGSwe6eDgyN/0onoEojvnzvtXevI2W/sVlzsGCxC38+u4QVwLKHw0kI0zQ1qbDk0OjaGaGUHAA+cwHh+OCRXPIAoC6WDRy8DI8wlVW1ki1AkrJv1b9k0NtVFotY0hxI0DIWUFXjebdWEaFMNu/Lln1AMaWz7hGm/36ub+3C6dS84dm4L32TMe7Vnqkw5TXFvuaHw/ldZj6CEKSY9QN/wi0m3AX7cF68OloL7srQTsiCc3jmEPng6/kYAoR/U7n5Cok+X92acibWShcFkXh30U/uP3DjRnf/qcx4e/cXwU20Uegz2ZNPxoiUKYHDF2dKg/3CiU0CGzhXgL1mqyv/9DvhUFeajjj8M3M2zm2i+ xzk83tjb Z3bzybD9cirpA4zYYuSBuxUiTEQ0dr8L3754WmifpG8vfbjzdAp85/1dmK1xFZRYyfQNy1PNH610bkWv0Dp4Zio8Sjle8TxGEDUZIvdtLdeut/fR6qyb/spemjvaebeX+BZVxr8qjzXiO4LZLJ9WczC+gu5/HZASwoThvvvytK3yOMBkhNw6Q5/FgFGuKinZxH1k0uHlklhDJF840CnUusILPc/BdLib4yddHY+LmwJSwtQtLj3IjPkP7OGsIJq2l4krxZT0563lOyN5ky/R9xKcs48HnbR18KvDOlARF37ciW5EzY1PG2AmstNj5wu5ScwJ6ZFHzVMGH5SqJr2eduTf/mgLi2TtzgkahcA7bxpcSxBUrkP1IVCls1ExDaZLN5sQ9pHFUHVTN8GUqQfNOiCEI1OYMi1sc0wmwd3JzavM9910q5tx9yl2EprJ2hp+3BjFCeJlecT+loIJI8fx/SrgKkkZTInJMFbv7dCzrHxH5d7O4sMVYbXRFJ5nhZL9UNQKx6Nu5SWATOl/IFkHgNytSz4gVhgj2s/KfZVGf69iOpsk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 10:37:03AM +0100, Pankaj Raghav (Samsung) wrote: > From: Luis Chamberlain > > Set the file_ra_state->ra_pages in file_ra_state_init() to be at least > mapping_min_order of pages if the bdi->ra_pages is less than that. > > Signed-off-by: Luis Chamberlain > --- > mm/readahead.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/mm/readahead.c b/mm/readahead.c > index 2648ec4f0494..4fa7d0e65706 100644 > --- a/mm/readahead.c > +++ b/mm/readahead.c > @@ -138,7 +138,12 @@ > void > file_ra_state_init(struct file_ra_state *ra, struct address_space *mapping) > { > + unsigned int min_nrpages = mapping_min_folio_nrpages(mapping); > + unsigned int max_pages = inode_to_bdi(mapping->host)->io_pages; > + > ra->ra_pages = inode_to_bdi(mapping->host)->ra_pages; > + if (ra->ra_pages < min_nrpages && min_nrpages < max_pages) > + ra->ra_pages = min_nrpages; Why do we want to clamp readahead in this case to io_pages? We're still going to be allocating a min_order folio in the page cache, but it is far more efficient to initialise the entire folio all in a single readahead pass than it is to only partially fill it with data here and then have to issue and wait for more IO to bring the folio fully up to date before we can read out data out of it, right? -Dave. -- Dave Chinner david@fromorbit.com