From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5F94C4829A for ; Tue, 13 Feb 2024 21:19:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EDE88D0011; Tue, 13 Feb 2024 16:19:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 79D6D8D000E; Tue, 13 Feb 2024 16:19:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 665638D0011; Tue, 13 Feb 2024 16:19:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 547338D000E for ; Tue, 13 Feb 2024 16:19:30 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E227A1603BB for ; Tue, 13 Feb 2024 21:19:29 +0000 (UTC) X-FDA: 81788046858.14.ABB64EA Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf07.hostedemail.com (Postfix) with ESMTP id D8BE34001D for ; Tue, 13 Feb 2024 21:19:27 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=zqoOi2XD; spf=pass (imf07.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707859168; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gewUBLZJkZ832bNkMemwPNuP6AjEYnwmsKdeIxmXvlI=; b=d9YuFx6smLJ/uBAh5gdOlMLnknY5dBGcr7mNh0UGRmkum+mehvrZt3Q1De9nrENL4Vv8Z3 u992W14rszZQ/+XfeD/Di5hOz2v2KAhlPm8AHONk9RtxAfwga9wHG5U4MlsYeqaRqHGyOh ek+clFiGho61rKQW5eKQVL3pSs5/hNw= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=zqoOi2XD; spf=pass (imf07.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707859168; a=rsa-sha256; cv=none; b=W5zYj6P4i6ULCTywLwxdMPBMeAZJIAGIvuixDyVDcELAmtzaSxjrtrn22l6bL/QhqLP32F e4NWlthorfj6bGEGSh4AbbG7Gj5bLxwR9A9j4llzLHCaiYWqrVW3MY8T8fRaamPu7/pWwC D5JQWTuM9WT2YLyt54kfKrGjFAnW6Wc= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1db562438e0so819575ad.3 for ; Tue, 13 Feb 2024 13:19:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1707859166; x=1708463966; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gewUBLZJkZ832bNkMemwPNuP6AjEYnwmsKdeIxmXvlI=; b=zqoOi2XDTP9+4oGjUUB0Q5KJ7iJ87f2HA4tXjg30eX7745GwqcktTIN1auKKS/7Qwh F5lfbTK1fYIQXW765cm0ZjpUWmUlqqhWT7MDhVWiJlcUawXXQrSua+ISy4z2Uf/BqOus Re9Ma/Zaa4vgYz3xjQAbQz0kAex6u/i9UcFfpawV6y1lx94n0VrDFH4cf0hduTJemYRG I+rU56Xe/PoHRpkrmNCsHPsQWZiJGmkLPCAEcCaWbK29lGQoOvea9vID9DIFPGXl83rG 1NYCe3Kx/Z/4EB4n347haw3ZyuPHBRQZCHQH391OfM+SLExrPhRtC6A8NjAplM70jlOa XcAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707859166; x=1708463966; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gewUBLZJkZ832bNkMemwPNuP6AjEYnwmsKdeIxmXvlI=; b=vB9mcDgLwefi2VHOzVulv7UIt2sbz09HvGdPoQQ3QYGqWm8K/0c2LMpRSYB8yEJx5Y 9/5JTiVz9gpRWU8vXwIwLN7qKPrJR16M83X1RFERF0zvNQr6wK+yV0b4ef558PKr5Fnt NWSp7LqARjvofPNmnSS26GxP4+SPQJmyqJpYVATd905sBr0SiJTbGOCSPxQJL5gm66jH YjgK3oQMRkmFQ0ju8qKwuypV5Sj3++42SD4f8e4faEOHluDo2e0bu9SpP3aXAC/gJMaD aQyAicgMb8iKvM6HuWtuY8cxoQ4Q5yoE85WWi7Gd6ZdWNXoXd59GM18guJ+udjqJdYF1 hLpA== X-Forwarded-Encrypted: i=1; AJvYcCXfkh3es7YdIioMZzPQB+RfwXEb+8ytNxLRkEjzE664+bC87xye16D364TDD0iv1Mxs8+cZFQTG5Lajxm2C8pXd6nE= X-Gm-Message-State: AOJu0Yy43ZB+W+2Sr916s6eLc2fVE5kPtrOPGNUU8Ko//CSzIXNznU9m LLcsq4uuiz9VzNp7Si6NO3JYO8EJb+Qa6E7Cg80qLuKa3mi7SPIttib3cnahynI= X-Google-Smtp-Source: AGHT+IGLUSZXB3ylBDOhdlT0T3KZyXplzyMRS717PUcEqeBADrUjMdBE30QvnJ3A0SsgCKfJuXzdRA== X-Received: by 2002:a17:902:7c90:b0:1d8:e4b8:95e5 with SMTP id y16-20020a1709027c9000b001d8e4b895e5mr735185pll.32.1707859166637; Tue, 13 Feb 2024 13:19:26 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWO0TbDjhh/ndSsZJYVcwjhjhY0VK36KvnOtetues9rvO72mKN9S6yrohbe5HpmsHReSYH//kgA3cLVZxJSMxKOBS/2qAwhj/Ve3rjcJb72MNFOXoUbYL/1CHTiHPkUj3x8m/33hM3Sh4vq1BII/6HK8bXM3Mc+Yi72mVEPrASerHOqghSCpuXChXE6/J76YAtOSgKQzIE87VSXT8enpMMaMSj+ozTtytuBa4adQH6IY58agY4JRs+hnLXJzLmsg0ygeU0Hb0UpvuBuGvaPYhTsC2dXedD1qO8CynIO3MzKF6GndNboo1QM78YmrQ8do/9qEnP5vdEp/v481jEju4juRSj8dnYazah1MlNqE9Axz1VtwYEiLPIwFr1EaSFkyDujAUTN2jw/42pr6bDcyywOqMSEwl6dTczNiRo= Received: from dread.disaster.area (pa49-181-38-249.pa.nsw.optusnet.com.au. [49.181.38.249]) by smtp.gmail.com with ESMTPSA id e21-20020a170902d39500b001d8e5a3be8asm2466833pld.259.2024.02.13.13.19.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 13:19:26 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1ra0BX-0066dX-0Y; Wed, 14 Feb 2024 08:19:23 +1100 Date: Wed, 14 Feb 2024 08:19:23 +1100 From: Dave Chinner To: "Pankaj Raghav (Samsung)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, akpm@linux-foundation.org, kbusch@kernel.org, djwong@kernel.org, chandan.babu@oracle.com, p.raghav@samsung.com, linux-kernel@vger.kernel.org, hare@suse.de, willy@infradead.org, linux-mm@kvack.org Subject: Re: [RFC v2 13/14] xfs: add an experimental CONFIG_XFS_LBS option Message-ID: References: <20240213093713.1753368-1-kernel@pankajraghav.com> <20240213093713.1753368-14-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240213093713.1753368-14-kernel@pankajraghav.com> X-Rspamd-Queue-Id: D8BE34001D X-Rspam-User: X-Stat-Signature: 4i4w1z39cr79kgnmhbqfq997xhqqt4s6 X-Rspamd-Server: rspam01 X-HE-Tag: 1707859167-183547 X-HE-Meta: U2FsdGVkX18NHMAQigmpl8OTTGTL0fVt5L3/+EJu/25y02SQAqgh2zOq79hhTTTgKs6DVwPuGmLJBlNuF8KkeNkaMa0JMQ+hZnQi37t/7R2zb5GygBdGurNmR4FTlmYELByR6uVOLx9CSvuZt/oCtGRmWuDZ/Aqfxdeh0uwwTutLAMY+iybHyYyDndWOSIlh5fxHArvsJwMe2aclap56g4xYLEw8c/Hv9BCJUkjNwtPFkKQy43XhXcZUrWkwdYheVkiX5ZbQBRUDxKuii9Ldrp4KwK07tWDMV5e/2TEeeWdeNlSllCQChjo8wX5UK5j6hOwvWK5tjarwVYzjOPQ8Ddg7ghGhAgJJZ5d1zrP21+Tr9qmT0fjmwKC31hoy7AH+6WrHSeYfgPNdORkDXb2zCc+VZrkq64n6RHXGH5Z+6aiXpalodQyzFoW8ChUfUIIdeB045otJHClKdR+u40LyNX0mhdatrPVEWWXRVHhgEma/JtDL6lz02tcRr5o92gH7sRvq6bgXQ4lIrDHXKTmc9grvUMF9coTQm7IqzRbJgv4s1f94W9X+YilMRIEasATQ33tgNSplIkzRvO30wOBhHREBf/Qg77TxkRp4UyPDGH3Pur8+AvXGLaiNPXrKo9yFTM8u5HXgp2lOpT4y/fcDD4pnJTztTT5T57W6dYhxk0GUS3RvednN6oKNgtP0vsav2lJ+Hb3TOLtFYplUwCP7B+qw238Yfe9rH3gBtMKivgNg+HuiGtVcxx8DPNBFFSvXJXbO1dnlqHzxTy/Qj5WS4sTILAAhIw9jRUxUiqqCCZqDqHi8DFhjZhCaIJNxUl5Q7kxsYSylMrZqMPsiT7XxzwWzihGOAG2MudpBfbyzy9FQoN986AxJSTUGo7XIQ12RtLMmv5tGc2wFJi7MYLB9qOMgOWtL8FbR2XAzJN559sokQ0cRPQimtBbKZNpyZRBcUjadPgaRsyoCeifgmdT i4VVPFMx gfOpR47TbvuhTXeABe99reqcPfvZadeLMPMeyaRD02+iLBjy1MWEtUDdy+k5COvujcNX/hkELzJa+eJP+onEhi87kxr0F9xF7g6zzKAQ/NFXamFVFZ0k3UVNpZoCxJeS0g7vRWQ1GduSKn47s1o14ID3Al+hW+nFdIL6xZXdb2rcpFf8N498FZEWfR3lEGd2lQUifwV7sGP1+pWrVdjSH5U6BjW/byLwJupNvL7MTnPfXErpExd6QDRXA1LoudJKlCm+I7ZCjBqJHq+9+Ukpa/Gi16rH9EayXymx8wjIlva+lr+FumEsIKE3B3sZDbKIZEGgLZOK9S51lJFHPN5jyD40pvdT+YZTBM2TY908DDE/yjGLySKcK5eQMo0dCl7rQujpv1mu0P/MChxI9gUi5pb+KM399wyvvovS0sKtXYw/1Fbkf2C9p6b9fOiFU4YrZ5OIsgooaHmBGoK8AeNz0PV91JmJkgrGWaTEFZNKPCwvPw6vHYm846GBwj4aNxsegycQJZj7FxowaqWI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 10:37:12AM +0100, Pankaj Raghav (Samsung) wrote: > From: Pankaj Raghav > > Add an experimental CONFIG_XFS_LBS option to enable LBS support in XFS. > Retain the ASSERT for PAGE_SHIFT if CONFIG_XFS_LBS is not enabled. > > Signed-off-by: Pankaj Raghav NAK. There it no reason for this existing - the same code is run regardless of the state of this config variable just with a difference in min folio order. All it does is increase the test matrix arbitrarily - now we have two kernel configs we have to test and there's no good reason for doing that. -Dave. -- Dave Chinner david@fromorbit.com