From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AF2CC4829A for ; Tue, 13 Feb 2024 17:43:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF1738D000F; Tue, 13 Feb 2024 12:43:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA1418D0001; Tue, 13 Feb 2024 12:43:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D68A28D000F; Tue, 13 Feb 2024 12:43:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C55938D0001 for ; Tue, 13 Feb 2024 12:43:40 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 407CF40D09 for ; Tue, 13 Feb 2024 17:43:40 +0000 (UTC) X-FDA: 81787503000.16.E824456 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf19.hostedemail.com (Postfix) with ESMTP id 74AA61A0012 for ; Tue, 13 Feb 2024 17:43:38 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=T5m0fqVI; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of 3SarLZQoKCAI0qut0cjogfiqqing.eqonkpwz-oomxcem.qti@flex--yosryahmed.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3SarLZQoKCAI0qut0cjogfiqqing.eqonkpwz-oomxcem.qti@flex--yosryahmed.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707846218; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2KwJMEy4sS/qM3Y5N93JFeZraBwlubTDdqUKKmj/hdQ=; b=iwMqLvcuTjWJhDbnnJCjUr8gTBMBHYJ9g9HuE4caFhryUrHzNXyfeUrt1H/xjavgnngu9Q 1msFd/eApnBQj3hhLgpATVvnDW69xlbl6UrQrIHVQmQXcY40E6FXl3J7RnQnqNUDDmnM1u oATCe7dzdApeypUtnexuZgd+DJPL5Fk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=T5m0fqVI; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of 3SarLZQoKCAI0qut0cjogfiqqing.eqonkpwz-oomxcem.qti@flex--yosryahmed.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3SarLZQoKCAI0qut0cjogfiqqing.eqonkpwz-oomxcem.qti@flex--yosryahmed.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707846218; a=rsa-sha256; cv=none; b=A/bSG08QZvVgGSqO/gxJ0bPEwmsDZyJpNR7tThBiFAKO9fVbwN1+45zzE9C/J50RlvbglG 3P+Wm+cSsu91e6+gkNU8yzb+vbVHNQt8tSN/q0aRmIcOLM1RkRkCVC/KuJFUnwi+cudP40 p2skfHDTht+w71Z8eZHvyeI7Ey/MHc4= Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dcbfe1a42a4so3255110276.2 for ; Tue, 13 Feb 2024 09:43:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707846217; x=1708451017; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=2KwJMEy4sS/qM3Y5N93JFeZraBwlubTDdqUKKmj/hdQ=; b=T5m0fqVIuS+e+lghu6GXxBQU0nVXFD4GkBrZMcp1aS4bcJyOzE+Of2ENDEfiGnd7kL haAchg2BJxrwnSywniftb3oNQe4y+NfudmjD1MqS7bHhXaGb+OUXUutHdM1cMPTMaqsp a7ycCauQXOueNjxw697syHkONpl88qDn+YrfbyDLq3jv3qr6HlQynPFl6gQ4udGFfSkX /yUMuzV0sVl61ux/Y9VMVxLosyxn003x9+A6IZQXuwZtJOTGmiRTT8XsWkwKtJ/GwMyl x6MLsEupEjYjgubJ7lNUfMu0ktwS8lP2bzYj4STa4dOfupG8wTERKVW4/Go1AD2Aohax Jaqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707846217; x=1708451017; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2KwJMEy4sS/qM3Y5N93JFeZraBwlubTDdqUKKmj/hdQ=; b=kb2yY7Ew5DOI9tTagg7IiZnvJ3IrIQLJXHMzdbPQjlaiaHsWWxvv2L2LhyaX2J5FMq 71vf8yEU7QyOQiYXhimlGPPtTe3RqkdqwA+35r2WiP4lgCYVaSB5wiejR+lmxbFnT2zv jZHblDdt1MfXOxjrUVJDPpYlmBTAdmkValb6j21jAseV/MyMael73w3y9cac0+1VaP/S f0aY6wibChakPN+KfzEybOsQkqMOrwwNhkuM3Mfod/wTI4cKxEUzh+i9FzMaaReBJPgC KwMw09MOf2CpJNCcIXxMzpZpmH6ipllKeJqfAOzNYpobyeAc7TwEuxekMeL2LYDzFRFa 2biQ== X-Forwarded-Encrypted: i=1; AJvYcCWKZzQS9gL3gdssBiR2WVZlEGjvbCJDTk6bInwdOgn6Zm/1Sd61o6/2//qsI6lbeRMms0sVgO8eHRDPfV6tdOVK63E= X-Gm-Message-State: AOJu0YwthfLSH+uZKzCipCHFpEvvs1w8e5teVf6jf7q/osNritIdT7ub Nv2Ar1fofEfFO+/9upxFo9KbTrp4A+apKDBZfKi+hiJs+CSd70F2P4OwO94suL4P8huCnrBs16H PXkmwi1FIstaTS74Szw== X-Google-Smtp-Source: AGHT+IGlLBH/abZsC+jCB97eWiFSL+EQnp3tg/1z71JKyCYUkKCSbCluqfyE6etiG3YuwSx9HMgMW2+Rf/dUggc+ X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a05:6902:1109:b0:dc6:5396:c0d4 with SMTP id o9-20020a056902110900b00dc65396c0d4mr2952081ybu.1.1707846217557; Tue, 13 Feb 2024 09:43:37 -0800 (PST) Date: Tue, 13 Feb 2024 17:43:35 +0000 In-Reply-To: Mime-Version: 1.0 References: <20240210-zswap-global-lru-v1-0-853473d7b0da@bytedance.com> <20240210-zswap-global-lru-v1-1-853473d7b0da@bytedance.com> Message-ID: Subject: Re: [PATCH 1/2] mm/zswap: global lru and shrinker shared by all zswap_pools From: Yosry Ahmed To: Chengming Zhou Cc: Andrew Morton , Johannes Weiner , Nhat Pham , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 74AA61A0012 X-Stat-Signature: fy1p6ufgio4wmjfppq1ykq6nker6sz45 X-HE-Tag: 1707846218-469111 X-HE-Meta: U2FsdGVkX1/3m4MXZOFyVc3/kkDTEe1OUIu35xfGVAx5LBgjBhJKjPiJYjif7xnnpauS8bL5vSxLhvYJtluXtGMaUPjb7ywmNUwDgCbizwe2+gpXpNSO6XKFLGu1vgzF09DsumMspQ67Z9WSNFNDDZjPzSWNKHEUO403apcmK0+Jn1ADIWiv5NJdFzG6r8pPRo9f474Hgzpq254wbbMQRPxE5Y8Wj9FPZZtAczfrzHghiidHhsAoKB3L3a3X3iybfLfaVk5EET4lezWOfRpe8lM3kCs7K2b+RxvDKIL0SzXIEPFO2ugsBwIDOuxxiNMc3Fxq2XdnVYpe6Rcmu8kA3f7v0qQi3Uw1o+7pm2FpJRaJ8j+6dM+nuMnwW1VvN17YK2bOrhCfrt27w6GpDq8nlzOo4ZTmK3kytLZBR+EWgvH87jCezGfyfIt5wHdpkNbIgQnwfgTeiUEqqPq7lW+h8sFqxThhlaufM9tB0BcUVFecD/qJSoRvwlQ42S4gaX53sl+qv8UrFTObo9t5nYV6cWVUyJT/ZrA/rQHCyItMpuF7ieCVeSr/nV6A7JMXNz1xGfk8j/1Tk8sFXazZOdxrnzZ37vyBUjWw/ZDgwV26Zst67ZZHgZsTrrTQnrbkdAXhuqMy0FitMv0k0gkek1DjNdDv8DnZS+3RbyofLfoGyjb21MH5s0y2YLTyy+QRInr4Q00NIp6OgO1D5tLVvweEO9R7pnK5zYYv2xriZ/WO6MlBUqAZgroSWfMLh8VDrRgvlSE8ZigTgzi5PG0uh9L93a17NbcUfcKcyDnKjErWm/NV5fwbOn4JNxknIFawIC14RgPHRBnnfYtKHOVNrSx+iSy6d5FgIhsHC/8YdlnuA/DrNjSMTUVkdfdNyKKoYBmK3yr6vm64Zf/UiVM/uac4grm/k0TC4AtuT0SPc50P0sL75+eeifKkYKV+wKiusAf6ofrpt6kUGuUYvz/hfrA FjUXJB+r aX+jh0l4dPC6IAR6MpuXTqqozDmXFz13cV+PJJruMOdJEcKwl+c++S0meYVHTpZXYKjPY4Xyyg7IyHOX7nDvVeuEMxwvEX+rgJws4hsLPktkmr5pEhIEq4CvaIL4ZTA+IsVjWiIcCt947oIX9pl0Q6zAIWyMmxCXWDgXkFRNrnlupmS+IYuxlWRovpLRwz93LQC+KNWXxKF40kCkNiuD98J54YR0TkH1+mWmJs8y06qPHUM6yEdk6AqUbXrxy6K3tS6dN6PhzDKGob9O22VlCdISEmUytRiI41X4/VAnCYHktQOMqYPAlMXJbcjz+N+28OFLd8h55PpJddj8daoOJ1Jc5GmBMzpe2aHtYvXdnqpaDTlXTY+oT1ro723WL5qrX3b+D5DG4i+CxGSQNRvTemPJdqe3c1ExYHXfZ6lJ9sWR0vCtBSFQlse+jxbyQGnmvmGCxyc83VTq4syTfp1y0rSRSJLPhCs2kkD8ZOaKBe4EFfe/qfH5mZe0fNwvFcli4FUWrdUcZfdnqJCA+JFdDirA5kSfycfyEq6Y5Btm2rhHl4c4PEwZpjF2RT+3KgKHRzPMzb8TpY9CGQ5XKUP1HP4eBJoBu0dwSjf5t4EFF57OKGhhJ3vp0iBsULlq1iH5m0MJfIx+Zhy/JoOTtU+1uIIHWnFi9um+TSD+o X-Bogosity: Ham, tests=bogofilter, spamicity=0.000033, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > >> @@ -353,30 +353,16 @@ static struct zswap_pool *zswap_pool_create(char *type, char *compressor) > >> if (ret) > >> goto error; > >> > >> - zswap_alloc_shrinker(pool); > >> - if (!pool->shrinker) > >> - goto error; > >> - > >> - pr_debug("using %s compressor\n", pool->tfm_name); > >> - > > > > Why are we removing this debug print? This pr_debug() was introduced when dynamic zswap pools were introduced, and it was supposed to be printed right after the compressor is initialized. IOW, it is supposed to be after the call to cpuhp_state_add_instance() succeeds. The call to zswap_alloc_shrinker() was mistakenly added above that pr_debug() call. Anyway, I just realized you are now removing all failure cases between than pr_debug() and the zswap_pool_debug() below, so there is no need to keep both. You are right. I am wondering if these debug prints are useful at all now, but that's a question for another day :)