From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E3A4C4829A for ; Tue, 13 Feb 2024 16:55:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CBE28D0016; Tue, 13 Feb 2024 11:55:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 97D318D000E; Tue, 13 Feb 2024 11:55:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81CC18D0016; Tue, 13 Feb 2024 11:55:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6F45B8D000E for ; Tue, 13 Feb 2024 11:55:58 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 370E980A42 for ; Tue, 13 Feb 2024 16:55:58 +0000 (UTC) X-FDA: 81787382796.11.CAE1E62 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf09.hostedemail.com (Postfix) with ESMTP id 6D47714003B for ; Tue, 13 Feb 2024 16:55:56 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of mark.rutland@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=mark.rutland@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707843356; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pKy9PTkFCzw9Fg7LIOJJ205iugMhHVEDB4xfQm61ZR8=; b=Br/iGVgOwVD6EryRaOFADXliUst/jEm08OMtS735RC6C4Mx94bm0ZcHGoXxFSDQ7tQ/fjH lFF/CNubAuT8fgiPpFSc6In07iIT6Xy0E756eIp/HTeM5EOuEDU1UXnQM98nb8QTUHhIQD 6ykJeK8EPzJEAr+NgVENE/wwo5JWF4s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707843356; a=rsa-sha256; cv=none; b=NhmO88Xui3lvoElB3uJNhoZ8DgXji4E+N68abn0TQWyxqKi1o8nEfEHANVN89LVgkBOVA/ KsSo4pQ0ScgMRMsXoTH20Nrsz2u6Fzi9lkcJLToyxsgh7g9vUZrFvuCD207zRT1eqdTmJs OOWNmnNaN/a1WeLcu/RA7xVFFE01VsA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of mark.rutland@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=mark.rutland@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6FC74DA7; Tue, 13 Feb 2024 08:56:36 -0800 (PST) Received: from FVFF77S0Q05N.cambridge.arm.com (FVFF77S0Q05N.cambridge.arm.com [10.1.36.130]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6CD3D3F5A1; Tue, 13 Feb 2024 08:55:51 -0800 (PST) Date: Tue, 13 Feb 2024 16:55:49 +0000 From: Mark Rutland To: Ryan Roberts Cc: Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , James Morse , Andrey Ryabinin , Andrew Morton , Matthew Wilcox , David Hildenbrand , Kefeng Wang , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 24/25] arm64/mm: __always_inline to improve fork() perf Message-ID: References: <20240202080756.1453939-1-ryan.roberts@arm.com> <20240202080756.1453939-25-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240202080756.1453939-25-ryan.roberts@arm.com> X-Rspamd-Queue-Id: 6D47714003B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: b4bt7s36jx7gapa1ngz8hj631orexjif X-HE-Tag: 1707843356-325938 X-HE-Meta: U2FsdGVkX1/y1fV1GFdY2m4BcvDDUavjATlXXW5norb5yja2soUojnb8NCWLC2NN4TojDOX3xZKkGBR/B9Igrqxj1WwL83lKPRbECb3M1tVBxSTZ6pcmbg+ZkTHEFvUCTL+u6fSS5MlRF2M97dwlHC6Ehkmme0I7Aav9IoghDL8b43RW+aV4L8mQyxiTE1DIrbt97mnMqY8Ac3U8+CHMMKpVO0WvY97g+sE1H5RBgwop2h03S/jDvIL3cBp8iACWaMAAl3GJ4d1Gu/ijzqUDRsb3x3YkVFhqNMZy8qTF4/orB7IfMmiDFTyOpu+ljSCUPZndX2r8z7saWJLrrAi/DT9+DaQS0ssk3su81mADsyAkI0ykXSCx+qbA3Lx2q2Uybr05lWybs7WrEFSciyq97nTTxz65F6kYoDNFNjTluYCw70infQ4xLlUkVzOtlM17ZJFROmH/o31KRk33BH8Qou+HKfYw3opTM/pmChKdLCumOmpTbIZBlcuj7/pWJJM02Cv4ItkAzY4GJS7RGrFrQPKDhLb+gYqOeKJKO9gMBDkng49QmxMmwKL7usbtuISa6yhv/FYXqBNUPGk9eaX/QTNJzHS54yrkdiooX4uwRF2RUc61c6G+Qp6ojvkUeW+iI6jp3FvxJpXk17hNGcX2WuOiXWieeQfssIg0pWVz0WrxD90Ev6YaEAzuQe47kB9EGIzKQm0LXSDuR9edy8vdi5gECCOrYztmXfMxzWQkYAtMI4Dr+AIfStW66dqFazfrr3me16ZYseVa8Uwy2fuFG66tfhC4wr/aWeQwHvJI1RRQ1BFJW4LOoFKbb3jH9uEZjAeoXM76N5YxGF5FrJ3J6dUT0HCEobd94AFBq5AC7A/cZLURXm/2SXGsHpmD9I/Pgw5pDku1PQzJ98eCUPf1Z1OK+XgzYRMwTRTohJkNOXeT0mlMNVAVX5ocOPk8AmbjD3CdLQcyDDvnS6w8asV 8Qhv8lUM /JSZlqQcmkSM3pmtUTrOnXqMg0sSGZAVEctGEWPobfLrRKxQdQhefLJhflRPJQyfRgvyqmc7SQOTmKWJI3ZfsPO+KOX/p/xAxNEJgS7lUnpiSRJnt9cncVQ/LGVBou+Xqep6LDtE5peeG0EY5YMbKC/MBNA5JPrSr/sIbVA8evsbNOxVMinLeRjayinmGqqMXucnOe+W+HSxAL3BUBUZV9fHuX1scZ/ro3d3VbhGjfHTqWYFySPqtHIYaSxqH2UJEPHYZls//IF9z9BtVfetCxrq7hSMYawJnQLFxOC+afQgZaulFR/flCekioC/JeejEHP7kptqyBWnShRvnTHzfgljLtkDw9EkqO/+6/PwnzqjAyYJiCGgLJ3U4RznhqfCBd0PP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 02, 2024 at 08:07:55AM +0000, Ryan Roberts wrote: > As set_ptes() and wrprotect_ptes() become a bit more complex, the > compiler may choose not to inline them. But this is critical for fork() > performance. So mark the functions, along with contpte_try_unfold() > which is called by them, as __always_inline. This is worth ~1% on the > fork() microbenchmark with order-0 folios (the common case). > > Signed-off-by: Ryan Roberts I have no strong feelings either way on this, so: Acked-by: Mark Rutland Mark. > --- > arch/arm64/include/asm/pgtable.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index 353ea67b5d75..cdc310880a3b 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -1213,8 +1213,8 @@ extern int contpte_ptep_set_access_flags(struct vm_area_struct *vma, > unsigned long addr, pte_t *ptep, > pte_t entry, int dirty); > > -static inline void contpte_try_unfold(struct mm_struct *mm, unsigned long addr, > - pte_t *ptep, pte_t pte) > +static __always_inline void contpte_try_unfold(struct mm_struct *mm, > + unsigned long addr, pte_t *ptep, pte_t pte) > { > if (unlikely(pte_valid_cont(pte))) > __contpte_try_unfold(mm, addr, ptep, pte); > @@ -1279,7 +1279,7 @@ static inline void set_pte(pte_t *ptep, pte_t pte) > } > > #define set_ptes set_ptes > -static inline void set_ptes(struct mm_struct *mm, unsigned long addr, > +static __always_inline void set_ptes(struct mm_struct *mm, unsigned long addr, > pte_t *ptep, pte_t pte, unsigned int nr) > { > pte = pte_mknoncont(pte); > @@ -1361,8 +1361,8 @@ static inline int ptep_clear_flush_young(struct vm_area_struct *vma, > } > > #define wrprotect_ptes wrprotect_ptes > -static inline void wrprotect_ptes(struct mm_struct *mm, unsigned long addr, > - pte_t *ptep, unsigned int nr) > +static __always_inline void wrprotect_ptes(struct mm_struct *mm, > + unsigned long addr, pte_t *ptep, unsigned int nr) > { > if (likely(nr == 1)) { > /* > -- > 2.25.1 >