From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FA71C4829A for ; Tue, 13 Feb 2024 16:04:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A81AF8D000F; Tue, 13 Feb 2024 11:04:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A31B58D0001; Tue, 13 Feb 2024 11:04:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8AB8C8D000F; Tue, 13 Feb 2024 11:04:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7BA728D0001 for ; Tue, 13 Feb 2024 11:04:06 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5E33EA1997 for ; Tue, 13 Feb 2024 16:04:06 +0000 (UTC) X-FDA: 81787252092.13.E874779 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf08.hostedemail.com (Postfix) with ESMTP id CEBAC16002E for ; Tue, 13 Feb 2024 16:03:35 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Zy+f35Fj; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=FE8XoO3Y; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Zy+f35Fj; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=FE8XoO3Y; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf08.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707840216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FRNhjJkgXL7v16ZU0iS2vdAZzEHkrAUpw4bf8r6ZDEw=; b=z6+MEW6lMUc/4oR5YzbLYzPHLQnjqasX3L1XT0JS4ZNtpyEBsmE7WfBoOtVnBKciB9xkZi PNXEndZNlkH5QGGt8InubnXJwwlCk+q3YlYMrKyNXuFoK14oYsLtjpYJTHb6/wLCXhMDyC cXdDm3TDcMXbhjhOG9lktgD7G+Y07DY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Zy+f35Fj; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=FE8XoO3Y; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Zy+f35Fj; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=FE8XoO3Y; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf08.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707840216; a=rsa-sha256; cv=none; b=ew/O4XC5Gxe706szR8+afVnWKKCHN/m4AmPSmR2DmBTbgt6vrK6Jcl13nHlmv7sy7I/lK/ vPFjt9ysHdIC8/LOzxo/qHybY6u+OsA3xuDv7zZ4uT+iofgGDjG/i3kxzKM3cwu67WmjbJ eh/Ar6SGEkqgJpkEdG1Eh3x8XgA9y3c= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CC1A01FCE6; Tue, 13 Feb 2024 16:03:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707840213; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FRNhjJkgXL7v16ZU0iS2vdAZzEHkrAUpw4bf8r6ZDEw=; b=Zy+f35FjpVmxtg237HXhU3wXU4q82NcWwOfCXnQm6NcCnHtYS8itTBh5i9ty1JqgapXpIu mC3lB2vZ/C9YdPgoytALScmPR/UDV1uYoHrmOdux1SFNrNZKrD+IgPYIqobqsOYR9M26BT jwAWpjb+cBrbDmJ5qlfl2lFoozubtEg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707840213; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FRNhjJkgXL7v16ZU0iS2vdAZzEHkrAUpw4bf8r6ZDEw=; b=FE8XoO3YAebclHOu7Kze9qUhPPIPinRmWaprVrIK6Q8n0kkOLGEEUQoD/aLo1zdKLXMUMY lhf37WClN5sYdNDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707840213; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FRNhjJkgXL7v16ZU0iS2vdAZzEHkrAUpw4bf8r6ZDEw=; b=Zy+f35FjpVmxtg237HXhU3wXU4q82NcWwOfCXnQm6NcCnHtYS8itTBh5i9ty1JqgapXpIu mC3lB2vZ/C9YdPgoytALScmPR/UDV1uYoHrmOdux1SFNrNZKrD+IgPYIqobqsOYR9M26BT jwAWpjb+cBrbDmJ5qlfl2lFoozubtEg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707840213; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FRNhjJkgXL7v16ZU0iS2vdAZzEHkrAUpw4bf8r6ZDEw=; b=FE8XoO3YAebclHOu7Kze9qUhPPIPinRmWaprVrIK6Q8n0kkOLGEEUQoD/aLo1zdKLXMUMY lhf37WClN5sYdNDg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 545EE1329E; Tue, 13 Feb 2024 16:03:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id kUPbEdWSy2VSBQAAn2gu4w (envelope-from ); Tue, 13 Feb 2024 16:03:33 +0000 Date: Tue, 13 Feb 2024 17:04:38 +0100 From: Oscar Salvador To: Vlastimil Babka Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Marco Elver , Andrey Konovalov , Alexander Potapenko Subject: Re: [PATCH v8 2/5] mm,page_owner: Implement the tracking of the stacks count Message-ID: References: <20240212223029.30769-1-osalvador@suse.de> <20240212223029.30769-3-osalvador@suse.de> <8ff46f99-d167-448f-9aae-a634b8aae4d0@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: CEBAC16002E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: t6b5gd54rjzhkwxt8srkqiqhbohjo5oe X-HE-Tag: 1707840215-476656 X-HE-Meta: U2FsdGVkX197yrffVLuvQ3ZeQKDmy4DIGRF8pyXbX9Ijn6f+PJy1jZ35NqIIMZQD4sxur4ZAFkSMaoQPXMoUlSV+1qkjqfCU6JtNLmOl9iu2R8K40OdSHljCIm/KFDFdfhuq3AlZ4KRKnzKKr0nv71fhbkdCZI0Aye3aJQ3PGBa7lcMuutJf28dIMa6Q5qn/mOmYAuIOFJvAktV0n4KdIrRloAtmwU5USowK8CcGM8FsIx2ozfMrlLz85cknyEUGd1VL3XrwFtWj+ZtxESz4k8mhgIcY5Ab2RU2eCSBKEMTf3BXr+xhrjy2CtkZvOiwC4tadChojimz9ZmNxwUYep3Qxhw5xTjW4k0wB6GiZEZIZCMNmQHJYAO4UgwXtqrQ/BPRwj9YV1k4teEdflK6SX9yQDou55QY7keuSLChzjQjaxWw6HHdj04qMkTzYq/7//qcO94QU6627UmkQMTm1eB5zhpS2c4Dgn7ulcVy3oI1lMN5Aly1wlyfuo1xMa+NAHnApNfoKhxtd8XgTZAtfbustEVleoIWCSiqlWmPTaWSztNvmCTk9GdzUtq3p8bzg9or/4FZJbEcN6eMotoDdn4Wb2XP0Mvzw5lNP2q24qTmSTbKgRoacYer02TsxjExvyQzDUmJ3A2S7cc/aWLhEIZVvt0DPGOf2bltiVlS5nGXW/nI8E4fSPx21/wmJfFMzbPseu103sWmo3OsHqw6iF8pNE1YU0F3S9n2aDCG9gj3MzM0ZghZizgXE2r236bZzgtM1PMLfmpUTXJtdcVsG7Ooqvd34zjFPeA9mMZgz1EupzkUaatIf/TZSjAM+DSg64EqBSZvWKeJ2iNaEzNwDpBnwaRzBLUVtv6IvaLGMNhHZu2Qf/80fXXrXf9aoC/GVZvdP1NXq270KvcY4LogGScRHNpDaagWeY68hHUHJPY7dtl9px1WkkOtS73buVebUCaarsE2fOwizSybKrJu ziOSh5N6 wpUUV9JPyJll2iu9eR9w7SOD3zGNGXwvAjgGq1VA0NL9kWimM8FIhepIYJhPidXCRYbvD7hBZvc6p06+FbcudG/k20kqCQQ6SX+8JttVJ+/bkLs5p8Sgi3OcbW3zICl5gvc+CfsewUo7AeUfMiAUI4DfsHkhtUB7yfW1wLYVZuCdBSpJy/1CMYLdCKngWA64oZJGhYmf9UNFiO6uKY1JTtPuMxsbV8oNsZhum7Rhjyp4SuYEllke5nuZ9ee5mmaBfFMYi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 04:29:28PM +0100, Oscar Salvador wrote: > I thought about giving them a refcount of 1, because we only print > stacks which refcount > 1 anyways, but setting it to 0 has comes with > the advantage of catching spurious increments, should someone call > refcount_inc on those (which should not really happen). On a second thought, I think we want a refcount of 1 for these stacks at the beginning. So should we e.g: re-enter page_owner, we would increment dummy_stack's refcount. If refcount is 0, we will get a warning. -- Oscar Salvador SUSE Labs