From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 787E0C4829A for ; Tue, 13 Feb 2024 09:15:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E84686B006E; Tue, 13 Feb 2024 04:15:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E339C8D0001; Tue, 13 Feb 2024 04:15:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD3C86B007D; Tue, 13 Feb 2024 04:15:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BCA2F6B006E for ; Tue, 13 Feb 2024 04:15:37 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 80FC51205A6 for ; Tue, 13 Feb 2024 09:15:37 +0000 (UTC) X-FDA: 81786222714.29.D496DA8 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf21.hostedemail.com (Postfix) with ESMTP id 3ADDC1C0004 for ; Tue, 13 Feb 2024 09:15:34 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WB8gtpV+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=W12NEeOO; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DLq09Ear; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ucbYrPw9; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707815735; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G2rOmls9bl9Zcz0eoq23xATUmZNLd2aQXwncrMMfP6Q=; b=WyVQDHSP4wbI1lxbGzxYoO0RcurVYQPy1elyBcoOKynQLeEG3l61MPWHKE43RxN5JCXzfo oPX9GvYOBQNngKYfZf76RGRGyLumPPiMCr7PODGE+sNmdaIvp2E8IeklWiKpJU67pYHRnw hj9a5uCWHPSAU3YyHJnc5dWPKaOgvKc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WB8gtpV+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=W12NEeOO; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DLq09Ear; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ucbYrPw9; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707815735; a=rsa-sha256; cv=none; b=g0gDsn5bvlH3uMPXaaMPP6at3G8Md7J3WY8SIssw3vh2MC+UryZF3i8MzWTI0x3o5zynY4 wjJup8f7A2tL6pvzY5JlNn9HNM6hM19xAfZiWpm3d8PXgJYXskDcMm9uWIUf2j8fE44BUZ w4LHSfpsfz87vpWbx2X1buzozrOhOao= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 847B32116D; Tue, 13 Feb 2024 09:15:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707815733; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G2rOmls9bl9Zcz0eoq23xATUmZNLd2aQXwncrMMfP6Q=; b=WB8gtpV+5r8bQwRrN625be2/rKvHQt9uT8EgvcusbnwKj8yXo518mXn/uuJKnJkGgY/9e9 /hdaW9I1qNUU7kx+8ifCVMdhq/83TcqdtG86n40DbS3vKRhPkwNzI8fIFrxPicZGU4atju zlNYRfCM3DenSLkiBDB3E7/fM1GrtsU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707815733; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G2rOmls9bl9Zcz0eoq23xATUmZNLd2aQXwncrMMfP6Q=; b=W12NEeOOVD3ON0NpTmtSX8KXDy77lEDzMUms8HpbJZp34LgWhkaE79qjaVBLg2SPy7b1jX BRV42h+3cKZZnDCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707815732; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G2rOmls9bl9Zcz0eoq23xATUmZNLd2aQXwncrMMfP6Q=; b=DLq09EarOij1+YF93pF4GDTxvYCoh2E8KQdgvsuDW8qX9XR/IWtjR7tu0FdKmSlxVEboox dj8sDEiiW6HCvpsuTU9SZXedtG7OQMvuAFH09oP9u0RZKmvT1Gljml7WNKtATw6ROlm1wz fhn7aUytJpMYKT6H5OsEsPZ66Nd4zjE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707815732; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G2rOmls9bl9Zcz0eoq23xATUmZNLd2aQXwncrMMfP6Q=; b=ucbYrPw9opZ9pO0fWUfJB5ZoEEkVkx59BZoT6xgukf3gpXfabKs9Hh1KnlqcfOepeGk6ld vlPTv/scdxuj1vDA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 081A613A0E; Tue, 13 Feb 2024 09:15:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id xfAIOjMzy2WbHwAAn2gu4w (envelope-from ); Tue, 13 Feb 2024 09:15:31 +0000 Date: Tue, 13 Feb 2024 10:16:41 +0100 From: Oscar Salvador To: Marco Elver Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Andrey Konovalov , Alexander Potapenko Subject: Re: [PATCH v8 2/5] mm,page_owner: Implement the tracking of the stacks count Message-ID: References: <20240212223029.30769-1-osalvador@suse.de> <20240212223029.30769-3-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 3ADDC1C0004 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 4awbuamrn59p61ggz4b4f1n3jbto6yqj X-HE-Tag: 1707815734-120832 X-HE-Meta: U2FsdGVkX1/SwqZcx1mufRqiYJ1Dc7cO5jEB1WOVHmQpkvZuCBAXqtcx1y2rUrmkoRs7Cpe3o8KmmLiQAC/14DR4djo/YMeTAgCmM7U+R7eUYoUn5yEq/W6sZVUTW216MyGYzPSj/jGDmITEfyKZCTGmPCnuitW2NsuPTy7GC1COkqZ+N1qwE1o5M7dBjjix24lFPSVYqDrrBihSl5Nm5J/E9pnJrpFt2t9SDCRC5rXWIB4urY/QGAbIeTz7ffEHBZ/OLNnQXMw0QIn691fzIVT4zuUlJXFVXClIrhm97JLz4m6LF+vbQw8V8PCYAYFxj2KQRu0MLRw3KYKslP4uP5YLOxBiQcjpZwsvpmxTIKohERg0iWAafGpSjZirhKrI0WsFVc+iHs/mZdCy9zAAEa1wl/lQpEtGE/CaYtvp9jbN6uzdGVSimIHKtijxxSh6aqvv+0IBx173qBm18guCcvc2ClkflOYNFAT1IuQQJ6eaP5SD8WXcp1uC8PKJe/ajIiDjWBFo7ZrunYWvRPnKo/K+s7u9GqIOEM14TIsfS+hd/3J1tENde0Jw/JSrcpuJ50gNyjy8Rd0TQWmzdieV4T1uLJN0qoSPzSFT6G9ei5zV18LytJvujDDGXcqSb91KSetWhiJMSLjtsf68Y/8kz5t8d/REIuB0l2GjvmRbilVZRRCDzmDYe6b6OaeztT8fZiHyqNhmHCWHddtkmWAW62I3vF3HkIFz1gffhkVpNGimkaWKc5EQG7Rg09YfDAdP/to2zMbyrn5dVMNFHWeoBTjPLCUrHO1p5mKVpSuKkEFFSHy4sV6AMfG7ppBr0NRjwxwrxPBCN90eFWDBLp2CjhbvfxF+pnbJS/FYxLvObDRoWyRgE8lw4S38cnYfWjMny+n/iUCSO+lbfhpgEhLJWE0XoojMy1U7rjBkB4dNNsZK9URJ/Wq9W8sU2bJP7iK8ddmvF6bJsCePlAeooPf Q6gsmazx rKaJdq4fKr/5ClFtCOHt9+0iMxntigeR6Xkx4NJv1ke/0rJM1Xd7/scc8rqZxZ4dYFT6UiaoaqwB06n3h+NViJdhQjH72HMWBX/sEzsS3OSkAQ1aOSF6K+NhVw0ZxGixPyVijkl73+I4HGYRff3eWAJuqZfSomg6vPZfIoMy2xnm0Ge8COMvO2D2jaxuveNdReGeGFpNerUruQZDtp4C4SguMK/NIHXo/fKdLhURMM+826yBdebtz2MNggY7umT+gfUsOCgh9eyjYuR68dCEhAZs4RQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 09:30:25AM +0100, Marco Elver wrote: > On Mon, 12 Feb 2024 at 23:29, Oscar Salvador wrote: > > Signed-off-by: Oscar Salvador > > For the code: > > Reviewed-by: Marco Elver Thanks! > But see minor comments below. > > +/** > > + * __stack_depot_get_stack_record - Get a pointer to a stack_record struct > > + * This function is only for internal purposes. > > I think the body of the kernel doc needs to go after argument declarations. I see. I will amend that. > > +static void add_stack_record_to_list(struct stack_record *stack_record) > > +{ > > + unsigned long flags; > > + struct stack *stack; > > + > > + stack = kmalloc(sizeof(*stack), GFP_KERNEL); > > + if (stack) { > > It's usually more elegant to write > > if (!stack) > return; > > If the rest of the function is conditional. Yeah, probably better to save some identation. > > + if (stack_record) { > > + /* > > + * New stack_record's that do not use STACK_DEPOT_FLAG_GET start > > + * with REFCOUNT_SATURATED to catch spurious increments of their > > + * refcount. > > + * Since we do not use STACK_DEPOT_FLAG_{GET,PUT} API, let us > > I think I mentioned this in the other email, there is no > STACK_DEPOT_FLAG_PUT, only stack_depot_put(). Yes, you did. This was an oversight. I will fix that. Thanks for the feedback Marco! -- Oscar Salvador SUSE Labs