From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF50BC48260 for ; Tue, 13 Feb 2024 09:42:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F42F8D000F; Tue, 13 Feb 2024 04:42:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A1998D0001; Tue, 13 Feb 2024 04:42:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 242CD8D000F; Tue, 13 Feb 2024 04:42:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 118258D0001 for ; Tue, 13 Feb 2024 04:42:33 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D9A331A0B30 for ; Tue, 13 Feb 2024 09:42:32 +0000 (UTC) X-FDA: 81786290544.04.BB1F6E0 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf05.hostedemail.com (Postfix) with ESMTP id BE970100010 for ; Tue, 13 Feb 2024 09:42:29 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=PxGx4mjI; dkim=pass header.d=suse.com header.s=susede1 header.b=DllEvvoi; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf05.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707817350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e2Ltw12kqpA6OxvwDncuH/HwlbdCgZy0yfwT2wFnJeI=; b=IMkeWrUgqhdFbnX5HJ815tyfZVcRPdLDWVaQjxZ/fkfdRwgZXENKcxxMThcMAWQxa48IfA +puftirEA0l4hySpOFxT/ExBYaGxQkVqJ4AvwQ935XD5VGCp604OScbuZm8LfuQbXLeZdo 3VWLWH8fz5Z6JCHjK25hLb+s8dKOqvU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=PxGx4mjI; dkim=pass header.d=suse.com header.s=susede1 header.b=DllEvvoi; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf05.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707817350; a=rsa-sha256; cv=none; b=DD0RKH0M4sLVyNq7DuG5x8+xLvkDHrCVwNtTV1efiEXVqAOdXiYekee5Ee5X45UDeX36xN 5gglw3Lf3iHJRYbKmtcOBGTy0GvZ9z3mY2VEnPIbTx+2Vtpj8SZii7ms0l4YtdgdbWcXva ilNwnzn1KghWSzQXX80yCmz9B6YHtcs= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id ED45F1FC81; Tue, 13 Feb 2024 09:42:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1707817348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e2Ltw12kqpA6OxvwDncuH/HwlbdCgZy0yfwT2wFnJeI=; b=PxGx4mjIyTfC5qkijDQ3F7ewptxWcNNvw/5AwqogaCDSrwUGuiddySK7UNzHm5ZyUI5yju 3OpEPOPoimtCqrbNiO9m96DBgvQuZ9/Kx6hub8QfM6HItxfNsvsJApA0jAJz+CYCrprns0 uFLipUkmHrCUtIv2sxyogGEGQ9X2hQY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1707817347; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e2Ltw12kqpA6OxvwDncuH/HwlbdCgZy0yfwT2wFnJeI=; b=DllEvvoiBQpim82m7fFn3FEJrkiQnFxNNdXKl0fo3lcDWOuJ74M5VE2PvNGKT/I8MKfDqS jBf5tlEEwBWkRCpNPEbbX2pM/W6iuhj02h4Kt/3bW70l3jjkYwTBFbTsbKHMx3GB51gwLG nj5nBNP9jAzq8GcP6An2pi5nYT1O0tk= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D4C1A13A69; Tue, 13 Feb 2024 09:42:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id B5n2MIM5y2UOXQAAD6G6ig (envelope-from ); Tue, 13 Feb 2024 09:42:27 +0000 Date: Tue, 13 Feb 2024 10:42:27 +0100 From: Michal Hocko To: Johannes Weiner Cc: Andrew Morton , Shakeel Butt , Roman Gushchin , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Jonas =?iso-8859-1?Q?Sch=E4fer?= , Narcis Garcia , Yosry Ahmed Subject: Re: [PATCH] mm: memcontrol: clarify swapaccount=0 deprecation warning Message-ID: References: <20240213081634.3652326-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240213081634.3652326-1-hannes@cmpxchg.org> X-Rspam-User: X-Stat-Signature: goi73kksy17geh545oqwgc7eu51giwiz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BE970100010 X-HE-Tag: 1707817349-756048 X-HE-Meta: U2FsdGVkX1/y0dv5ZHOb/LR15KerTr+Wi49u0Dp4OQ1tofCdJavEZlw8lslLOaLETJQq2jG9zoCCsw1uHMbffT7Fqf0JqpIq+oUp2DdJhb+b5fWg3cILCNGFnAWAMqr6NeOR+ZP3bN1E3awXn6KEAov5ttflTQ+G4kyQzPuo4lEkhFJFc5+CA6MiF0WUy+vWNu4XBxiUmV4uhCaeoLWX9ktLEt/c1ypsYnT09Z3ZsgEQOLXnACKAIBhnDJj2nJ1mzStaQJ7O9az77gPV6iBzjklyq+AKat/KdrIat91+ZEXJHGeEUHI2ffU9vVbBk9WdWWepU1myM3jSiqj9mS0bCU0UeNR553J+MhP6aVX5XNzvYmJW6SlAFmRDuovwDSlsIcTooIYl9IcLZQ4iSNBdzCfDAGnE5x1snIIcTvvJFxUfWe+nQbQyFks6pGua3cn+/GMIOVTBOegnZCu0KoGZSbM1qtoNNL0uV0Kz3nw3XY3GQKAeE4F1cR1bMBBDZciqcj77Uivrje2r4vimL8Onn2/+KzzjNTEQtjH2TMpbpevJX40fw9HttmzXeYdxjEEjjB4UMPfMQDwVMLt8QndhKmgeVhyRUFH2tm9gnoXenYRbpqK5pU7uirMQwmMTg2j/U3rJkjdpGPtGYxKe3HXeop06PHTgA8r8+xy54uAVdpFEAD1znWXot4nwAIYrHwA9HrsigfJejfr4x/DOo5brrmPg8XZS8GaMcqxb74ah0S3w3MMSKag+FgiOcE50Q3jgercxq1F8fZWdDmVpG4YFraM3MC6fjx0ks1cF2r/52KIS1gvp6kmD5s5+Wh+qEn1a0v/S5lAHJLmF6pBqRsRhNivQRf2HAp1/iOjph2kWsiMpPlKIyKa6bL0nGxMYmUoojjhA9KFxispf2t5DwA9vm0E34GRc1yrbCmnvc/quFBiz3C/3b2hri+CTtZAM28frW0Bfm1L9b8sLfnGdqOy b+fGl5bH tnQgotAv/nabYWQsz677H7jEo7llKzr5UOhyiAReIq16mdoXU4PkkqmWIxxXHztpB1iIH8oNnirLZnfI94tumACfrANy87L+xQDJ3iaMogznHdSFhh0Cgw36WPyzNFHQA9Cgxj1WuNepvd0C4T1rYqUO28pTFp3sawZUM4NNpmXsqVDv2Y+SCnc3Jo9EP1Ca9xiwKtS6OJ7VeHcsTi2yiDRi8N443qEsfguEnILfuX7HZTG5Gm0V8fhuerG7Iaf5Tc8O/H4etWKxunPrW5PzHSsTH4RB1qAt2WbV02qg/hbKx5z4QUhVzgTaeWhGT2ZzuoeJmQYA2flLQMTQaZwHewQWuMKliw6DEXySTkN19kuZYlPGgiG1kL3E+TQX7b7BAjUlfSGr70XJDtA0jSWCQT3p9YCdvLuMAeHXntHtdJACa5DMlci/4hzeWs5S7exQwvjBS8rm5VtK8xp/pH/QZrx4JbM0BrLbaCd28sa+bJiOh09q2HmJuovIuXLie8asmKc/PTFRmVeUSbynZdRCrregZ+bUXQSnr5IhsHEvz1jrQ1qYnLtv1hPUCWg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 13-02-24 03:16:34, Johannes Weiner wrote: > The swapaccount deprecation warning is throwing false positives. Since > we deprecated the knob and defaulted to enabling, the only reports > we've been getting are from folks that set swapaccount=1. While this > is a nice affirmation that always-enabling was the right choice, we > certainly don't want to warn when users request the supported mode. > > Only warn when disabling is requested, and clarify the warning. > > Fixes: b25806dcd3d5 ("mm: memcontrol: deprecate swapaccounting=0 mode") > Cc: stable@vger.kernel.org > Reported-by: "Jonas Schäfer" > Reported-by: Narcis Garcia > Suggested-by: Yosry Ahmed > Signed-off-by: Johannes Weiner Acked-by: Michal Hocko Thanks! > --- > mm/memcontrol.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 1ed40f9d3a27..107ec5d36819 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -7971,9 +7971,13 @@ bool mem_cgroup_swap_full(struct folio *folio) > > static int __init setup_swap_account(char *s) > { > - pr_warn_once("The swapaccount= commandline option is deprecated. " > - "Please report your usecase to linux-mm@kvack.org if you " > - "depend on this functionality.\n"); > + bool res; > + > + if (!kstrtobool(s, &res) && !res) > + pr_warn_once("The swapaccount=0 commdandline option is deprecated " > + "in favor of configuring swap control via cgroupfs. " > + "Please report your usecase to linux-mm@kvack.org if you " > + "depend on this functionality.\n"); > return 1; > } > __setup("swapaccount=", setup_swap_account); > -- > 2.43.0 -- Michal Hocko SUSE Labs