From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BD52C48260 for ; Tue, 13 Feb 2024 09:20:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EAF6B8D0002; Tue, 13 Feb 2024 04:20:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E38008D0001; Tue, 13 Feb 2024 04:20:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB1C58D0002; Tue, 13 Feb 2024 04:20:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B80578D0001 for ; Tue, 13 Feb 2024 04:20:44 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8DB6E120AD2 for ; Tue, 13 Feb 2024 09:20:44 +0000 (UTC) X-FDA: 81786235608.03.61B2021 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id 588EA4000B for ; Tue, 13 Feb 2024 09:20:42 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=0jQvgWAz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=FUUCW58s; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=0jQvgWAz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=FUUCW58s; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707816042; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AOS35PXmDzxq8mJA/3f1NRxq/MHHhAThVo5B9zGgbyM=; b=eucAzFKFxbPU9PPSQdFtsXqMeUmTIQE1hHsczG0Y9dGHGAkDa8wzOXXHe3F4mtfRyr1djx ln2R5NIddczT8TTZmAkz7iInIsNHKuQlu1GjAlhkZsRB9a+ImB15CxQufWYtIFL2HGcOPl f+s7+LlBZmCPtzBPps1kQDoldEd8j1E= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=0jQvgWAz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=FUUCW58s; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=0jQvgWAz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=FUUCW58s; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707816042; a=rsa-sha256; cv=none; b=lLNKUdWNZ86+GkTXwjAePVhOgGlUnXM2Eri3sy1kf2/Tf2HbXsnh0ml8GtfeoLsnIPyOl4 PYs7mEFiAFXyUUHI9LymAT9SUiby1UpS9PTr1pjyo6k047ykPP8XUZoehwDiK858RoD7R0 SIAgs8Y6eZpiKcKw0XsfgzYYOyMFY7s= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CBCE721CB5; Tue, 13 Feb 2024 09:20:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707816040; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AOS35PXmDzxq8mJA/3f1NRxq/MHHhAThVo5B9zGgbyM=; b=0jQvgWAzsAfGieokk1BRChjKDJjs8YvOEql95YcoU9BVAhK3cLki48DmjDIeNJ6Q7gCULb 3h+uCPvK2bPXRUTOtGmNX6y2c1EMZ1MJIvIJhg4ABIW4L7URzIwDt0J/5P16GyOCgcULf2 KGi86YjrwV+xYDw59cuXQ4PwXTLR0fw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707816040; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AOS35PXmDzxq8mJA/3f1NRxq/MHHhAThVo5B9zGgbyM=; b=FUUCW58sTyeIzP4oFj2BY4J5q1fr8u6mOVOGRUHlKhEOMQJZMWzQEsJToM6IpHCHvYxzRd b0wHfInYidlTxvBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707816040; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AOS35PXmDzxq8mJA/3f1NRxq/MHHhAThVo5B9zGgbyM=; b=0jQvgWAzsAfGieokk1BRChjKDJjs8YvOEql95YcoU9BVAhK3cLki48DmjDIeNJ6Q7gCULb 3h+uCPvK2bPXRUTOtGmNX6y2c1EMZ1MJIvIJhg4ABIW4L7URzIwDt0J/5P16GyOCgcULf2 KGi86YjrwV+xYDw59cuXQ4PwXTLR0fw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707816040; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AOS35PXmDzxq8mJA/3f1NRxq/MHHhAThVo5B9zGgbyM=; b=FUUCW58sTyeIzP4oFj2BY4J5q1fr8u6mOVOGRUHlKhEOMQJZMWzQEsJToM6IpHCHvYxzRd b0wHfInYidlTxvBg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 51D0C13A0E; Tue, 13 Feb 2024 09:20:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id v0PeEGg0y2XQIAAAn2gu4w (envelope-from ); Tue, 13 Feb 2024 09:20:40 +0000 Date: Tue, 13 Feb 2024 10:21:50 +0100 From: Oscar Salvador To: Marco Elver Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Andrey Konovalov , Alexander Potapenko Subject: Re: [PATCH v8 4/5] mm,page_owner: Filter out stacks by a threshold Message-ID: References: <20240212223029.30769-1-osalvador@suse.de> <20240212223029.30769-5-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 588EA4000B X-Stat-Signature: fkqdbnyre7uxh5n6irca4xo58q4pe5nq X-HE-Tag: 1707816042-219412 X-HE-Meta: U2FsdGVkX18ZuSaCk+34SQ474CWjlUx7nXlQE9Yayr4LVxTCDiY13yKZnMH4tj9PoN31FYWF7iJyzosA2q8VBF8pTPaCSNHL78iy2gxJ1+7vUWIPvbjp+YMu95cFEu7YUdck58AbZwsUDqM5iUSFnh9AmLx8WOzOILUGX71gs2MSrwLJejom8r5+Q4vI9fN0VeBOsH+BcbCSZQUs1hhoj6F+sBAbHxCvLHDQUOPZK7YBRnFSeLK4grg48tAJYtwKucxpvbCJn+ZIOAy9gevYAfzDSUNeWYqludNvdHnRNMcrJ7dLzCtCGgY+IyW60kca+ViavSB5Fu2xOBt6veWlyCDLHccGjwzzHrEKj0XjXE+wp+bz//T94QbJGAhWAXgDR9TluP/UdR/D48axXwoNvYXTlOW4iuxlCv00Sc9XkqBnOYqAmOq85EjTwsSiadYKxWpWt+tWIRRPV4lRypbid8eeSA7NiT5HYrghZvkB7NlCqnYz12LL9Y7e7/qd40kPAlWKKyPjSsGhhyhkk9x3/3HY0kkxieOEIjLcksvQemFR3zNkC7n7Dhg3Xz+UWHBq8fq+1FTuhcSfEl5fK6dFhmAjEtZQB3kXEK/6vgt4inTjbjBRKkRX3QuWTH6vnSCNOdtnT6EOnkIF/hPrQeixYstUyUVC7MMSmuJUCHPixsk46WIo/7kc/jidcp/BQ01YNTdmVYOaSmIihwtTK5nl+0hbFymedKTC/5j67rCtoXb/4Kgnq+Gr1BV2/v7wbkB9El5IczJmlvcuoi9wifcDrDTw/WcEAQbLUbXH1AZuMrufgr7A1VjwlZMXL25HkUycWtuTCcD8XhIPgfU2myQj/Bbbb9ohJiLoFLKWnOMNMR28KntE60K97uVY+A/cDcyqd/wFVB5pdH38gzDycMtIm0X9HF/3wJeB5mrk+RNHTUgf2VbrFEjFwcDCAiPlyBznLqbtU9MkCS7Y2QHawTy xTEglX9T YTl9MuQV9VQkH5CQfcCT3g1sufkREMnrARWJcvhare7+mPfc6EUDOvg+YAYlkmUqUCXEzuVqUuCKXfc94pMquZoZaQpKb1K+92qM07Clqyq4p+gnRQXWVtY+SJwfB2cWis4YwK4a1LVTUemznDJk56RCa9ovZPWt2KsoZEPFxaQhR+qBTN5JxDX8owixVJi/ohDXMzxlvDhhkkqrrVEO6WyEj91qkQv2gO8iO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 09:44:47AM +0100, Marco Elver wrote: > On Mon, 12 Feb 2024 at 23:29, Oscar Salvador wrote: > > + debugfs_create_file("set_threshold", 0600, dir, NULL, > > + &proc_page_owner_threshold); > > Can't you also read from "set_threshold", so the name "set_threshold" > is misleading. Why not just "threshold"? Yes, it can also be read. I guess I was too focused on the set part. I will rename that one, plus add the {READ,WRITE}_ONCE. Thanks! -- Oscar Salvador SUSE Labs